1 2012-01-01 Murray Cumming <murrayc@murrayc.com>
3 Slight modification to *Mapper comments.
5 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
7 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
9 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
11 Remove comments mentioning GIN because they are just copied from
12 the example code and are apparently not helpful:
13 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
14 Also change the mention of a class that is only in the example code.
16 2012-01-01 Murray Cumming <murrayc@murrayc.com>
18 GwtTestOnlineGlom test: Minor changes.
20 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
21 Avoid the long qualified class name and modify the comment
22 because it is now obvious to me that the mocked class is the only
23 custom one created via GWT.create().
25 2012-01-01 Murray Cumming <murrayc@murrayc.com>
27 Tests: Added the beginnings of a test using gwt-test-utils.
29 * pom.xml: Add dependencies on gwt-test-utils and easymock.
30 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
31 which tells gwt-test-utils what class will be tested.
32 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
33 Add a simple (but empty) test case. One class, used by the OnlineGlom
34 class, is mocked so that it can be created. However, I am not sure
35 why only this class needs to be mocked.
37 Note that mockito seems more popular, and clearer, than easymock,
38 but I have not got that working yet. It might be a matter of the
41 This test is run during mvn integration-test.
43 2011-12-31 Murray Cumming <murrayc@murrayc.com>
45 Tests: Use junit4-style syntax instead of junit3-style.
47 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
48 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
49 * src/test/java/org/glom/web/shared/DataItemTest.java:
50 Use the @Test annotation rather than relying on the test*() prefix.
51 Also no longer implement TestCase, to avoid triggering support for
52 the junit3-way, which stops the annotations from working.
53 Change the imports from import junit.framework.* to
54 import org.junit.*, which is apparently the new way.
56 2011-12-31 Murray Cumming <murrayc@murrayc.com>
58 Added a test for ListPlace token parsing and creation.
60 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
61 This is much the same as DetailsPlaceTest.
63 I wonder how we could test the other parts of the *Place API.
65 2011-12-30 Murray Cumming <murrayc@murrayc.com>
67 DetailsPlace test: Also test getToken() and recreation via getPlace().
69 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
70 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
71 recreate it, testing the recreated DetailsPlace for the same parameter
74 2011-12-30 Murray Cumming <murrayc@murrayc.com>
76 Use the surefire-report plugin.
78 * pom.xml: This generates a HTML report about the tests in
79 target/site/surefire-report.html
80 when you do mvn surefire-report:report. It seems to be popular/normal.
82 2011-12-30 Murray Cumming <murrayc@murrayc.com>
84 Added a test for DetailsPlace.
86 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
87 Test the getPlace() token parsing.
89 2011-12-30 Murray Cumming <murrayc@murrayc.com>
91 Added a first unit test.
93 * pom.xml: Add a test goal, and a dependency on junit in that scope.
94 * src/test/java/org/glom/web/shared/DataItemTest.java:
95 This is a silly test but it is just to get things started. Note that
96 maven/junit finds the test because it looks in src/test by default.
98 2011-12-22 Ben Konrath <ben@bagu.org>
100 Change charsetName to "UTF-8" when replacing line breaks.
102 JavaScript requires the charsetName to be "UTF-8". CharsetName values
103 that work in Java (such as "UTF8") will not work when compiled to
106 This fixes a problem with multi-line details view fields that have hard
107 line breaks. The "License Text" field on this page demonstrates the
110 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
112 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
114 2011-12-22 Ben Konrath <ben@bagu.org>
116 Fix another bug with related list navigation.
118 I've tested all the navigation buttons in all of the related lists
119 so things should be good now.
121 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
123 2011-12-22 Ben Konrath <ben@bagu.org>
125 Fix a crasher when refreshing the list view with the default table.
127 This crash will also happen when loading the list view with the default
128 table from a link or bookmark.
130 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
131 to the main document selection page when the document id hasn't been
133 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
134 the main document selection page when the document id hasn't been
136 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
137 values for the details place when the document id hasn't been set.
138 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
139 values for the list place when the document id hasn't been set.
141 2011-12-21 Ben Konrath <ben@bagu.org>
143 Protect against NPE when glom.document.locale is not in config.
145 This patch protects against an NPE when glom.document.locale is not in
146 the config file. This NPE will also happen if glom.document.locale is
149 The patch also updates the error message to display the class name when
150 the getMessage() returns null. This was happening when the NPE was
151 thrown and I had "Configuration Error: null". If an NPE is encountered
152 with this patch, "Configuration Error: NullPointerException " will be
155 This commit closes this bug:
157 https://bugzilla.gnome.org/show_bug.cgi?id=666669
159 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
161 2011-12-20 Murray Cumming <murrayc@murrayc.com>
163 Rename onlineglom.properties to onlineglom.properties.sample.
165 * src/main/resources/onlineglom.properties: Rename to:
166 * src/main/resources/onlineglom.properties.sample:
167 * src/main/resources/README: And add this file explaining that people
168 should rename it back when deploying.
170 2011-12-20 Murray Cumming <murrayc@murrayc.com>
172 Allow choosing the translation in the .properties file.
174 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
175 init(): Read a glom.document.locale value from the configuration file
176 and call Glom's TransatableItem::set_current_locale() method.
177 * src/main/resources/onlineglom.properties: Add a commented-out
178 example of this new setting.
180 It would be better to add &lang=de_DE to the URL, but the current
181 libglom API does not allow us to do this easily. I am working on that.
183 2011-12-19 Murray Cumming <murrayc@murrayc.com>
185 Avoid a crash in parsing of token parameters.
187 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
188 ava: getTokenParams(): Do not crash if a parameter has a key but no
189 value, and ignore parameters with neither.
191 2011-12-17 Murray Cumming <murrayc@murayc.com>
193 History token building/handling: Improve use of token parameters.
195 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
196 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
197 and buildParamsToken(HashMap), for use by derived classes.
198 Make the separator private because it is no longer be needed.
199 * src/main/java/org/glom/web/client/place/DetailsPlace.java
200 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
201 instead of manual string concatenation.
202 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
203 of hardcoded indices and awkward splitting code.
204 * src/main/java/org/glom/web/client/place/ListPlace.java
205 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
206 instead of manual string concatenation.
207 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
208 of hardcoded indices and awkward splitting code.
209 This should fix bug #666420
211 2011-12-16 Murray Cumming <murrayc@murrayc.com>
213 Fix a Navgiation->Navigation typo in the code.
215 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
216 Rename processNavgiation() to processNavigation().
218 2011-12-16 Murray Cumming <murrayc@murrayc.com>
220 Fix a seperator->separator typo in the code.
222 * src/main/java/org/glom/web/client/place/DetailsPlace.java
223 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
224 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
227 2011-12-15 Ben Konrath <ben@bagu.org>
229 Cleanup some comments.
231 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
233 2011-12-14 Ben Konrath <ben@bagu.org>
235 Replace \n with <br/> for multiline text in the details view.
237 Vertical scrollbars are added when needed as well.
239 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
241 2011-12-14 Ben Konrath <ben@bagu.org>
243 Specify the font for document selection links.
245 * src/main/webapp/style.css:
247 2011-12-14 Ben Konrath <ben@bagu.org>
249 Fix bouncy CellTable while paging.
251 This doesn't currently work with related list tables in unselected
254 * src/main/java/org/glom/web/client/ui/list/ListTable.java
256 2011-12-14 Ben Konrath <ben@bagu.org>
258 Revamp the appearance of the document selection page.
260 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
261 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
262 * src/main/webapp/style.css:
264 2011-12-13 Ben Konrath <ben@bagu.org>
266 Set navigation button column to the smallest size possible.
268 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
270 2011-12-13 Ben Konrath <ben@bagu.org>
272 Change OpenButton nomenclature to NavigationButton.
274 Using NavigtionButton makes things more generic. Classes, methods and
275 variables have been changed.
277 This is a rename-only refactor.
279 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
280 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
281 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
282 Renamed from OpenButtonCell.
283 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
284 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
285 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
287 2011-12-12 Ben Konrath <ben@bagu.org>
289 Remove unnecessary String argument in RelatedListTable and ListViewTable.
291 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
292 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
293 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
294 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
296 2011-12-12 Ben Konrath <ben@bagu.org>
298 Update variable names and comments.
300 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
301 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
303 2011-12-12 Ben Konrath <ben@bagu.org>
305 Properly initialize numNonEmptyRows variable to zero.
307 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
308 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
310 2011-12-05 Ben Konrath <ben@bagu.org>
312 Add latest mockup with HTML tables.
314 Features of this mockup:
316 -> HTML table for flowtable
317 -> HTML table for flowtable column
318 -> Example of how related lists would look
319 -> Not using text entries for data items
321 The current version of Online Glom doesn't use HTML tables for the
324 This mockup has been sent to the glom-devel mailing list but it's good
325 to have it here as well.
327 * mockups/details-view-html-tables.html:
329 2011-12-05 Ben Konrath <ben@bagu.org>
331 Remove unnecessary getPrimaryKeyField() method.
333 getPrimaryKeyFieldForTable(String) has been renamed to
334 getPrimaryKeyField(String).
336 * src/main/java/org/glom/web/server/database/DBAccess.java:
337 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
338 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
340 2011-12-05 Ben Konrath <ben@bagu.org>
342 Add string representation of TypedDataItem value to conversion error message.
344 * src/main/java/org/glom/web/server/Utils.java: Logging the error
345 message was extracted into its own method to avoid duplication.
347 2011-12-05 Ben Konrath <ben@bagu.org>
349 Add type checking to navigation primary key value creation.
351 Create navigation primary key only if the expected type from the Glom
352 document matches the type returned by the SQL query.
354 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
356 2011-12-05 Ben Konrath <ben@bagu.org>
358 Rename a couple of variables in RelatedListNavigation.
360 This is a rename-only refactor.
362 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
364 2011-12-05 Ben Konrath <ben@bagu.org>
366 Move getListLayoutGroup() into getListViewLayoutGroup().
368 This removes getListLayoutGroup(). It was only being called by
369 getListViewLayoutGroup().
371 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
373 2011-12-05 Ben Konrath <ben@bagu.org>
375 Remove check for LayoutItem_Portal in list table method.
377 This check is no longer necessary because the method isn't being used
378 to create the LayoutItemPortal DTO.
380 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
382 2011-12-05 Ben Konrath <ben@bagu.org>
384 Properly support related list navigation.
386 Navigation from the "Repository Analyzer -> Package Scans ->
387 Dependencies" related table wasn't working because the primary key for
388 related tables wasn't being set properly. This commit fixes the
391 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
392 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
393 doesn't set the primary key properly for related list tables.
394 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
395 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
396 useful for getting the primary key for list view tables and for related
398 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
399 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
400 Move code to set the primary key for the table from the abstract
401 ListDBAccess class to ListViewDBAccess as it's only correct for list
403 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
404 Properly add primary key to related list tables.
406 2011-12-02 Ben Konrath <ben@bagu.org>
408 Properly set the horizontal alignment of fields.
410 This fix is for both the list tables and the details view.
412 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
413 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
414 to set the horizontal alignment of fields.
416 2011-12-02 Ben Konrath <ben@bagu.org>
418 Display currency codes in the details view.
420 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
422 2011-12-02 Ben Konrath <ben@bagu.org>
424 Avoid duplicate JNI call.
426 JNI is not as efficient as pure Java and this is an easy (and small)
429 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
430 Use previously retrieved value for whereClauseToTableName instead of
433 2011-12-02 Ben Konrath <ben@bagu.org>
435 Rename a couple of variables in RelatedListNavigation.
437 This is a rename-only refactor.
439 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
441 2011-12-02 Ben Konrath <ben@bagu.org>
443 Indicate clearly that a mismatched primary key type is a bug.
445 * src/main/java/org/glom/web/server/Utils.java: Change log level from
446 warning to error. Add 'This is a bug.' to message.
448 2011-12-02 Ben Konrath <ben@bagu.org>
450 Update / fix some comments.
452 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
454 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
456 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
457 Fix comments. Add some TODOs.
459 2011-12-02 Ben Konrath <ben@bagu.org>
461 Enable navigation to details view with string primary key from related list.
463 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
464 Create a text primary key value when return type of result is
465 java.sql.Types.VARCHAR.
467 2011-12-02 Ben Konrath <ben@bagu.org>
469 Use checkboxes for booleans in the details view.
471 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
473 2011-12-01 Ben Konrath <ben@bagu.org>
475 Improve performance of related list height calculation.
477 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
478 Put code to calculate the expected height in a static initializer so
479 that that it's only called once.
481 2011-12-01 Ben Konrath <ben@bagu.org>
483 Show related list tables in notebooks (again).
485 Calculate the height of the related list tables so the Notebook can be
486 set the correct height. The height of the related list table is also needed by
487 FlowTable to be able decide how to create the layout.
489 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
490 and set the Portal height based on the height of the related list
491 table and the Portal container.
492 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
493 Add method to calculate the height of the related list tables.
494 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
495 * src/main/webapp/style.css: Add css class for Pager. This is needed to
496 calculate the height of the Pager widget.
498 2011-12-01 Ben Konrath <ben@bagu.org>
500 Use CellTable API for table property instead of setting style on Element.
502 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
504 2011-12-01 Ben Konrath <ben@bagu.org>
506 Make ListViewTable and RelatedListTable a consistent height.
508 The tables are now a consistent height regardless of the contents of
509 the table. A hidden button is added to empty rows to ensure that the
510 height of these rows will match the height of rows with data.
512 A navigation button column is now added to every table. The width of
513 the navigation column is set to 0px when a RelatedListTable shouldn't
514 have navigation buttons. This maintains the a consistent row height in
515 tables that don't show the navigation buttons.
517 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
518 navigation column when not needed.
519 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
520 arguments for navigation button to constructor of ListViewTable.
521 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
522 hidden button for empty data rows.
523 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
524 arguments for navigation button to constructor.
525 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
526 create navigation buttons. Add hideNavigationButtons() method.
527 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
528 arguments for navigation button to constructor.
530 2011-12-01 Ben Konrath <ben@bagu.org>
532 Use 'visibility: hidden' in Utils.getWidgetHeight().
534 This is better choice because hidden elements are invisible, don't
535 respond to events and are not part of the tab order. They will,
536 however, take up space which is required to be able to calculate the
537 height of the widget.
539 * src/main/java/org/glom/web/client/Utils.java:
541 2011-12-01 Ben Konrath <ben@bagu.org>
543 Use Utils.getWidgetHeight() in FlowTable.
545 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
547 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
549 2011-12-01 Ben Konrath <ben@bagu.org>
551 Put the details css class name on the correct table column.
553 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
555 2011-11-30 Ben Konrath <ben@bagu.org>
557 Update for java-libglom API change.
559 The getters and setters on FieldFormatting and NumericFormat were
560 changed to remove the 'M'.
562 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
564 2011-11-29 Ben Konrath <ben@bagu.org>
566 Only allow RelatedListTables in Portals.
568 * src/main/java/org/glom/web/client/ui/details/Portal.java:
570 2011-11-29 Ben Konrath <ben@bagu.org>
572 Only create a contents panel for Portals when title is being set.
574 * src/main/java/org/glom/web/client/ui/details/Portal.java:
576 2011-11-29 Ben Konrath <ben@bagu.org>
578 Set TabLayoutPanel height based on calculated height its widgets.
580 This is a potential fix for this bug:
582 https://bugzilla.gnome.org/show_bug.cgi?id=665133
584 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
586 2011-11-29 Ben Konrath <ben@bagu.org>
588 Align details field labels and data with the Open buttons.
590 * src/main/webapp/style.css:
592 2011-11-29 Ben Konrath <ben@bagu.org>
594 Remove unnecessary <div> in the Notebook widget.
596 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
597 method to get container FlowPanel (<div>).
598 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
599 initWidget() method directly on the TabLayoutPanel widget instead of
600 Group's container widget.
602 2011-11-29 Ben Konrath <ben@bagu.org>
604 Don't add group titles for Portals in Notebooks.
606 This reverts the previous patch and fixes a bug I introduced with
607 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
609 * src/main/java/org/glom/web/client/ui/details/Group.java:
610 * src/main/java/org/glom/web/client/ui/details/Portal.java:
612 2011-11-28 Ben Konrath <ben@bagu.org>
614 Remove unused boolean argument in Portal constructor.
618 * src/main/java/org/glom/web/client/ui/details/Group.java:
619 * src/main/java/org/glom/web/client/ui/details/Portal.java:
621 2011-11-28 Ben Konrath <ben@bagu.org>
623 Remove hack for glom 1.18 style glom files.
625 * src/main/java/org/glom/web/client/ui/details/Group.java:
626 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
627 * src/main/java/org/glom/web/client/ui/details/Portal.java:
629 2011-11-28 Ben Konrath <ben@bagu.org>
631 Use Gda Value version of primary key to log result too large error.
633 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
635 2011-11-28 Ben Konrath <ben@bagu.org>
637 Don't use TypedDataItem.getText() for Unknown types from the URL.
639 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
640 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
641 instead of getText().
642 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
643 String field and getUnknown() method.
645 2011-11-28 Ben Konrath <ben@bagu.org>
647 Log an error message when the java-libglom .so is not present.
649 The error message was being set in the exception but not logged.
651 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
653 2011-11-28 Ben Konrath <ben@bagu.org>
655 Ignore LayoutItem_CalendarPortals.
657 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
658 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
660 2011-11-28 Ben Konrath <ben@bagu.org>
662 Extract method for creating the LayoutItemPortal DTO.
664 Just breaking the code up into smaller chunks.
666 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
668 2011-11-28 Ben Konrath <ben@bagu.org>
672 This should have been added with the refactor. Oops!
674 * src/main/java/org/glom/web/shared/TypedDataItem.java:
676 2011-11-28 Ben Konrath <ben@bagu.org>
678 Create primary key value from URL string using type from Glom document.
680 See this bug, comments 19 - 25:
682 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
684 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
685 create a TypeDataItem for the primary key here when loading from a
686 URL. Show the same string for the primary key value as was received
687 from the URL string (when loading from a URL).
688 * src/main/java/org/glom/web/server/Utils.java: Update method for
689 creating the Gda Value from the TypeDataItem to properly deal with
690 creating a Gda Value based on the Glom document type for the primary
691 key value string when loading from a URL.
692 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
693 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
694 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
695 Update for changed method name.
697 2011-11-27 Ben Konrath <ben@bagu.org>
699 Rename PrimaryKeyItem to TypedDataItem.
701 The name PrimaryKeyItem suggests what the class should be used for.
702 TypedDataItem is a neutral name that describes the class better.
704 This is a rename-only refactor.
706 * src/main/java/org/glom/web/client/OnlineGlomService.java:
707 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
708 * src/main/java/org/glom/web/client/Utils.java:
709 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
710 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
711 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
712 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
713 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
714 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
715 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
716 * src/main/java/org/glom/web/server/Utils.java:
717 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
718 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
719 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
720 * src/main/java/org/glom/web/shared/NavigationRecord.java:
722 2011-11-25 Ben Konrath <ben@bagu.org>
724 Improve Gda Value conversion from PrimaryKeyItem.
726 The value from the PrimaryKeyItem is only used if its type match the
727 type from the glom document.
729 * src/main/java/org/glom/web/server/Utils.java:
731 2011-11-25 Ben Konrath <ben@bagu.org>
733 Manually check if the java-liblgom .so is visible to the JVM.
735 It seems that Tomcat has problems when a static initializer throws an
736 exception. This check is done before the first method call into
737 java-libglom so that execution doesn't continue if the .so is not
740 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
742 2011-11-25 Ben Konrath <ben@bagu.org>
744 Improve browser configuration error messages.
748 https://bugzilla.gnome.org/show_bug.cgi?id=662792
750 * src/main/java/org/glom/web/client/OnlineGlomService.java:
751 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
752 getConfigurationErrorMessage() method.
753 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
754 Get and display a specific configuration error message when no Glom
756 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
757 Implement getConfigurationErrorMessage() method. Surround configuration
758 code in the init() method with a try/catch block. This allows the
759 errors to be caught while keeping the servlet available to retrieve the
760 configuration error message.
762 2011-11-25 Ben Konrath <ben@bagu.org>
764 Don't use Strings to hold primary key values.
766 The primary key values are now held in a new data object
767 (PrimaryKeyItem) that holds type information and the primary key value
768 using the correct type.
770 * src/main/java/org/glom/web/client/OnlineGlomService.java:
771 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
772 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
773 PrimaryKeyItem instead of String to hold the primary key value.
774 * src/main/java/org/glom/web/client/Utils.java: Remove
775 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
776 PrimaryKeyItem based on the GlomFieldType and the DataItem.
777 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
778 PrimaryKeyItem instead of String to hold the primary key value. Load
779 document selection page when the documentID has not been set correctly.
780 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
781 DetailsPlace -> URL and URL -> DetailsPlace conversion with
783 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
784 Return empty string for URL instead of "null".
785 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
786 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
787 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
788 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
789 PrimaryKeyItem instead of String to hold primary key values.
790 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
791 PrimaryKeyValue to a Gda Value.
792 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
793 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
794 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
795 Replace temporary database access code that uses the PrimaryKeyValue to
796 Gda Value conversion.
797 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
798 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
799 PrimaryKeyItem instead of String.
800 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
801 hold primary key values.
803 2011-11-24 Ben Konrath <ben@bagu.org>
805 Use newly added java-libglom API to create queries.
807 This isn't finished. I still need to stop using Strings for primary key
808 values in the client code.
810 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
811 libglom to use fake connections so that retrieving the query string will
813 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
814 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
815 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
816 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
817 Use the newly added libglom sql methods and classes to create the
818 query. Add temporary hack to convert primary value strings to Gda
821 2011-11-23 Ben Konrath <ben@bagu.org>
823 Don't explicitly set the height of Portals.
825 See comments 6 - 10 of this bug for details:
827 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
829 * src/main/java/org/glom/web/client/ui/details/Portal.java:
831 2011-11-23 Ben Konrath <ben@bagu.org>
833 Use an HTML table instead of CSS for the FlowTable layout.
835 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
836 GWT's FlexTable to implement the FlowTable.
837 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
839 2011-11-18 Ben Konrath <ben@bagu.org>
841 Add boolean example to HTML table mockup.
843 * mockups/details-view-html-tables-text-entries.html:
845 2011-11-17 Ben Konrath <ben@bagu.org>
847 Ensure the pager buttons are always visible for related lists.
849 To accomplish this, I've turned off text wrapping in the list view and
850 related list tables for both the header and data text. The related list
851 table now has a fixed layout so the it doesn't overflow its container.
852 This is required to ensure that the cell text is clipped when it
853 overflows the cell and an ellipsis is added to the right side of the
854 cell when text is clipped.
856 A fixed table layout for the related list table in the details view
857 seems what we want for the details view anyway, so the side-effect is
860 The ellipsis will only be displayed in Firefox >= 7.
864 https://bugzilla.gnome.org/show_bug.cgi?id=662930
866 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
867 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
868 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
870 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
871 Set the 'table-layout: fixed' CSS property to the related list table.
872 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
873 'white-space: nowrap;' CSS property on both the list view and the
876 2011-11-16 Ben Konrath <ben@bagu.org>
878 Rework the fix for empty notebook tab labels.
880 Setting the empty group titles with its name caused problems for the
881 details layout. Instead of using libglom's
882 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
883 to the client when the title is empty. This allows the Notebook to use
884 the name when the title is empty without affecting anything else.
886 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
887 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
889 2011-11-16 Ben Konrath <ben@bagu.org>
891 Set group titles with name when title is empty.
893 This fixes a problem with an empty notebook tab label in the Lesson
894 Planner document. The forth tab in the notebook should be "Internet":
896 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
898 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
899 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
902 2011-11-16 Ben Konrath <ben@bagu.org>
904 Remove whitespace from the configured username properties.
906 This assumes that usernames won't have whitespace at the beginning
907 or end. But I think this is a reasonable assumption.
909 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
910 String.trim() to remove the whitespace from the username properties.
912 2011-11-15 Ben Konrath <ben@bagu.org>
914 Add details view mockup with HTML tables and text entries.
916 This is from the attachment on this bug:
918 https://bugzilla.gnome.org/show_bug.cgi?id=663109
920 * mockups/details-view-html-tables-text-entries.html:
922 2011-11-15 Ben Konrath <ben@bagu.org>
924 Add space between the columns of the flow table.
928 https://bugzilla.gnome.org/show_bug.cgi?id=662918
930 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
931 space between columns in the flow table.
933 2011-11-15 Ben Konrath <ben@bagu.org>
935 Add backup files to the .gitignore.
937 * .gitignore: Ignore files that end with ~.
939 2011-11-09 Ben Konrath <ben@bagu.org>
941 Use latest release of gwt-log.
943 Gwt-log releases are now being submitted to the maven central
944 repository so manual installation of the jar is no longer required.
946 * pom.xml: Update version and groupId of gwt-log dependency.
948 2011-10-31 Ben Konrath <ben@bagu.org>
950 Don't use GWT numeric formatting to override the glom currency formatting.
952 Currencies are now displayed like they are in Glom. See this bug:
954 https://bugzilla.gnome.org/show_bug.cgi?id=646216
956 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
958 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
959 currency code to constructor and set it when the cell is rendered.
960 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
961 currency code to the constructor of the NumericCell.
963 2011-10-27 Ben Konrath <ben@bagu.org>
965 Require the latest release of java-libglom (1.17.4).
969 2011-10-26 Ben Konrath <ben@bagu.org>
971 Add style to Notebook that matches current theme.
973 It's not the best style in the world but it's better than the default.
975 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
976 padding at the bottom of the child widgets.
977 * src/main/webapp/style.css: Add style for the Notebook.
979 2011-10-26 Ben Konrath <ben@bagu.org>
981 Move servlet initialization code to overridden init method.
983 This is half of the solution to getting proper error messages
984 displayed when configuration errors occur. Here's the relevant bug:
986 https://bugzilla.gnome.org/show_bug.cgi?id=662792
988 The rest of the solution involves surrounding the init method with a
989 try/catch block and setting a global variable with the error /
990 exception. A new async method should be created to retrieve and display
991 the error message / exception.
993 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
994 code from constructor to init method adding exceptions as needed.
996 2011-10-26 Ben Konrath <ben@bagu.org>
998 Add script to monitor and restart tomcat if required.
1000 * utils/check-and-recover-tomcat.py: New file.
1002 2011-10-26 Ben Konrath <ben@bagu.org>
1004 Display the correct number of data items in the pager.
1008 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1010 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1011 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1012 The implementation is the same for both tables: Keep track of the
1013 number of non-empty rows and fire and RowCountChangeEvent after the data has
1015 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1016 custom Pager class that subclasses SimplePager to handle displaying
1017 the correct number when empty rows have been added.
1019 2011-10-26 Ben Konrath <ben@bagu.org>
1021 Correct error in previous commit.
1023 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1024 eventBus parameter from listView.setCellTable().
1026 2011-10-26 Ben Konrath <ben@bagu.org>
1028 Fix error in TODO comment.
1030 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1032 2011-10-24 Ben Konrath <ben@bagu.org>
1034 Create Notebook widgets to the details view.
1036 This isn't finished just yet - I still need to create a reasonable
1037 style to match the current theme.
1039 * src/main/java/org/glom/web/client/Utils.java: Add method for
1040 calculating the height of a widget. This is used in the Notebook class.
1041 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1042 new constructor method in Group.
1043 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1044 method for creating child widget that can be used by subclasses
1045 like Notebook. New constructor that allows disabling the group
1046 titles - Notebooks don't set a group title for their child groups.
1047 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1048 to make Notebooks using GWT's TabLayoutPanel.
1049 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1050 constructor that allows disabling the group titles.
1051 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1052 LayoutItemNotebook DTO.
1053 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1054 DTO for Notebooks. It's just an empty class for now but we might need
1055 it to transfer some specific information in the future.
1057 2011-10-21 Ben Konrath <ben@bagu.org>
1059 Add navigation buttons to related list tables.
1061 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1062 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1063 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1064 method getSuitableRecordToViewDetails() for getting the table name
1065 and primary key value for related list navigation buttons.
1066 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1067 private cell renderer class to get the navigation information for
1068 related list tables from the server. Extract the navigation
1069 processing code from the details cell navigation and use it for the
1070 related list navigation as well.
1071 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1072 cell renderer class for the details open buttons. This was needed
1073 because the related list navigation buttons and the list view
1074 navigation buttons need to react differently when clicked.
1075 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1076 the onEnterKeyDown() method because it's now overriden in the
1077 subclasses that are specific to the related list tables and the list
1079 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1080 the vertical size a little because the buttons add a bit of vertical
1081 space to table. This is not a perfect solution because the vertical
1082 size of with table fewer than 5 rows will be a little smaller.
1083 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1084 changes in how navigation buttons are handled.
1085 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1086 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1087 database access object.
1088 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1089 to find the portal for a given relationship name from
1090 RelatedListDBAccess. Add method to find a primary key field for a
1092 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1093 Move code to find the portal for a given relationship name to
1095 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1096 New file: database access object for getting the related list
1097 navigation information (the table name and the primary key value).
1098 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1099 DTO for transferring a table name to navigate to and a primary key
1101 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1102 boolean and getter/setter to specifies if the related list should add
1105 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1107 Use the master branch of java-libglom
1109 * pom.xml: Depend on java-libglom 1.19 instead.
1111 This is the master branch. See also the libglom-1-18 branch.
1113 2011-10-11 Ben Konrath <ben@bagu.org>
1115 Enable the open navigation button when the data has been set.
1117 This avoids having active buttons that don't do anything when the data
1120 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1122 2011-10-11 Ben Konrath <ben@bagu.org>
1124 Use IsWidget interface for FlowTableItem.
1126 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1127 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1129 2011-10-11 Ben Konrath <ben@bagu.org>
1131 Remove GWT styling from open button in details view.
1133 There are still some issues with how the details cell is arranged but
1134 this should be made to match Glom 1.20. I'm going to leave fixing this
1135 until I have Glom 1.20 up and running.
1137 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1138 style name on open button.
1139 * src/main/webapp/style.css: Move and edit details-navigation class.
1140 Re-arrange some classes to make them appear in the same order as the
1143 2011-10-07 Ben Konrath <ben@bagu.org>
1145 Update to GWT 2.4.0.
1147 * .gitignore: Ignore new cache directory.
1148 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1149 * pom.xml: Change GWT and maven plugin to 2.4.0.
1150 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1152 * src/main/java/org/glom/web/client/ClientFactory.java:
1153 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1154 * src/main/java/org/glom/web/client/OnlineGlom.java:
1155 Update source for API changes.
1156 * utils/build-onlineglom-war.sh: Remove cache directory before the
1159 2011-10-07 Ben Konrath <ben@bagu.org>
1161 Add navigation buttons in the details view.
1163 This isn't finished but I thought I'd commit what I have as it's a
1164 pretty good start. I still need to:
1166 1. Change the style so that it fits better into the current theme
1167 2. Adjust the details cell to expand as much as possible.
1169 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1170 click handlers to navigation buttons in the DetailsCells. Create a
1171 refreshData() method to get just the data from the server without the
1173 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1174 Update the tableSelector and browser title when the table name
1175 changes without using the tableSelector.
1176 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1177 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1178 getDetailsCells() to getCells(). Update variable names.
1179 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1180 method to set click handler on navigation button. Rename a few
1181 variables. Add navigation buttons where needed.
1182 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1183 variables and methods.
1184 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1185 navigation boolean and navigation table as required in the
1186 LayoutItemField DTO.
1187 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1188 variables for navigation along with getter/setter methods.
1190 2011-10-07 Ben Konrath <ben@bagu.org>
1192 Rename Field to DetailsCell.
1194 This is a refactor-only commit. No functionality has been added or
1197 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1198 Update variable and method names.
1199 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1200 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1201 variable and method names.
1202 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1204 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1205 variable and method names.
1207 2011-10-07 Ben Konrath <ben@bagu.org>
1209 Create separate methods for layout and data the details view.
1211 This is a refactor-only commit. No functionality has been added or
1214 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1215 private methods: setData(), createLayout().
1217 2011-10-07 Ben Konrath <ben@bagu.org>
1219 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1221 This is part of a change to get navigation buttons in the details view
1222 but it should have been done this way from the start.
1224 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1225 for method name change in TableSelectionView.
1226 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1227 Create TableChangeEvent and set the browser title using the
1228 TableSelectionView API.
1229 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1230 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1231 Change getSelectedTable() to getSelectedTableName(). Add
1232 getSelectedTableTitle().
1234 2011-10-07 Ben Konrath <ben@bagu.org>
1236 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1238 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1240 2011-10-07 Ben Konrath <ben@bagu.org>
1242 Update TableChangeEvent to use newTableName naming convention.
1244 This makes the class more consistent with GWT naming conventions.
1246 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1247 Update for method name change in TableChangeEvent.
1248 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1249 for method name change in TableChangeEvent.
1250 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1251 newTableName variable and getter method. Make toDebugString()
1254 2011-09-30 Ben Konrath <ben@bagu.org>
1256 Disable the pager in the list tables when the data row count is less than the minimum.
1258 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1259 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1261 2011-09-30 Ben Konrath <ben@bagu.org>
1263 Add empty rows to the end of related list and list view tables.
1265 I also extracted the cell rendering classes from the ListTable because
1266 the code was becoming a little crazy with all the anonymous inner
1267 classes. My plan is to use these cell rendering classes in the details
1268 view as well so this refactor will be needed for that change.
1270 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1271 set the row count in related list tables if the data has more rows
1272 than the minimum number of rows visible.
1273 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1274 row count in list view tables if the data has more rows than the
1275 minimum number of rows visible.
1276 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1277 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1279 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1280 for rendering TYPE_NUMERIC cells. The code was extracted from the
1282 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1283 class for rendering cells with buttons in list views. The code was
1284 extracted from the ListTable class.
1285 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1286 for rendering TYPE_TEXT cells. The code was extracted from the
1288 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1289 Add empty rows to the end of the data if required. Implement
1290 ListTable.getMinNumVisibleRows().
1291 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1292 cell renderer code to public classes. Return null in
1293 Column.getValue() for empty rows. Add new abstract method:
1294 getMinNumVisibleRows(). Move code to set the row count of the list view
1295 table to ListViewImpl.
1296 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1297 empty rows to the end of the data if required. Implement
1298 ListTable.getMinNumVisibleRows().
1301 2011-09-27 Ben Konrath <ben@bagu.org>
1303 Use GWT.log for client-side debugging statements.
1305 These are optimized out when deployed so I should have used this method
1306 in the first place. These statements will eventually be replaced with some sort
1307 of notification in the browser.
1309 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1310 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1311 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1312 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1313 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1315 2011-09-27 Ben Konrath <ben@bagu.org>
1317 Put tableselector on the right, back to list link on right.
1319 The idea is that the table selector is acting like a label for the
1320 currently displayed table so it should be placed below the document title. This
1321 puts the table title in a similar position to where it is in Glom.
1323 * mockups/details-contacts.html:
1324 * mockups/details-projects.html:
1325 * mockups/listview-contacts.html:
1326 * mockups/listview-projects.html:
1327 * mockups/style.css:
1328 Update mockups to match how the interfaces currently look.
1329 * src/main/webapp/style.css: Swap positions of backlink with the table
1330 selector. Add some space on the left side of the table selector to
1331 line things up with the document title.
1333 2011-09-27 Ben Konrath <ben@bagu.org>
1335 Add field colouring to details view.
1337 This change re-works how field colouring works. The colour formatting
1338 information is now set to the client with the layout information instead of
1339 with the data. This eliminates the need to send the same colour strings for
1340 data in list view column when colour information is set.
1342 In order to set an alternate colour for negative numeric values, the
1343 number is now sent to client and formatted with the GWT NumberFormat class.
1345 This change also fixes:
1347 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1349 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1350 internationalization framework which is needed for client side numeric
1352 * src/main/java/org/glom/web/client/Utils.java: New file for some
1353 client static utility methods.
1354 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1355 the DataItem object to the Field class. Use a utility method to
1356 create the foreignKeyValue string.
1357 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1358 alignment and text colours in the constructor. Add setData(DataItem)
1359 method. Remove setText(String) method.
1360 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1361 colour information to GlomTextCell. Create and use GlomNumberCell for
1362 rendering numbers. Use utility method to get the string for the
1363 primary key of the key provider. Re-work how the horizontal alignment
1365 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1366 formatting to layout information. Methods for converting the libglom
1367 formatting information were moved from DBAccess.
1368 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1369 numeric formatting (it's now done on the client side). Don't set text
1370 colours in DataItem. Move libglom formatting conversion methods to
1372 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1373 getters/setters for text colour information.
1374 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1375 for transferring the libglom NumericFormat information to the client.
1376 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1377 and getters/setters for: GlomNumericFormat, background colour and
1378 foreground colour strings.
1380 2011-09-26 Ben Konrath <ben@bagu.org>
1382 Simplify code that iterates through the LayoutGroup.
1384 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1386 2011-09-26 Ben Konrath <ben@bagu.org>
1388 Accept Eclipse formatting for OnlineGlomServiceAsync.
1390 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1392 2011-09-26 Ben Konrath <ben@bagu.org>
1394 Don't use the ListDBAccess classes to get the primary key layout information.
1396 This was causing a bug where the wrong index for the hidden primary key
1397 was being sent to the client.
1399 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1400 primary key while creating the LayoutGroup DTO. Create a
1401 LayoutItemField DTO for hidden primary keys. Don't use the
1402 RelatedListDBAccess because it was only used for getting the primary
1404 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1405 access modifier from public to protected for getPrimaryKeyField() and
1406 getPrimaryKeyLayoutItemField().
1407 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1408 abstract method getExpectedResultSize() because RelatedListDBAccess
1409 doesn't have enough info to implement it.
1410 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1411 Remove @Override for getExpectedResultSize().
1412 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1413 Remove method getExpectedResultSize().
1415 2011-09-23 Ben Konrath <ben@bagu.org>
1417 Log which layout (list or details) the ignored item is from.
1419 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1421 2011-09-23 Ben Konrath <ben@bagu.org>
1423 Remove annotations that turn off code formatting in DataItem.
1425 * src/main/java/org/glom/web/shared/DataItem.java:
1427 2011-09-23 Ben Konrath <ben@bagu.org>
1429 Rename GlomField to DataItem and update associated methods.
1431 This is a rename-only refactor. No functionality has been added or
1434 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1435 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1436 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1437 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1438 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1439 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1440 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1441 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1442 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1443 * src/main/java/org/glom/web/server/database/DBAccess.java:
1444 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1445 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1446 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1447 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1448 * src/main/java/org/glom/web/shared/DataItem.java:
1449 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1450 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1452 2011-09-23 Ben Konrath <ben@bagu.org>
1454 Rename GlomDocument to DocumentInfo and update associated methods.
1456 This is a rename-only refactor. No functionality has been added or
1459 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1460 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1461 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1462 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1463 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1464 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1465 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1467 2011-09-20 Ben Konrath <ben@bagu.org>
1469 Require java-libglom 1.17.3.
1471 This picks up the fix for the seg fault problem with the Scenes table
1472 in the Openismus Film Manager example.
1476 2011-09-20 Ben Konrath <ben@bagu.org>
1478 Change the way sort clause is added for primary key when no sort clause is requested.
1480 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1481 before the sort clause is created. When a sort clause is not requested, the
1482 sort clause is created by finding the primary key in the LayoutFieldVector
1485 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1487 2011-09-20 Ben Konrath <ben@bagu.org>
1489 Log error message if no documents are found in the configured directory.
1491 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1492 Extract the glom file extension string to a private static final class
1493 variable (mostly as syntactic sugar). Accept a minor formatting change.
1494 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1495 the example glom.document.directory configuration property to make it
1496 more clear that it can any directory, not just the home directory.
1498 2011-09-18 Ben Konrath <ben@bagu.org>
1500 Add related lists to details view.
1502 The related list table has support for paging and sorting just like the
1503 table in the list view.
1505 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1506 SQL queries for the related list tables.
1507 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1508 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1509 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1510 Rename getList methods to getListView and add comments. Remove
1511 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1512 it being unused. Add methods: getDetailsLayoutAndData(),
1513 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1514 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1515 Create the layout and set the data for the fields in one async call
1516 instead of two. Create related lists where appropriate.
1517 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1518 for method name changes in OnlineGlomService.
1519 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1520 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1521 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1523 * src/main/java/org/glom/web/client/ui/ListView.java:
1524 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1525 tableName from setCellTable(). Create a ListViewTable instead of
1527 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1528 represent a data field in the details view.
1529 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1530 from addDetailsCell() to Field class. Keep track of the Fields and
1531 Portals in the details view.
1532 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1533 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1534 and add a method to get it. Add method to set the contents of the
1536 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1537 New class for related list tables. This class has the data provider
1538 for the related list table.
1539 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1540 abstract class which is the base class for the ListViewTable and the
1542 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1543 New class for list view tables. This class has the data provider for
1544 the list view table.
1545 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1546 methods for related list tables. Add more information to the
1547 LayoutItemField and LayoutItemPortal DTOs.
1548 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1549 Remove debugging print statement.
1550 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1551 Remove debugging print statements. Add primary key field to SQL count
1553 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1554 Remove unnecessary LayoutFieldVector parameter from
1555 getResultSizeOfSQLQuery() method.
1556 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1557 New class for related list table database access.
1558 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1559 class that is a wrapper DTO for details view layout and data.
1560 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1561 new 'fromField' string to this DTO.
1562 * src/main/webapp/style.css: Remove bottom margin and override top
1565 2011-09-15 Ben Konrath <ben@bagu.org>
1567 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1569 This sets things up to make it easier to add the data retrieval for
1570 related lists (portals). No user noticeable changes were made with
1573 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1574 class has the code to retrieve the layouts and access the
1575 database using the new database helper classes.
1576 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1577 Most of the functionality has been removed from this class. This
1578 class now represents the public interface for the client side
1579 code. It also deals with configuring the servlet and cleaning
1580 things up when the servlet is stopped.
1581 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1582 of static methods into this utility class.
1583 * src/main/java/org/glom/web/server/database/DBAccess.java:
1584 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1585 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1586 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1587 These classes have the database retrieval code. The class hierarchy
1588 has been setup to make it easy to reuse code for similar
1591 2011-09-06 Ben Konrath <ben@bagu.org>
1593 Create separate classes for list table code and the data provider.
1595 As part of this refactor, I also split up the code a bit to make it
1598 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1599 table code to two new classes (below).
1600 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1601 with code from ListViewImpl.
1602 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1603 New file with code from ListViewImpl.
1605 2011-09-06 Ben Konrath <ben@bagu.org>
1607 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1609 This fixes the LayoutItemPortal DTO to match the libglom layout object
1612 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1614 2011-09-01 Ben Konrath <ben@bagu.org>
1616 Set title of Portals in the Details View.
1618 * pom.xml: Bump required version of java-libglom to 1.17.1.
1619 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1620 widget creation to its own class. Add comments to constructor.
1621 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1622 The code is mostly from the Group class with the title now set.
1623 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1624 title of Portal. Update some comments. Fix some code formatting.
1626 2011-09-01 Ben Konrath <ben@bagu.org>
1628 Remove TODO comment for the flow table column width.
1630 The flow table column width is working correctly and doesn't need to be
1631 changed. See this mailing list post for more info:
1633 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1635 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1637 2011-08-27 Ben Konrath <ben@bagu.org>
1639 Add document title (database name) to top of the browser page.
1641 I added the document title to the TableSelecitonView but that will
1642 change if / when we add a view that doesn't require table selection.
1644 * mockups/details-contacts.html:
1645 * mockups/details-projects.html:
1646 * mockups/listview-contacts.html:
1647 * mockups/listview-projects.html:
1648 * mockups/style.css: Add document title to mockups to keep things
1650 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1651 sizes to account for the document title.
1652 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1653 Set the document title when it has been retrieved from the server.
1654 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1655 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1656 and implement setDocumentTitle(String) method.
1657 * src/main/webapp/style.css: Add ID for document title style.
1659 2011-08-25 Ben Konrath <ben@bagu.org>
1661 Add NavigationType enum to LayoutItemPortal DTO.
1663 This is the start of adding support for Portals to the Details View.
1665 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1666 LayoutItem_Portal.navigation_type enum from libglom to
1667 LayoutItemPortal.NavigationType enum.
1668 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1669 NavigationType enum, field for storing the NavigationType and getter
1672 2011-08-25 Ben Konrath <ben@bagu.org>
1674 Implement the flow table layout in the Details View.
1676 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1677 FlowTable to Group to account for the renamed class.
1678 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1679 File. This is a container widget that implements the Glom details view
1680 flow table behaviour.
1681 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1682 org/glom/web/client/ui/FlowTable.java.
1683 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1684 so that the size of the subgroups are a closer match to the size of
1685 the Glom subgroups. This makes the flowtable layout match the layout
1686 in Glom for the Music Collection example file.
1688 2011-08-16 Ben Konrath <ben@bagu.org>
1690 Create container element for LayoutItemPortal in Details View.
1692 This will help me develop the layout for the FlowTable.
1694 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1695 fieldPanel variable to detailsCell.
1697 2011-08-15 Ben Konrath <ben@bagu.org>
1699 Set the height of the data element in the Details View.
1701 I changed the InlineLabels (text in a span element) to Labels (text in
1702 a div element) so that I could set the height of the details-data
1703 elements instead of the details-cell parent elements. This allows the
1704 the details-data element to display the correct height if style is
1705 applied that shows the height.
1707 This change has the added benefit of allowing the order of the labels
1708 and data elements to be changed for right-to-left languages.
1710 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1711 InlineLabels to Labels.
1712 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1713 InlineLabels to Labels. Set the height of the data element.
1714 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1715 multiline text height in the Formatting DTO.
1716 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1717 for multiline height along with getter and setter methods.
1718 * src/main/webapp/style.css: Adjust style to account for the change
1719 from span elements to div elements in the details cell.
1721 2011-08-15 Ben Konrath <ben@bagu.org>
1723 Make the List View appearance match the mockups.
1725 It doesn't match exactly but it's much better than it was.
1727 * mockups/listview-contacts.html: Remove unused css classes.
1728 * mockups/listview-projects.html: Remove unused css classes.
1729 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1730 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1731 for mainPanel instead of VerticalPanel (table). Set style name on
1732 CellTable. Set style name on Details column. Right-align Details
1734 * src/main/webapp/style.css: Adjust properties to match the mockups.
1736 2011-08-12 Ben Konrath <ben@bagu.org>
1738 Add better support for subgroups in the details view.
1740 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1741 changed FlowTable constructor.
1742 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1743 support for subgroups and subgroup-titles.
1744 * src/main/webapp/style.css: Add CSS class for subgroups and
1747 2011-08-12 Ben Konrath <ben@bagu.org>
1749 Return the top level LayoutGroup title.
1751 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1753 2011-08-11 Ben Konrath <ben@bagu.org>
1755 Make the TableSelector header match the mockup.
1757 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1758 the layout panel. Properly lineup the table selection header with
1759 the list and details view.
1760 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1761 margin around the details view.
1762 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1763 Rename listBox variable to tableSelector. Set id for the style sheet.
1764 Use a FlowPanel instead of a HorizontalPanel.
1765 * src/main/webapp/style.css: Add properties to make the TableSelector
1766 box match the mockups.
1768 2011-07-13 Ben Konrath <ben@bagu.org>
1770 Update install script for java-libglom version change.
1772 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1775 2011-07-13 Ben Konrath <ben@bagu.org>
1777 Add support sub-group in the details view.
1779 I also removed the code that special-cased the default details view
1782 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1784 I still have to make a proper flowtable.
1786 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1787 Don't special-case default details view layout.
1788 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1789 addLayoutField() as I'm going to use it.
1790 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1791 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1793 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1794 extracted from DetailsViewImpl.GroupPanel. Add support for
1796 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1797 column count when getting the details layout.
1799 2011-07-12 Ben Konrath <ben@bagu.org>
1801 Set browser title with database and table titles.
1803 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1804 Set the browser title when the table changes and when the activity
1806 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1807 title when retrieving document info (the GlomDocument object).
1808 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1809 with getter and setter methods. Remove unused convenience constructor.
1810 Use default code formatting.
1812 2011-07-12 Ben Konrath <ben@bagu.org>
1814 Ignore LayoutItemPortals in the details view.
1816 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1819 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1820 LayoutItemPortal layout objects.
1821 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1822 LayoutItemPortal objects when retrieving the details layout.
1823 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1824 file. This is an empty class and just used to get type information for
1827 2011-07-12 Ben Konrath <ben@bagu.org>
1829 Use java-libglom 1.17.0.
1833 2011-07-11 Ben Konrath <ben@bagu.org>
1835 Remove "Table:" label from table selector.
1837 This matches a recent change in the Glom UI.
1839 * mockups/details-contacts.html:
1840 * mockups/details-projects.html:
1841 * mockups/listview-contacts.html:
1842 * mockups/listview-projects.html: Remove the "Table:" label from the
1844 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1846 2011-07-11 Ben Konrath <ben@bagu.org>
1848 Add main groups to the details view.
1850 This makes things look a little nicer in the details view. The next step
1851 is to implement the flowtable.
1853 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1854 resources from the standard gwt css theme. Standard.css is now
1855 included in OnlineGlom.html so that the online glom css rules have
1856 precedence over the gwt theme.
1857 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1858 the whole LayoutGroup to the DetailsView instead of just the titles.
1859 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1860 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1861 details layout with a helper class (GroupPanel). I might extract this
1862 class when I make the full flowtable.
1863 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1864 string as default so I don't have to worry about NPEs when processing
1866 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1867 note beside OnlineGlom.gwt.xml above).
1868 * src/main/webapp/style.css: Add default font-size to body to override
1869 the font-size set by the standard theme. Don't use h2 tags for
1870 group-title. Create new details-cell class.
1872 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1874 ConfiguredDocument: Set the port number too.
1876 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1877 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1878 Glom document. Presumably this worked sometimes so far because there is a
1879 default port number.
1881 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1883 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
1885 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1886 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
1887 correct, though we should throw an exception too.
1889 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1891 Fix a addDocuemnt typo.
1893 * src/main/java/org/glom/web/shared/Documents.java
1894 (Documents.addDocuemnt): Rename to addDocument().
1895 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1896 (OnlineGlomServiceImpl.getDocuments): Adapt.
1898 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1900 Slightly improved log output when connection fails.
1902 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1903 (ConfiguredDocument.setUsernameAndPassword):
1904 We don't know for sure if it' the username/password that's wrong, so
1905 rephrase the message.
1906 Also ouput the exception message, though it's generic in this case.
1908 2011-07-08 Ben Konrath <ben@bagu.org>
1912 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
1913 added braces to a one line if statement because the Eclipse formatter
1914 was getting confused.
1916 2011-07-07 Ben Konrath <ben@bagu.org>
1918 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
1920 These should really be two separate tasks but I counldn't get things to
1921 work with GWT 2.2.0 and Eclipse 3.7.
1925 * .settings/org.eclipse.jdt.core.prefs:
1926 * .settings/org.eclipse.jdt.ui.prefs:
1927 * .settings/org.eclipse.ltk.core.refactoring.prefs:
1928 * .settings/org.eclipse.m2e.core.prefs:
1929 Add new config files. Update current files. Remove references to the
1930 webtools plugins as we're not using any of the webtools features.
1931 * .gitignore: Add logs directory which is created when running with
1933 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
1934 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
1935 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
1937 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
1939 2011-07-07 Murray Cumming <murrayc@murrayc.com>
1941 onlineglom.properties: Add explanatory comments.
1943 * src/main/resources/onlineglom.properties: Also change the default user
1944 from ben to someuser, to avoid the risk of people thinking we just
1945 stupidly hard-coded a locale path, when they see that on stderr or in a log.
1947 2011-06-28 Ben Konrath <ben@bagu.org>
1949 Use filename in Log for incorrect passwords.
1951 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1952 getFileName(String) method to get the filename from the URI.
1954 2011-06-28 Ben Konrath <ben@bagu.org>
1956 Add the table name to the URL token for the ListPlace.
1958 This makes things consistent between the DetailsPlace and the
1959 ListPlace. It also allows the the ListPlace to be bookmarked.
1961 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1962 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1963 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1964 Remove getDefaultListLayout(). The default layout is now returned
1965 by the getListLayout() method when the table name is an empty string.
1966 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1967 Add table name field. Change to a new ListPlace when the table
1968 has been changed. Use getListLayout() for getting the default
1970 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1971 Add table name field. Set the correct table name in the list box
1972 when loading from bookmark. This corrects a problem for the
1974 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1975 Move table name to super-class (HasSelectableTable). Move document
1976 and table URL keys to super-class in HasSelectableTable.
1977 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1978 Add table name field. Add Tokenizer class with URL key common to
1979 the subclasses (DetailsPlace and ListPlace).
1980 * src/main/java/org/glom/web/client/place/ListPlace.java:
1981 Add table name. Add code to parse the URL token.
1982 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1983 Update ListPlace construction with empty table name string.
1984 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1985 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1986 Change setTableSelectedIndex(int) to setSelectedTableName(String).
1987 Update ListPlace construction with table name string.
1988 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1989 Change defaultTableName field to tableName to reflect how it's now
1990 used. Update the getter and setter methods.
1992 2011-06-28 Ben Konrath <ben@bagu.org>
1994 Enable the table selector in the DetailsView.
1996 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1997 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1998 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1999 Remove getDefaultDetailsLayout(). The default layout is now returned
2000 by the getDetailsLayout() method when the table name is an empty
2002 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2003 event handler for table change event. Change to using
2004 getDetailsLayout() for the default details layout.
2005 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2007 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2008 when navigating to the details place.
2010 2011-06-27 Ben Konrath <ben@bagu.org>
2012 Use filename based unique document ID in URL and for RPC.
2014 The document ID is the glom document name with spaces (' ') replaced
2015 with pluses ('+') and without the .glom extension.
2017 This change is mostly a string substitution of 'documentTitle' for
2018 'documentID'. The only code change is the addition of a Documents DTO to get the
2019 filename to document title mappings as indicated below.
2021 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2022 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2023 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2024 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2025 Use Documents DTO to create the document links in the document
2027 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2028 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2029 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2030 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2031 * src/main/java/org/glom/web/client/place/ListPlace.java:
2032 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2033 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2034 * src/main/java/org/glom/web/client/ui/ListView.java:
2035 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2036 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2037 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2038 * src/main/java/org/glom/web/server/Log.java:
2039 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2040 getDocumentTitles() to getDocuments() and return the Documents DTO.
2041 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2042 transferring the filename to document title mappings.
2044 2011-06-25 Ben Konrath <ben@bagu.org>
2046 Make the authentication popup work again.
2048 This bug was introduced when I extracted ConfiguredDocument to its own class.
2050 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2051 correct success / fail status in setUsernameAndPassword().
2053 2011-06-25 Ben Konrath <ben@bagu.org>
2055 Use filename as unique key for configuring database usernames and passwords.
2057 This replaces the use of the Glom document title which could change
2058 depending on the locale. Thanks to Murray Cumming for pointing out this
2061 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2062 * src/main/resources/onlineglom.properties:
2064 2011-06-24 Ben Konrath <ben@bagu.org>
2066 Pass primary key value to DetailsView.
2068 This enables the DetailsView to load the correct data.
2070 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2071 primary key value field and set in constructor. Pass primary key
2072 value to getDetailsData().
2073 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2074 variables for document title and primary key value.
2075 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2076 key value to the DetailsPlace.
2078 2011-06-24 Ben Konrath <ben@bagu.org>
2080 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2082 This allows the primary key to be retrieved by the Details button. This
2083 functionality has not been implemented yet but it's in the works.
2085 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2086 the LayoutGroup result to ListView.setCellTable instead of all of its
2087 fields individually.
2088 * src/main/java/org/glom/web/client/ui/ListView.java:
2089 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2090 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2091 get the primary key for the table.
2092 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2093 index of the primary key in the LayoutGroup accounting for hidden
2094 primary keys. Rename getJavaNumberFormat() to
2095 convertToJavaNumberFormat() for consistency. Cleanup / add some
2097 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2098 field for primary key index and a field to indicate whether the
2099 primary key is hidden or not.
2101 2011-06-23 Ben Konrath <ben@bagu.org>
2103 Rename getTableData methods to getListData.
2105 This is a rename refactor for consistency with other methods.
2107 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2108 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2109 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2110 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2112 2011-06-23 Ben Konrath <ben@bagu.org>
2114 Extract the ConfiguredDocument innerclass into its own class.
2116 This makes the servlet code more object oriented.
2118 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2119 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2120 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2121 new ConfiguredDocument class.
2123 2011-06-21 Ben Konrath <ben@bagu.org>
2125 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2127 This makes things more inline with how libglom works and reduces code
2128 duplication. This refactor lays the groundwork for adding the primary key to
2129 the LayoutGroup object.
2131 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2132 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2133 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2134 Change method names to getListLayout and getDefaultListLayout for
2135 consistency. Use LayoutGroup as the DTO for the list layout instead of
2136 ColumnInfo and LayoutListTable.
2137 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2138 new method names along with the LayoutGroup object for transferring the
2140 * src/main/java/org/glom/web/client/ui/ListView.java:
2141 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2142 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2143 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2145 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2146 Replaced with LayoutGroup.
2147 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2148 expectedResultSize and defaultTableName fields which are needed for
2150 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2151 type field which is needed for the list layout but will also be
2152 useful for the details layout as things progress.
2153 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2154 Make class abstract. Remove the unnecessary
2155 getFormattingHorizontalAlignment method. Add setFormatting method.
2157 2011-06-16 Ben Konrath <ben@bagu.org>
2159 Add scripts for building and installing war.
2161 These will help when updating OnlineGlom but they're also good
2162 supplemental documentation of the build and deployment proceeding.
2164 * utils/build-onlineglom-war.sh: New file.
2165 * utils/install-onlineglom-war.sh: New file.
2167 2011-06-16 Ben Konrath <ben@bagu.org>
2169 Create wrapper class to create consistent log messages.
2171 I wrapped methods in the Log class of gwt-log to add the method names
2172 from the servlet and create consistent formatting of the document title
2173 and table names in the log messages.
2175 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2176 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2177 log methods to use methods from wrapped Log class.
2179 2011-06-16 Ben Konrath <ben@bagu.org>
2181 Remove superfluous conditional return.
2183 Thanks to Murray Cumming for pointing this out!
2185 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2187 2011-06-15 Ben Konrath <ben@bagu.org>
2189 Return an ArrayList of LayoutGroups for the Details layout.
2191 This corrects a problem with the details layout as it can have more
2192 than one top level LayoutGroup.
2194 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2195 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2196 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2197 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2198 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2199 with ArrayList of LayoutGroups for the details view layout.
2200 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2201 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2202 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2203 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2204 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2205 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2207 2011-06-14 Ben Konrath <ben@bagu.org>
2209 Use cast_dynamic method to determine the libglom LayoutItem type.
2211 This is better than finding the LayoutItem type by using the string
2212 returned from the get_part_type_name() method.
2214 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2216 2011-06-14 Ben Konrath <ben@bagu.org>
2218 Add method names to log entries in the servlet.
2220 This helps when tracking down deployment problems.
2222 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2224 2011-06-14 Ben Konrath <ben@bagu.org>
2226 Add data to the DetailsView using a hard-coded primary key value.
2228 The layout and functionality of the DetailsView is not complete. This
2229 is just a checkpoint so the patch doesn't get too big.
2231 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2232 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2233 Add getDetailsData() servlet method.
2234 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2235 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2236 LayoutFields are added to the DetailsView.
2237 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2238 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2239 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2240 take the string for the title instead of the object.
2241 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2242 Add implementation getDetailsData() along with some private helper
2244 * src/main/webapp/style.css: Add padding to details-data class. Add a
2245 details-label class with the same padding as the details-data class.
2247 2011-06-03 Ben Konrath <ben@bagu.org>
2249 Use presenter.goTo() to change to the DetailsPlace.
2251 This will make things easier when we need to open the DetailsView with
2252 data specific to the row that was clicked.
2254 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2256 2011-06-02 Ben Konrath <ben@bagu.org>
2258 Add CSS file from mockups.
2260 I'm adding this now because it's going to be useful to have when
2261 developing the DetailsView. The TableSelectionView and ListView aren't
2264 * src/main/webapp/OnlineGlom.html:
2265 * src/main/webapp/style.css:
2267 2011-06-02 Ben Konrath <ben@bagu.org>
2269 Use String.isEmpty() to check for empty string.
2271 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2273 2011-06-02 Ben Konrath <ben@bagu.org>
2275 Display main layout group titles in the DetailsView.
2277 This is the start of the DetailsActivity/DetailsView implementation.
2279 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2280 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2281 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2282 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2283 Get the layout information for the details view from the server and set
2284 the main layout group titles.
2285 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2286 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2287 Add addLayoutGroup() and addLayoutField() methods. This are just
2288 temporary methods for creating the the details view that will change
2290 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2291 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2293 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2294 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2295 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2296 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2297 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2298 Data Transfer Objects that mimic the libglom object structure. These are
2299 used for transferring the details layout but could also be used for
2300 transferring the list layout.
2302 2011-05-27 Ben Konrath <ben@bagu.org>
2304 Reset the AuthenticationPopup when clearing the ListView.
2306 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2308 2011-05-27 Ben Konrath <ben@bagu.org>
2310 Fix problem with onlineglom.properties file loading.
2312 The old way worked in Eclipse but not on the server. Loading the
2313 onlineglom.properties file now works in Eclipse and on the server.
2315 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2317 2011-05-24 Ben Konrath <ben@bagu.org>
2319 Update gwt-log from 3.1.0 to 3.1.2.
2321 Gwt-log 3.1.0 has been marked as depreciated.
2325 2011-05-24 Ben Konrath <ben@bagu.org>
2327 Add comment to ListActivity.goTo() method.
2329 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2331 2011-05-24 Ben Konrath <ben@bagu.org>
2333 Remove FIXME in convertGdkColorToHtmlColour()
2335 The Gdk::Color value returned by libglom is 16-bits per channel on both
2336 64 and 32-bit platforms.
2338 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2340 2011-05-19 Ben Konrath <ben@bagu.org>
2342 Improve performance of initial ListView load.
2344 I removed a round trip to the server for getting the default table name
2345 and then requesting information about that table. This also removes a potential
2346 problem with the table change handler not being setup in time to receive the
2347 table change event from the ListActivity.
2349 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2350 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2351 getDefaultLayoutListTable() method. Improve comments.
2352 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2353 getDefaultLayoutListTable() method instead of firing a table change
2354 event to get the table to load.
2355 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2356 implementation of getDefaultLayoutListTable() method.
2357 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2360 2011-05-19 Ben Konrath <ben@bagu.org>
2362 Override toDebugString() in TableChangeEvent.
2364 This is useful to have for debugging.
2366 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2368 2011-05-19 Ben Konrath <ben@bagu.org>
2370 Add a "Back to List" link when at the DetailsPlace.
2372 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2373 Populate the CellTable based on the selected table of the ListBox if
2374 it's set otherwise use the default table. This allows the "Back to
2376 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2377 Remove Place from constructors. Add a setPlace() method. Add
2378 goToPlace() method. Set class as presenter for TableSelectionView.
2379 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2380 Use the same TableSelectionActivity when switching between the List and
2382 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2383 Subclass the new HasSelectableTablePlace. This removes some duplicate
2385 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2386 New class to represent Places that display the TableSelectionView.
2387 * src/main/java/org/glom/web/client/place/ListPlace.java:
2388 Subclass the new HasSelectableTablePlace. This removes some duplicate
2390 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2391 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2392 Add Presenter interface. Add setBackLinkVisible() method. Add
2393 setBackLink() method.
2395 2011-05-18 Ben Konrath <ben@bagu.org>
2397 Enable the "Details" buttons.
2399 Right now only an empty details view is displayed.
2401 * src/main/java/org/glom/web/client/ClientFactory.java:
2402 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2403 Add DetailsView to ClientFactory.
2404 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2405 A basic activity for the details view.
2406 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2407 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2409 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2410 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2412 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2413 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2414 unnecessary super() in constructor.
2415 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2416 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2417 really shouldn't create a new TableSelectionActivity for both the ListPlace
2418 and the DetailsPlace so this should be considered a temporary solution.
2419 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2420 New file. Represents a URL for the details view.
2421 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2422 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2423 A basic details view interface and implementation.
2424 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2425 Enable the "Details" buttons.
2427 2011-05-12 Ben Konrath <ben@bagu.org>
2429 Use a LayoutPanel with multiple display areas for main layout.
2431 This is mostly a refactor in that there are no changes from the user
2432 point of view. These changes are required so that we can swap out the list view
2433 with the details view when the user clicks the "Details" button.
2435 * src/main/java/org/glom/web/client/ClientFactory.java:
2436 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2437 OnlineGlomView. Add TableSelectionView, ListView and
2438 AuthenticationPopup.
2439 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2440 for main layout. Add display regions for main activities. Add
2441 activity manager for for main activities.
2442 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2443 file from parts of the deleted OnlineGlomActivity.
2444 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2445 New file from parts of the deleted OnlineGlomActivity.
2446 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2447 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2448 New files for app wide table change event.
2449 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2450 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2451 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2452 Activity mappers for the main activities replace the deleted app-wide
2454 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2455 Fix a spelling error in he comment.
2456 * src/main/java/org/glom/web/client/ui/ListView.java:
2457 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2458 Renamed from LayoutListView and modified for MVP. This still not a
2459 proper dumb view as prescribed by the MVP pattern but it works for now.
2460 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2461 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2462 New widget stripped out of the deleted OnlineGlomView.
2463 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2464 Remove hack that is fixed by this patch.
2466 2011-05-06 Ben Konrath <ben@bagu.org>
2468 Rename OnlineGlomPlace to ListPlace.
2470 The only change besides the rename is that url will now display #list
2471 instead of #Document.
2473 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2474 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2475 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2476 * src/main/java/org/glom/web/client/place/ListPlace.java:
2477 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2479 2011-05-06 Ben Konrath <ben@bagu.org>
2481 Use Presenter for app navigation.
2483 This is the proper way to deal with Place (URL) changes with the MVP
2486 * src/main/java/org/glom/web/client/ClientFactory.java:
2487 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2488 PlaceHistoryMapper and PlaceHistoryHandler.
2489 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2490 PlaceHistoryMapper and PlaceHistoryHandler.
2491 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2492 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2493 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2494 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2495 Add Presenter interface and setPresenter methods. Rename addHyperLink
2496 to addDocumentLink taking only the document title as a parameter.
2498 2011-04-14 Ben Konrath <ben@bagu.org>
2500 Prompt for db username/password if they haven't been set.
2502 This is implemented with a popup widget that is contained within the
2503 OnlineGlomView and managed by the OnlineGlomActivity.
2505 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2506 methods for checking and setting the database username and password.
2507 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2508 new methods for checking and setting the database username and
2510 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2511 Display authentication popup if the JDBC connection to the database
2512 has not been authenticated.
2513 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2515 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2516 for dealing with the authentication popup.
2517 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2518 Implement the methods for dealing with the authentication popup.
2519 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2520 try to executed queries if the database connection hasn't been
2521 authenticated. Implement methods for checking and setting the
2522 database username and password.
2524 2011-04-12 Ben Konrath <ben@bagu.org>
2526 Make log messages a little clearer.
2528 Add a dash betweeen the document title and the table name.
2530 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2532 2011-04-12 Ben Konrath <ben@bagu.org>
2534 Protect against NPEs when cleaning up database resources.
2536 While this isn't strictly necessary because the exception is caught,
2537 not protecting against the NPEs makes it harder to find the real error
2540 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2542 2011-04-12 Ben Konrath <ben@bagu.org>
2544 Move configuration of the servlet to the constructor.
2546 The servlet will be initialized even if the database authentication
2547 information is not set or correct. I still need to add the UI for prompting
2548 the user for the authentication information when it's required.
2550 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2551 javadocs for getDocumentTitles() method.
2552 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2553 Set error message when RPC fails.
2554 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2555 glom files directory from the configuration file. Try to set the
2556 database authentication information for the specific document if it's
2557 set and works otherwise try to use the global authentication
2558 information set for the directory.
2559 * src/main/resources/onlineglom.properties: Moved from
2560 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2561 Added detailed comments for the new keys.
2563 2011-04-11 Ben Konrath <ben@bagu.org>
2565 Remove unnecessary @Override in DocumentSelectionViewImpl.
2567 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2569 2011-04-11 Ben Konrath <ben@bagu.org>
2571 Remove center alignment in DocumentSelectionView.
2573 The title element is still centred but the document titles and bottom
2574 sentence are both left-aligned.
2576 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2578 2011-04-11 Ben Konrath <ben@bagu.org>
2580 Change 'Demo' naming convention to 'Document'.
2582 This is just a rename refactor with no functional changes to the code.
2584 * src/main/java/org/glom/web/client/ClientFactory.java:
2585 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2586 * src/main/java/org/glom/web/client/OnlineGlom.java:
2587 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2588 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2589 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2590 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2591 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2592 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2593 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2594 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2595 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2596 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2598 2011-04-08 Ben Konrath <ben@bagu.org>
2600 Remove FIXME from safeLongToInt() method.
2602 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2605 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2607 2011-04-08 Ben Konrath <ben@bagu.org>
2609 Display an error if no glom documents are found in the specified directory.
2611 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2612 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2613 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2614 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2616 2011-04-08 Ben Konrath <ben@bagu.org>
2618 Add copyright header to one more file ... oops.
2620 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2622 2011-04-08 Ben Konrath <ben@bagu.org>
2624 Add copyright header to files without it.
2626 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2627 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2628 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2629 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2630 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2631 * src/main/java/org/glom/web/shared/GlomField.java:
2633 2011-04-08 Ben Konrath <ben@bagu.org>
2635 Add support for accessing multiple glom documents in the servlet.
2637 This completes the demo selection functionality.
2639 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2640 document title to methods.
2641 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2642 document title to methods.
2643 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2644 Set browser window title when the activity starts. Correct name of
2645 document title variable.
2646 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2647 Set browser window title when the activity starts. Set the table
2648 selector change handler after table selector has been set. Clear the
2649 OnlineGlomView when the activity has been stopped.
2650 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2651 document title as the place token. Use "#Document:" instead of
2652 "#OnlineGlomPlace:" in the URL.
2653 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2654 Change heading to "Online Glom"
2655 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2656 document title in RPC methods.
2657 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2658 setDocumentTitle() method. Add clear() method.
2659 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2660 setDocumentTitle() method. Implement clear() method which removes the
2661 change handler on the ListBox, clears the ListBox and clears the
2663 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2664 Implement methods with document title. Keep track for the configured
2665 glom documents and their corresponding JDBC configurations in a hash
2666 table. This information is retrieved using the document title as the
2667 key in the hash table.
2668 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2669 document title field as it's no longer needed.
2671 2011-04-08 Ben Konrath <ben@bagu.org>
2673 Update the Eclipse JDT configuration.
2675 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2676 methods. Automatically add the copyright header to new files.
2678 2011-04-05 Ben Konrath <ben@bagu.org>
2680 Add new page for demo selection.
2682 This patch adds all the components required to view and start an
2683 OnlineGlom demo by clicking on the desired hyperlink. The user is
2684 able to return to the demo selection page with the browser's back
2685 button. I still need to modify the servlet to work with multiple
2686 documents so all demo links will load the file defined in the
2687 OnlineGlom.properties.
2689 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2690 This is only useful during development so we don't need to save it.
2691 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2692 get a reference to the DemoSelectionView.
2693 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2694 method to get a reference to the DemoSelectionView.
2695 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2696 default view to DemoSelectionView.
2697 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2698 to get glom document titles for glom files in a hard-coded directory.
2699 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2700 method to get glom document titles for glom files in a hard-coded
2702 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2703 Presenter for DemoSelectionView.
2704 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2705 for DemoSelectionView.
2706 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2707 Update for DemoSelectionView.
2708 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2709 Basic 'Place' implementation for the DemoSelectionView.
2710 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2711 The interface for the DemoSelectionView.
2712 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2713 The implementation of the DemoSelectionView.
2714 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2715 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2716 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2717 implementation of method to get glom document titles for glom files
2718 in a hard-coded directory.
2719 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2720 on longer being used.
2721 * src/main/webapp/glom.png: Glom logo.
2723 2011-04-05 Ben Konrath <ben@bagu.org>
2725 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2727 This is the forth and final commit of a refactor that will allow
2728 OnlineGlom to be used with multiple documents.
2730 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2731 Move RPC code from OnlineGlomViewImpl to this class.
2732 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2734 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2735 RPC code to the presenter class (the P in MVP).
2737 2011-04-04 Ben Konrath <ben@bagu.org>
2739 Start moving the existing OnlineGlom code to MVP.
2741 This work is based on the GWT MVP framework that is documented here:
2743 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2745 This is the third commit of a refactor that will allow OnlineGlom to
2746 be used with multiple documents.
2748 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2749 Interface for client factory which is used to get instances of various
2750 classes throughout the app.
2751 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2752 Implementation of client factory.
2753 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2754 initialize the MVP framework.
2755 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2756 New file. Activity manager for the main container widget. This is the
2758 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2759 Maps place (URL) to its corresponding activity.
2760 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2761 New file. This is just a place holder for a generated file.
2762 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2763 New file. Represents the URL for the main Online Glom app.
2764 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2765 for changes in LayoutListViewImpl.
2766 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2767 interface for View. Move code to OnlineGlomViewImpl class.
2768 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2769 file. Implementation of OnlineGlomView.
2770 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2771 Place resources. Use ClientFactoryImpl by default.
2773 2011-04-04 Ben Konrath <ben@bagu.org>
2775 Move View classes to their own package.
2777 This is the second commit of a refactor that will allow OnlineGlom to
2778 be used with multiple documents.
2780 * src/main/java/org/glom/web/client/OnlineGlom.java:
2781 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2782 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2784 2011-04-02 Ben Konrath <ben@bagu.org>
2786 Move UI code from the main module to its own class.
2788 This is the first commit of a refactor that will allow OnlineGlom to be
2789 used with multiple documents.
2791 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2792 references to OnlineGlom to OnlineGlomView.
2793 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2794 OnlineGlomView and instantiate it here.
2795 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2796 represents the main OnlineGlomView with one document.
2798 2011-04-01 Ben Konrath <ben@bagu.org>
2800 Fix formatting of gwt.xml and add DTD.
2802 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2804 2011-03-30 Ben Konrath <ben@bagu.org>
2806 Propperly convert gdkColor string to html colour string.
2808 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2810 2011-03-28 Ben Konrath <ben@bagu.org>
2812 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2814 This implementation matches
2815 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2816 readable and is not tied to Swig.
2818 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2820 2011-03-28 Ben Konrath <ben@bagu.org>
2822 Use read-only checkboxes for boolean field types.
2824 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2825 in the CellTable based on the field type. It currently only
2826 distinguishes between boolean and text columns but I'll need to add
2827 support for more types.
2828 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2829 column type in the ColumnInfo object. Add method to convert between the
2830 glom field type enum in ColumnInfo and the glom field type in libglom.
2831 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2833 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2834 getting and setting booleans.
2836 2011-03-25 Ben Konrath <ben@bagu.org>
2838 Don't get the Date twice from the ResultSet.
2840 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2842 2011-03-25 Ben Konrath <ben@bagu.org>
2844 Cleanup code in the servlet.
2846 * TODO: Remove item about row count. Add item about testing row count
2847 query with large number of rows.
2848 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2849 spelling mistakes, change method parameter to be consistent with
2852 2011-03-25 Ben Konrath <ben@bagu.org>