1 2012-01-01 Murray Cumming <murrayc@murrayc.com>
3 Tests: Added the beginnings of a test using gwt-test-utils.
5 * pom.xml: Add dependencies on gwt-test-utils and easymock.
6 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
7 which tells gwt-test-utils what class will be tested.
8 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
9 Add a simple (but empty) test case. One class, used by the OnlineGlom
10 class, is mocked so that it can be created. However, I am not sure
11 why only this class needs to be mocked.
13 Note that mockito seems more popular, and clearer, than easymock,
14 but I have not got that working yet. It might be a matter of the
17 2011-12-31 Murray Cumming <murrayc@murrayc.com>
19 Tests: Use junit4-style syntax instead of junit3-style.
21 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
22 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
23 * src/test/java/org/glom/web/shared/DataItemTest.java:
24 Use the @Test annotation rather than relying on the test*() prefix.
25 Also no longer implement TestCase, to avoid triggering support for
26 the junit3-way, which stops the annotations from working.
27 Change the imports from import junit.framework.* to
28 import org.junit.*, which is apparently the new way.
30 2011-12-31 Murray Cumming <murrayc@murrayc.com>
32 Added a test for ListPlace token parsing and creation.
34 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
35 This is much the same as DetailsPlaceTest.
37 I wonder how we could test the other parts of the *Place API.
39 2011-12-30 Murray Cumming <murrayc@murrayc.com>
41 DetailsPlace test: Also test getToken() and recreation via getPlace().
43 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
44 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
45 recreate it, testing the recreated DetailsPlace for the same parameter
48 2011-12-30 Murray Cumming <murrayc@murrayc.com>
50 Use the surefire-report plugin.
52 * pom.xml: This generates a HTML report about the tests in
53 target/site/surefire-report.html
54 when you do mvn surefire-report:report. It seems to be popular/normal.
56 2011-12-30 Murray Cumming <murrayc@murrayc.com>
58 Added a test for DetailsPlace.
60 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
61 Test the getPlace() token parsing.
63 2011-12-30 Murray Cumming <murrayc@murrayc.com>
65 Added a first unit test.
67 * pom.xml: Add a test goal, and a dependency on junit in that scope.
68 * src/test/java/org/glom/web/shared/DataItemTest.java:
69 This is a silly test but it is just to get things started. Note that
70 maven/junit finds the test because it looks in src/test by default.
72 2011-12-22 Ben Konrath <ben@bagu.org>
74 Change charsetName to "UTF-8" when replacing line breaks.
76 JavaScript requires the charsetName to be "UTF-8". CharsetName values
77 that work in Java (such as "UTF8") will not work when compiled to
80 This fixes a problem with multi-line details view fields that have hard
81 line breaks. The "License Text" field on this page demonstrates the
84 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
86 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
88 2011-12-22 Ben Konrath <ben@bagu.org>
90 Fix another bug with related list navigation.
92 I've tested all the navigation buttons in all of the related lists
93 so things should be good now.
95 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
97 2011-12-22 Ben Konrath <ben@bagu.org>
99 Fix a crasher when refreshing the list view with the default table.
101 This crash will also happen when loading the list view with the default
102 table from a link or bookmark.
104 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
105 to the main document selection page when the document id hasn't been
107 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
108 the main document selection page when the document id hasn't been
110 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
111 values for the details place when the document id hasn't been set.
112 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
113 values for the list place when the document id hasn't been set.
115 2011-12-21 Ben Konrath <ben@bagu.org>
117 Protect against NPE when glom.document.locale is not in config.
119 This patch protects against an NPE when glom.document.locale is not in
120 the config file. This NPE will also happen if glom.document.locale is
123 The patch also updates the error message to display the class name when
124 the getMessage() returns null. This was happening when the NPE was
125 thrown and I had "Configuration Error: null". If an NPE is encountered
126 with this patch, "Configuration Error: NullPointerException " will be
129 This commit closes this bug:
131 https://bugzilla.gnome.org/show_bug.cgi?id=666669
133 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
135 2011-12-20 Murray Cumming <murrayc@murrayc.com>
137 Rename onlineglom.properties to onlineglom.properties.sample.
139 * src/main/resources/onlineglom.properties: Rename to:
140 * src/main/resources/onlineglom.properties.sample:
141 * src/main/resources/README: And add this file explaining that people
142 should rename it back when deploying.
144 2011-12-20 Murray Cumming <murrayc@murrayc.com>
146 Allow choosing the translation in the .properties file.
148 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
149 init(): Read a glom.document.locale value from the configuration file
150 and call Glom's TransatableItem::set_current_locale() method.
151 * src/main/resources/onlineglom.properties: Add a commented-out
152 example of this new setting.
154 It would be better to add &lang=de_DE to the URL, but the current
155 libglom API does not allow us to do this easily. I am working on that.
157 2011-12-19 Murray Cumming <murrayc@murrayc.com>
159 Avoid a crash in parsing of token parameters.
161 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
162 ava: getTokenParams(): Do not crash if a parameter has a key but no
163 value, and ignore parameters with neither.
165 2011-12-17 Murray Cumming <murrayc@murayc.com>
167 History token building/handling: Improve use of token parameters.
169 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
170 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
171 and buildParamsToken(HashMap), for use by derived classes.
172 Make the separator private because it is no longer be needed.
173 * src/main/java/org/glom/web/client/place/DetailsPlace.java
174 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
175 instead of manual string concatenation.
176 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
177 of hardcoded indices and awkward splitting code.
178 * src/main/java/org/glom/web/client/place/ListPlace.java
179 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
180 instead of manual string concatenation.
181 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
182 of hardcoded indices and awkward splitting code.
183 This should fix bug #666420
185 2011-12-16 Murray Cumming <murrayc@murrayc.com>
187 Fix a Navgiation->Navigation typo in the code.
189 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
190 Rename processNavgiation() to processNavigation().
192 2011-12-16 Murray Cumming <murrayc@murrayc.com>
194 Fix a seperator->separator typo in the code.
196 * src/main/java/org/glom/web/client/place/DetailsPlace.java
197 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
198 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
201 2011-12-15 Ben Konrath <ben@bagu.org>
203 Cleanup some comments.
205 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
207 2011-12-14 Ben Konrath <ben@bagu.org>
209 Replace \n with <br/> for multiline text in the details view.
211 Vertical scrollbars are added when needed as well.
213 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
215 2011-12-14 Ben Konrath <ben@bagu.org>
217 Specify the font for document selection links.
219 * src/main/webapp/style.css:
221 2011-12-14 Ben Konrath <ben@bagu.org>
223 Fix bouncy CellTable while paging.
225 This doesn't currently work with related list tables in unselected
228 * src/main/java/org/glom/web/client/ui/list/ListTable.java
230 2011-12-14 Ben Konrath <ben@bagu.org>
232 Revamp the appearance of the document selection page.
234 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
235 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
236 * src/main/webapp/style.css:
238 2011-12-13 Ben Konrath <ben@bagu.org>
240 Set navigation button column to the smallest size possible.
242 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
244 2011-12-13 Ben Konrath <ben@bagu.org>
246 Change OpenButton nomenclature to NavigationButton.
248 Using NavigtionButton makes things more generic. Classes, methods and
249 variables have been changed.
251 This is a rename-only refactor.
253 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
254 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
255 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
256 Renamed from OpenButtonCell.
257 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
258 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
259 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
261 2011-12-12 Ben Konrath <ben@bagu.org>
263 Remove unnecessary String argument in RelatedListTable and ListViewTable.
265 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
266 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
267 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
268 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
270 2011-12-12 Ben Konrath <ben@bagu.org>
272 Update variable names and comments.
274 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
275 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
277 2011-12-12 Ben Konrath <ben@bagu.org>
279 Properly initialize numNonEmptyRows variable to zero.
281 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
282 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
284 2011-12-05 Ben Konrath <ben@bagu.org>
286 Add latest mockup with HTML tables.
288 Features of this mockup:
290 -> HTML table for flowtable
291 -> HTML table for flowtable column
292 -> Example of how related lists would look
293 -> Not using text entries for data items
295 The current version of Online Glom doesn't use HTML tables for the
298 This mockup has been sent to the glom-devel mailing list but it's good
299 to have it here as well.
301 * mockups/details-view-html-tables.html:
303 2011-12-05 Ben Konrath <ben@bagu.org>
305 Remove unnecessary getPrimaryKeyField() method.
307 getPrimaryKeyFieldForTable(String) has been renamed to
308 getPrimaryKeyField(String).
310 * src/main/java/org/glom/web/server/database/DBAccess.java:
311 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
312 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
314 2011-12-05 Ben Konrath <ben@bagu.org>
316 Add string representation of TypedDataItem value to conversion error message.
318 * src/main/java/org/glom/web/server/Utils.java: Logging the error
319 message was extracted into its own method to avoid duplication.
321 2011-12-05 Ben Konrath <ben@bagu.org>
323 Add type checking to navigation primary key value creation.
325 Create navigation primary key only if the expected type from the Glom
326 document matches the type returned by the SQL query.
328 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
330 2011-12-05 Ben Konrath <ben@bagu.org>
332 Rename a couple of variables in RelatedListNavigation.
334 This is a rename-only refactor.
336 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
338 2011-12-05 Ben Konrath <ben@bagu.org>
340 Move getListLayoutGroup() into getListViewLayoutGroup().
342 This removes getListLayoutGroup(). It was only being called by
343 getListViewLayoutGroup().
345 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
347 2011-12-05 Ben Konrath <ben@bagu.org>
349 Remove check for LayoutItem_Portal in list table method.
351 This check is no longer necessary because the method isn't being used
352 to create the LayoutItemPortal DTO.
354 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
356 2011-12-05 Ben Konrath <ben@bagu.org>
358 Properly support related list navigation.
360 Navigation from the "Repository Analyzer -> Package Scans ->
361 Dependencies" related table wasn't working because the primary key for
362 related tables wasn't being set properly. This commit fixes the
365 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
366 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
367 doesn't set the primary key properly for related list tables.
368 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
369 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
370 useful for getting the primary key for list view tables and for related
372 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
373 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
374 Move code to set the primary key for the table from the abstract
375 ListDBAccess class to ListViewDBAccess as it's only correct for list
377 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
378 Properly add primary key to related list tables.
380 2011-12-02 Ben Konrath <ben@bagu.org>
382 Properly set the horizontal alignment of fields.
384 This fix is for both the list tables and the details view.
386 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
387 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
388 to set the horizontal alignment of fields.
390 2011-12-02 Ben Konrath <ben@bagu.org>
392 Display currency codes in the details view.
394 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
396 2011-12-02 Ben Konrath <ben@bagu.org>
398 Avoid duplicate JNI call.
400 JNI is not as efficient as pure Java and this is an easy (and small)
403 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
404 Use previously retrieved value for whereClauseToTableName instead of
407 2011-12-02 Ben Konrath <ben@bagu.org>
409 Rename a couple of variables in RelatedListNavigation.
411 This is a rename-only refactor.
413 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
415 2011-12-02 Ben Konrath <ben@bagu.org>
417 Indicate clearly that a mismatched primary key type is a bug.
419 * src/main/java/org/glom/web/server/Utils.java: Change log level from
420 warning to error. Add 'This is a bug.' to message.
422 2011-12-02 Ben Konrath <ben@bagu.org>
424 Update / fix some comments.
426 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
428 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
430 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
431 Fix comments. Add some TODOs.
433 2011-12-02 Ben Konrath <ben@bagu.org>
435 Enable navigation to details view with string primary key from related list.
437 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
438 Create a text primary key value when return type of result is
439 java.sql.Types.VARCHAR.
441 2011-12-02 Ben Konrath <ben@bagu.org>
443 Use checkboxes for booleans in the details view.
445 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
447 2011-12-01 Ben Konrath <ben@bagu.org>
449 Improve performance of related list height calculation.
451 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
452 Put code to calculate the expected height in a static initializer so
453 that that it's only called once.
455 2011-12-01 Ben Konrath <ben@bagu.org>
457 Show related list tables in notebooks (again).
459 Calculate the height of the related list tables so the Notebook can be
460 set the correct height. The height of the related list table is also needed by
461 FlowTable to be able decide how to create the layout.
463 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
464 and set the Portal height based on the height of the related list
465 table and the Portal container.
466 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
467 Add method to calculate the height of the related list tables.
468 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
469 * src/main/webapp/style.css: Add css class for Pager. This is needed to
470 calculate the height of the Pager widget.
472 2011-12-01 Ben Konrath <ben@bagu.org>
474 Use CellTable API for table property instead of setting style on Element.
476 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
478 2011-12-01 Ben Konrath <ben@bagu.org>
480 Make ListViewTable and RelatedListTable a consistent height.
482 The tables are now a consistent height regardless of the contents of
483 the table. A hidden button is added to empty rows to ensure that the
484 height of these rows will match the height of rows with data.
486 A navigation button column is now added to every table. The width of
487 the navigation column is set to 0px when a RelatedListTable shouldn't
488 have navigation buttons. This maintains the a consistent row height in
489 tables that don't show the navigation buttons.
491 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
492 navigation column when not needed.
493 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
494 arguments for navigation button to constructor of ListViewTable.
495 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
496 hidden button for empty data rows.
497 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
498 arguments for navigation button to constructor.
499 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
500 create navigation buttons. Add hideNavigationButtons() method.
501 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
502 arguments for navigation button to constructor.
504 2011-12-01 Ben Konrath <ben@bagu.org>
506 Use 'visibility: hidden' in Utils.getWidgetHeight().
508 This is better choice because hidden elements are invisible, don't
509 respond to events and are not part of the tab order. They will,
510 however, take up space which is required to be able to calculate the
511 height of the widget.
513 * src/main/java/org/glom/web/client/Utils.java:
515 2011-12-01 Ben Konrath <ben@bagu.org>
517 Use Utils.getWidgetHeight() in FlowTable.
519 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
521 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
523 2011-12-01 Ben Konrath <ben@bagu.org>
525 Put the details css class name on the correct table column.
527 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
529 2011-11-30 Ben Konrath <ben@bagu.org>
531 Update for java-libglom API change.
533 The getters and setters on FieldFormatting and NumericFormat were
534 changed to remove the 'M'.
536 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
538 2011-11-29 Ben Konrath <ben@bagu.org>
540 Only allow RelatedListTables in Portals.
542 * src/main/java/org/glom/web/client/ui/details/Portal.java:
544 2011-11-29 Ben Konrath <ben@bagu.org>
546 Only create a contents panel for Portals when title is being set.
548 * src/main/java/org/glom/web/client/ui/details/Portal.java:
550 2011-11-29 Ben Konrath <ben@bagu.org>
552 Set TabLayoutPanel height based on calculated height its widgets.
554 This is a potential fix for this bug:
556 https://bugzilla.gnome.org/show_bug.cgi?id=665133
558 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
560 2011-11-29 Ben Konrath <ben@bagu.org>
562 Align details field labels and data with the Open buttons.
564 * src/main/webapp/style.css:
566 2011-11-29 Ben Konrath <ben@bagu.org>
568 Remove unnecessary <div> in the Notebook widget.
570 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
571 method to get container FlowPanel (<div>).
572 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
573 initWidget() method directly on the TabLayoutPanel widget instead of
574 Group's container widget.
576 2011-11-29 Ben Konrath <ben@bagu.org>
578 Don't add group titles for Portals in Notebooks.
580 This reverts the previous patch and fixes a bug I introduced with
581 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
583 * src/main/java/org/glom/web/client/ui/details/Group.java:
584 * src/main/java/org/glom/web/client/ui/details/Portal.java:
586 2011-11-28 Ben Konrath <ben@bagu.org>
588 Remove unused boolean argument in Portal constructor.
592 * src/main/java/org/glom/web/client/ui/details/Group.java:
593 * src/main/java/org/glom/web/client/ui/details/Portal.java:
595 2011-11-28 Ben Konrath <ben@bagu.org>
597 Remove hack for glom 1.18 style glom files.
599 * src/main/java/org/glom/web/client/ui/details/Group.java:
600 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
601 * src/main/java/org/glom/web/client/ui/details/Portal.java:
603 2011-11-28 Ben Konrath <ben@bagu.org>
605 Use Gda Value version of primary key to log result too large error.
607 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
609 2011-11-28 Ben Konrath <ben@bagu.org>
611 Don't use TypedDataItem.getText() for Unknown types from the URL.
613 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
614 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
615 instead of getText().
616 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
617 String field and getUnknown() method.
619 2011-11-28 Ben Konrath <ben@bagu.org>
621 Log an error message when the java-libglom .so is not present.
623 The error message was being set in the exception but not logged.
625 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
627 2011-11-28 Ben Konrath <ben@bagu.org>
629 Ignore LayoutItem_CalendarPortals.
631 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
632 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
634 2011-11-28 Ben Konrath <ben@bagu.org>
636 Extract method for creating the LayoutItemPortal DTO.
638 Just breaking the code up into smaller chunks.
640 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
642 2011-11-28 Ben Konrath <ben@bagu.org>
646 This should have been added with the refactor. Oops!
648 * src/main/java/org/glom/web/shared/TypedDataItem.java:
650 2011-11-28 Ben Konrath <ben@bagu.org>
652 Create primary key value from URL string using type from Glom document.
654 See this bug, comments 19 - 25:
656 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
658 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
659 create a TypeDataItem for the primary key here when loading from a
660 URL. Show the same string for the primary key value as was received
661 from the URL string (when loading from a URL).
662 * src/main/java/org/glom/web/server/Utils.java: Update method for
663 creating the Gda Value from the TypeDataItem to properly deal with
664 creating a Gda Value based on the Glom document type for the primary
665 key value string when loading from a URL.
666 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
667 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
668 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
669 Update for changed method name.
671 2011-11-27 Ben Konrath <ben@bagu.org>
673 Rename PrimaryKeyItem to TypedDataItem.
675 The name PrimaryKeyItem suggests what the class should be used for.
676 TypedDataItem is a neutral name that describes the class better.
678 This is a rename-only refactor.
680 * src/main/java/org/glom/web/client/OnlineGlomService.java:
681 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
682 * src/main/java/org/glom/web/client/Utils.java:
683 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
684 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
685 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
686 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
687 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
688 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
689 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
690 * src/main/java/org/glom/web/server/Utils.java:
691 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
692 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
693 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
694 * src/main/java/org/glom/web/shared/NavigationRecord.java:
696 2011-11-25 Ben Konrath <ben@bagu.org>
698 Improve Gda Value conversion from PrimaryKeyItem.
700 The value from the PrimaryKeyItem is only used if its type match the
701 type from the glom document.
703 * src/main/java/org/glom/web/server/Utils.java:
705 2011-11-25 Ben Konrath <ben@bagu.org>
707 Manually check if the java-liblgom .so is visible to the JVM.
709 It seems that Tomcat has problems when a static initializer throws an
710 exception. This check is done before the first method call into
711 java-libglom so that execution doesn't continue if the .so is not
714 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
716 2011-11-25 Ben Konrath <ben@bagu.org>
718 Improve browser configuration error messages.
722 https://bugzilla.gnome.org/show_bug.cgi?id=662792
724 * src/main/java/org/glom/web/client/OnlineGlomService.java:
725 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
726 getConfigurationErrorMessage() method.
727 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
728 Get and display a specific configuration error message when no Glom
730 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
731 Implement getConfigurationErrorMessage() method. Surround configuration
732 code in the init() method with a try/catch block. This allows the
733 errors to be caught while keeping the servlet available to retrieve the
734 configuration error message.
736 2011-11-25 Ben Konrath <ben@bagu.org>
738 Don't use Strings to hold primary key values.
740 The primary key values are now held in a new data object
741 (PrimaryKeyItem) that holds type information and the primary key value
742 using the correct type.
744 * src/main/java/org/glom/web/client/OnlineGlomService.java:
745 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
746 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
747 PrimaryKeyItem instead of String to hold the primary key value.
748 * src/main/java/org/glom/web/client/Utils.java: Remove
749 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
750 PrimaryKeyItem based on the GlomFieldType and the DataItem.
751 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
752 PrimaryKeyItem instead of String to hold the primary key value. Load
753 document selection page when the documentID has not been set correctly.
754 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
755 DetailsPlace -> URL and URL -> DetailsPlace conversion with
757 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
758 Return empty string for URL instead of "null".
759 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
760 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
761 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
762 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
763 PrimaryKeyItem instead of String to hold primary key values.
764 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
765 PrimaryKeyValue to a Gda Value.
766 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
767 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
768 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
769 Replace temporary database access code that uses the PrimaryKeyValue to
770 Gda Value conversion.
771 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
772 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
773 PrimaryKeyItem instead of String.
774 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
775 hold primary key values.
777 2011-11-24 Ben Konrath <ben@bagu.org>
779 Use newly added java-libglom API to create queries.
781 This isn't finished. I still need to stop using Strings for primary key
782 values in the client code.
784 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
785 libglom to use fake connections so that retrieving the query string will
787 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
788 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
789 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
790 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
791 Use the newly added libglom sql methods and classes to create the
792 query. Add temporary hack to convert primary value strings to Gda
795 2011-11-23 Ben Konrath <ben@bagu.org>
797 Don't explicitly set the height of Portals.
799 See comments 6 - 10 of this bug for details:
801 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
803 * src/main/java/org/glom/web/client/ui/details/Portal.java:
805 2011-11-23 Ben Konrath <ben@bagu.org>
807 Use an HTML table instead of CSS for the FlowTable layout.
809 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
810 GWT's FlexTable to implement the FlowTable.
811 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
813 2011-11-18 Ben Konrath <ben@bagu.org>
815 Add boolean example to HTML table mockup.
817 * mockups/details-view-html-tables-text-entries.html:
819 2011-11-17 Ben Konrath <ben@bagu.org>
821 Ensure the pager buttons are always visible for related lists.
823 To accomplish this, I've turned off text wrapping in the list view and
824 related list tables for both the header and data text. The related list
825 table now has a fixed layout so the it doesn't overflow its container.
826 This is required to ensure that the cell text is clipped when it
827 overflows the cell and an ellipsis is added to the right side of the
828 cell when text is clipped.
830 A fixed table layout for the related list table in the details view
831 seems what we want for the details view anyway, so the side-effect is
834 The ellipsis will only be displayed in Firefox >= 7.
838 https://bugzilla.gnome.org/show_bug.cgi?id=662930
840 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
841 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
842 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
844 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
845 Set the 'table-layout: fixed' CSS property to the related list table.
846 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
847 'white-space: nowrap;' CSS property on both the list view and the
850 2011-11-16 Ben Konrath <ben@bagu.org>
852 Rework the fix for empty notebook tab labels.
854 Setting the empty group titles with its name caused problems for the
855 details layout. Instead of using libglom's
856 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
857 to the client when the title is empty. This allows the Notebook to use
858 the name when the title is empty without affecting anything else.
860 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
861 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
863 2011-11-16 Ben Konrath <ben@bagu.org>
865 Set group titles with name when title is empty.
867 This fixes a problem with an empty notebook tab label in the Lesson
868 Planner document. The forth tab in the notebook should be "Internet":
870 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
872 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
873 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
876 2011-11-16 Ben Konrath <ben@bagu.org>
878 Remove whitespace from the configured username properties.
880 This assumes that usernames won't have whitespace at the beginning
881 or end. But I think this is a reasonable assumption.
883 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
884 String.trim() to remove the whitespace from the username properties.
886 2011-11-15 Ben Konrath <ben@bagu.org>
888 Add details view mockup with HTML tables and text entries.
890 This is from the attachment on this bug:
892 https://bugzilla.gnome.org/show_bug.cgi?id=663109
894 * mockups/details-view-html-tables-text-entries.html:
896 2011-11-15 Ben Konrath <ben@bagu.org>
898 Add space between the columns of the flow table.
902 https://bugzilla.gnome.org/show_bug.cgi?id=662918
904 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
905 space between columns in the flow table.
907 2011-11-15 Ben Konrath <ben@bagu.org>
909 Add backup files to the .gitignore.
911 * .gitignore: Ignore files that end with ~.
913 2011-11-09 Ben Konrath <ben@bagu.org>
915 Use latest release of gwt-log.
917 Gwt-log releases are now being submitted to the maven central
918 repository so manual installation of the jar is no longer required.
920 * pom.xml: Update version and groupId of gwt-log dependency.
922 2011-10-31 Ben Konrath <ben@bagu.org>
924 Don't use GWT numeric formatting to override the glom currency formatting.
926 Currencies are now displayed like they are in Glom. See this bug:
928 https://bugzilla.gnome.org/show_bug.cgi?id=646216
930 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
932 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
933 currency code to constructor and set it when the cell is rendered.
934 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
935 currency code to the constructor of the NumericCell.
937 2011-10-27 Ben Konrath <ben@bagu.org>
939 Require the latest release of java-libglom (1.17.4).
943 2011-10-26 Ben Konrath <ben@bagu.org>
945 Add style to Notebook that matches current theme.
947 It's not the best style in the world but it's better than the default.
949 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
950 padding at the bottom of the child widgets.
951 * src/main/webapp/style.css: Add style for the Notebook.
953 2011-10-26 Ben Konrath <ben@bagu.org>
955 Move servlet initialization code to overridden init method.
957 This is half of the solution to getting proper error messages
958 displayed when configuration errors occur. Here's the relevant bug:
960 https://bugzilla.gnome.org/show_bug.cgi?id=662792
962 The rest of the solution involves surrounding the init method with a
963 try/catch block and setting a global variable with the error /
964 exception. A new async method should be created to retrieve and display
965 the error message / exception.
967 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
968 code from constructor to init method adding exceptions as needed.
970 2011-10-26 Ben Konrath <ben@bagu.org>
972 Add script to monitor and restart tomcat if required.
974 * utils/check-and-recover-tomcat.py: New file.
976 2011-10-26 Ben Konrath <ben@bagu.org>
978 Display the correct number of data items in the pager.
982 https://bugzilla.gnome.org/show_bug.cgi?id=661441
984 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
985 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
986 The implementation is the same for both tables: Keep track of the
987 number of non-empty rows and fire and RowCountChangeEvent after the data has
989 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
990 custom Pager class that subclasses SimplePager to handle displaying
991 the correct number when empty rows have been added.
993 2011-10-26 Ben Konrath <ben@bagu.org>
995 Correct error in previous commit.
997 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
998 eventBus parameter from listView.setCellTable().
1000 2011-10-26 Ben Konrath <ben@bagu.org>
1002 Fix error in TODO comment.
1004 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1006 2011-10-24 Ben Konrath <ben@bagu.org>
1008 Create Notebook widgets to the details view.
1010 This isn't finished just yet - I still need to create a reasonable
1011 style to match the current theme.
1013 * src/main/java/org/glom/web/client/Utils.java: Add method for
1014 calculating the height of a widget. This is used in the Notebook class.
1015 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1016 new constructor method in Group.
1017 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1018 method for creating child widget that can be used by subclasses
1019 like Notebook. New constructor that allows disabling the group
1020 titles - Notebooks don't set a group title for their child groups.
1021 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1022 to make Notebooks using GWT's TabLayoutPanel.
1023 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1024 constructor that allows disabling the group titles.
1025 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1026 LayoutItemNotebook DTO.
1027 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1028 DTO for Notebooks. It's just an empty class for now but we might need
1029 it to transfer some specific information in the future.
1031 2011-10-21 Ben Konrath <ben@bagu.org>
1033 Add navigation buttons to related list tables.
1035 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1036 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1037 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1038 method getSuitableRecordToViewDetails() for getting the table name
1039 and primary key value for related list navigation buttons.
1040 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1041 private cell renderer class to get the navigation information for
1042 related list tables from the server. Extract the navigation
1043 processing code from the details cell navigation and use it for the
1044 related list navigation as well.
1045 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1046 cell renderer class for the details open buttons. This was needed
1047 because the related list navigation buttons and the list view
1048 navigation buttons need to react differently when clicked.
1049 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1050 the onEnterKeyDown() method because it's now overriden in the
1051 subclasses that are specific to the related list tables and the list
1053 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1054 the vertical size a little because the buttons add a bit of vertical
1055 space to table. This is not a perfect solution because the vertical
1056 size of with table fewer than 5 rows will be a little smaller.
1057 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1058 changes in how navigation buttons are handled.
1059 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1060 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1061 database access object.
1062 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1063 to find the portal for a given relationship name from
1064 RelatedListDBAccess. Add method to find a primary key field for a
1066 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1067 Move code to find the portal for a given relationship name to
1069 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1070 New file: database access object for getting the related list
1071 navigation information (the table name and the primary key value).
1072 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1073 DTO for transferring a table name to navigate to and a primary key
1075 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1076 boolean and getter/setter to specifies if the related list should add
1079 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1081 Use the master branch of java-libglom
1083 * pom.xml: Depend on java-libglom 1.19 instead.
1085 This is the master branch. See also the libglom-1-18 branch.
1087 2011-10-11 Ben Konrath <ben@bagu.org>
1089 Enable the open navigation button when the data has been set.
1091 This avoids having active buttons that don't do anything when the data
1094 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1096 2011-10-11 Ben Konrath <ben@bagu.org>
1098 Use IsWidget interface for FlowTableItem.
1100 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1101 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1103 2011-10-11 Ben Konrath <ben@bagu.org>
1105 Remove GWT styling from open button in details view.
1107 There are still some issues with how the details cell is arranged but
1108 this should be made to match Glom 1.20. I'm going to leave fixing this
1109 until I have Glom 1.20 up and running.
1111 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1112 style name on open button.
1113 * src/main/webapp/style.css: Move and edit details-navigation class.
1114 Re-arrange some classes to make them appear in the same order as the
1117 2011-10-07 Ben Konrath <ben@bagu.org>
1119 Update to GWT 2.4.0.
1121 * .gitignore: Ignore new cache directory.
1122 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1123 * pom.xml: Change GWT and maven plugin to 2.4.0.
1124 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1126 * src/main/java/org/glom/web/client/ClientFactory.java:
1127 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1128 * src/main/java/org/glom/web/client/OnlineGlom.java:
1129 Update source for API changes.
1130 * utils/build-onlineglom-war.sh: Remove cache directory before the
1133 2011-10-07 Ben Konrath <ben@bagu.org>
1135 Add navigation buttons in the details view.
1137 This isn't finished but I thought I'd commit what I have as it's a
1138 pretty good start. I still need to:
1140 1. Change the style so that it fits better into the current theme
1141 2. Adjust the details cell to expand as much as possible.
1143 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1144 click handlers to navigation buttons in the DetailsCells. Create a
1145 refreshData() method to get just the data from the server without the
1147 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1148 Update the tableSelector and browser title when the table name
1149 changes without using the tableSelector.
1150 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1151 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1152 getDetailsCells() to getCells(). Update variable names.
1153 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1154 method to set click handler on navigation button. Rename a few
1155 variables. Add navigation buttons where needed.
1156 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1157 variables and methods.
1158 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1159 navigation boolean and navigation table as required in the
1160 LayoutItemField DTO.
1161 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1162 variables for navigation along with getter/setter methods.
1164 2011-10-07 Ben Konrath <ben@bagu.org>
1166 Rename Field to DetailsCell.
1168 This is a refactor-only commit. No functionality has been added or
1171 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1172 Update variable and method names.
1173 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1174 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1175 variable and method names.
1176 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1178 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1179 variable and method names.
1181 2011-10-07 Ben Konrath <ben@bagu.org>
1183 Create separate methods for layout and data the details view.
1185 This is a refactor-only commit. No functionality has been added or
1188 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1189 private methods: setData(), createLayout().
1191 2011-10-07 Ben Konrath <ben@bagu.org>
1193 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1195 This is part of a change to get navigation buttons in the details view
1196 but it should have been done this way from the start.
1198 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1199 for method name change in TableSelectionView.
1200 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1201 Create TableChangeEvent and set the browser title using the
1202 TableSelectionView API.
1203 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1204 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1205 Change getSelectedTable() to getSelectedTableName(). Add
1206 getSelectedTableTitle().
1208 2011-10-07 Ben Konrath <ben@bagu.org>
1210 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1212 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1214 2011-10-07 Ben Konrath <ben@bagu.org>
1216 Update TableChangeEvent to use newTableName naming convention.
1218 This makes the class more consistent with GWT naming conventions.
1220 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1221 Update for method name change in TableChangeEvent.
1222 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1223 for method name change in TableChangeEvent.
1224 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1225 newTableName variable and getter method. Make toDebugString()
1228 2011-09-30 Ben Konrath <ben@bagu.org>
1230 Disable the pager in the list tables when the data row count is less than the minimum.
1232 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1233 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1235 2011-09-30 Ben Konrath <ben@bagu.org>
1237 Add empty rows to the end of related list and list view tables.
1239 I also extracted the cell rendering classes from the ListTable because
1240 the code was becoming a little crazy with all the anonymous inner
1241 classes. My plan is to use these cell rendering classes in the details
1242 view as well so this refactor will be needed for that change.
1244 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1245 set the row count in related list tables if the data has more rows
1246 than the minimum number of rows visible.
1247 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1248 row count in list view tables if the data has more rows than the
1249 minimum number of rows visible.
1250 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1251 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1253 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1254 for rendering TYPE_NUMERIC cells. The code was extracted from the
1256 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1257 class for rendering cells with buttons in list views. The code was
1258 extracted from the ListTable class.
1259 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1260 for rendering TYPE_TEXT cells. The code was extracted from the
1262 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1263 Add empty rows to the end of the data if required. Implement
1264 ListTable.getMinNumVisibleRows().
1265 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1266 cell renderer code to public classes. Return null in
1267 Column.getValue() for empty rows. Add new abstract method:
1268 getMinNumVisibleRows(). Move code to set the row count of the list view
1269 table to ListViewImpl.
1270 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1271 empty rows to the end of the data if required. Implement
1272 ListTable.getMinNumVisibleRows().
1275 2011-09-27 Ben Konrath <ben@bagu.org>
1277 Use GWT.log for client-side debugging statements.
1279 These are optimized out when deployed so I should have used this method
1280 in the first place. These statements will eventually be replaced with some sort
1281 of notification in the browser.
1283 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1284 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1285 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1286 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1287 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1289 2011-09-27 Ben Konrath <ben@bagu.org>
1291 Put tableselector on the right, back to list link on right.
1293 The idea is that the table selector is acting like a label for the
1294 currently displayed table so it should be placed below the document title. This
1295 puts the table title in a similar position to where it is in Glom.
1297 * mockups/details-contacts.html:
1298 * mockups/details-projects.html:
1299 * mockups/listview-contacts.html:
1300 * mockups/listview-projects.html:
1301 * mockups/style.css:
1302 Update mockups to match how the interfaces currently look.
1303 * src/main/webapp/style.css: Swap positions of backlink with the table
1304 selector. Add some space on the left side of the table selector to
1305 line things up with the document title.
1307 2011-09-27 Ben Konrath <ben@bagu.org>
1309 Add field colouring to details view.
1311 This change re-works how field colouring works. The colour formatting
1312 information is now set to the client with the layout information instead of
1313 with the data. This eliminates the need to send the same colour strings for
1314 data in list view column when colour information is set.
1316 In order to set an alternate colour for negative numeric values, the
1317 number is now sent to client and formatted with the GWT NumberFormat class.
1319 This change also fixes:
1321 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1323 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1324 internationalization framework which is needed for client side numeric
1326 * src/main/java/org/glom/web/client/Utils.java: New file for some
1327 client static utility methods.
1328 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1329 the DataItem object to the Field class. Use a utility method to
1330 create the foreignKeyValue string.
1331 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1332 alignment and text colours in the constructor. Add setData(DataItem)
1333 method. Remove setText(String) method.
1334 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1335 colour information to GlomTextCell. Create and use GlomNumberCell for
1336 rendering numbers. Use utility method to get the string for the
1337 primary key of the key provider. Re-work how the horizontal alignment
1339 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1340 formatting to layout information. Methods for converting the libglom
1341 formatting information were moved from DBAccess.
1342 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1343 numeric formatting (it's now done on the client side). Don't set text
1344 colours in DataItem. Move libglom formatting conversion methods to
1346 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1347 getters/setters for text colour information.
1348 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1349 for transferring the libglom NumericFormat information to the client.
1350 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1351 and getters/setters for: GlomNumericFormat, background colour and
1352 foreground colour strings.
1354 2011-09-26 Ben Konrath <ben@bagu.org>
1356 Simplify code that iterates through the LayoutGroup.
1358 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1360 2011-09-26 Ben Konrath <ben@bagu.org>
1362 Accept Eclipse formatting for OnlineGlomServiceAsync.
1364 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1366 2011-09-26 Ben Konrath <ben@bagu.org>
1368 Don't use the ListDBAccess classes to get the primary key layout information.
1370 This was causing a bug where the wrong index for the hidden primary key
1371 was being sent to the client.
1373 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1374 primary key while creating the LayoutGroup DTO. Create a
1375 LayoutItemField DTO for hidden primary keys. Don't use the
1376 RelatedListDBAccess because it was only used for getting the primary
1378 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1379 access modifier from public to protected for getPrimaryKeyField() and
1380 getPrimaryKeyLayoutItemField().
1381 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1382 abstract method getExpectedResultSize() because RelatedListDBAccess
1383 doesn't have enough info to implement it.
1384 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1385 Remove @Override for getExpectedResultSize().
1386 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1387 Remove method getExpectedResultSize().
1389 2011-09-23 Ben Konrath <ben@bagu.org>
1391 Log which layout (list or details) the ignored item is from.
1393 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1395 2011-09-23 Ben Konrath <ben@bagu.org>
1397 Remove annotations that turn off code formatting in DataItem.
1399 * src/main/java/org/glom/web/shared/DataItem.java:
1401 2011-09-23 Ben Konrath <ben@bagu.org>
1403 Rename GlomField to DataItem and update associated methods.
1405 This is a rename-only refactor. No functionality has been added or
1408 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1409 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1410 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1411 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1412 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1413 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1414 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1415 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1416 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1417 * src/main/java/org/glom/web/server/database/DBAccess.java:
1418 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1419 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1420 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1421 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1422 * src/main/java/org/glom/web/shared/DataItem.java:
1423 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1424 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1426 2011-09-23 Ben Konrath <ben@bagu.org>
1428 Rename GlomDocument to DocumentInfo and update associated methods.
1430 This is a rename-only refactor. No functionality has been added or
1433 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1434 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1435 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1436 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1437 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1438 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1439 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1441 2011-09-20 Ben Konrath <ben@bagu.org>
1443 Require java-libglom 1.17.3.
1445 This picks up the fix for the seg fault problem with the Scenes table
1446 in the Openismus Film Manager example.
1450 2011-09-20 Ben Konrath <ben@bagu.org>
1452 Change the way sort clause is added for primary key when no sort clause is requested.
1454 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1455 before the sort clause is created. When a sort clause is not requested, the
1456 sort clause is created by finding the primary key in the LayoutFieldVector
1459 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1461 2011-09-20 Ben Konrath <ben@bagu.org>
1463 Log error message if no documents are found in the configured directory.
1465 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1466 Extract the glom file extension string to a private static final class
1467 variable (mostly as syntactic sugar). Accept a minor formatting change.
1468 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1469 the example glom.document.directory configuration property to make it
1470 more clear that it can any directory, not just the home directory.
1472 2011-09-18 Ben Konrath <ben@bagu.org>
1474 Add related lists to details view.
1476 The related list table has support for paging and sorting just like the
1477 table in the list view.
1479 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1480 SQL queries for the related list tables.
1481 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1482 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1483 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1484 Rename getList methods to getListView and add comments. Remove
1485 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1486 it being unused. Add methods: getDetailsLayoutAndData(),
1487 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1488 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1489 Create the layout and set the data for the fields in one async call
1490 instead of two. Create related lists where appropriate.
1491 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1492 for method name changes in OnlineGlomService.
1493 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1494 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1495 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1497 * src/main/java/org/glom/web/client/ui/ListView.java:
1498 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1499 tableName from setCellTable(). Create a ListViewTable instead of
1501 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1502 represent a data field in the details view.
1503 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1504 from addDetailsCell() to Field class. Keep track of the Fields and
1505 Portals in the details view.
1506 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1507 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1508 and add a method to get it. Add method to set the contents of the
1510 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1511 New class for related list tables. This class has the data provider
1512 for the related list table.
1513 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1514 abstract class which is the base class for the ListViewTable and the
1516 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1517 New class for list view tables. This class has the data provider for
1518 the list view table.
1519 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1520 methods for related list tables. Add more information to the
1521 LayoutItemField and LayoutItemPortal DTOs.
1522 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1523 Remove debugging print statement.
1524 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1525 Remove debugging print statements. Add primary key field to SQL count
1527 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1528 Remove unnecessary LayoutFieldVector parameter from
1529 getResultSizeOfSQLQuery() method.
1530 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1531 New class for related list table database access.
1532 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1533 class that is a wrapper DTO for details view layout and data.
1534 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1535 new 'fromField' string to this DTO.
1536 * src/main/webapp/style.css: Remove bottom margin and override top
1539 2011-09-15 Ben Konrath <ben@bagu.org>
1541 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1543 This sets things up to make it easier to add the data retrieval for
1544 related lists (portals). No user noticeable changes were made with
1547 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1548 class has the code to retrieve the layouts and access the
1549 database using the new database helper classes.
1550 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1551 Most of the functionality has been removed from this class. This
1552 class now represents the public interface for the client side
1553 code. It also deals with configuring the servlet and cleaning
1554 things up when the servlet is stopped.
1555 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1556 of static methods into this utility class.
1557 * src/main/java/org/glom/web/server/database/DBAccess.java:
1558 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1559 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1560 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1561 These classes have the database retrieval code. The class hierarchy
1562 has been setup to make it easy to reuse code for similar
1565 2011-09-06 Ben Konrath <ben@bagu.org>
1567 Create separate classes for list table code and the data provider.
1569 As part of this refactor, I also split up the code a bit to make it
1572 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1573 table code to two new classes (below).
1574 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1575 with code from ListViewImpl.
1576 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1577 New file with code from ListViewImpl.
1579 2011-09-06 Ben Konrath <ben@bagu.org>
1581 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1583 This fixes the LayoutItemPortal DTO to match the libglom layout object
1586 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1588 2011-09-01 Ben Konrath <ben@bagu.org>
1590 Set title of Portals in the Details View.
1592 * pom.xml: Bump required version of java-libglom to 1.17.1.
1593 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1594 widget creation to its own class. Add comments to constructor.
1595 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1596 The code is mostly from the Group class with the title now set.
1597 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1598 title of Portal. Update some comments. Fix some code formatting.
1600 2011-09-01 Ben Konrath <ben@bagu.org>
1602 Remove TODO comment for the flow table column width.
1604 The flow table column width is working correctly and doesn't need to be
1605 changed. See this mailing list post for more info:
1607 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1609 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1611 2011-08-27 Ben Konrath <ben@bagu.org>
1613 Add document title (database name) to top of the browser page.
1615 I added the document title to the TableSelecitonView but that will
1616 change if / when we add a view that doesn't require table selection.
1618 * mockups/details-contacts.html:
1619 * mockups/details-projects.html:
1620 * mockups/listview-contacts.html:
1621 * mockups/listview-projects.html:
1622 * mockups/style.css: Add document title to mockups to keep things
1624 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1625 sizes to account for the document title.
1626 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1627 Set the document title when it has been retrieved from the server.
1628 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1629 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1630 and implement setDocumentTitle(String) method.
1631 * src/main/webapp/style.css: Add ID for document title style.
1633 2011-08-25 Ben Konrath <ben@bagu.org>
1635 Add NavigationType enum to LayoutItemPortal DTO.
1637 This is the start of adding support for Portals to the Details View.
1639 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1640 LayoutItem_Portal.navigation_type enum from libglom to
1641 LayoutItemPortal.NavigationType enum.
1642 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1643 NavigationType enum, field for storing the NavigationType and getter
1646 2011-08-25 Ben Konrath <ben@bagu.org>
1648 Implement the flow table layout in the Details View.
1650 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1651 FlowTable to Group to account for the renamed class.
1652 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1653 File. This is a container widget that implements the Glom details view
1654 flow table behaviour.
1655 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1656 org/glom/web/client/ui/FlowTable.java.
1657 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1658 so that the size of the subgroups are a closer match to the size of
1659 the Glom subgroups. This makes the flowtable layout match the layout
1660 in Glom for the Music Collection example file.
1662 2011-08-16 Ben Konrath <ben@bagu.org>
1664 Create container element for LayoutItemPortal in Details View.
1666 This will help me develop the layout for the FlowTable.
1668 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1669 fieldPanel variable to detailsCell.
1671 2011-08-15 Ben Konrath <ben@bagu.org>
1673 Set the height of the data element in the Details View.
1675 I changed the InlineLabels (text in a span element) to Labels (text in
1676 a div element) so that I could set the height of the details-data
1677 elements instead of the details-cell parent elements. This allows the
1678 the details-data element to display the correct height if style is
1679 applied that shows the height.
1681 This change has the added benefit of allowing the order of the labels
1682 and data elements to be changed for right-to-left languages.
1684 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1685 InlineLabels to Labels.
1686 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1687 InlineLabels to Labels. Set the height of the data element.
1688 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1689 multiline text height in the Formatting DTO.
1690 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1691 for multiline height along with getter and setter methods.
1692 * src/main/webapp/style.css: Adjust style to account for the change
1693 from span elements to div elements in the details cell.
1695 2011-08-15 Ben Konrath <ben@bagu.org>
1697 Make the List View appearance match the mockups.
1699 It doesn't match exactly but it's much better than it was.
1701 * mockups/listview-contacts.html: Remove unused css classes.
1702 * mockups/listview-projects.html: Remove unused css classes.
1703 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1704 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1705 for mainPanel instead of VerticalPanel (table). Set style name on
1706 CellTable. Set style name on Details column. Right-align Details
1708 * src/main/webapp/style.css: Adjust properties to match the mockups.
1710 2011-08-12 Ben Konrath <ben@bagu.org>
1712 Add better support for subgroups in the details view.
1714 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1715 changed FlowTable constructor.
1716 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1717 support for subgroups and subgroup-titles.
1718 * src/main/webapp/style.css: Add CSS class for subgroups and
1721 2011-08-12 Ben Konrath <ben@bagu.org>
1723 Return the top level LayoutGroup title.
1725 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1727 2011-08-11 Ben Konrath <ben@bagu.org>
1729 Make the TableSelector header match the mockup.
1731 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1732 the layout panel. Properly lineup the table selection header with
1733 the list and details view.
1734 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1735 margin around the details view.
1736 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1737 Rename listBox variable to tableSelector. Set id for the style sheet.
1738 Use a FlowPanel instead of a HorizontalPanel.
1739 * src/main/webapp/style.css: Add properties to make the TableSelector
1740 box match the mockups.
1742 2011-07-13 Ben Konrath <ben@bagu.org>
1744 Update install script for java-libglom version change.
1746 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1749 2011-07-13 Ben Konrath <ben@bagu.org>
1751 Add support sub-group in the details view.
1753 I also removed the code that special-cased the default details view
1756 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1758 I still have to make a proper flowtable.
1760 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1761 Don't special-case default details view layout.
1762 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1763 addLayoutField() as I'm going to use it.
1764 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1765 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1767 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1768 extracted from DetailsViewImpl.GroupPanel. Add support for
1770 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1771 column count when getting the details layout.
1773 2011-07-12 Ben Konrath <ben@bagu.org>
1775 Set browser title with database and table titles.
1777 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1778 Set the browser title when the table changes and when the activity
1780 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1781 title when retrieving document info (the GlomDocument object).
1782 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1783 with getter and setter methods. Remove unused convenience constructor.
1784 Use default code formatting.
1786 2011-07-12 Ben Konrath <ben@bagu.org>
1788 Ignore LayoutItemPortals in the details view.
1790 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1793 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1794 LayoutItemPortal layout objects.
1795 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1796 LayoutItemPortal objects when retrieving the details layout.
1797 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1798 file. This is an empty class and just used to get type information for
1801 2011-07-12 Ben Konrath <ben@bagu.org>
1803 Use java-libglom 1.17.0.
1807 2011-07-11 Ben Konrath <ben@bagu.org>
1809 Remove "Table:" label from table selector.
1811 This matches a recent change in the Glom UI.
1813 * mockups/details-contacts.html:
1814 * mockups/details-projects.html:
1815 * mockups/listview-contacts.html:
1816 * mockups/listview-projects.html: Remove the "Table:" label from the
1818 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1820 2011-07-11 Ben Konrath <ben@bagu.org>
1822 Add main groups to the details view.
1824 This makes things look a little nicer in the details view. The next step
1825 is to implement the flowtable.
1827 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1828 resources from the standard gwt css theme. Standard.css is now
1829 included in OnlineGlom.html so that the online glom css rules have
1830 precedence over the gwt theme.
1831 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1832 the whole LayoutGroup to the DetailsView instead of just the titles.
1833 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1834 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1835 details layout with a helper class (GroupPanel). I might extract this
1836 class when I make the full flowtable.
1837 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1838 string as default so I don't have to worry about NPEs when processing
1840 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1841 note beside OnlineGlom.gwt.xml above).
1842 * src/main/webapp/style.css: Add default font-size to body to override
1843 the font-size set by the standard theme. Don't use h2 tags for
1844 group-title. Create new details-cell class.
1846 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1848 ConfiguredDocument: Set the port number too.
1850 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1851 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1852 Glom document. Presumably this worked sometimes so far because there is a
1853 default port number.
1855 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1857 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
1859 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1860 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
1861 correct, though we should throw an exception too.
1863 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1865 Fix a addDocuemnt typo.
1867 * src/main/java/org/glom/web/shared/Documents.java
1868 (Documents.addDocuemnt): Rename to addDocument().
1869 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1870 (OnlineGlomServiceImpl.getDocuments): Adapt.
1872 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1874 Slightly improved log output when connection fails.
1876 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1877 (ConfiguredDocument.setUsernameAndPassword):
1878 We don't know for sure if it' the username/password that's wrong, so
1879 rephrase the message.
1880 Also ouput the exception message, though it's generic in this case.
1882 2011-07-08 Ben Konrath <ben@bagu.org>
1886 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
1887 added braces to a one line if statement because the Eclipse formatter
1888 was getting confused.
1890 2011-07-07 Ben Konrath <ben@bagu.org>
1892 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
1894 These should really be two separate tasks but I counldn't get things to
1895 work with GWT 2.2.0 and Eclipse 3.7.
1899 * .settings/org.eclipse.jdt.core.prefs:
1900 * .settings/org.eclipse.jdt.ui.prefs:
1901 * .settings/org.eclipse.ltk.core.refactoring.prefs:
1902 * .settings/org.eclipse.m2e.core.prefs:
1903 Add new config files. Update current files. Remove references to the
1904 webtools plugins as we're not using any of the webtools features.
1905 * .gitignore: Add logs directory which is created when running with
1907 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
1908 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
1909 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
1911 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
1913 2011-07-07 Murray Cumming <murrayc@murrayc.com>
1915 onlineglom.properties: Add explanatory comments.
1917 * src/main/resources/onlineglom.properties: Also change the default user
1918 from ben to someuser, to avoid the risk of people thinking we just
1919 stupidly hard-coded a locale path, when they see that on stderr or in a log.
1921 2011-06-28 Ben Konrath <ben@bagu.org>
1923 Use filename in Log for incorrect passwords.
1925 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1926 getFileName(String) method to get the filename from the URI.
1928 2011-06-28 Ben Konrath <ben@bagu.org>
1930 Add the table name to the URL token for the ListPlace.
1932 This makes things consistent between the DetailsPlace and the
1933 ListPlace. It also allows the the ListPlace to be bookmarked.
1935 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1936 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1937 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1938 Remove getDefaultListLayout(). The default layout is now returned
1939 by the getListLayout() method when the table name is an empty string.
1940 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1941 Add table name field. Change to a new ListPlace when the table
1942 has been changed. Use getListLayout() for getting the default
1944 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1945 Add table name field. Set the correct table name in the list box
1946 when loading from bookmark. This corrects a problem for the
1948 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1949 Move table name to super-class (HasSelectableTable). Move document
1950 and table URL keys to super-class in HasSelectableTable.
1951 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1952 Add table name field. Add Tokenizer class with URL key common to
1953 the subclasses (DetailsPlace and ListPlace).
1954 * src/main/java/org/glom/web/client/place/ListPlace.java:
1955 Add table name. Add code to parse the URL token.
1956 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1957 Update ListPlace construction with empty table name string.
1958 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1959 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1960 Change setTableSelectedIndex(int) to setSelectedTableName(String).
1961 Update ListPlace construction with table name string.
1962 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1963 Change defaultTableName field to tableName to reflect how it's now
1964 used. Update the getter and setter methods.
1966 2011-06-28 Ben Konrath <ben@bagu.org>
1968 Enable the table selector in the DetailsView.
1970 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1971 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1972 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1973 Remove getDefaultDetailsLayout(). The default layout is now returned
1974 by the getDetailsLayout() method when the table name is an empty
1976 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1977 event handler for table change event. Change to using
1978 getDetailsLayout() for the default details layout.
1979 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
1981 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
1982 when navigating to the details place.
1984 2011-06-27 Ben Konrath <ben@bagu.org>
1986 Use filename based unique document ID in URL and for RPC.
1988 The document ID is the glom document name with spaces (' ') replaced
1989 with pluses ('+') and without the .glom extension.
1991 This change is mostly a string substitution of 'documentTitle' for
1992 'documentID'. The only code change is the addition of a Documents DTO to get the
1993 filename to document title mappings as indicated below.
1995 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1996 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1997 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1998 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1999 Use Documents DTO to create the document links in the document
2001 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2002 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2003 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2004 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2005 * src/main/java/org/glom/web/client/place/ListPlace.java:
2006 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2007 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2008 * src/main/java/org/glom/web/client/ui/ListView.java:
2009 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2010 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2011 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2012 * src/main/java/org/glom/web/server/Log.java:
2013 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2014 getDocumentTitles() to getDocuments() and return the Documents DTO.
2015 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2016 transferring the filename to document title mappings.
2018 2011-06-25 Ben Konrath <ben@bagu.org>
2020 Make the authentication popup work again.
2022 This bug was introduced when I extracted ConfiguredDocument to its own class.
2024 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2025 correct success / fail status in setUsernameAndPassword().
2027 2011-06-25 Ben Konrath <ben@bagu.org>
2029 Use filename as unique key for configuring database usernames and passwords.
2031 This replaces the use of the Glom document title which could change
2032 depending on the locale. Thanks to Murray Cumming for pointing out this
2035 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2036 * src/main/resources/onlineglom.properties:
2038 2011-06-24 Ben Konrath <ben@bagu.org>
2040 Pass primary key value to DetailsView.
2042 This enables the DetailsView to load the correct data.
2044 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2045 primary key value field and set in constructor. Pass primary key
2046 value to getDetailsData().
2047 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2048 variables for document title and primary key value.
2049 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2050 key value to the DetailsPlace.
2052 2011-06-24 Ben Konrath <ben@bagu.org>
2054 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2056 This allows the primary key to be retrieved by the Details button. This
2057 functionality has not been implemented yet but it's in the works.
2059 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2060 the LayoutGroup result to ListView.setCellTable instead of all of its
2061 fields individually.
2062 * src/main/java/org/glom/web/client/ui/ListView.java:
2063 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2064 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2065 get the primary key for the table.
2066 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2067 index of the primary key in the LayoutGroup accounting for hidden
2068 primary keys. Rename getJavaNumberFormat() to
2069 convertToJavaNumberFormat() for consistency. Cleanup / add some
2071 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2072 field for primary key index and a field to indicate whether the
2073 primary key is hidden or not.
2075 2011-06-23 Ben Konrath <ben@bagu.org>
2077 Rename getTableData methods to getListData.
2079 This is a rename refactor for consistency with other methods.
2081 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2082 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2083 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2084 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2086 2011-06-23 Ben Konrath <ben@bagu.org>
2088 Extract the ConfiguredDocument innerclass into its own class.
2090 This makes the servlet code more object oriented.
2092 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2093 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2094 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2095 new ConfiguredDocument class.
2097 2011-06-21 Ben Konrath <ben@bagu.org>
2099 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2101 This makes things more inline with how libglom works and reduces code
2102 duplication. This refactor lays the groundwork for adding the primary key to
2103 the LayoutGroup object.
2105 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2106 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2107 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2108 Change method names to getListLayout and getDefaultListLayout for
2109 consistency. Use LayoutGroup as the DTO for the list layout instead of
2110 ColumnInfo and LayoutListTable.
2111 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2112 new method names along with the LayoutGroup object for transferring the
2114 * src/main/java/org/glom/web/client/ui/ListView.java:
2115 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2116 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2117 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2119 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2120 Replaced with LayoutGroup.
2121 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2122 expectedResultSize and defaultTableName fields which are needed for
2124 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2125 type field which is needed for the list layout but will also be
2126 useful for the details layout as things progress.
2127 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2128 Make class abstract. Remove the unnecessary
2129 getFormattingHorizontalAlignment method. Add setFormatting method.
2131 2011-06-16 Ben Konrath <ben@bagu.org>
2133 Add scripts for building and installing war.
2135 These will help when updating OnlineGlom but they're also good
2136 supplemental documentation of the build and deployment proceeding.
2138 * utils/build-onlineglom-war.sh: New file.
2139 * utils/install-onlineglom-war.sh: New file.
2141 2011-06-16 Ben Konrath <ben@bagu.org>
2143 Create wrapper class to create consistent log messages.
2145 I wrapped methods in the Log class of gwt-log to add the method names
2146 from the servlet and create consistent formatting of the document title
2147 and table names in the log messages.
2149 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2150 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2151 log methods to use methods from wrapped Log class.
2153 2011-06-16 Ben Konrath <ben@bagu.org>
2155 Remove superfluous conditional return.
2157 Thanks to Murray Cumming for pointing this out!
2159 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2161 2011-06-15 Ben Konrath <ben@bagu.org>
2163 Return an ArrayList of LayoutGroups for the Details layout.
2165 This corrects a problem with the details layout as it can have more
2166 than one top level LayoutGroup.
2168 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2169 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2170 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2171 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2172 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2173 with ArrayList of LayoutGroups for the details view layout.
2174 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2175 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2176 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2177 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2178 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2179 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2181 2011-06-14 Ben Konrath <ben@bagu.org>
2183 Use cast_dynamic method to determine the libglom LayoutItem type.
2185 This is better than finding the LayoutItem type by using the string
2186 returned from the get_part_type_name() method.
2188 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2190 2011-06-14 Ben Konrath <ben@bagu.org>
2192 Add method names to log entries in the servlet.
2194 This helps when tracking down deployment problems.
2196 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2198 2011-06-14 Ben Konrath <ben@bagu.org>
2200 Add data to the DetailsView using a hard-coded primary key value.
2202 The layout and functionality of the DetailsView is not complete. This
2203 is just a checkpoint so the patch doesn't get too big.
2205 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2206 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2207 Add getDetailsData() servlet method.
2208 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2209 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2210 LayoutFields are added to the DetailsView.
2211 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2212 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2213 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2214 take the string for the title instead of the object.
2215 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2216 Add implementation getDetailsData() along with some private helper
2218 * src/main/webapp/style.css: Add padding to details-data class. Add a
2219 details-label class with the same padding as the details-data class.
2221 2011-06-03 Ben Konrath <ben@bagu.org>
2223 Use presenter.goTo() to change to the DetailsPlace.
2225 This will make things easier when we need to open the DetailsView with
2226 data specific to the row that was clicked.
2228 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2230 2011-06-02 Ben Konrath <ben@bagu.org>
2232 Add CSS file from mockups.
2234 I'm adding this now because it's going to be useful to have when
2235 developing the DetailsView. The TableSelectionView and ListView aren't
2238 * src/main/webapp/OnlineGlom.html:
2239 * src/main/webapp/style.css:
2241 2011-06-02 Ben Konrath <ben@bagu.org>
2243 Use String.isEmpty() to check for empty string.
2245 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2247 2011-06-02 Ben Konrath <ben@bagu.org>
2249 Display main layout group titles in the DetailsView.
2251 This is the start of the DetailsActivity/DetailsView implementation.
2253 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2254 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2255 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2256 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2257 Get the layout information for the details view from the server and set
2258 the main layout group titles.
2259 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2260 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2261 Add addLayoutGroup() and addLayoutField() methods. This are just
2262 temporary methods for creating the the details view that will change
2264 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2265 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2267 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2268 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2269 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2270 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2271 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2272 Data Transfer Objects that mimic the libglom object structure. These are
2273 used for transferring the details layout but could also be used for
2274 transferring the list layout.
2276 2011-05-27 Ben Konrath <ben@bagu.org>
2278 Reset the AuthenticationPopup when clearing the ListView.
2280 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2282 2011-05-27 Ben Konrath <ben@bagu.org>
2284 Fix problem with onlineglom.properties file loading.
2286 The old way worked in Eclipse but not on the server. Loading the
2287 onlineglom.properties file now works in Eclipse and on the server.
2289 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2291 2011-05-24 Ben Konrath <ben@bagu.org>
2293 Update gwt-log from 3.1.0 to 3.1.2.
2295 Gwt-log 3.1.0 has been marked as depreciated.
2299 2011-05-24 Ben Konrath <ben@bagu.org>
2301 Add comment to ListActivity.goTo() method.
2303 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2305 2011-05-24 Ben Konrath <ben@bagu.org>
2307 Remove FIXME in convertGdkColorToHtmlColour()
2309 The Gdk::Color value returned by libglom is 16-bits per channel on both
2310 64 and 32-bit platforms.
2312 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2314 2011-05-19 Ben Konrath <ben@bagu.org>
2316 Improve performance of initial ListView load.
2318 I removed a round trip to the server for getting the default table name
2319 and then requesting information about that table. This also removes a potential
2320 problem with the table change handler not being setup in time to receive the
2321 table change event from the ListActivity.
2323 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2324 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2325 getDefaultLayoutListTable() method. Improve comments.
2326 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2327 getDefaultLayoutListTable() method instead of firing a table change
2328 event to get the table to load.
2329 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2330 implementation of getDefaultLayoutListTable() method.
2331 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2334 2011-05-19 Ben Konrath <ben@bagu.org>
2336 Override toDebugString() in TableChangeEvent.
2338 This is useful to have for debugging.
2340 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2342 2011-05-19 Ben Konrath <ben@bagu.org>
2344 Add a "Back to List" link when at the DetailsPlace.
2346 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2347 Populate the CellTable based on the selected table of the ListBox if
2348 it's set otherwise use the default table. This allows the "Back to
2350 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2351 Remove Place from constructors. Add a setPlace() method. Add
2352 goToPlace() method. Set class as presenter for TableSelectionView.
2353 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2354 Use the same TableSelectionActivity when switching between the List and
2356 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2357 Subclass the new HasSelectableTablePlace. This removes some duplicate
2359 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2360 New class to represent Places that display the TableSelectionView.
2361 * src/main/java/org/glom/web/client/place/ListPlace.java:
2362 Subclass the new HasSelectableTablePlace. This removes some duplicate
2364 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2365 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2366 Add Presenter interface. Add setBackLinkVisible() method. Add
2367 setBackLink() method.
2369 2011-05-18 Ben Konrath <ben@bagu.org>
2371 Enable the "Details" buttons.
2373 Right now only an empty details view is displayed.
2375 * src/main/java/org/glom/web/client/ClientFactory.java:
2376 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2377 Add DetailsView to ClientFactory.
2378 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2379 A basic activity for the details view.
2380 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2381 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2383 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2384 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2386 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2387 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2388 unnecessary super() in constructor.
2389 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2390 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2391 really shouldn't create a new TableSelectionActivity for both the ListPlace
2392 and the DetailsPlace so this should be considered a temporary solution.
2393 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2394 New file. Represents a URL for the details view.
2395 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2396 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2397 A basic details view interface and implementation.
2398 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2399 Enable the "Details" buttons.
2401 2011-05-12 Ben Konrath <ben@bagu.org>
2403 Use a LayoutPanel with multiple display areas for main layout.
2405 This is mostly a refactor in that there are no changes from the user
2406 point of view. These changes are required so that we can swap out the list view
2407 with the details view when the user clicks the "Details" button.
2409 * src/main/java/org/glom/web/client/ClientFactory.java:
2410 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2411 OnlineGlomView. Add TableSelectionView, ListView and
2412 AuthenticationPopup.
2413 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2414 for main layout. Add display regions for main activities. Add
2415 activity manager for for main activities.
2416 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2417 file from parts of the deleted OnlineGlomActivity.
2418 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2419 New file from parts of the deleted OnlineGlomActivity.
2420 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2421 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2422 New files for app wide table change event.
2423 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2424 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2425 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2426 Activity mappers for the main activities replace the deleted app-wide
2428 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2429 Fix a spelling error in he comment.
2430 * src/main/java/org/glom/web/client/ui/ListView.java:
2431 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2432 Renamed from LayoutListView and modified for MVP. This still not a
2433 proper dumb view as prescribed by the MVP pattern but it works for now.
2434 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2435 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2436 New widget stripped out of the deleted OnlineGlomView.
2437 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2438 Remove hack that is fixed by this patch.
2440 2011-05-06 Ben Konrath <ben@bagu.org>
2442 Rename OnlineGlomPlace to ListPlace.
2444 The only change besides the rename is that url will now display #list
2445 instead of #Document.
2447 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2448 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2449 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2450 * src/main/java/org/glom/web/client/place/ListPlace.java:
2451 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2453 2011-05-06 Ben Konrath <ben@bagu.org>
2455 Use Presenter for app navigation.
2457 This is the proper way to deal with Place (URL) changes with the MVP
2460 * src/main/java/org/glom/web/client/ClientFactory.java:
2461 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2462 PlaceHistoryMapper and PlaceHistoryHandler.
2463 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2464 PlaceHistoryMapper and PlaceHistoryHandler.
2465 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2466 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2467 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2468 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2469 Add Presenter interface and setPresenter methods. Rename addHyperLink
2470 to addDocumentLink taking only the document title as a parameter.
2472 2011-04-14 Ben Konrath <ben@bagu.org>
2474 Prompt for db username/password if they haven't been set.
2476 This is implemented with a popup widget that is contained within the
2477 OnlineGlomView and managed by the OnlineGlomActivity.
2479 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2480 methods for checking and setting the database username and password.
2481 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2482 new methods for checking and setting the database username and
2484 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2485 Display authentication popup if the JDBC connection to the database
2486 has not been authenticated.
2487 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2489 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2490 for dealing with the authentication popup.
2491 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2492 Implement the methods for dealing with the authentication popup.
2493 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2494 try to executed queries if the database connection hasn't been
2495 authenticated. Implement methods for checking and setting the
2496 database username and password.
2498 2011-04-12 Ben Konrath <ben@bagu.org>
2500 Make log messages a little clearer.
2502 Add a dash betweeen the document title and the table name.
2504 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2506 2011-04-12 Ben Konrath <ben@bagu.org>
2508 Protect against NPEs when cleaning up database resources.
2510 While this isn't strictly necessary because the exception is caught,
2511 not protecting against the NPEs makes it harder to find the real error
2514 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2516 2011-04-12 Ben Konrath <ben@bagu.org>
2518 Move configuration of the servlet to the constructor.
2520 The servlet will be initialized even if the database authentication
2521 information is not set or correct. I still need to add the UI for prompting
2522 the user for the authentication information when it's required.
2524 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2525 javadocs for getDocumentTitles() method.
2526 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2527 Set error message when RPC fails.
2528 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2529 glom files directory from the configuration file. Try to set the
2530 database authentication information for the specific document if it's
2531 set and works otherwise try to use the global authentication
2532 information set for the directory.
2533 * src/main/resources/onlineglom.properties: Moved from
2534 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2535 Added detailed comments for the new keys.
2537 2011-04-11 Ben Konrath <ben@bagu.org>
2539 Remove unnecessary @Override in DocumentSelectionViewImpl.
2541 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2543 2011-04-11 Ben Konrath <ben@bagu.org>
2545 Remove center alignment in DocumentSelectionView.
2547 The title element is still centred but the document titles and bottom
2548 sentence are both left-aligned.
2550 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2552 2011-04-11 Ben Konrath <ben@bagu.org>
2554 Change 'Demo' naming convention to 'Document'.
2556 This is just a rename refactor with no functional changes to the code.
2558 * src/main/java/org/glom/web/client/ClientFactory.java:
2559 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2560 * src/main/java/org/glom/web/client/OnlineGlom.java:
2561 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2562 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2563 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2564 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2565 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2566 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2567 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2568 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2569 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2570 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2572 2011-04-08 Ben Konrath <ben@bagu.org>
2574 Remove FIXME from safeLongToInt() method.
2576 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2579 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2581 2011-04-08 Ben Konrath <ben@bagu.org>
2583 Display an error if no glom documents are found in the specified directory.
2585 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2586 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2587 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2588 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2590 2011-04-08 Ben Konrath <ben@bagu.org>
2592 Add copyright header to one more file ... oops.
2594 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2596 2011-04-08 Ben Konrath <ben@bagu.org>
2598 Add copyright header to files without it.
2600 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2601 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2602 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2603 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2604 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2605 * src/main/java/org/glom/web/shared/GlomField.java:
2607 2011-04-08 Ben Konrath <ben@bagu.org>
2609 Add support for accessing multiple glom documents in the servlet.
2611 This completes the demo selection functionality.
2613 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2614 document title to methods.
2615 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2616 document title to methods.
2617 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2618 Set browser window title when the activity starts. Correct name of
2619 document title variable.
2620 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2621 Set browser window title when the activity starts. Set the table
2622 selector change handler after table selector has been set. Clear the
2623 OnlineGlomView when the activity has been stopped.
2624 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2625 document title as the place token. Use "#Document:" instead of
2626 "#OnlineGlomPlace:" in the URL.
2627 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2628 Change heading to "Online Glom"
2629 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2630 document title in RPC methods.
2631 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2632 setDocumentTitle() method. Add clear() method.
2633 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2634 setDocumentTitle() method. Implement clear() method which removes the
2635 change handler on the ListBox, clears the ListBox and clears the
2637 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2638 Implement methods with document title. Keep track for the configured
2639 glom documents and their corresponding JDBC configurations in a hash
2640 table. This information is retrieved using the document title as the
2641 key in the hash table.
2642 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2643 document title field as it's no longer needed.
2645 2011-04-08 Ben Konrath <ben@bagu.org>
2647 Update the Eclipse JDT configuration.
2649 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2650 methods. Automatically add the copyright header to new files.
2652 2011-04-05 Ben Konrath <ben@bagu.org>
2654 Add new page for demo selection.
2656 This patch adds all the components required to view and start an
2657 OnlineGlom demo by clicking on the desired hyperlink. The user is
2658 able to return to the demo selection page with the browser's back
2659 button. I still need to modify the servlet to work with multiple
2660 documents so all demo links will load the file defined in the
2661 OnlineGlom.properties.
2663 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2664 This is only useful during development so we don't need to save it.
2665 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2666 get a reference to the DemoSelectionView.
2667 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2668 method to get a reference to the DemoSelectionView.
2669 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2670 default view to DemoSelectionView.
2671 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2672 to get glom document titles for glom files in a hard-coded directory.
2673 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2674 method to get glom document titles for glom files in a hard-coded
2676 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2677 Presenter for DemoSelectionView.
2678 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2679 for DemoSelectionView.
2680 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2681 Update for DemoSelectionView.
2682 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2683 Basic 'Place' implementation for the DemoSelectionView.
2684 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2685 The interface for the DemoSelectionView.
2686 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2687 The implementation of the DemoSelectionView.
2688 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2689 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2690 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2691 implementation of method to get glom document titles for glom files
2692 in a hard-coded directory.
2693 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2694 on longer being used.
2695 * src/main/webapp/glom.png: Glom logo.
2697 2011-04-05 Ben Konrath <ben@bagu.org>
2699 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2701 This is the forth and final commit of a refactor that will allow
2702 OnlineGlom to be used with multiple documents.
2704 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2705 Move RPC code from OnlineGlomViewImpl to this class.
2706 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2708 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2709 RPC code to the presenter class (the P in MVP).
2711 2011-04-04 Ben Konrath <ben@bagu.org>
2713 Start moving the existing OnlineGlom code to MVP.
2715 This work is based on the GWT MVP framework that is documented here:
2717 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2719 This is the third commit of a refactor that will allow OnlineGlom to
2720 be used with multiple documents.
2722 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2723 Interface for client factory which is used to get instances of various
2724 classes throughout the app.
2725 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2726 Implementation of client factory.
2727 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2728 initialize the MVP framework.
2729 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2730 New file. Activity manager for the main container widget. This is the
2732 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2733 Maps place (URL) to its corresponding activity.
2734 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2735 New file. This is just a place holder for a generated file.
2736 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2737 New file. Represents the URL for the main Online Glom app.
2738 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2739 for changes in LayoutListViewImpl.
2740 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2741 interface for View. Move code to OnlineGlomViewImpl class.
2742 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2743 file. Implementation of OnlineGlomView.
2744 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2745 Place resources. Use ClientFactoryImpl by default.
2747 2011-04-04 Ben Konrath <ben@bagu.org>
2749 Move View classes to their own package.
2751 This is the second commit of a refactor that will allow OnlineGlom to
2752 be used with multiple documents.
2754 * src/main/java/org/glom/web/client/OnlineGlom.java:
2755 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2756 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2758 2011-04-02 Ben Konrath <ben@bagu.org>
2760 Move UI code from the main module to its own class.
2762 This is the first commit of a refactor that will allow OnlineGlom to be
2763 used with multiple documents.
2765 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2766 references to OnlineGlom to OnlineGlomView.
2767 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2768 OnlineGlomView and instantiate it here.
2769 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2770 represents the main OnlineGlomView with one document.
2772 2011-04-01 Ben Konrath <ben@bagu.org>
2774 Fix formatting of gwt.xml and add DTD.
2776 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2778 2011-03-30 Ben Konrath <ben@bagu.org>
2780 Propperly convert gdkColor string to html colour string.
2782 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2784 2011-03-28 Ben Konrath <ben@bagu.org>
2786 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2788 This implementation matches
2789 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2790 readable and is not tied to Swig.
2792 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2794 2011-03-28 Ben Konrath <ben@bagu.org>
2796 Use read-only checkboxes for boolean field types.
2798 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2799 in the CellTable based on the field type. It currently only
2800 distinguishes between boolean and text columns but I'll need to add
2801 support for more types.
2802 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2803 column type in the ColumnInfo object. Add method to convert between the
2804 glom field type enum in ColumnInfo and the glom field type in libglom.
2805 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2807 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2808 getting and setting booleans.
2810 2011-03-25 Ben Konrath <ben@bagu.org>
2812 Don't get the Date twice from the ResultSet.
2814 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2816 2011-03-25 Ben Konrath <ben@bagu.org>
2818 Cleanup code in the servlet.
2820 * TODO: Remove item about row count. Add item about testing row count
2821 query with large number of rows.
2822 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2823 spelling mistakes, change method parameter to be consistent with
2826 2011-03-25 Ben Konrath <ben@bagu.org>
2828 Add server side logging with the gwt-log library.
2830 * .gitignore: Ignore the log file we're now producing.
2831 * TODO: Add a couple TODO item for logging.
2832 * pom.xml: Add gwt-log and log4j as a dependency.
2833 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2834 logging of errors, warnings and some important info.
2835 * src/main/resources/log4j.properties: New file to configure log4j.
2837 2011-03-24 Ben Konrath <ben@bagu.org>
2839 Add a disable button for the Details view.
2841 * src/main/java/org/glom/web/client/LayoutListView.java:
2843 2011-03-22 Ben Konrath <ben@bagu.org>
2845 Use a count query to get the number of rows for the list view pager.
2847 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2849 2011-03-22 Ben Konrath <ben@bagu.org>
2851 Add more TODO information about CellTable pager positioning.
2855 2011-03-19 Ben Konrath &