1 2012-03-06 Murray Cumming <murrayc@localhost.localdomain>
3 ReportGenerator: Take the Report itself instead of the name and group.
5 * src/main/java/org/glom/web/server/ConfiguredDocument.java
6 Remove getReportLayoutGroup().
7 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
8 getReportHTML(): Pass the report instead
9 of its name and layout group.
10 * src/main/java/org/glom/web/server/ReportGenerator.java
11 generateReport(): Use the report object to use the title
14 2012-03-06 Murray Cumming <murrayc@murrayc.com>
16 ReportGenerator: Remove designBand parameters.
18 * src/main/java/org/glom/web/server/ReportGenerator.java:
19 Make designBand a class member instead of passing it to all
22 2012-03-06 Murray Cumming <murrayc@murrayc.com>
24 ReportGenerator: Add lines, a bit like in the desktop version.
26 * src/main/java/org/glom/web/server/ReportGenerator.java
27 addToReport(): Use JRDesignLine.
29 2012-03-06 Murray Cumming <murrayc@murrayc.com>
31 ReportGenerator: Correct the title positions and use some bold style.
33 * src/main/java/org/glom/web/server/ReportGenerator.java:
34 Break the code up into reusable functions, correct the placement of
35 titles, and use normal/bold styles as in the reports in the desktop
38 2012-03-06 Murray Cumming <murrayc@murrayc.com>
40 ReportGenerator: Add a header band to show the field titles.
42 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
43 getReportHTML(): Pass the localeId to the ReportGenerator
45 * src/main/java/org/glom/web/server/ReportGenerator.java
46 constructor: Take the localeID so we can get translated field
48 generateReport(), addToReport(), addFieldToBand(): Add field
49 titles in a column header band.
51 2012-03-05 Murray Cumming <murrayc@murrayc.com>
53 Reports drop-down list: Some improvement.
55 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
56 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
57 Adedd setSelectedReport(),
58 setReportList(): Add a blank line so that the user can select the
60 * src/main/java/org/glom/web/client/activity/ReportActivity.java
61 start(): Show the current report by calling setSelectedReport().
62 This does not seem to work yet.
64 2012-03-05 Murray Cumming <murrayc@murrayc.com>
66 DetailsActivity, ListActivity: Move some variables into a base class.
68 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
69 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
70 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
71 the clientFactory, documentID, tableName and authenticationPopup into
72 a base class, to avoid duplication.
74 2012-03-05 Murray Cumming <murrayc@murrayc.com>
76 Translate the Reports label.
78 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
79 Get the "Reports" label string from the constants.
80 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
81 perties: Add Reports to the constants.
83 2012-03-03 Ben Konrath <ben@bagu.org>
85 Display date and time in details view.
87 https://bugzilla.gnome.org/show_bug.cgi?id=671257
89 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
91 2012-03-05 Murray Cumming <murrayc@murrayc.com>
93 Require the latest java-libglom.
95 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
97 2012-03-05 Murray Cumming <murrayc@murrayc.com>
99 Reports: Implement grouping.
101 * src/main/java/org/glom/web/server/ReportGenerator.java:
102 Handle LayoutItem_GroupBy items and try to do the right thing
103 with JRDesignGroup. It seems to work.
105 2012-03-04 Murray Cumming <murrayc@murrayc.com>
107 Actually show some data with JasperReports.
109 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
110 getReportHTML(): Move most code into a ReportGenerator class.
111 * src/main/java/org/glom/web/server/ReportGenerator.java:
112 Recurse into sub-groups, adding fields to the JasperDesign's details
113 band. Note that we must set an arbitrary width and height, or it just
114 will not show any data.
116 2012-03-04 Murray Cumming <murrayc@murrayc.com>
118 Reports Chooser: Show the titles, not the names.
120 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
121 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
122 and the names as the values.
123 * src/main/java/org/glom/web/server/ConfiguredDocument.java
124 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
125 group now that we provide the report name, so it should always
128 2012-03-04 Murray Cumming <murrayc@murrayc.com>
130 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
132 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
133 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
134 an empty quickfind string. I also corrected libglom to create only
135 empty where clauses for empty quickfind strings, but this avoids the
138 2012-02-24 Ben Konrath <ben@bagu.org>
140 Improve the tabs in the Notebook widget.
144 2012-02-15 Murray Cumming <murrayc@murrayc.com>
146 Depend on jasperreports.
148 * pom.xml: Add the dependency. My plan is to use this on the
151 2012-01-31 Murray Cumming <murrayc@murrayc.com>
153 Implement navigation to report places.
155 * src/main/java/org/glom/web/client/activity/ReportActivity.java
156 start(): Do not bother to handle all events here.
157 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
158 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
159 Added getSelectedReport().
160 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
161 .java: start(): When handling a change to the reports chooser,
162 call getSelectedReport() and goTo() its ReportPlace.
163 * src/main/java/org/glom/web/client/ui/ReportView.java
164 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
165 Added setReportHTML() which puts the html in a gwt HTML widget.
166 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
167 getReportHTML(): Return "TODO" just to show that this works.
169 2012-01-31 Murray Cumming <murrayc@murrayc.com>
171 Make ReportPlace usable.
173 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
175 * src/main/java/org/glom/web/client/place/ReportPlace.java:
176 Correct the @prefix annotation.
178 2012-01-31 Murray Cumming <murrayc@murrayc.com>
180 OnlineGlomService: Return report HTML rather than the LayoutGroup.
182 * src/main/java/org/glom/web/client/OnlineGlomService.java:
183 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
184 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
185 Change getReportLayout() to getReportHMTL() because we will not need to
186 parse or render the report layout on the client side.
187 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
188 getReportLayout(): Return the libglom LayoutGroup type because we will
189 not need to convert to a shared type, because this will not be used on
191 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
194 Note that there is still no implementation for this.
196 2012-01-30 Murray Cumming <murrayc@murrayc.com>
198 Translations: Try to translate the strings.
200 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
201 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
202 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
203 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
204 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
205 Take the Open translation from GTK+'s .po files.
206 Take the Details translation from Glom's po files.
207 I have added the other strings to Glom so we can get translations that way:
208 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
210 2012-01-27 Murray Cumming <murrayc@murrayc.com>
212 Add a (empty) Report Place, View, and Activity.
214 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
216 * src/main/java/org/glom/web/client/place/HasTablePlace.java
217 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
218 this into a superclass:
219 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
220 and also use it as the base of this new ReportPlace:
221 * src/main/java/org/glom/web/client/place/ReportPlace.java
223 * src/main/java/org/glom/web/client/ui/ReportView.java
224 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
225 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
226 Add these, containing mostly boiler-plate for now.
228 * src/main/java/org/glom/web/client/OnlineGlomService.java
229 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
230 * src/main/java/org/glom/web/server/ConfiguredDocument.java
231 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
232 Add API to get the LayoutGroup for the report.
234 2012-01-27 Murray Cumming <murrayc@murrayc.com>
236 TableSelectionViewImpl: Put the search label and entry in a div.
238 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
239 Put the search widgets in a FlowTable so that the CSS can be used to
240 style them while keeping them together.
241 * src/main/webapp/style.css: Mention the new div.
243 2012-01-27 Murray Cumming <murrayc@murrayc.com>
245 Translate more strings in more locales.
247 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
248 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
249 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
250 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
251 Translate the "Details" and "Open" string too.
253 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
254 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
255 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
256 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
257 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
258 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
259 Add these new locales as placeholders though they currently contain English.
261 2012-01-27 Murray Cumming <murrayc@murrayc.com>
263 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
265 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
266 Check the ConfiguredDocument* for null before using it.
268 2012-01-26 Murray Cumming <murrayc@murrayc.com>
270 Tell Eclipse about the generated java files.
272 * .classpath: This lets it find OnlineGlomConstants.java.
273 It would be nice if Eclipse just used the maven build files.
275 2012-01-26 Murray Cumming <murrayc@murrayc.com>
277 Prevent a crash when no locale is specified in the URL.
279 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
280 Avoid returning a null string, obtained from
281 Window.Location.getParameter(). This caused a crash when it was
282 later passed to libglom's API.
283 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
284 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
285 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
286 guard against future null strings.
288 2012-01-26 Murray Cumming <murrayc@murrayc.com>
290 Use the ?locale= query param instead of the &lang= token param.
292 * src/main/java/org/glom/web/client/place/ListPlace.java
293 * src/main/java/org/glom/web/client/place/DetailsPlace.java
294 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
295 Remove the lang token key and value.
297 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
298 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
299 When the user selects a different locale from the chooser, use
300 Window.Location.assign() to change the URL, which then causes a reload.
302 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
303 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
304 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
305 * src/main/java/org/glom/web/client/activity/ListActivity.java
306 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
307 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
308 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
309 * src/main/java/org/glom/web/client/ui/ListView.java:
310 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
312 Remove localeID member variables and method/constructor parameters, instead
313 using Utils.getCurrentLocaleID() when we need a localID to pass to
316 2012-01-26 Murray Cumming <murrayc@murrayc.com>
318 Internationalize the UI strings.
320 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
321 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
322 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
323 because it is unused. Messages are apparently strings that can have
324 parameters, but we do not need that yet, so Contants will be enough for now.
325 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
326 to say that we support the en and de locales.
327 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
328 The original English strings.
329 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
330 Some German translations of the English strings.
331 The i18n goal then uses the .properties file to generate an
332 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
333 returns an implementation that returns the translated strings.
334 The documentation suggests putting these in src/java/*/client/, but it seems
335 best to put it in src/resources/*/client/.
336 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
337 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
338 instead of hard-coding them.
339 Note that we cannot import OnlineGlomConstants because it does not exist yet,
340 but that does not seem to stop the build, though it confuses Eclipse.
342 You can see the translated string by adding ?locale=de to the URL, like so:
343 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
345 2012-01-24 Murray Cumming <murrayc@murrayc.com>
347 Improve null/empty String checks.
349 * pom.xml: Add a dependency on commons-lang, to use
350 org.apache.commons.lang.StringUtils.
351 * src/main/java/org/glom/web/server/ConfiguredDocument.java
352 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
353 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
354 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
355 Use StringUtils.isEmpty().
357 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
358 StringUtils class with a static isEmpty() function because we
359 cannot use org.apache.commons.lang.StringUtils in client-side
360 GWT code because it (apparently) cannot be compiled to javascript.
361 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
362 * src/main/java/org/glom/web/client/activity/ListActivity.java
363 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
364 * src/main/java/org/glom/web/client/place/DetailsPlace.java
365 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
366 * src/main/java/org/glom/web/client/place/ListPlace.java
367 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
368 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
369 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
370 * src/main/java/org/glom/web/client/ui/details/Group.java
371 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
372 our StringUtils.isEmpty() function.
374 2012-01-24 Murray Cumming <murrayc@murrayc.com>
376 Update to the latest java-libglom API.
378 * pom.xml: Require java-libglom 1.21.4.
379 * src/main/java/org/glom/web/server/ConfiguredDocument.java
380 getDocumentInfo(), getListViewLayoutGroup():
381 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
383 * src/main/java/org/glom/web/server/database/DBAccess.java
384 getFieldsToShowForSQLQueryAddGroup(),
385 getPrimaryKeyLayoutItemField(): Replace get_database_title()
386 with either get_database_title_original() or
387 get_database_title(localeID).
389 2012-01-24 Murray Cumming <murrayc@murrayc.com>
391 ConfiguredDocument: Avoid a null pointer exception.
393 * src/main/java/org/glom/web/server/ConfiguredDocument.java
394 Initialize localeID to "" to avoid returning a null String which
395 causes a crash in java-libglom's swing-generated code.
397 2012-01-23 Murray Cumming <murrayc@murrayc.com>
399 Some simple renaming.
401 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
402 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
403 for localeChooser. This seems more appropriate and is less ambiguous
404 particularly in the .css file.
406 2012-01-23 Murray Cumming <murrayc@murrayc.com>
408 ConfiguredDocument: Rename the localedID private member variable.
410 2012-01-23 Murray Cumming <murrayc@murrayc.com>
412 Adapt to the latest java-libglom API from git master.
414 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
415 libglom now uses only Vector instead of List, which uses add() instead of
418 2012-01-23 Murray Cumming <murrayc@murrayc.com>
420 Add and fill a Reports drop-down list box.
422 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
424 * src/main/java/org/glom/web/client/OnlineGlomService.java:
425 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
426 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
427 Added getReports(document, table, localeID), calling
428 ConfiguredDocument.getReports().
429 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
430 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
431 Added setReportsList() and a list widget.
432 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
433 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
435 2012-01-22 Murray Cumming <murrayc@murrayc.com>
437 ConfiguredDocument: Rename the localedID private member variable.
439 2012-01-20 Murray Cumming <murrayc@murrayc.com>
441 Build a source tarball with mvn assembly:single
443 * assembly.xml: Add this file.
444 * pom.xml: Use the maven-assembly-plugin and tell it to use
445 our assembly.xml file.
447 2012-01-19 Murray Cumming <murrayc@murrayc.com>
449 OnlineGlomServiceImpl: Get .glom files recursively.
451 * pom.xml: Depend on commons-io from org.apache.commons.
452 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
453 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
454 files recursively, and with the easier filter for the extension.
455 Use org.apache.commons.io.FilenameUtils.removeExtension() to
456 simplify that code too.
458 2012-01-19 Murray Cumming <murrayc@murrayc.com>
460 README: Mention that you must install java-libglom packages separately.
462 But then it works, because java-libglom is now in the central maven
465 2012-01-18 Murray Cumming <murrayc@murrayc.com>
467 locales drop-down: Show the correct selected locale when the URL changes.
469 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
470 .java: setPlace(): Move some code into fillView().
472 2012-01-18 Murray Cumming <murrayc@murrayc.com>
474 locales drop-down: Do not lose the primary key.
476 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
477 start(): onLocaleChange(): Pass the current primary key value,
478 instead of an empty value.
480 2012-01-18 Murray Cumming <murrayc@murrayc.com>
482 locales drop-down: Do not lose the drop-down selection.
484 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
485 .java (TableSelectionActivity.fillView): Set the selected locale
486 after changing the drop-down items (though we do not really need
487 to change them just because the locale changes.)
489 2012-01-18 Murray Cumming <murrayc@murrayc.com>
491 locales drop-down: Change the tables list when this changes.
493 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
494 .java: TableSelectionActivity.start(): Move the async table titles
495 retrieval into a private fillView() method and also call this when
496 the chosen locale changes.
497 Note that the document title is not actually translatable yet, but
498 that is a problem that I should fix soon in libglom.
500 2012-01-18 Murray Cumming <murrayc@murrayc.com>
502 Improve the placement of the locales drop-down.
504 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
505 Put the title and locales drop-down in a div (gwt.FlowTable).
506 * src/main/webapp/style.css: Add magic css properties to make this work.
507 Also remove the left margin from the title so that it lines up with the
510 2012-01-18 Murray Cumming <murrayc@murrayc.com>
512 locales selector: Show human-readable locale titles.
514 * src/main/java/org/glom/web/server/ConfiguredDocument.java
515 getDocumentInfo(): Use java.util.Locale to show a real title of
516 each locale, in the locale's own language.
518 2012-01-17 Murray Cumming <murrayc@murrayc.com>
520 Add a language/locale selector drop-down.
522 * src/main/java/org/glom/web/shared/DocumentInfo.java:
523 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
524 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
525 getDocumentInfo(): Store the available Locales in the DocumentInfo.
526 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
527 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
528 Add a ListBox to show the available locales. Add getLocaleSelector(),
529 setLocaleList(), getSelectedLocale(), setSelectedLocale().
530 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
531 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
532 java: Add these classes.
533 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
534 start(): Fill the locales ListBox. Handle its change event, firing a
536 setPlace(): Show the selected locale as specified by the URL token.
537 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
538 * src/main/java/org/glom/web/client/activity/ListActivity.java:
539 Handle LocaleChangeEvent, going to a new *Place with that locale.
541 The placement of the ListBox is not pretty, and it currently uses the ID
542 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
546 2012-01-17 Murray Cumming <murrayc@murrayc.com>
548 Search box: Show the search text from the URL token.
550 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
551 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
552 Add setQuickFindText().
553 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
554 .java: setPlace(): Store the queryText if the place is a ListPlace,
555 and call TableSelectionView.setQuickFindText().
557 2012-01-17 Murray Cumming <murrayc@murrayc.com>
559 Allow use of translations via, for instance, &lang=de in the URL.
561 * pom.xml: Use the unstable java-libglom 1.21 version.
563 * src/main/java/org/glom/web/client/OnlineGlomService.java:
564 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
565 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
566 init(): Instead of calling TranslatableItem.set_current_locale()
567 (now removed), call ConfiguredDocument.setDefaultLocaleID().
568 However, this is only for default locales, which are not needed to
569 change the locale in the URL.
570 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
571 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
572 getSortedRelatedListData(): Add a localeID parameter, so we can get the
573 layout for a particular locale.
574 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
575 Add get/setDefaultLocaleID().
576 getDocumentInfo(), getListViewData(), getRelatedListData(),
577 getDetailsLayoutGroup(), getListViewLayoutGroup(),
578 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
579 localeID parameter, so we can get the layout for a particular locale.
581 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
582 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
583 * src/main/java/org/glom/web/client/place/ListPlace.java:
584 Parse and construct a lang parameter too.
586 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
587 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
588 passed to subsequent methods and constructors.
589 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
590 * src/main/java/org/glom/web/client/activity/ListActivity.java:
591 Store the localeID from the *Place and pass it to other constructors
592 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
594 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
595 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
596 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
597 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
598 * src/main/java/org/glom/web/client/ui/ListView.java:
599 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
600 Take localeID parameters and pass them to subsequent constructors and
601 methods, so that the layout is always retrieved for that locale.
603 This is rather repetitive.
605 Note that "" means the original (default) locale of the Glom document,
606 which is usually English.
608 2012-01-17 Murray Cumming <murrayc@murrayc.com>
610 Documents: Remove final keyword to fix startup configuration.
612 * src/main/java/org/glom/web/shared/Documents.java: Remove the
613 final keywords on the private member variables because that breaks
614 the startup, apparently (there are warnings) because it stops them
615 from being serialized. I added these in the previous commit.
617 2012-01-13 Murray Cumming <murrayc@murrayc.com>
619 Documents: Add some final keywords.
621 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
624 2012-01-13 Murray Cumming <murrayc@murrayc.com>
626 OnlineGlomServiceImpl: Add to overview comments.
628 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
629 Note that this is where all the document are loaded. They are not
630 loaded freshly for each page.
632 2012-01-12 Murray Cumming <murrayc@murrayc.com>
636 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
637 Add a TextBox for the text of a quick find.
638 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
640 setBackLink(): Add a String quickFind parameter.
641 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
642 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
643 to the base interface, because that is how TableSelectionViewImpl is used.
644 * src/main/webapp/style.css: Add style for the search box and its label.
646 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
647 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
648 Add these files, based on the existing TableChangeEvent and
649 TableChangeEventHandlers.
650 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
651 start(): Handle QuickFindChangeEvent, passing its quickFind text to
652 a ListPlace() that the user should be taken to.
653 * src/main/java/org/glom/web/client/activity/ListActivity.java
654 start(): Handle it here too and adapt the TableChangeEvent handler to
655 pass the extra "" quickFind parameter to ListPlace.
656 * src/main/java/org/glom/web/client/place/ListPlace.java:
657 Constructor: Take an extra String quickFind parameter and store it,
658 returning it from a new getQuickFind() method.
659 getToken(): Put the quickFind text in the URL token.
660 getPlace(): Parse the quickFind text from the URL token.
661 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
662 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
663 ListPlace constructor.
664 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
665 .java: start(): Add a Change handler for the TableSelectionView's
666 TextBox (via its base HasChangeHandlers interface), firing the new
667 QuickFindChangeEvent.
668 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
669 pass the extra "" quickFind parameter.
671 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
672 setCellTable(): Add a String quickFind parameter and pass it to
673 the ListViewTable() constructor.
674 * src/main/java/org/glom/web/client/ui/ListView.java: Change
675 setCellTable() in the base interface, because that is how ListViewImpl
678 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
679 Add a String quickFind member variable.
680 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
681 Constructor: Add a String quickFind parameter, storing it in the
682 base ListTable's member variable.
683 onRangeChanged(): Pass quickFind to the
684 OnlineGlomServiceAsync.getSortedListViewData() and
685 OnlineGlomServiceAsync.getListViewData() methods.
687 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
688 getListViewData(), getSortedListViewData(): Add a String quickFind
689 parameter, passing it to ConfiguredDocument.getListViewData().
690 * src/main/java/org/glom/web/client/OnlineGlomService.java:
691 Change getListViewData(), getSortedListViewData() in the base interface,
692 because that is how OnlineGlomServiceImpl is used, via this:
693 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
694 Change getListViewData(), getSortedListViewData() here too.
695 This class can apparently be used to asynchronously call methods on
696 OnlineGlomService, and GWT seems to implement that after recognizing
697 just the *Async name convention and the extra AsyncCallback parameters.
699 * src/main/java/org/glom/web/server/ConfiguredDocument.java
700 getListViewData(): Add a String quickFind parameter, and pass it to
701 ListViewDBAccess.getData().
702 * src/main/java/org/glom/web/server/database/ListDBAccess.java
703 getListData(): Add a String quickFind parameter and pass it to
705 getSelectQuery(): Add a String quickFind parameter.
706 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
707 getSelectQuery(): Add a String quickFind parameter and use it with
708 Glom.get_find_where_clause_quick() to pass a where_clause to
709 Glom.build_sql_select_with_where_clause(), to actually filter the
711 getData(): Add a String quickFind parameter, passing it to getListData().
712 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
713 va: getData(): Pass an empty string to getListData() for the
716 2012-01-12 Murray Cumming <murrayc@murrayc.com>
718 ListTable: Minor change.
720 * src/main/java/org/glom/web/client/ui/list/ListTable.java
721 createCellTable(): Make this protected instead of public.
723 2012-01-12 Murray Cumming <murrayc@murrayc.com>
725 Many files: Use final for the parameters and use the @override attribute.
727 2012-01-22 Ben Konrath <ben@bagu.org>
729 Add anchor links for single line text that starts with http, ftp and www.
733 2012-01-22 Ben Konrath <ben@bagu.org>
735 Add ellipsis to single line text in details view.
739 2012-01-04 Murray Cumming <murrayc@murrayc.com>
741 Remove all javadoc author tags.
743 Because they are awkward and meaningless when many people touch
745 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
747 2012-01-04 Murray Cumming <murrayc@murrayc.com>
749 Revert the COPYING.LESSER to COPYING rename.
751 Apparently both should be there if it is LGPL.
753 2012-01-03 Murray Cumming <murrayc@murrayc.com>
755 *View: Remove unused imports.
757 * src/main/java/org/glom/web/client/ui/DetailsView.java:
758 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
759 * src/main/java/org/glom/web/client/ui/ListView.java:
760 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
761 Remove unused imports, as suggested by Eclipse.
763 2012-01-02 Murray Cumming <murrayc@murrayc.com>
765 Move the *View::Presenter types, and some API into one base View.
767 * src/main/java/org/glom/web/client/ui/DetailsView.java:
768 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
769 * src/main/java/org/glom/web/client/ui/ListView.java:
770 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
771 Presenter, setPresenter() and clear() into a shared base interface,
772 to avoid the unnecessary duplicate Presenter types and to more clearly
773 show how the *Views share the same structure, even if they are not
774 used polymorphically.
776 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
777 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
779 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
780 * src/main/java/org/glom/web/client/activity/ListActivity.java:
781 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
783 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
786 Feel free to revert this if there is a good reason for the duplicate
789 2012-01-02 Murray Cumming <murrayc@murrayc.com>
791 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
793 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
794 a class member instead of a local variable in the method.
795 This lets us use it to get the view instances, for use in tests.
796 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
797 beforeOnlineGlom(): Test some more details of the initial view.
798 Again, this is not very useful.
800 To really test gwt-glom we will need to start a local postgresql
801 instance with local data, like the Glom tests in C++.
803 2012-01-02 Murray Cumming <murrayc@murrayc.com>
805 pom.xml: Mention the LGPL license.
807 * pom.xml: Add a licenses section.
808 * COPYING.LESSER: Move this to COPYING, which
809 previously contained the GPL. But gwt-glom is all LGPL.
811 2012-01-02 Murray Cumming <murrayc@murrayc.com>
813 Add project information to README and pom.xml.
815 * README: Add a brief description and mention some mvn
817 * pom.xml: This extra information shows up in mvn site
820 2011-01-02 Murray Cumming <murrayc@murrayc.com>
822 Use the latest java-libglom version.
824 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
826 2012-01-01 Murray Cumming <murrayc@murrayc.com>
828 GwtTestOnlineGlom: Test a little more.
830 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
831 protected rather than private, as suggested by the gwt-test-utils
833 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
834 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
835 Test the initial visibility of the panels.
837 However, this is not a very useful test.
838 And I wonder how we should generally test using this idea for an
839 activity/places app like ours where the real changes happen implicitly
840 based on the history token/URL.
842 2012-01-01 Murray Cumming <murrayc@murrayc.com>
844 Slight modification to *Mapper comments.
846 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
848 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
850 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
852 Remove comments mentioning GIN because they are just copied from
853 the example code and are apparently not helpful:
854 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
855 Also change the mention of a class that is only in the example code.
857 2012-01-01 Murray Cumming <murrayc@murrayc.com>
859 GwtTestOnlineGlom test: Minor changes.
861 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
862 Avoid the long qualified class name and modify the comment
863 because it is now obvious to me that the mocked class is the only
864 custom one created via GWT.create().
866 2012-01-01 Murray Cumming <murrayc@murrayc.com>
868 Tests: Added the beginnings of a test using gwt-test-utils.
870 * pom.xml: Add dependencies on gwt-test-utils and easymock.
871 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
872 which tells gwt-test-utils what class will be tested.
873 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
874 Add a simple (but empty) test case. One class, used by the OnlineGlom
875 class, is mocked so that it can be created. However, I am not sure
876 why only this class needs to be mocked.
878 Note that mockito seems more popular, and clearer, than easymock,
879 but I have not got that working yet. It might be a matter of the
882 This test is run during mvn integration-test.
884 2011-12-31 Murray Cumming <murrayc@murrayc.com>
886 Tests: Use junit4-style syntax instead of junit3-style.
888 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
889 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
890 * src/test/java/org/glom/web/shared/DataItemTest.java:
891 Use the @Test annotation rather than relying on the test*() prefix.
892 Also no longer implement TestCase, to avoid triggering support for
893 the junit3-way, which stops the annotations from working.
894 Change the imports from import junit.framework.* to
895 import org.junit.*, which is apparently the new way.
897 2011-12-31 Murray Cumming <murrayc@murrayc.com>
899 Added a test for ListPlace token parsing and creation.
901 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
902 This is much the same as DetailsPlaceTest.
904 I wonder how we could test the other parts of the *Place API.
906 2011-12-30 Murray Cumming <murrayc@murrayc.com>
908 DetailsPlace test: Also test getToken() and recreation via getPlace().
910 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
911 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
912 recreate it, testing the recreated DetailsPlace for the same parameter
915 2011-12-30 Murray Cumming <murrayc@murrayc.com>
917 Use the surefire-report plugin.
919 * pom.xml: This generates a HTML report about the tests in
920 target/site/surefire-report.html
921 when you do mvn surefire-report:report. It seems to be popular/normal.
923 2011-12-30 Murray Cumming <murrayc@murrayc.com>
925 Added a test for DetailsPlace.
927 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
928 Test the getPlace() token parsing.
930 2011-12-30 Murray Cumming <murrayc@murrayc.com>
932 Added a first unit test.
934 * pom.xml: Add a test goal, and a dependency on junit in that scope.
935 * src/test/java/org/glom/web/shared/DataItemTest.java:
936 This is a silly test but it is just to get things started. Note that
937 maven/junit finds the test because it looks in src/test by default.
939 2011-12-22 Ben Konrath <ben@bagu.org>
941 Change charsetName to "UTF-8" when replacing line breaks.
943 JavaScript requires the charsetName to be "UTF-8". CharsetName values
944 that work in Java (such as "UTF8") will not work when compiled to
947 This fixes a problem with multi-line details view fields that have hard
948 line breaks. The "License Text" field on this page demonstrates the
951 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
953 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
955 2011-12-22 Ben Konrath <ben@bagu.org>
957 Fix another bug with related list navigation.
959 I've tested all the navigation buttons in all of the related lists
960 so things should be good now.
962 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
964 2011-12-22 Ben Konrath <ben@bagu.org>
966 Fix a crasher when refreshing the list view with the default table.
968 This crash will also happen when loading the list view with the default
969 table from a link or bookmark.
971 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
972 to the main document selection page when the document id hasn't been
974 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
975 the main document selection page when the document id hasn't been
977 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
978 values for the details place when the document id hasn't been set.
979 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
980 values for the list place when the document id hasn't been set.
982 2011-12-21 Ben Konrath <ben@bagu.org>
984 Protect against NPE when glom.document.locale is not in config.
986 This patch protects against an NPE when glom.document.locale is not in
987 the config file. This NPE will also happen if glom.document.locale is
990 The patch also updates the error message to display the class name when
991 the getMessage() returns null. This was happening when the NPE was
992 thrown and I had "Configuration Error: null". If an NPE is encountered
993 with this patch, "Configuration Error: NullPointerException " will be
996 This commit closes this bug:
998 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1000 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1002 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1004 Rename onlineglom.properties to onlineglom.properties.sample.
1006 * src/main/resources/onlineglom.properties: Rename to:
1007 * src/main/resources/onlineglom.properties.sample:
1008 * src/main/resources/README: And add this file explaining that people
1009 should rename it back when deploying.
1011 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1013 Allow choosing the translation in the .properties file.
1015 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1016 init(): Read a glom.document.locale value from the configuration file
1017 and call Glom's TransatableItem::set_current_locale() method.
1018 * src/main/resources/onlineglom.properties: Add a commented-out
1019 example of this new setting.
1021 It would be better to add &lang=de_DE to the URL, but the current
1022 libglom API does not allow us to do this easily. I am working on that.
1024 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1026 Avoid a crash in parsing of token parameters.
1028 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1029 ava: getTokenParams(): Do not crash if a parameter has a key but no
1030 value, and ignore parameters with neither.
1032 2011-12-17 Murray Cumming <murrayc@murayc.com>
1034 History token building/handling: Improve use of token parameters.
1036 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1037 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1038 and buildParamsToken(HashMap), for use by derived classes.
1039 Make the separator private because it is no longer be needed.
1040 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1041 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1042 instead of manual string concatenation.
1043 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1044 of hardcoded indices and awkward splitting code.
1045 * src/main/java/org/glom/web/client/place/ListPlace.java
1046 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1047 instead of manual string concatenation.
1048 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1049 of hardcoded indices and awkward splitting code.
1050 This should fix bug #666420
1052 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1054 Fix a Navgiation->Navigation typo in the code.
1056 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1057 Rename processNavgiation() to processNavigation().
1059 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1061 Fix a seperator->separator typo in the code.
1063 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1064 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1065 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1068 2011-12-15 Ben Konrath <ben@bagu.org>
1070 Cleanup some comments.
1072 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1074 2011-12-14 Ben Konrath <ben@bagu.org>
1076 Replace \n with <br/> for multiline text in the details view.
1078 Vertical scrollbars are added when needed as well.
1080 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1082 2011-12-14 Ben Konrath <ben@bagu.org>
1084 Specify the font for document selection links.
1086 * src/main/webapp/style.css:
1088 2011-12-14 Ben Konrath <ben@bagu.org>
1090 Fix bouncy CellTable while paging.
1092 This doesn't currently work with related list tables in unselected
1095 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1097 2011-12-14 Ben Konrath <ben@bagu.org>
1099 Revamp the appearance of the document selection page.
1101 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1102 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1103 * src/main/webapp/style.css:
1105 2011-12-13 Ben Konrath <ben@bagu.org>
1107 Set navigation button column to the smallest size possible.
1109 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1111 2011-12-13 Ben Konrath <ben@bagu.org>
1113 Change OpenButton nomenclature to NavigationButton.
1115 Using NavigtionButton makes things more generic. Classes, methods and
1116 variables have been changed.
1118 This is a rename-only refactor.
1120 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1121 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1122 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1123 Renamed from OpenButtonCell.
1124 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1125 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1126 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1128 2011-12-12 Ben Konrath <ben@bagu.org>
1130 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1132 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1133 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1134 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1135 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1137 2011-12-12 Ben Konrath <ben@bagu.org>
1139 Update variable names and comments.
1141 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1142 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1144 2011-12-12 Ben Konrath <ben@bagu.org>
1146 Properly initialize numNonEmptyRows variable to zero.
1148 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1149 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1151 2011-12-05 Ben Konrath <ben@bagu.org>
1153 Add latest mockup with HTML tables.
1155 Features of this mockup:
1157 -> HTML table for flowtable
1158 -> HTML table for flowtable column
1159 -> Example of how related lists would look
1160 -> Not using text entries for data items
1162 The current version of Online Glom doesn't use HTML tables for the
1165 This mockup has been sent to the glom-devel mailing list but it's good
1166 to have it here as well.
1168 * mockups/details-view-html-tables.html:
1170 2011-12-05 Ben Konrath <ben@bagu.org>
1172 Remove unnecessary getPrimaryKeyField() method.
1174 getPrimaryKeyFieldForTable(String) has been renamed to
1175 getPrimaryKeyField(String).
1177 * src/main/java/org/glom/web/server/database/DBAccess.java:
1178 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1179 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1181 2011-12-05 Ben Konrath <ben@bagu.org>
1183 Add string representation of TypedDataItem value to conversion error message.
1185 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1186 message was extracted into its own method to avoid duplication.
1188 2011-12-05 Ben Konrath <ben@bagu.org>
1190 Add type checking to navigation primary key value creation.
1192 Create navigation primary key only if the expected type from the Glom
1193 document matches the type returned by the SQL query.
1195 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1197 2011-12-05 Ben Konrath <ben@bagu.org>
1199 Rename a couple of variables in RelatedListNavigation.
1201 This is a rename-only refactor.
1203 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1205 2011-12-05 Ben Konrath <ben@bagu.org>
1207 Move getListLayoutGroup() into getListViewLayoutGroup().
1209 This removes getListLayoutGroup(). It was only being called by
1210 getListViewLayoutGroup().
1212 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1214 2011-12-05 Ben Konrath <ben@bagu.org>
1216 Remove check for LayoutItem_Portal in list table method.
1218 This check is no longer necessary because the method isn't being used
1219 to create the LayoutItemPortal DTO.
1221 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1223 2011-12-05 Ben Konrath <ben@bagu.org>
1225 Properly support related list navigation.
1227 Navigation from the "Repository Analyzer -> Package Scans ->
1228 Dependencies" related table wasn't working because the primary key for
1229 related tables wasn't being set properly. This commit fixes the
1232 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1233 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1234 doesn't set the primary key properly for related list tables.
1235 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1236 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1237 useful for getting the primary key for list view tables and for related
1239 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1240 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1241 Move code to set the primary key for the table from the abstract
1242 ListDBAccess class to ListViewDBAccess as it's only correct for list
1244 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1245 Properly add primary key to related list tables.
1247 2011-12-02 Ben Konrath <ben@bagu.org>
1249 Properly set the horizontal alignment of fields.
1251 This fix is for both the list tables and the details view.
1253 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1254 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1255 to set the horizontal alignment of fields.
1257 2011-12-02 Ben Konrath <ben@bagu.org>
1259 Display currency codes in the details view.
1261 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1263 2011-12-02 Ben Konrath <ben@bagu.org>
1265 Avoid duplicate JNI call.
1267 JNI is not as efficient as pure Java and this is an easy (and small)
1270 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1271 Use previously retrieved value for whereClauseToTableName instead of
1274 2011-12-02 Ben Konrath <ben@bagu.org>
1276 Rename a couple of variables in RelatedListNavigation.
1278 This is a rename-only refactor.
1280 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1282 2011-12-02 Ben Konrath <ben@bagu.org>
1284 Indicate clearly that a mismatched primary key type is a bug.
1286 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1287 warning to error. Add 'This is a bug.' to message.
1289 2011-12-02 Ben Konrath <ben@bagu.org>
1291 Update / fix some comments.
1293 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1295 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1297 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1298 Fix comments. Add some TODOs.
1300 2011-12-02 Ben Konrath <ben@bagu.org>
1302 Enable navigation to details view with string primary key from related list.
1304 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1305 Create a text primary key value when return type of result is
1306 java.sql.Types.VARCHAR.
1308 2011-12-02 Ben Konrath <ben@bagu.org>
1310 Use checkboxes for booleans in the details view.
1312 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1314 2011-12-01 Ben Konrath <ben@bagu.org>
1316 Improve performance of related list height calculation.
1318 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1319 Put code to calculate the expected height in a static initializer so
1320 that that it's only called once.
1322 2011-12-01 Ben Konrath <ben@bagu.org>
1324 Show related list tables in notebooks (again).
1326 Calculate the height of the related list tables so the Notebook can be
1327 set the correct height. The height of the related list table is also needed by
1328 FlowTable to be able decide how to create the layout.
1330 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1331 and set the Portal height based on the height of the related list
1332 table and the Portal container.
1333 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1334 Add method to calculate the height of the related list tables.
1335 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1336 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1337 calculate the height of the Pager widget.
1339 2011-12-01 Ben Konrath <ben@bagu.org>
1341 Use CellTable API for table property instead of setting style on Element.
1343 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1345 2011-12-01 Ben Konrath <ben@bagu.org>
1347 Make ListViewTable and RelatedListTable a consistent height.
1349 The tables are now a consistent height regardless of the contents of
1350 the table. A hidden button is added to empty rows to ensure that the
1351 height of these rows will match the height of rows with data.
1353 A navigation button column is now added to every table. The width of
1354 the navigation column is set to 0px when a RelatedListTable shouldn't
1355 have navigation buttons. This maintains the a consistent row height in
1356 tables that don't show the navigation buttons.
1358 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1359 navigation column when not needed.
1360 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1361 arguments for navigation button to constructor of ListViewTable.
1362 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1363 hidden button for empty data rows.
1364 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1365 arguments for navigation button to constructor.
1366 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1367 create navigation buttons. Add hideNavigationButtons() method.
1368 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1369 arguments for navigation button to constructor.
1371 2011-12-01 Ben Konrath <ben@bagu.org>
1373 Use 'visibility: hidden' in Utils.getWidgetHeight().
1375 This is better choice because hidden elements are invisible, don't
1376 respond to events and are not part of the tab order. They will,
1377 however, take up space which is required to be able to calculate the
1378 height of the widget.
1380 * src/main/java/org/glom/web/client/Utils.java:
1382 2011-12-01 Ben Konrath <ben@bagu.org>
1384 Use Utils.getWidgetHeight() in FlowTable.
1386 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1388 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1390 2011-12-01 Ben Konrath <ben@bagu.org>
1392 Put the details css class name on the correct table column.
1394 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1396 2011-11-30 Ben Konrath <ben@bagu.org>
1398 Update for java-libglom API change.
1400 The getters and setters on FieldFormatting and NumericFormat were
1401 changed to remove the 'M'.
1403 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1405 2011-11-29 Ben Konrath <ben@bagu.org>
1407 Only allow RelatedListTables in Portals.
1409 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1411 2011-11-29 Ben Konrath <ben@bagu.org>
1413 Only create a contents panel for Portals when title is being set.
1415 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1417 2011-11-29 Ben Konrath <ben@bagu.org>
1419 Set TabLayoutPanel height based on calculated height its widgets.
1421 This is a potential fix for this bug:
1423 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1425 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1427 2011-11-29 Ben Konrath <ben@bagu.org>
1429 Align details field labels and data with the Open buttons.
1431 * src/main/webapp/style.css:
1433 2011-11-29 Ben Konrath <ben@bagu.org>
1435 Remove unnecessary <div> in the Notebook widget.
1437 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1438 method to get container FlowPanel (<div>).
1439 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1440 initWidget() method directly on the TabLayoutPanel widget instead of
1441 Group's container widget.
1443 2011-11-29 Ben Konrath <ben@bagu.org>
1445 Don't add group titles for Portals in Notebooks.
1447 This reverts the previous patch and fixes a bug I introduced with
1448 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1450 * src/main/java/org/glom/web/client/ui/details/Group.java:
1451 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1453 2011-11-28 Ben Konrath <ben@bagu.org>
1455 Remove unused boolean argument in Portal constructor.
1457 Just a code cleanup.
1459 * src/main/java/org/glom/web/client/ui/details/Group.java:
1460 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1462 2011-11-28 Ben Konrath <ben@bagu.org>
1464 Remove hack for glom 1.18 style glom files.
1466 * src/main/java/org/glom/web/client/ui/details/Group.java:
1467 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1468 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1470 2011-11-28 Ben Konrath <ben@bagu.org>
1472 Use Gda Value version of primary key to log result too large error.
1474 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1476 2011-11-28 Ben Konrath <ben@bagu.org>
1478 Don't use TypedDataItem.getText() for Unknown types from the URL.
1480 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1481 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1482 instead of getText().
1483 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1484 String field and getUnknown() method.
1486 2011-11-28 Ben Konrath <ben@bagu.org>
1488 Log an error message when the java-libglom .so is not present.
1490 The error message was being set in the exception but not logged.
1492 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1494 2011-11-28 Ben Konrath <ben@bagu.org>
1496 Ignore LayoutItem_CalendarPortals.
1498 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1499 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1501 2011-11-28 Ben Konrath <ben@bagu.org>
1503 Extract method for creating the LayoutItemPortal DTO.
1505 Just breaking the code up into smaller chunks.
1507 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1509 2011-11-28 Ben Konrath <ben@bagu.org>
1513 This should have been added with the refactor. Oops!
1515 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1517 2011-11-28 Ben Konrath <ben@bagu.org>
1519 Create primary key value from URL string using type from Glom document.
1521 See this bug, comments 19 - 25:
1523 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1525 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1526 create a TypeDataItem for the primary key here when loading from a
1527 URL. Show the same string for the primary key value as was received
1528 from the URL string (when loading from a URL).
1529 * src/main/java/org/glom/web/server/Utils.java: Update method for
1530 creating the Gda Value from the TypeDataItem to properly deal with
1531 creating a Gda Value based on the Glom document type for the primary
1532 key value string when loading from a URL.
1533 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1534 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1535 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1536 Update for changed method name.
1538 2011-11-27 Ben Konrath <ben@bagu.org>
1540 Rename PrimaryKeyItem to TypedDataItem.
1542 The name PrimaryKeyItem suggests what the class should be used for.
1543 TypedDataItem is a neutral name that describes the class better.
1545 This is a rename-only refactor.
1547 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1548 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1549 * src/main/java/org/glom/web/client/Utils.java:
1550 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1551 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1552 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1553 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1554 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1555 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1556 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1557 * src/main/java/org/glom/web/server/Utils.java:
1558 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1559 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1560 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1561 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1563 2011-11-25 Ben Konrath <ben@bagu.org>
1565 Improve Gda Value conversion from PrimaryKeyItem.
1567 The value from the PrimaryKeyItem is only used if its type match the
1568 type from the glom document.
1570 * src/main/java/org/glom/web/server/Utils.java:
1572 2011-11-25 Ben Konrath <ben@bagu.org>
1574 Manually check if the java-liblgom .so is visible to the JVM.
1576 It seems that Tomcat has problems when a static initializer throws an
1577 exception. This check is done before the first method call into
1578 java-libglom so that execution doesn't continue if the .so is not
1581 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1583 2011-11-25 Ben Konrath <ben@bagu.org>
1585 Improve browser configuration error messages.
1589 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1591 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1592 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1593 getConfigurationErrorMessage() method.
1594 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1595 Get and display a specific configuration error message when no Glom
1596 documents are found.
1597 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1598 Implement getConfigurationErrorMessage() method. Surround configuration
1599 code in the init() method with a try/catch block. This allows the
1600 errors to be caught while keeping the servlet available to retrieve the
1601 configuration error message.
1603 2011-11-25 Ben Konrath <ben@bagu.org>
1605 Don't use Strings to hold primary key values.
1607 The primary key values are now held in a new data object
1608 (PrimaryKeyItem) that holds type information and the primary key value
1609 using the correct type.
1611 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1612 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1613 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1614 PrimaryKeyItem instead of String to hold the primary key value.
1615 * src/main/java/org/glom/web/client/Utils.java: Remove
1616 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1617 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1618 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1619 PrimaryKeyItem instead of String to hold the primary key value. Load
1620 document selection page when the documentID has not been set correctly.
1621 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1622 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1624 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1625 Return empty string for URL instead of "null".
1626 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1627 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1628 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1629 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1630 PrimaryKeyItem instead of String to hold primary key values.
1631 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1632 PrimaryKeyValue to a Gda Value.
1633 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1634 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1635 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1636 Replace temporary database access code that uses the PrimaryKeyValue to
1637 Gda Value conversion.
1638 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1639 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1640 PrimaryKeyItem instead of String.
1641 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1642 hold primary key values.
1644 2011-11-24 Ben Konrath <ben@bagu.org>
1646 Use newly added java-libglom API to create queries.
1648 This isn't finished. I still need to stop using Strings for primary key
1649 values in the client code.
1651 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1652 libglom to use fake connections so that retrieving the query string will
1654 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1655 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1656 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1657 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1658 Use the newly added libglom sql methods and classes to create the
1659 query. Add temporary hack to convert primary value strings to Gda
1662 2011-11-23 Ben Konrath <ben@bagu.org>
1664 Don't explicitly set the height of Portals.
1666 See comments 6 - 10 of this bug for details:
1668 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1670 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1672 2011-11-23 Ben Konrath <ben@bagu.org>
1674 Use an HTML table instead of CSS for the FlowTable layout.
1676 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1677 GWT's FlexTable to implement the FlowTable.
1678 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1680 2011-11-18 Ben Konrath <ben@bagu.org>
1682 Add boolean example to HTML table mockup.
1684 * mockups/details-view-html-tables-text-entries.html:
1686 2011-11-17 Ben Konrath <ben@bagu.org>
1688 Ensure the pager buttons are always visible for related lists.
1690 To accomplish this, I've turned off text wrapping in the list view and
1691 related list tables for both the header and data text. The related list
1692 table now has a fixed layout so the it doesn't overflow its container.
1693 This is required to ensure that the cell text is clipped when it
1694 overflows the cell and an ellipsis is added to the right side of the
1695 cell when text is clipped.
1697 A fixed table layout for the related list table in the details view
1698 seems what we want for the details view anyway, so the side-effect is
1701 The ellipsis will only be displayed in Firefox >= 7.
1705 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1707 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1708 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1709 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1711 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1712 Set the 'table-layout: fixed' CSS property to the related list table.
1713 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1714 'white-space: nowrap;' CSS property on both the list view and the
1715 related list tables.
1717 2011-11-16 Ben Konrath <ben@bagu.org>
1719 Rework the fix for empty notebook tab labels.
1721 Setting the empty group titles with its name caused problems for the
1722 details layout. Instead of using libglom's
1723 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1724 to the client when the title is empty. This allows the Notebook to use
1725 the name when the title is empty without affecting anything else.
1727 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1728 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1730 2011-11-16 Ben Konrath <ben@bagu.org>
1732 Set group titles with name when title is empty.
1734 This fixes a problem with an empty notebook tab label in the Lesson
1735 Planner document. The forth tab in the notebook should be "Internet":
1737 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1739 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1740 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1743 2011-11-16 Ben Konrath <ben@bagu.org>
1745 Remove whitespace from the configured username properties.
1747 This assumes that usernames won't have whitespace at the beginning
1748 or end. But I think this is a reasonable assumption.
1750 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1751 String.trim() to remove the whitespace from the username properties.
1753 2011-11-15 Ben Konrath <ben@bagu.org>
1755 Add details view mockup with HTML tables and text entries.
1757 This is from the attachment on this bug:
1759 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1761 * mockups/details-view-html-tables-text-entries.html:
1763 2011-11-15 Ben Konrath <ben@bagu.org>
1765 Add space between the columns of the flow table.
1769 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1771 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1772 space between columns in the flow table.
1774 2011-11-15 Ben Konrath <ben@bagu.org>
1776 Add backup files to the .gitignore.
1778 * .gitignore: Ignore files that end with ~.
1780 2011-11-09 Ben Konrath <ben@bagu.org>
1782 Use latest release of gwt-log.
1784 Gwt-log releases are now being submitted to the maven central
1785 repository so manual installation of the jar is no longer required.
1787 * pom.xml: Update version and groupId of gwt-log dependency.
1789 2011-10-31 Ben Konrath <ben@bagu.org>
1791 Don't use GWT numeric formatting to override the glom currency formatting.
1793 Currencies are now displayed like they are in Glom. See this bug:
1795 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1797 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1799 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1800 currency code to constructor and set it when the cell is rendered.
1801 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1802 currency code to the constructor of the NumericCell.
1804 2011-10-27 Ben Konrath <ben@bagu.org>
1806 Require the latest release of java-libglom (1.17.4).
1810 2011-10-26 Ben Konrath <ben@bagu.org>
1812 Add style to Notebook that matches current theme.
1814 It's not the best style in the world but it's better than the default.
1816 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1817 padding at the bottom of the child widgets.
1818 * src/main/webapp/style.css: Add style for the Notebook.
1820 2011-10-26 Ben Konrath <ben@bagu.org>
1822 Move servlet initialization code to overridden init method.
1824 This is half of the solution to getting proper error messages
1825 displayed when configuration errors occur. Here's the relevant bug:
1827 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1829 The rest of the solution involves surrounding the init method with a
1830 try/catch block and setting a global variable with the error /
1831 exception. A new async method should be created to retrieve and display
1832 the error message / exception.
1834 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1835 code from constructor to init method adding exceptions as needed.
1837 2011-10-26 Ben Konrath <ben@bagu.org>
1839 Add script to monitor and restart tomcat if required.
1841 * utils/check-and-recover-tomcat.py: New file.
1843 2011-10-26 Ben Konrath <ben@bagu.org>
1845 Display the correct number of data items in the pager.
1849 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1851 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1852 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1853 The implementation is the same for both tables: Keep track of the
1854 number of non-empty rows and fire and RowCountChangeEvent after the data has
1856 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1857 custom Pager class that subclasses SimplePager to handle displaying
1858 the correct number when empty rows have been added.
1860 2011-10-26 Ben Konrath <ben@bagu.org>
1862 Correct error in previous commit.
1864 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1865 eventBus parameter from listView.setCellTable().
1867 2011-10-26 Ben Konrath <ben@bagu.org>
1869 Fix error in TODO comment.
1871 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1873 2011-10-24 Ben Konrath <ben@bagu.org>
1875 Create Notebook widgets to the details view.
1877 This isn't finished just yet - I still need to create a reasonable
1878 style to match the current theme.
1880 * src/main/java/org/glom/web/client/Utils.java: Add method for
1881 calculating the height of a widget. This is used in the Notebook class.
1882 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1883 new constructor method in Group.
1884 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1885 method for creating child widget that can be used by subclasses
1886 like Notebook. New constructor that allows disabling the group
1887 titles - Notebooks don't set a group title for their child groups.
1888 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1889 to make Notebooks using GWT's TabLayoutPanel.
1890 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1891 constructor that allows disabling the group titles.
1892 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1893 LayoutItemNotebook DTO.
1894 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1895 DTO for Notebooks. It's just an empty class for now but we might need
1896 it to transfer some specific information in the future.
1898 2011-10-21 Ben Konrath <ben@bagu.org>
1900 Add navigation buttons to related list tables.
1902 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1903 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1904 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1905 method getSuitableRecordToViewDetails() for getting the table name
1906 and primary key value for related list navigation buttons.
1907 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1908 private cell renderer class to get the navigation information for
1909 related list tables from the server. Extract the navigation
1910 processing code from the details cell navigation and use it for the
1911 related list navigation as well.
1912 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1913 cell renderer class for the details open buttons. This was needed
1914 because the related list navigation buttons and the list view
1915 navigation buttons need to react differently when clicked.
1916 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1917 the onEnterKeyDown() method because it's now overriden in the
1918 subclasses that are specific to the related list tables and the list
1920 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1921 the vertical size a little because the buttons add a bit of vertical
1922 space to table. This is not a perfect solution because the vertical
1923 size of with table fewer than 5 rows will be a little smaller.
1924 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1925 changes in how navigation buttons are handled.
1926 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1927 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1928 database access object.
1929 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1930 to find the portal for a given relationship name from
1931 RelatedListDBAccess. Add method to find a primary key field for a
1933 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1934 Move code to find the portal for a given relationship name to
1936 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1937 New file: database access object for getting the related list
1938 navigation information (the table name and the primary key value).
1939 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1940 DTO for transferring a table name to navigate to and a primary key
1942 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1943 boolean and getter/setter to specifies if the related list should add
1946 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1948 Use the master branch of java-libglom
1950 * pom.xml: Depend on java-libglom 1.19 instead.
1952 This is the master branch. See also the libglom-1-18 branch.
1954 2011-10-11 Ben Konrath <ben@bagu.org>
1956 Enable the open navigation button when the data has been set.
1958 This avoids having active buttons that don't do anything when the data
1961 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1963 2011-10-11 Ben Konrath <ben@bagu.org>
1965 Use IsWidget interface for FlowTableItem.
1967 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1968 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1970 2011-10-11 Ben Konrath <ben@bagu.org>
1972 Remove GWT styling from open button in details view.
1974 There are still some issues with how the details cell is arranged but
1975 this should be made to match Glom 1.20. I'm going to leave fixing this
1976 until I have Glom 1.20 up and running.
1978 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1979 style name on open button.
1980 * src/main/webapp/style.css: Move and edit details-navigation class.
1981 Re-arrange some classes to make them appear in the same order as the
1984 2011-10-07 Ben Konrath <ben@bagu.org>
1986 Update to GWT 2.4.0.
1988 * .gitignore: Ignore new cache directory.
1989 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1990 * pom.xml: Change GWT and maven plugin to 2.4.0.
1991 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1993 * src/main/java/org/glom/web/client/ClientFactory.java:
1994 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1995 * src/main/java/org/glom/web/client/OnlineGlom.java:
1996 Update source for API changes.
1997 * utils/build-onlineglom-war.sh: Remove cache directory before the
2000 2011-10-07 Ben Konrath <ben@bagu.org>
2002 Add navigation buttons in the details view.
2004 This isn't finished but I thought I'd commit what I have as it's a
2005 pretty good start. I still need to:
2007 1. Change the style so that it fits better into the current theme
2008 2. Adjust the details cell to expand as much as possible.
2010 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2011 click handlers to navigation buttons in the DetailsCells. Create a
2012 refreshData() method to get just the data from the server without the
2014 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2015 Update the tableSelector and browser title when the table name
2016 changes without using the tableSelector.
2017 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2018 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2019 getDetailsCells() to getCells(). Update variable names.
2020 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2021 method to set click handler on navigation button. Rename a few
2022 variables. Add navigation buttons where needed.
2023 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2024 variables and methods.
2025 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2026 navigation boolean and navigation table as required in the
2027 LayoutItemField DTO.
2028 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2029 variables for navigation along with getter/setter methods.
2031 2011-10-07 Ben Konrath <ben@bagu.org>
2033 Rename Field to DetailsCell.
2035 This is a refactor-only commit. No functionality has been added or
2038 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2039 Update variable and method names.
2040 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2041 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2042 variable and method names.
2043 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2045 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2046 variable and method names.
2048 2011-10-07 Ben Konrath <ben@bagu.org>
2050 Create separate methods for layout and data the details view.
2052 This is a refactor-only commit. No functionality has been added or
2055 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2056 private methods: setData(), createLayout().
2058 2011-10-07 Ben Konrath <ben@bagu.org>
2060 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2062 This is part of a change to get navigation buttons in the details view
2063 but it should have been done this way from the start.
2065 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2066 for method name change in TableSelectionView.
2067 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2068 Create TableChangeEvent and set the browser title using the
2069 TableSelectionView API.
2070 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2071 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2072 Change getSelectedTable() to getSelectedTableName(). Add
2073 getSelectedTableTitle().
2075 2011-10-07 Ben Konrath <ben@bagu.org>
2077 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2079 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2081 2011-10-07 Ben Konrath <ben@bagu.org>
2083 Update TableChangeEvent to use newTableName naming convention.
2085 This makes the class more consistent with GWT naming conventions.
2087 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2088 Update for method name change in TableChangeEvent.
2089 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2090 for method name change in TableChangeEvent.
2091 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2092 newTableName variable and getter method. Make toDebugString()
2095 2011-09-30 Ben Konrath <ben@bagu.org>
2097 Disable the pager in the list tables when the data row count is less than the minimum.
2099 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2100 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2102 2011-09-30 Ben Konrath <ben@bagu.org>
2104 Add empty rows to the end of related list and list view tables.
2106 I also extracted the cell rendering classes from the ListTable because
2107 the code was becoming a little crazy with all the anonymous inner
2108 classes. My plan is to use these cell rendering classes in the details
2109 view as well so this refactor will be needed for that change.
2111 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2112 set the row count in related list tables if the data has more rows
2113 than the minimum number of rows visible.
2114 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2115 row count in list view tables if the data has more rows than the
2116 minimum number of rows visible.
2117 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2118 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2120 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2121 for rendering TYPE_NUMERIC cells. The code was extracted from the
2123 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2124 class for rendering cells with buttons in list views. The code was
2125 extracted from the ListTable class.
2126 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2127 for rendering TYPE_TEXT cells. The code was extracted from the
2129 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2130 Add empty rows to the end of the data if required. Implement
2131 ListTable.getMinNumVisibleRows().
2132 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2133 cell renderer code to public classes. Return null in
2134 Column.getValue() for empty rows. Add new abstract method:
2135 getMinNumVisibleRows(). Move code to set the row count of the list view
2136 table to ListViewImpl.
2137 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2138 empty rows to the end of the data if required. Implement
2139 ListTable.getMinNumVisibleRows().
2142 2011-09-27 Ben Konrath <ben@bagu.org>
2144 Use GWT.log for client-side debugging statements.
2146 These are optimized out when deployed so I should have used this method
2147 in the first place. These statements will eventually be replaced with some sort
2148 of notification in the browser.
2150 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2151 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2152 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2153 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2154 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2156 2011-09-27 Ben Konrath <ben@bagu.org>
2158 Put tableselector on the right, back to list link on right.
2160 The idea is that the table selector is acting like a label for the
2161 currently displayed table so it should be placed below the document title. This
2162 puts the table title in a similar position to where it is in Glom.
2164 * mockups/details-contacts.html:
2165 * mockups/details-projects.html:
2166 * mockups/listview-contacts.html:
2167 * mockups/listview-projects.html:
2168 * mockups/style.css:
2169 Update mockups to match how the interfaces currently look.
2170 * src/main/webapp/style.css: Swap positions of backlink with the table
2171 selector. Add some space on the left side of the table selector to
2172 line things up with the document title.
2174 2011-09-27 Ben Konrath <ben@bagu.org>
2176 Add field colouring to details view.
2178 This change re-works how field colouring works. The colour formatting
2179 information is now set to the client with the layout information instead of
2180 with the data. This eliminates the need to send the same colour strings for
2181 data in list view column when colour information is set.
2183 In order to set an alternate colour for negative numeric values, the
2184 number is now sent to client and formatted with the GWT NumberFormat class.
2186 This change also fixes:
2188 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2190 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2191 internationalization framework which is needed for client side numeric
2193 * src/main/java/org/glom/web/client/Utils.java: New file for some
2194 client static utility methods.
2195 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2196 the DataItem object to the Field class. Use a utility method to
2197 create the foreignKeyValue string.
2198 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2199 alignment and text colours in the constructor. Add setData(DataItem)
2200 method. Remove setText(String) method.
2201 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2202 colour information to GlomTextCell. Create and use GlomNumberCell for
2203 rendering numbers. Use utility method to get the string for the
2204 primary key of the key provider. Re-work how the horizontal alignment
2206 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2207 formatting to layout information. Methods for converting the libglom
2208 formatting information were moved from DBAccess.
2209 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2210 numeric formatting (it's now done on the client side). Don't set text
2211 colours in DataItem. Move libglom formatting conversion methods to
2213 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2214 getters/setters for text colour information.
2215 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2216 for transferring the libglom NumericFormat information to the client.
2217 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2218 and getters/setters for: GlomNumericFormat, background colour and
2219 foreground colour strings.
2221 2011-09-26 Ben Konrath <ben@bagu.org>
2223 Simplify code that iterates through the LayoutGroup.
2225 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2227 2011-09-26 Ben Konrath <ben@bagu.org>
2229 Accept Eclipse formatting for OnlineGlomServiceAsync.
2231 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2233 2011-09-26 Ben Konrath <ben@bagu.org>
2235 Don't use the ListDBAccess classes to get the primary key layout information.
2237 This was causing a bug where the wrong index for the hidden primary key
2238 was being sent to the client.
2240 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2241 primary key while creating the LayoutGroup DTO. Create a
2242 LayoutItemField DTO for hidden primary keys. Don't use the
2243 RelatedListDBAccess because it was only used for getting the primary
2245 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2246 access modifier from public to protected for getPrimaryKeyField() and
2247 getPrimaryKeyLayoutItemField().
2248 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2249 abstract method getExpectedResultSize() because RelatedListDBAccess
2250 doesn't have enough info to implement it.
2251 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2252 Remove @Override for getExpectedResultSize().
2253 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2254 Remove method getExpectedResultSize().
2256 2011-09-23 Ben Konrath <ben@bagu.org>
2258 Log which layout (list or details) the ignored item is from.
2260 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2262 2011-09-23 Ben Konrath <ben@bagu.org>
2264 Remove annotations that turn off code formatting in DataItem.
2266 * src/main/java/org/glom/web/shared/DataItem.java:
2268 2011-09-23 Ben Konrath <ben@bagu.org>
2270 Rename GlomField to DataItem and update associated methods.
2272 This is a rename-only refactor. No functionality has been added or
2275 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2276 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2277 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2278 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2279 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2280 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2281 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2282 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2283 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2284 * src/main/java/org/glom/web/server/database/DBAccess.java:
2285 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2286 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2287 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2288 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2289 * src/main/java/org/glom/web/shared/DataItem.java:
2290 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2291 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2293 2011-09-23 Ben Konrath <ben@bagu.org>
2295 Rename GlomDocument to DocumentInfo and update associated methods.
2297 This is a rename-only refactor. No functionality has been added or
2300 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2301 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2302 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2303 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2304 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2305 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2306 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2308 2011-09-20 Ben Konrath <ben@bagu.org>
2310 Require java-libglom 1.17.3.
2312 This picks up the fix for the seg fault problem with the Scenes table
2313 in the Openismus Film Manager example.
2317 2011-09-20 Ben Konrath <ben@bagu.org>
2319 Change the way sort clause is added for primary key when no sort clause is requested.
2321 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2322 before the sort clause is created. When a sort clause is not requested, the
2323 sort clause is created by finding the primary key in the LayoutFieldVector
2326 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2328 2011-09-20 Ben Konrath <ben@bagu.org>
2330 Log error message if no documents are found in the configured directory.
2332 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2333 Extract the glom file extension string to a private static final class
2334 variable (mostly as syntactic sugar). Accept a minor formatting change.
2335 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2336 the example glom.document.directory configuration property to make it
2337 more clear that it can any directory, not just the home directory.
2339 2011-09-18 Ben Konrath <ben@bagu.org>
2341 Add related lists to details view.
2343 The related list table has support for paging and sorting just like the
2344 table in the list view.
2346 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2347 SQL queries for the related list tables.
2348 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2349 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2350 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2351 Rename getList methods to getListView and add comments. Remove
2352 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2353 it being unused. Add methods: getDetailsLayoutAndData(),
2354 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2355 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2356 Create the layout and set the data for the fields in one async call
2357 instead of two. Create related lists where appropriate.
2358 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2359 for method name changes in OnlineGlomService.
2360 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2361 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2362 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2364 * src/main/java/org/glom/web/client/ui/ListView.java:
2365 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2366 tableName from setCellTable(). Create a ListViewTable instead of
2368 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2369 represent a data field in the details view.
2370 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2371 from addDetailsCell() to Field class. Keep track of the Fields and
2372 Portals in the details view.
2373 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2374 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2375 and add a method to get it. Add method to set the contents of the
2377 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2378 New class for related list tables. This class has the data provider
2379 for the related list table.
2380 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2381 abstract class which is the base class for the ListViewTable and the
2383 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2384 New class for list view tables. This class has the data provider for
2385 the list view table.
2386 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2387 methods for related list tables. Add more information to the
2388 LayoutItemField and LayoutItemPortal DTOs.
2389 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2390 Remove debugging print statement.
2391 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2392 Remove debugging print statements. Add primary key field to SQL count
2394 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2395 Remove unnecessary LayoutFieldVector parameter from
2396 getResultSizeOfSQLQuery() method.
2397 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2398 New class for related list table database access.
2399 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2400 class that is a wrapper DTO for details view layout and data.
2401 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2402 new 'fromField' string to this DTO.
2403 * src/main/webapp/style.css: Remove bottom margin and override top
2406 2011-09-15 Ben Konrath <ben@bagu.org>
2408 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2410 This sets things up to make it easier to add the data retrieval for
2411 related lists (portals). No user noticeable changes were made with
2414 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2415 class has the code to retrieve the layouts and access the
2416 database using the new database helper classes.
2417 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2418 Most of the functionality has been removed from this class. This
2419 class now represents the public interface for the client side
2420 code. It also deals with configuring the servlet and cleaning
2421 things up when the servlet is stopped.
2422 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2423 of static methods into this utility class.
2424 * src/main/java/org/glom/web/server/database/DBAccess.java:
2425 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2426 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2427 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2428 These classes have the database retrieval code. The class hierarchy
2429 has been setup to make it easy to reuse code for similar
2432 2011-09-06 Ben Konrath <ben@bagu.org>
2434 Create separate classes for list table code and the data provider.
2436 As part of this refactor, I also split up the code a bit to make it
2439 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2440 table code to two new classes (below).
2441 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2442 with code from ListViewImpl.
2443 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2444 New file with code from ListViewImpl.
2446 2011-09-06 Ben Konrath <ben@bagu.org>
2448 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2450 This fixes the LayoutItemPortal DTO to match the libglom layout object
2453 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2455 2011-09-01 Ben Konrath <ben@bagu.org>
2457 Set title of Portals in the Details View.
2459 * pom.xml: Bump required version of java-libglom to 1.17.1.
2460 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2461 widget creation to its own class. Add comments to constructor.
2462 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2463 The code is mostly from the Group class with the title now set.
2464 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2465 title of Portal. Update some comments. Fix some code formatting.
2467 2011-09-01 Ben Konrath <ben@bagu.org>
2469 Remove TODO comment for the flow table column width.
2471 The flow table column width is working correctly and doesn't need to be
2472 changed. See this mailing list post for more info:
2474 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2476 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2478 2011-08-27 Ben Konrath <ben@bagu.org>
2480 Add document title (database name) to top of the browser page.
2482 I added the document title to the TableSelecitonView but that will
2483 change if / when we add a view that doesn't require table selection.
2485 * mockups/details-contacts.html:
2486 * mockups/details-projects.html:
2487 * mockups/listview-contacts.html:
2488 * mockups/listview-projects.html:
2489 * mockups/style.css: Add document title to mockups to keep things
2491 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2492 sizes to account for the document title.
2493 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2494 Set the document title when it has been retrieved from the server.
2495 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2496 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2497 and implement setDocumentTitle(String) method.
2498 * src/main/webapp/style.css: Add ID for document title style.
2500 2011-08-25 Ben Konrath <ben@bagu.org>
2502 Add NavigationType enum to LayoutItemPortal DTO.
2504 This is the start of adding support for Portals to the Details View.
2506 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2507 LayoutItem_Portal.navigation_type enum from libglom to
2508 LayoutItemPortal.NavigationType enum.
2509 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2510 NavigationType enum, field for storing the NavigationType and getter
2513 2011-08-25 Ben Konrath <ben@bagu.org>
2515 Implement the flow table layout in the Details View.
2517 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2518 FlowTable to Group to account for the renamed class.
2519 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2520 File. This is a container widget that implements the Glom details view
2521 flow table behaviour.
2522 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2523 org/glom/web/client/ui/FlowTable.java.
2524 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2525 so that the size of the subgroups are a closer match to the size of
2526 the Glom subgroups. This makes the flowtable layout match the layout
2527 in Glom for the Music Collection example file.
2529 2011-08-16 Ben Konrath <ben@bagu.org>
2531 Create container element for LayoutItemPortal in Details View.
2533 This will help me develop the layout for the FlowTable.
2535 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2536 fieldPanel variable to detailsCell.
2538 2011-08-15 Ben Konrath <ben@bagu.org>
2540 Set the height of the data element in the Details View.
2542 I changed the InlineLabels (text in a span element) to Labels (text in
2543 a div element) so that I could set the height of the details-data
2544 elements instead of the details-cell parent elements. This allows the
2545 the details-data element to display the correct height if style is
2546 applied that shows the height.
2548 This change has the added benefit of allowing the order of the labels
2549 and data elements to be changed for right-to-left languages.
2551 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2552 InlineLabels to Labels.
2553 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2554 InlineLabels to Labels. Set the height of the data element.
2555 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2556 multiline text height in the Formatting DTO.
2557 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2558 for multiline height along with getter and setter methods.
2559 * src/main/webapp/style.css: Adjust style to account for the change
2560 from span elements to div elements in the details cell.
2562 2011-08-15 Ben Konrath <ben@bagu.org>
2564 Make the List View appearance match the mockups.
2566 It doesn't match exactly but it's much better than it was.
2568 * mockups/listview-contacts.html: Remove unused css classes.
2569 * mockups/listview-projects.html: Remove unused css classes.
2570 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2571 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2572 for mainPanel instead of VerticalPanel (table). Set style name on
2573 CellTable. Set style name on Details column. Right-align Details
2575 * src/main/webapp/style.css: Adjust properties to match the mockups.
2577 2011-08-12 Ben Konrath <ben@bagu.org>
2579 Add better support for subgroups in the details view.
2581 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2582 changed FlowTable constructor.
2583 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2584 support for subgroups and subgroup-titles.
2585 * src/main/webapp/style.css: Add CSS class for subgroups and
2588 2011-08-12 Ben Konrath <ben@bagu.org>
2590 Return the top level LayoutGroup title.
2592 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2594 2011-08-11 Ben Konrath <ben@bagu.org>
2596 Make the TableSelector header match the mockup.
2598 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2599 the layout panel. Properly lineup the table selection header with
2600 the list and details view.
2601 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2602 margin around the details view.
2603 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2604 Rename listBox variable to tableSelector. Set id for the style sheet.
2605 Use a FlowPanel instead of a HorizontalPanel.
2606 * src/main/webapp/style.css: Add properties to make the TableSelector
2607 box match the mockups.
2609 2011-07-13 Ben Konrath <ben@bagu.org>
2611 Update install script for java-libglom version change.
2613 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2616 2011-07-13 Ben Konrath <ben@bagu.org>
2618 Add support sub-group in the details view.
2620 I also removed the code that special-cased the default details view
2623 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2625 I still have to make a proper flowtable.
2627 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2628 Don't special-case default details view layout.
2629 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2630 addLayoutField() as I'm going to use it.
2631 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2632 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2634 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2635 extracted from DetailsViewImpl.GroupPanel. Add support for
2637 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2638 column count when getting the details layout.
2640 2011-07-12 Ben Konrath <ben@bagu.org>
2642 Set browser title with database and table titles.
2644 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2645 Set the browser title when the table changes and when the activity
2647 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2648 title when retrieving document info (the GlomDocument object).
2649 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2650 with getter and setter methods. Remove unused convenience constructor.
2651 Use default code formatting.
2653 2011-07-12 Ben Konrath <ben@bagu.org>
2655 Ignore LayoutItemPortals in the details view.
2657 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2660 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2661 LayoutItemPortal layout objects.
2662 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2663 LayoutItemPortal objects when retrieving the details layout.
2664 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2665 file. This is an empty class and just used to get type information for
2668 2011-07-12 Ben Konrath <ben@bagu.org>
2670 Use java-libglom 1.17.0.
2674 2011-07-11 Ben Konrath <ben@bagu.org>
2676 Remove "Table:" label from table selector.
2678 This matches a recent change in the Glom UI.
2680 * mockups/details-contacts.html:
2681 * mockups/details-projects.html:
2682 * mockups/listview-contacts.html:
2683 * mockups/listview-projects.html: Remove the "Table:" label from the
2685 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2687 2011-07-11 Ben Konrath <ben@bagu.org>
2689 Add main groups to the details view.
2691 This makes things look a little nicer in the details view. The next step
2692 is to implement the flowtable.
2694 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2695 resources from the standard gwt css theme. Standard.css is now
2696 included in OnlineGlom.html so that the online glom css rules have
2697 precedence over the gwt theme.
2698 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2699 the whole LayoutGroup to the DetailsView instead of just the titles.
2700 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2701 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2702 details layout with a helper class (GroupPanel). I might extract this
2703 class when I make the full flowtable.
2704 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2705 string as default so I don't have to worry about NPEs when processing
2707 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2708 note beside OnlineGlom.gwt.xml above).
2709 * src/main/webapp/style.css: Add default font-size to body to override
2710 the font-size set by the standard theme. Don't use h2 tags for
2711 group-title. Create new details-cell class.
2713 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2715 ConfiguredDocument: Set the port number too.
2717 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2718 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2719 Glom document. Presumably this worked sometimes so far because there is a
2720 default port number.
2722 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2724 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2726 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2727 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2728 correct, though we should throw an exception too.
2730 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2732 Fix a addDocuemnt typo.
2734 * src/main/java/org/glom/web/shared/Documents.java
2735 (Documents.addDocuemnt): Rename to addDocument().
2736 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2737 (OnlineGlomServiceImpl.getDocuments): Adapt.
2739 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2741 Slightly improved log output when connection fails.
2743 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2744 (ConfiguredDocument.setUsernameAndPassword):
2745 We don't know for sure if it' the username/password that's wrong, so
2746 rephrase the message.
2747 Also ouput the exception message, though it's generic in this case.
2749 2011-07-08 Ben Konrath <ben@bagu.org>
2753 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2754 added braces to a one line if statement because the Eclipse formatter
2755 was getting confused.
2757 2011-07-07 Ben Konrath <ben@bagu.org>
2759 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2761 These should really be two separate tasks but I counldn't get things to
2762 work with GWT 2.2.0 and Eclipse 3.7.
2766 * .settings/org.eclipse.jdt.core.prefs:
2767 * .settings/org.eclipse.jdt.ui.prefs:
2768 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2769 * .settings/org.eclipse.m2e.core.prefs:
2770 Add new config files. Update current files. Remove references to the
2771 webtools plugins as we're not using any of the webtools features.
2772 * .gitignore: Add logs directory which is created when running with
2774 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2775 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2776 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2778 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2780 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2782 onlineglom.properties: Add explanatory comments.
2784 * src/main/resources/onlineglom.properties: Also change the default user
2785 from ben to someuser, to avoid the risk of people thinking we just
2786 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2788 2011-06-28 Ben Konrath <ben@bagu.org>
2790 Use filename in Log for incorrect passwords.
2792 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2793 getFileName(String) method to get the filename from the URI.
2795 2011-06-28 Ben Konrath <ben@bagu.org>
2797 Add the table name to the URL token for the ListPlace.
2799 This makes things consistent between the DetailsPlace and the
2800 ListPlace. It also allows the the ListPlace to be bookmarked.
2802 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2803 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2804 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2805 Remove getDefaultListLayout(). The default layout is now returned
2806 by the getListLayout() method when the table name is an empty string.
2807 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2808 Add table name field. Change to a new ListPlace when the table
2809 has been changed. Use getListLayout() for getting the default
2811 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2812 Add table name field. Set the correct table name in the list box
2813 when loading from bookmark. This corrects a problem for the
2815 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2816 Move table name to super-class (HasSelectableTable). Move document
2817 and table URL keys to super-class in HasSelectableTable.
2818 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2819 Add table name field. Add Tokenizer class with URL key common to
2820 the subclasses (DetailsPlace and ListPlace).
2821 * src/main/java/org/glom/web/client/place/ListPlace.java:
2822 Add table name. Add code to parse the URL token.
2823 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2824 Update ListPlace construction with empty table name string.
2825 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2826 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2827 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2828 Update ListPlace construction with table name string.
2829 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2830 Change defaultTableName field to tableName to reflect how it's now
2831 used. Update the getter and setter methods.
2833 2011-06-28 Ben Konrath <ben@bagu.org>
2835 Enable the table selector in the DetailsView.
2837 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2838 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2839 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2840 Remove getDefaultDetailsLayout(). The default layout is now returned
2841 by the getDetailsLayout() method when the table name is an empty
2843 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2844 event handler for table change event. Change to using
2845 getDetailsLayout() for the default details layout.
2846 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2848 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2849 when navigating to the details place.
2851 2011-06-27 Ben Konrath <ben@bagu.org>
2853 Use filename based unique document ID in URL and for RPC.
2855 The document ID is the glom document name with spaces (' ') replaced
2856 with pluses ('+') and without the .glom extension.
2858 This change is mostly a string substitution of 'documentTitle' for
2859 'documentID'. The only code change is the addition of a Documents DTO to get the