1 2012-07-20 Murray Cumming <murrayc@murrayc.com>
5 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
6 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
7 Avoid using a null Connection.
9 2012-07-20 Murray Cumming <murrayc@murrayc.com>
11 tests: Add a ConfiguredDocument test.
13 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
16 2012-07-20 Murray Cumming <murrayc@murrayc.com>
18 LayoutItemFIeld: getName(): Use the Field if it is set.
20 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
21 getName(): If the full field details have been set, return its name, so that
22 callers do not need to set the name separately.
23 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
24 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
25 so we can count the rows.
27 2012-07-20 Murray Cumming <murrayc@murrayc.com>
29 tests: SelfHoster: Test SqlUtils too.
31 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
32 Retrieve some data and check it too, as in the regular Glom
33 test_selfhosting_new_from_example.cc test.
34 * src/test/java/org/glom/web/server/SelfHoster.java:
35 createConnection(): Make this public.
37 2012-07-20 Murray Cumming <murrayc@murrayc.com>
39 tests: SelfHoster: createConnection(): Do not warn about expected failures.
41 Let the caller say if the connection is expected to fail, to avoid
42 irrelevant error output.
44 2012-07-20 Murray Cumming <murrayc@murrayc.com>
46 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
48 * src/test/java/org/glom/web/server/SelfHoster.java:
49 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
50 due to the inevitable need to retry the connection while the database server
53 2012-07-20 Murray Cumming <murrayc@murray.com>
55 tests: SelfHoster: createConnection(): Set a timeout.
57 * src/test/java/org/glom/web/server/SelfHoster.java:
58 createConnection(): Use setLoginTimeout() because it otherwise seems to take
59 ages to actually return when it fails.
61 2012-07-20 Murray Cumming <murrayc@murrayc.com>
63 tests: SelfHoster: selfHost(): Close the test connection.
65 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
66 When we check that the connection works, close the connection. This seems
67 to not be closed automatically otherwise.
69 2012-07-20 Murray Cumming <murrayc@murrayc.com>
71 Use slf4j-simple to see JDBC errors.
73 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
75 2012-07-19 Murray Cumming <murrayc@murrayc.com>
77 SelfHoster.discoverFirstFreePort(): Close the socket.
79 * src/test/java/org/glom/web/server/SelfHoster.java:
80 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
82 2012-07-19 Murray Cumming <murrayc@murrayc.com>
84 Avoid another code warning in Eclipse Juno.
86 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
87 Do instanceof checks on the FileUtils.listFiles() result and its
90 2012-07-13 Murray Cumming <murrayc@murrayc.com>
92 Avoid some code warnings in Eclipse Juno
94 * src/main/java/org/glom/web/server/libglom/Document.java:
95 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
96 * src/test/java/org/glom/web/server/SelfHoster.java
97 createTextFile(): Make sure that the FileOutputStream is closed.
99 2012-06-22 Murray Cumming <murrayc@murrayc.com>
101 Added OnlineGlomPropertiesTest.
103 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
104 Make sure we never return a null string.
105 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
106 Added tests of the OnlineGlomProperties API, using our sample file.
108 2012-06-20 Murray Cumming <murrayc@murrayc.com>
110 Make OnlineGlomProperties be a normal class.
112 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
113 Move OnlineGlomProperties into its own file to be a regular class:
114 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
115 This makes testing simpler.
117 2012-06-15 Murray Cumming <murrayc@murrayc.com>
119 OnlineGlomServiceImpl.init(): Move some code into a new method.
121 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
122 Create addDocument().
124 2012-06-15 Murray Cumming <murrayc@murrayc.com>
126 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
128 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
129 OnlineGlomProperties.getKey(): Make this more robust by moving the
130 check for *.*.filename to here.
132 2012-06-15 Murray Cumming <murrayc@murrayc.com>
134 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
136 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
137 init(): Move knowledge of the config file format into the
138 OnlineGlomProperties inner class.
140 2012-06-15 Murray Cumming <murrayc@murrayc.com>
142 SelfHostExampleTest: Make sure we cleanup on failure.
144 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
145 the use of cleanup() to a tearDown() JUnit method.
147 2012-06-12 Murray Cumming <murrayc@murrayc.com>
149 ConfiguredDocument: Add a primary key to portals at least once.
151 * src/main/java/org/glom/web/server/ConfiguredDocument.java
152 updatePortalsExtras): Fix a typo so that we add the primary key
153 column at least once.
154 This is a fix for the previous commit:
155 ConfiguredDocument: Do not add a primary key to portals each time.
157 2012-06-08 Murray Cumming <murrayc@murrayc.com>
159 SelfHoster: Avoid some compiler warnings.
161 * src/test/java/org/glom/web/server/SelfHoster.java
162 executeCommandLineAndWait():
163 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
164 the now-unused streams for stdout and stderr from the command Processes.
165 These are not used because readln() hangs while waiting for a new line,
166 where there may be no next line. The commented out code is still there
167 to help us figure out how to do this properly.
169 2012-06-08 Murray Cumming <murrayc@murrayc.com>
171 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
173 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
174 Make this actually test the cloning again, though it is not very useful
175 now that we do not use the part that had a problem with cloning before.
177 2012-06-08 Murray Cumming <murrayc@murrayc.com>
179 SelfHoster: Keep trying pg_ctl after starting postgres.
181 * src/test/java/org/glom/web/server/SelfHoster.java
182 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
183 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
184 regular Glom. This seems mad but it seems to work because the first
185 command would fail if pg_ctl would eventually fail.
187 2012-06-08 Murray Cumming <murrayc@murrayc.com>
189 SelfHoster: Wait until the server is really ready.
191 * src/test/java/org/glom/web/server/SelfHoster.java
192 selfHost(): Attempt the connection after starting the server, retrying
193 a few times if necessary, so that the server is really ready already when
194 we return from this method.
195 The regular Glom code does this too because pg_ctl reports success too soon.
197 2012-06-08 Murray Cumming <murrayc@murrayc.com>
199 ConfiguredDocument: Do not add a primary key to portals each time.
201 * src/main/java/org/glom/web/server/ConfiguredDocument.java
202 updatePortalsExtras(): Only add an extra primary key field if there is
203 none, to avoid adding one each time we retrieve the details layout from the
205 This should fix bug #676986 (Ben Konrath)
207 2012-05-25 Murray Cumming <murrayc@murrayc.com>
209 Document.load(): Support version 7 documents.
211 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
212 database_title attribute if the title attribute is not there.
215 2012-05-24 Ben Konrath <ben@bagu.org>
217 Add configuration for auto-generating mvn:i18n from with Eclipse.
219 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
221 2012-05-24 Murray Cumming <murrayc@murrayc.com>
223 Update translations, adding French.
225 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
226 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
227 Add a French translation, using the translation from Glom.
229 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
230 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
231 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
232 Update these based on the translations from Glom.
234 2012-05-24 Murray Cumming <murrayc@murrayc.com>
236 SelfHoster: Add some debug println messages to help when things fail.
238 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
239 System.out.println() lines.
241 2012-05-23 Murray Cumming <murrayc@murrayc.com>
243 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
245 * src/test/java/org/glom/web/server/SelfHoster.java:
246 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
247 instance) instead of just /usr/bin (as on Fedora). Check the result when
250 2012-05-23 Murray Cumming <murrayc@murrayc.com>
252 Remove LayoutItemPortal.get/setNavigationTable().
254 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
255 Remove get/setNavigationTable(), which is only a cache, because it is not
256 used, and does not need to be used, because that decision should be made on
258 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
259 updatePortalsExtras():
260 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
261 getNavigationRecord():
262 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
265 2012-05-21 Murray Cumming <murrayc@murrayc.com>
267 Initial self-hosting for tests.
269 * pom.xml: Change the scope for log4j, to hopefully make it
270 available to the test code which uses it indirectly via jOOQ.
271 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
272 self-hosting, though we only use it for testing.
274 * src/main/java/org/glom/web/server/libglom/Document.java:
275 example rows: Use a map instead of a list for each row of values,
276 so we know what field they are for, instead of relying on the sequence
277 being correct. This is not very efficient, but it does not really need
279 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
280 testReadTableExampleRows(): Adapted.
282 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
283 that returns an Object, for generic use. Note that Object seems to be
284 the implicit base even of double.
285 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
286 for use in CREATE TABLE SQL queries.
287 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
288 to do self-hosting of PostgreSQL databases via its command-line
289 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
290 backends/postgres_self.cc. This is incomplete - it needs more
291 warnings about failures and it needs to clean up properly when things
293 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
294 test of this new class.
296 2012-05-21 Murray Cumming <murrayc@murrayc.com>
298 Document: loading example data: Handle exceptions.
300 * src/main/java/org/glom/web/server/libglom/Document.java:
301 DateFormat.parse() and Double.valueOf() can throw exceptions, though
302 Eclipse did not warn about that.
304 2012-05-20 Murray Cumming <murrayc@murrayc.com>
306 Document: load(), save(): Handle the example rows.
308 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
310 * src/main/java/org/glom/web/server/libglom/Document.java:
311 load(), save(): Load and save the example rows, though the date, time
312 and image types are not handled properly yet.
313 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
314 Add testReadTableExampleRows() just to check that something is read.
316 2012-05-20 Murray Cumming <murrayc@murrayc.com>
318 Document: Add save().
320 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
321 Added getTranslationsMap() for use while saving.
322 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
323 Adedd getUseDefaultFormatting() for use while saving.
324 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
325 and several private methods that it uses.
327 This will be useful while testing via self-hosting.
328 It is not complete, but should be complete enough for testing.
330 2012-05-17 Murray Cumming <murrayc@murrayc.com>
332 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
334 * src/main/java/org/glom/web/client/OnlineGlomService.java
335 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
336 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
337 Remove getSortedListViewData() and getSortedRelatedListData(), adding
338 the sort column index and ascending bool to the regular method.
339 Instead, a sort column index of -1 now means no sort.
340 This is less explicit, but it's fairly simple, reduces the amount of
341 code, and makes the OnlineGlomService API slightly smaller.
342 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
343 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
345 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
346 getListViewData(), getRelatedListData():
347 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
348 getListViewData(), getRelatedListData():
349 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
351 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
353 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
358 2012-05-16 Murray Cumming <murrayc@murrayc.com>
360 Use translations for top-level groups too.
362 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
363 updateTitlesForLocale(): Use the translation for the group
364 as well as for child items.
368 Just recompiled to fix a problem in the released .tar.gz file.
372 2012-05-15 Murray Cumming <murrayc@murrayc.com>
374 Corrections to navigation to related records.
376 * src/main/java/org/glom/web/client/OnlineGlomService.java:
377 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
378 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
379 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
380 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
381 relationship name, because the relationship name is not necessarily unique
383 TOOD: This is inefficient, because it passes the whole list of
384 child field items back to the server, but it is more correct, and happens
385 to fix a bug with the primary key being lost after a few navigations.
386 There is probably a chance to make this more efficient anyway in some
389 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
390 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
391 * src/main/java/org/glom/web/server/ConfiguredDocument.java
392 * src/main/java/org/glom/web/server/database/DBAccess.java
393 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
394 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
397 2012-05-15 Murray Cumming <murrayc@murrayc.com>
399 Fix the use of translations.
401 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
402 Add updateTitlesForLocale().
403 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
404 Call it to discard unwanted translations and to make getTitle() return
405 the wanted translation wihout the need for the client code to specify a locale.
406 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
407 getTitle(): Fallback to the original title, as libglom does.
409 2012-05-15 Murray Cumming <murrayc@murrayc.com>
411 Document: Correctly report the number of available translation locales.
413 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
414 the available locale IDs list.
415 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
416 testLocales: Test this.
418 2012-05-15 Murray Cumming <murrayc@murrayc.com>
420 SqlUtils: Use camelCase.
422 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
423 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
424 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
425 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
426 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
427 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
429 2012-05-15 Murray Cumming <murrayc@murrayc.com>
431 Use jOOQ's tableByName() and fieldByName.
433 * pom.xml: Use jOOQ 2.3.1 to get the new API.
434 * src/main/java/org/glom/web/server/SqlUtils.java:
435 build_sql_select_step_with_where_clause(), .createField(),
436 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
437 so we can get correct quoting and escaping. Thanks to Lukas Eder for
438 adding this, and other things, to jOOQ.
440 2012-05-15 Murray Cumming <murrayc@murrayc.com>
442 SqlUtils: Remove the Connection parameters.
444 * src/main/java/org/glom/web/server/SqlUtils.java:
445 build_sql_select_with_key(), build_sql_select_with_where_clause(),
446 createSelect(), build_sql_select_step_with_where_clause(),
447 build_sql_count_select_with_where_clause(),
448 build_sql_select_count_rows(): Remove the Connection parameter because
449 jOOQ does not actually need a connectionwhen it is just used to build
451 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
453 * src/main/java/org/glom/web/server/ReportGenerator.java:
455 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
457 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
458 Constructor, getListData(), getResultSizeOfSQLQuery():
459 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
460 getSelectQuery(), getCountQuery():
461 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
462 getSelectQuery(), getCountQuery():
463 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
464 getNavigationRecord(): Adapted.
466 2012-05-14 Murray Cumming <murrayc@murrayc.com>
470 * src/main/java/org/glom/web/server/SqlUtils.java:
471 get_find_where_clause_quick(): Use a comparison of
472 lowercase values, instead of a simple equals. Regular Glom
473 uses the PostgreSQL ILIKE operator but jOOQ does not
474 support that just yet, though it will soon.
476 2012-05-14 Murray Cumming <murrayc@murrayc.com>
478 TableToViewDetails: Use a real serialization ID.
480 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
481 Though this does not fix the serialization problem.
483 2012-05-12 Murray Cumming <murrayc@murrayc.com>
485 Added LayoutItemPortalDeepCloneTest.
487 2012-05-11 Murray Cumming <murrayc@murrayc.com>
489 Make navigation work again.
491 * src/main/java/org/glom/web/server/libglom/Document.java:
492 Add getLayoutItemFieldShouldHaveNavigation().
493 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
494 Replace get/setAddNavigation() with the partly-existing
495 get/setNavigationTableName(), with an empty string being no navigation,
496 because this is simpler. Use the new
497 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
499 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
500 Add updateFieldsExtras() and call setNavigationTableName in it.
501 getDetailsLayoutGroup(),
502 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
503 createLayout(): Adapted.
504 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
505 Constructor: Adapted.
507 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
508 Replace get/setAddNavigation() with get/setNavigation(), returning a
509 TableToViewDetails class with both the table name and UsesRelationship,
510 because both are need. The previous code used java-libglom's output
511 variable (strangely, via sharedptr) to return both, but we cannot really
513 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
514 getNavigationRecord(): Adapt. However, we cannot actually use the cache
515 here because it somehow gets set to null during deepCopy(). I must test this.
516 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
517 testGetSuitableTableToViewDetails(): Adapted.
519 TODO: Find out why deepClone() is not quite working.
521 2012-05-11 Murray Cumming <murrayc@murrayc.com>
523 DBAccess: Simplify the retrievel of full field details.
525 * src/main/java/org/glom/web/server/database/DBAccess.java
526 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
527 because the Document loading should have done this.
529 2012-05-11 Murray Cumming <murrayc@murrayc.com>
531 Document: Correct loading of doubly-related layout fields.
533 * src/main/java/org/glom/web/server/libglom/Document.java:
534 loadUsesRelationship(): Actually set the related relationship, instead
535 of only setting it if it's not found.
537 2012-05-09 Murray Cumming <murrayc@murrayc.com>
539 Replace all appearances of Colour with color.
541 Because US English is dominant.
543 2012-05-09 Murray Cumming <murrayc@murrayc.com>
545 Use colors in HTML format, solving a warning about an unused function.
547 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
548 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
549 Add *asHTMLColor() versions of methods.
550 TODO: However, we should create and cache the results on the server.
551 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
552 * src/main/java/org/glom/web/client/ui/list/ListTable.java
553 * src/main/java/org/glom/web/server/ConfiguredDocument.java
554 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
555 Use the asHTMLcolor() versions.
557 2012-05-09 Murray Cumming <murrayc@murrayc.com>
559 ListViewTable: Constructor: Take the table name as a parameter.
561 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
562 Constructor: Take the tableName, and set the member variable, because
564 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
565 setCellTable(): Pass the table name.
566 This makes navigation to non-default tables work again. I don't know
567 why it worked before in the master branch.
569 2012-05-07 Murray Cumming <murrayc@murrayc.com>
571 ConfiguredDocument: Restore correct addition of hidden primary key items.
573 * src/main/java/org/glom/web/client/ui/list/ListTable.java
574 (ListTable.createCellTable): Uncomment out the check for the hidden
576 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
577 add primary key items for top-level lists and portals, as before,
578 instead of adding them to each group.
579 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
580 Actually implement the extra methods such as setHiddenPrimaryKey() and
581 comment that these are used only for top-level list groups and in portals.
582 This strangeness suggests even more that this should not be squeezed
583 into the LayoutGroup class.
585 2012-05-07 Murray Cumming <murrayc@murrayc.com>
587 Fix Formatting loading.
589 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
590 getFormattingUsed(): Remove the duplicate Formatting member variable
591 in favour of the one from the base class.
592 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
593 Initialize a new Formatting instead of using null by default, so we
594 have some defaults, instead of having to initialize one later just to
595 get the same defaults. This also makes loading of formatting from the
596 document work, because that expected a non-null.
598 2012-05-07 Murray Cumming <murrayc@murrayc.com>
600 RelatedListTable: Make sure that the tableName is set.
602 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
603 Constructor: Take the tableName so it is available later. Otherwise,
604 the server assumes that we mean the default table and cannot find the
606 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
607 setData(): Pass the tableName to the RelatedListTable constructor.
609 2012-05-07 Murray Cumming <murrayc@murrayc.com>
613 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
614 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
615 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
617 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
619 * src/main/java/org/glom/web/server/database/DBAccess.java:
620 convertResultSetToDTO(), getPortal():
621 * src/main/java/org/glom/web/server/database/ListDBAccess.java
623 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
624 Add checks for null objects and out of range access, with log messages to
625 give hints so we can fix these properly.
627 2012-05-07 Murray Cumming <murrayc@murrayc.com>
629 Portals: some corrections.
631 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
633 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
634 constructor: Use getRelationshipNameUsed() instead of getName(), because
635 that is what is meant.
636 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
637 getFromField(): Fix a typo, to get the field name, not the table name.
638 * src/main/java/org/glom/web/server/database/DBAccess.java:
639 getPortal(): Fix a typo that stopped this from working.
641 2012-05-07 Murray Cumming <murrayc@murrayc.com>
643 LayoutItemPortal: Also override getTitleOriginal().
645 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
646 This lets the base getTitle() with no parameters work.
647 TODO: Test this properly.
649 2012-05-06 Murray Cumming <murrayc@murrayc.com>
651 LayoutItemPortal: getTitle*(): Use the relationship title.
653 2012-05-06 Murray Cumming <murrayc@murrayc.com>
655 LayoutItemField: Fix loading of custom titles.
657 * src/main/java/org/glom/web/server/libglom/Document.java
658 loadDataLayoutItemField(): The title, if any, instead of the field
659 title, is stored in a title_custom node. Load it from there.
660 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
662 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
663 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
664 getTitle*() overrides.
665 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
668 2012-05-06 Murray Cumming <murrayc@murrayc.com>
670 LayoutItemField: Fall back to field titles, so some are really shown.
672 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
673 Override getTitleOriginal() and getTitle(), as in java-libglom.
674 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
677 2012-05-06 Murray Cumming <murrayc@murrayc.com>
679 Correct use of setExpectedResultSize().
681 * src/main/java/org/glom/web/server/ConfiguredDocument.java
682 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
683 Use setExpectedResultSize only on top-level groups (for instance, the
684 list layout) or on child portals (in details views).
685 Use the correct table name for portals to avoid SQL errors.
686 Update the expected counts when returning cached layouts.
688 2012-05-06 Murray Cumming <murrayc@murrayc.com>
690 Document: Interpret no group column count as 1.
692 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
693 default, though we now check for this in the UI code anyway.
695 2012-05-06 Murray Cumming <murrayc@murrayc.com>
699 2012-05-06 Murray Cumming <murrayc@murrayc.com>
701 Translatable: Use Hashmap instead of Treemap because GWT supports it.
703 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
704 The use of Treemap lead to this error from async methods, with no
706 "The response could not be deserialized"
708 2012-05-06 Murray Cumming <murrayc@murrayc.com>
710 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
712 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
713 when using the Google -> GWT Compile, or
714 g toolbar button -> GWT Compile Project... feature in Eclipse.
716 2012-05-06 Murray Cumming <murrayc@murrayc.com>
718 ListTable.addColumn(): Protect against a null Formatting.
720 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
721 Create a default Formatting if it is null, because that is the simplest
724 2012-05-06 Murray Cumming <murrayc@murrayc.com>
726 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
728 * src/main/java/org/glom/web/server/ConfiguredDocument.java
729 updateLayoutGroup(): Check that the field is not null.
731 2012-05-06 Murray Cumming <murrayc@murrayc.com>
733 ListViewImpl: Protected against a bad cast error.
735 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
736 onEnterKeyDown(): Do not cast without an instanceof check.
738 2012-05-06 Murray Cumming <murrayc@murrayc.com>
740 ListTable: Protect against an out of range error.
742 * src/main/java/org/glom/web/client/ui/list/ListTable.java
743 createCellTable(): This is unlikely, but can happen while debugging.
745 2012-05-06 Murray Cumming <murrayc@murrayc.com>
747 AsyncMessage onFailure() callbacks: Log the exception message.
749 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
750 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
751 * src/main/java/org/glom/web/client/activity/ListActivity.java:
752 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
753 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
754 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
755 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
756 These are useful clues when something is wrong.
758 2012-05-06 Murray Cumming <murrayc@murrayc.com>
760 ConfiguredDocument: Avoid a null dereference.
762 * src/main/java/org/glom/web/server/ConfiguredDocument.java
763 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
764 details maps are created.
766 2012-05-06 Murray Cumming <murrayc@murrayc.com>
768 Document: Correct the port number parsing.
770 * src/main/java/org/glom/web/server/libglom/Document.java:
771 This lets us actually connect to the database and show the document.
773 2012-05-05 Murray Cumming <murrayc@murrayc.com>
777 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
778 user-interaction, asking us to load a temporary URL in a browser.s
779 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
780 which is apparently necessary for testing the service. See the comment.
781 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
782 Show the exception, if any. This is how I saw the 404 in the HTML in
785 2012-05-05 Murray Cumming <murrayc@murrayc.com>
787 DocumentTest: Move the .glom files into the resources directory.
789 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
790 URI via getResource().
792 2012-05-05 Murray Cumming <murrayc@murrayc.com>
794 Document: Remove the FieldIdentifies inner class.
796 * src/main/java/org/glom/web/server/libglom/Document.java: We only
797 use the Relationship (though the same function in libglom is maybe
798 used in other ways) and so this removes a compiler warning.
800 2012-05-05 Murray Cumming <murrayc@murrayc.com>
802 Document.load() Remove the error code parameter.
804 * src/main/java/org/glom/web/server/libglom/Document.java: load():
805 Remove the parameter. We do not set it yet and it could never have
806 worked as an output parameter (though maybe it did in java-libglom).
807 We could use an exception if we really want the failure reason.
808 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
810 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
811 setUp(), testGetSuitableTableToViewDetails(): Adapt.
813 2012-05-05 Murray Cumming <murrayc@murrayc.com>
815 Make some inner classes static.
817 * src/main/java/org/glom/web/server/ConfiguredDocument.java
818 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
819 * src/main/java/org/glom/web/server/ReportGenerator.java
820 * src/main/java/org/glom/web/server/libglom/Document.java
821 Make all inner classes static that can be static.
823 2012-05-05 Murray Cumming <murrayc@murrayc.com>
825 OnlineGlomServiceImpl: Do not load and check for java-libglom.
827 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
828 init(): We do not use java-libglom any more.
830 2012-05-05 Murray Cumming <murrayc@murrayc.com>
832 Remove mentions of java-libglom.
834 * README: Remove mention of java-libglom, because it no longer needed.
835 * utils/build-onlineglom-war.sh:
836 * utils/check-and-recover-tomcat.py:
837 * utils/install-onlineglom-war.sh: Remove these as they are no longer
838 useful. Building is now far easier, with no need for jhbuild.
840 2012-05-05 Murray Cumming <murrayc@murrayc.com>
842 Fix the build (mvn package)
844 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
845 (LayoutGroup): Make the LayoutItemList inner class static and protected.
846 Otherwise the GWT Java->Javascript compilation fails with just this
847 error, during mvn package or when attempting to view in a browser,
848 in the GWT developer mode in Eclipse.
850 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
851 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
852 [INFO] Compiling module org.glom.web.OnlineGlom
853 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
854 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
855 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
856 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
857 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
858 [INFO] [ERROR] Cannot proceed due to previous errors
860 It has taken me 2 days to find out what was causing that. After reducing
861 the code, the compiler eventually showed me the full error message.
863 2012-05-04 Murray Cumming <murrayc@murrayc.com>
865 ConfiguredDocument: Cache the cloned and stripped layouts.
867 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
868 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
869 layout in a map, so we can retrieve it again without rebuilding it.
871 2012-05-04 Murray Cumming <murrayc@murrayc.com>
873 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
875 2012-05-04 Murray Cumming <murrayc@murrayc.com>
877 libglom classes: Implement some auto-generated emthods.
879 2012-05-04 Murray Cumming <murrayc@murrayc.com>
881 Add GwtTestOnlineGlomService.
883 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
884 However, this (and the other GwtTest*) does not seem to run during
887 2012-05-04 Murray Cumming <murrayc@murrayc.com>
889 Remove use of unsupported features from client code.
891 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
892 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
893 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
894 Use our client version of StringUtils instead of the apache commons one.
896 However, the GWT Javascript compliation still fails.
898 2012-04-25 Murray Cumming <murrayc@murrayc.com>
900 Add a Field class and implement some loading of it in Document.
902 2012-04-25 Murray Cumming <murrayc@murrayc.com>
904 Initial Document loading implementation, instead of libglom.
906 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
907 and Translatable classes, and adapt the rest of the code to use them.
908 However, this is still missing Layout and Field classes and loading.
910 2012-04-24 Murray Cumming <murrayc@murrayc.com>
912 Use of jOOQ: Move Field creation into a utility method.
914 * src/main/java/org/glom/web/server/SqlUtils.java:
915 This lets us improve it more easily.
917 2012-04-24 Murray Cumming <murrayc@murrayc.com>
919 Use of jOOQ: Improve the code to COUNT a sub-select.
921 * src/main/java/org/glom/web/server/SqlUtils.java:
922 Move initial query creation into
923 build_sql_select_step_with_where_clause().
924 build_sql_select_count_rows(): Use the jOOQ API instead of
925 concatentating text, because a jOOQ Select*Step is a TableLike,
926 which is what from() takes.
928 2012-04-23 Murray Cumming <murrayc@murrayc.com>
930 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
932 * pom.xml: Depend on jooq.
933 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
934 methods with jOOQ, based on the C++ implementations in libglom,
935 with some changes to the logic required by jooQ.
936 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
938 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
939 * src/main/java/org/glom/web/server/ReportGenerator.java:
940 * src/main/java/org/glom/web/server/SqlUtils.java:
941 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
942 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
943 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
944 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
945 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
946 Adapt. In particular, the SqlUtils methods now need to take a Connection,
947 because jOOQ needs that, though it seems unnecessary.
949 This is not quite finished. Ideally jOOQ would help us to build
950 table_name.field_name names, quoting and escaping them properly.
951 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
953 2012-04-21 Murray Cumming <murrayc@murrayc.com>
955 Move use of Glom.build_sql*() into a new SqlUtils class.
957 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
958 to wrap Glom.build_sql*(). The parameter types are still Glom one,
959 but this will make it easier to start using something other than
960 libglom or SqlBuilder.
962 2012-04-21 Murray Cumming <murrayc@murrayc.com>
964 Update the project URL.
966 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
968 2012-04-21 Murray Cumming <murrayc@murrayc.com>
970 Main layout: Use a FlowTable instead of absolute positioning.
972 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
973 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
974 child panels/widgets must have an absolute position. But that is annoying, so
975 this adds a FlowTable and puts the child panels in there.
977 2012-04-21 Murray Cumming <murrayc@murrayc.com>
979 GwtTestOnlineGlom: Comment out unused code.
981 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
982 Eclipse has started to say that some code is unused.
984 2012-04-21 Murray Cumming <murrayc@murrayc.com>
986 Update to the latest versions of dependencies.
988 * pom.xml: Update version numbers of dependencies to the latest
990 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
991 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
992 * src/main/java/org/glom/web/server/ReportGenerator.java:
993 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
994 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
995 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
997 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
998 Modify the imports where necessary.
1000 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1002 Style: Remove overflow:hidden from searchbox
1004 * src/main/webapp/style.css: Because this pushes the Back To Link
1005 label/link on to the next row, which is then hidden due to the
1006 hard-coded (in ems) height.
1008 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1010 Remove some duplicate code.
1012 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1013 getDocumentInfo(): This must have been duplicated during the merge from the
1018 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1020 Reports: Localize the waiting for report message.
1022 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1023 start(): Get the message from the contants.
1024 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1025 Add the string here.
1026 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1027 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1028 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1029 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1030 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1031 Update these files with the English text for newer strings for now.
1033 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1035 Reports: Show a message while waiting for the report.
1037 * src/main/java/org/glom/web/client/ui/ReportView.java
1038 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1039 Add setWaitingText(), to show a message saying that we are
1040 waiting for the report to be ready.
1041 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1042 start(): Call setWaitingText() before calling the async
1045 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1047 ReportGenerator: Specify date and time formats.
1049 * src/main/java/org/glom/web/server/ReportGenerator.java:
1050 createFieldValueElement(): Use the default (and localized)
1051 short formats, though we still need a way to show 4-digit
1052 years without providing the format for every locale.
1053 * src/main/java/org/glom/web/server/database/DBAccess.java:
1054 convertResultSetToDTO(): Use the short formats here too.
1056 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1058 ReportGenerator: Use the correct numeric formatting.
1060 * src/main/java/org/glom/web/server/ReportGenerator.java
1061 createFieldExpression(), createFieldValueElement(): Take the
1062 whole LayoutItem_Field instead of just the field name, so
1063 we have access to the formatting.
1064 createFieldValueElement(): Use JRTextField.setPattern() to
1065 specify the numeric formatting, with the help of a
1066 regular DecimalFormat.
1068 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1070 ReportGenerator: Avoid showing null for group by titles.
1072 * src/main/java/org/glom/web/server/ReportGenerator.java
1073 generateReport(): Use setBlankWhenNull() on the field title
1074 style too, because this is used for values in group by
1077 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1079 ReportGenerator: Add a colon to titles in vertical groups.
1081 * src/main/java/org/glom/web/server/ReportGenerator.java
1082 addFieldToDetailBandVertical(): Pass true for the withColon
1085 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1087 ReportGenerator: Simplify the code by using Position more.
1089 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1091 Reports: Support vertical groups, roughly.
1093 * src/main/java/org/glom/web/server/ReportGenerator.java:
1094 addToReport(): Rename to addGroupToReport() and, if necessary,
1095 call the new addVerticalGroupToReport() method.
1096 createFieldValueElement(): Let the caller specify the Y position
1099 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1101 Reports: Allow a second report to be shown.
1103 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1104 clear(): Do not remove the HTML widget, which broke the whole layout.
1106 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1108 Locales drop-down: Show that we use English by default.
1110 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1111 fillView(): When we use English, just because that is the default, when
1112 no locale is specified, show that in the Locales drop-down instead of
1113 just showing the first item.
1115 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1117 Unselect the Report/Locale/Table combo item when appropriate.
1119 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1120 setPlace(): clear reportName if this is not a ReportPlace.
1121 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1122 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1123 When the provided name is empty, unselect all items, so that none are
1124 indicated. This uses a for loop because I cannot find a single method
1127 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1129 Report: Give the user a way to get back to the list.
1131 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1132 start(), setPlace(): Show the Back To List link on reports, and also
1133 interpret selecting the empty report item as back to list.
1135 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1137 Really show the selected Report name.
1139 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1140 setPlace(): Store the reportName here, if it is that kind of Place.
1141 fillView(): Set the selected Report after filling the list of reports.
1142 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1143 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1144 null Strings, though we need some way to unselect all ListBox items
1147 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1149 ReportGenerator: Try to avoid some problems.
1151 * src/main/java/org/glom/web/server/ReportGenerator.java
1152 addField(): Try to avoid duplicates, and avoid using a null
1155 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1157 Reports: Use quickFind.
1159 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1160 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1161 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1162 getReportHTML(): Add a quickFind parameter.
1163 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1164 start(): Pass the quickFind parameter.
1165 * src/main/java/org/glom/web/server/ReportGenerator.java
1166 generateReport(): Take a quickFind parameter.
1168 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1170 ReportPlace: Actually use the report name.
1172 * src/main/java/org/glom/web/client/place/ReportPlace.java
1173 getPlace(): Do not assign the report name to the quickfind.
1175 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1177 Show java.library.path when complaining.
1179 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1180 init(): When telling us to check java.library.path, show the
1183 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1185 ReportGenerator: Do not show nulls.
1187 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1189 ReportGenerator: Make the title font larger.
1191 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1193 ReportGenerator: Put field titles inside groups, if there are groups.
1195 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1197 ReportGenerator: Take the Report itself instead of the name and group.
1199 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1200 Remove getReportLayoutGroup().
1201 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1202 getReportHTML(): Pass the report instead
1203 of its name and layout group.
1204 * src/main/java/org/glom/web/server/ReportGenerator.java
1205 generateReport(): Use the report object to use the title
1206 instead of the name.
1208 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1210 ReportGenerator: Remove designBand parameters.
1212 * src/main/java/org/glom/web/server/ReportGenerator.java:
1213 Make designBand a class member instead of passing it to all
1216 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1218 ReportGenerator: Add lines, a bit like in the desktop version.
1220 * src/main/java/org/glom/web/server/ReportGenerator.java
1221 addToReport(): Use JRDesignLine.
1223 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1225 ReportGenerator: Correct the title positions and use some bold style.
1227 * src/main/java/org/glom/web/server/ReportGenerator.java:
1228 Break the code up into reusable functions, correct the placement of
1229 titles, and use normal/bold styles as in the reports in the desktop
1232 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1234 ReportGenerator: Add a header band to show the field titles.
1236 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1237 getReportHTML(): Pass the localeId to the ReportGenerator
1239 * src/main/java/org/glom/web/server/ReportGenerator.java
1240 constructor: Take the localeID so we can get translated field
1242 generateReport(), addToReport(), addFieldToBand(): Add field
1243 titles in a column header band.
1245 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1247 Reports drop-down list: Some improvement.
1249 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1250 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1251 Adedd setSelectedReport(),
1252 setReportList(): Add a blank line so that the user can select the
1254 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1255 start(): Show the current report by calling setSelectedReport().
1256 This does not seem to work yet.
1258 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1260 DetailsActivity, ListActivity: Move some variables into a base class.
1262 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1263 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1264 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1265 the clientFactory, documentID, tableName and authenticationPopup into
1266 a base class, to avoid duplication.
1268 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1270 Translate the Reports label.
1272 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1273 Get the "Reports" label string from the constants.
1274 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1275 perties: Add Reports to the constants.
1277 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1279 Reports: Implement grouping.
1281 * src/main/java/org/glom/web/server/ReportGenerator.java:
1282 Handle LayoutItem_GroupBy items and try to do the right thing
1283 with JRDesignGroup. It seems to work.
1285 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1287 Actually show some data with JasperReports.
1289 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1290 getReportHTML(): Move most code into a ReportGenerator class.
1291 * src/main/java/org/glom/web/server/ReportGenerator.java:
1292 Recurse into sub-groups, adding fields to the JasperDesign's details
1293 band. Note that we must set an arbitrary width and height, or it just
1294 will not show any data.
1296 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1298 Reports Chooser: Show the titles, not the names.
1300 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1301 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1302 and the names as the values.
1303 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1304 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1305 group now that we provide the report name, so it should always
1308 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1310 Depend on jasperreports.
1312 * pom.xml: Add the dependency. My plan is to use this on the
1315 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1317 Implement navigation to report places.
1319 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1320 start(): Do not bother to handle all events here.
1321 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1322 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1323 Added getSelectedReport().
1324 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1325 .java: start(): When handling a change to the reports chooser,
1326 call getSelectedReport() and goTo() its ReportPlace.
1327 * src/main/java/org/glom/web/client/ui/ReportView.java
1328 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1329 Added setReportHTML() which puts the html in a gwt HTML widget.
1330 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1331 getReportHTML(): Return "TODO" just to show that this works.
1333 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1335 Make ReportPlace usable.
1337 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1338 Mention ReportPlace.
1339 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1340 Correct the @prefix annotation.
1342 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1344 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1346 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1347 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1348 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1349 Change getReportLayout() to getReportHMTL() because we will not need to
1350 parse or render the report layout on the client side.
1351 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1352 getReportLayout(): Return the libglom LayoutGroup type because we will
1353 not need to convert to a shared type, because this will not be used on
1355 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1358 Note that there is still no implementation for this.
1361 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1363 Add a (empty) Report Place, View, and Activity.
1365 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1367 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1368 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1369 this into a superclass:
1370 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1371 and also use it as the base of this new ReportPlace:
1372 * src/main/java/org/glom/web/client/place/ReportPlace.java
1374 * src/main/java/org/glom/web/client/ui/ReportView.java
1375 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1376 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1377 Add these, containing mostly boiler-plate for now.
1379 * src/main/java/org/glom/web/client/OnlineGlomService.java
1380 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1381 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1382 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1383 Add API to get the LayoutGroup for the report.
1385 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1387 Add and fill a Reports drop-down list box.
1389 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1391 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1392 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1393 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1394 Added getReports(document, table, localeID), calling
1395 ConfiguredDocument.getReports().
1396 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1397 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1398 Added setReportsList() and a list widget.
1399 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1400 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1405 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1407 Translations: Add Esperanto.
1409 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1410 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1411 properties: Add this translation because someone took the time to make it.
1413 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1415 Adapt to the java-libglom 1.21.7 API.
1417 * src/main/java/org/glom/web/server/ReportGenerator.java:
1418 addToReport(): get_group_secondary_fields() is now
1419 get_secondary_fields().
1422 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1424 Use the latest java-libglom version.
1426 * pom.xml: Use java-libglom 1.21.7.
1428 2012-03-03 Ben Konrath <ben@bagu.org>
1430 Display date and time in details view.
1432 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1434 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1436 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1438 Require the latest java-libglom.
1440 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1442 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1444 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1446 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1447 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1448 an empty quickfind string. I also corrected libglom to create only
1449 empty where clauses for empty quickfind strings, but this avoids the
1452 2012-02-24 Ben Konrath <ben@bagu.org>
1454 Improve the tabs in the Notebook widget.
1458 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1460 Translations: Try to translate the strings.
1462 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1463 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1464 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1465 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1466 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1467 Take the Open translation from GTK+'s .po files.
1468 Take the Details translation from Glom's po files.
1469 I have added the other strings to Glom so we can get translations that way:
1470 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1472 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1474 TableSelectionViewImpl: Put the search label and entry in a div.
1476 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1477 Put the search widgets in a FlowTable so that the CSS can be used to
1478 style them while keeping them together.
1479 * src/main/webapp/style.css: Mention the new div.
1481 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1483 Translate more strings in more locales.
1485 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1486 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1487 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1488 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1489 Translate the "Details" and "Open" string too.
1491 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1492 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1493 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1494 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1495 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1496 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1497 Add these new locales as placeholders though they currently contain English.
1499 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1501 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1503 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1504 Check the ConfiguredDocument* for null before using it.
1506 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1508 Tell Eclipse about the generated java files.
1510 * .classpath: This lets it find OnlineGlomConstants.java.
1511 It would be nice if Eclipse just used the maven build files.
1513 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1515 Prevent a crash when no locale is specified in the URL.
1517 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1518 Avoid returning a null string, obtained from
1519 Window.Location.getParameter(). This caused a crash when it was
1520 later passed to libglom's API.
1521 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1522 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1523 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1524 guard against future null strings.
1526 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1528 Use the ?locale= query param instead of the &lang= token param.
1530 * src/main/java/org/glom/web/client/place/ListPlace.java
1531 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1532 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1533 Remove the lang token key and value.
1535 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1536 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1537 When the user selects a different locale from the chooser, use
1538 Window.Location.assign() to change the URL, which then causes a reload.
1540 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1541 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1542 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1543 * src/main/java/org/glom/web/client/activity/ListActivity.java
1544 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1545 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1546 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1547 * src/main/java/org/glom/web/client/ui/ListView.java:
1548 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1550 Remove localeID member variables and method/constructor parameters, instead
1551 using Utils.getCurrentLocaleID() when we need a localID to pass to
1554 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1556 Internationalize the UI strings.
1558 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1559 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1560 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1561 because it is unused. Messages are apparently strings that can have
1562 parameters, but we do not need that yet, so Contants will be enough for now.
1563 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1564 to say that we support the en and de locales.
1565 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1566 The original English strings.
1567 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1568 Some German translations of the English strings.
1569 The i18n goal then uses the .properties file to generate an
1570 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1571 returns an implementation that returns the translated strings.
1572 The documentation suggests putting these in src/java/*/client/, but it seems
1573 best to put it in src/resources/*/client/.
1574 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1575 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1576 instead of hard-coding them.
1577 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1578 but that does not seem to stop the build, though it confuses Eclipse.
1580 You can see the translated string by adding ?locale=de to the URL, like so:
1581 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1583 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1585 Improve null/empty String checks.
1587 * pom.xml: Add a dependency on commons-lang, to use
1588 org.apache.commons.lang.StringUtils.
1589 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1590 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1591 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1592 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1593 Use StringUtils.isEmpty().
1595 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1596 StringUtils class with a static isEmpty() function because we
1597 cannot use org.apache.commons.lang.StringUtils in client-side
1598 GWT code because it (apparently) cannot be compiled to javascript.
1599 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1600 * src/main/java/org/glom/web/client/activity/ListActivity.java
1601 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1602 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1603 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1604 * src/main/java/org/glom/web/client/place/ListPlace.java
1605 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1606 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1607 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1608 * src/main/java/org/glom/web/client/ui/details/Group.java
1609 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1610 our StringUtils.isEmpty() function.
1612 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1614 Update to the latest java-libglom API.
1616 * pom.xml: Require java-libglom 1.21.4.
1617 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1618 getDocumentInfo(), getListViewLayoutGroup():
1619 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1621 * src/main/java/org/glom/web/server/database/DBAccess.java
1622 getFieldsToShowForSQLQueryAddGroup(),
1623 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1624 with either get_database_title_original() or
1625 get_database_title(localeID).
1627 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1629 ConfiguredDocument: Avoid a null pointer exception.
1631 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1632 Initialize localeID to "" to avoid returning a null String which
1633 causes a crash in java-libglom's swing-generated code.
1635 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1637 Some simple renaming.
1639 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1640 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1641 for localeChooser. This seems more appropriate and is less ambiguous
1642 particularly in the .css file.
1644 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1646 ConfiguredDocument: Rename the localedID private member variable.
1648 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1650 Adapt to the latest java-libglom API from git master.
1652 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1653 libglom now uses only Vector instead of List, which uses add() instead of
1656 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1658 ConfiguredDocument: Rename the localedID private member variable.
1660 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1662 Build a source tarball with mvn assembly:single
1664 * assembly.xml: Add this file.
1665 * pom.xml: Use the maven-assembly-plugin and tell it to use
1666 our assembly.xml file.
1668 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1670 OnlineGlomServiceImpl: Get .glom files recursively.
1672 * pom.xml: Depend on commons-io from org.apache.commons.
1673 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1674 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1675 files recursively, and with the easier filter for the extension.
1676 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1677 simplify that code too.
1679 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1681 README: Mention that you must install java-libglom packages separately.
1683 But then it works, because java-libglom is now in the central maven
1686 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1688 locales drop-down: Show the correct selected locale when the URL changes.
1690 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1691 .java: setPlace(): Move some code into fillView().
1693 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1695 locales drop-down: Do not lose the primary key.
1697 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1698 start(): onLocaleChange(): Pass the current primary key value,
1699 instead of an empty value.
1701 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1703 locales drop-down: Do not lose the drop-down selection.
1705 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1706 .java (TableSelectionActivity.fillView): Set the selected locale
1707 after changing the drop-down items (though we do not really need
1708 to change them just because the locale changes.)
1710 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1712 locales drop-down: Change the tables list when this changes.
1714 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1715 .java: TableSelectionActivity.start(): Move the async table titles
1716 retrieval into a private fillView() method and also call this when
1717 the chosen locale changes.
1718 Note that the document title is not actually translatable yet, but
1719 that is a problem that I should fix soon in libglom.
1721 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1723 Improve the placement of the locales drop-down.
1725 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1726 Put the title and locales drop-down in a div (gwt.FlowTable).
1727 * src/main/webapp/style.css: Add magic css properties to make this work.
1728 Also remove the left margin from the title so that it lines up with the
1731 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1733 locales selector: Show human-readable locale titles.
1735 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1736 getDocumentInfo(): Use java.util.Locale to show a real title of
1737 each locale, in the locale's own language.
1739 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1741 Add a language/locale selector drop-down.
1743 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1744 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1745 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1746 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1747 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1748 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1749 Add a ListBox to show the available locales. Add getLocaleSelector(),
1750 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1751 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1752 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1753 java: Add these classes.
1754 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1755 start(): Fill the locales ListBox. Handle its change event, firing a
1757 setPlace(): Show the selected locale as specified by the URL token.
1758 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1759 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1760 Handle LocaleChangeEvent, going to a new *Place with that locale.
1762 The placement of the ListBox is not pretty, and it currently uses the ID
1763 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1767 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1769 Search box: Show the search text from the URL token.
1771 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1772 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1773 Add setQuickFindText().
1774 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1775 .java: setPlace(): Store the queryText if the place is a ListPlace,
1776 and call TableSelectionView.setQuickFindText().
1778 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1780 Allow use of translations via, for instance, &lang=de in the URL.
1782 * pom.xml: Use the unstable java-libglom 1.21 version.
1784 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1785 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1786 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1787 init(): Instead of calling TranslatableItem.set_current_locale()
1788 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1789 However, this is only for default locales, which are not needed to
1790 change the locale in the URL.
1791 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1792 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1793 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1794 layout for a particular locale.
1795 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1796 Add get/setDefaultLocaleID().
1797 getDocumentInfo(), getListViewData(), getRelatedListData(),
1798 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1799 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1800 localeID parameter, so we can get the layout for a particular locale.
1802 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1803 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1804 * src/main/java/org/glom/web/client/place/ListPlace.java:
1805 Parse and construct a lang parameter too.
1807 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1808 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1809 passed to subsequent methods and constructors.
1810 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1811 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1812 Store the localeID from the *Place and pass it to other constructors
1813 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1815 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1816 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1817 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1818 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1819 * src/main/java/org/glom/web/client/ui/ListView.java:
1820 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1821 Take localeID parameters and pass them to subsequent constructors and
1822 methods, so that the layout is always retrieved for that locale.
1824 This is rather repetitive.
1826 Note that "" means the original (default) locale of the Glom document,
1827 which is usually English.
1829 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1831 Documents: Remove final keyword to fix startup configuration.
1833 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1834 final keywords on the private member variables because that breaks
1835 the startup, apparently (there are warnings) because it stops them
1836 from being serialized. I added these in the previous commit.
1838 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1840 Documents: Add some final keywords.
1842 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1845 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1847 OnlineGlomServiceImpl: Add to overview comments.
1849 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1850 Note that this is where all the document are loaded. They are not
1851 loaded freshly for each page.
1853 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1857 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1858 Add a TextBox for the text of a quick find.
1859 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1861 setBackLink(): Add a String quickFind parameter.
1862 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1863 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1864 to the base interface, because that is how TableSelectionViewImpl is used.
1865 * src/main/webapp/style.css: Add style for the search box and its label.
1867 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1868 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1869 Add these files, based on the existing TableChangeEvent and
1870 TableChangeEventHandlers.
1871 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1872 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1873 a ListPlace() that the user should be taken to.
1874 * src/main/java/org/glom/web/client/activity/ListActivity.java
1875 start(): Handle it here too and adapt the TableChangeEvent handler to
1876 pass the extra "" quickFind parameter to ListPlace.
1877 * src/main/java/org/glom/web/client/place/ListPlace.java:
1878 Constructor: Take an extra String quickFind parameter and store it,
1879 returning it from a new getQuickFind() method.
1880 getToken(): Put the quickFind text in the URL token.
1881 getPlace(): Parse the quickFind text from the URL token.
1882 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1883 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1884 ListPlace constructor.
1885 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1886 .java: start(): Add a Change handler for the TableSelectionView's
1887 TextBox (via its base HasChangeHandlers interface), firing the new
1888 QuickFindChangeEvent.
1889 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1890 pass the extra "" quickFind parameter.
1892 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1893 setCellTable(): Add a String quickFind parameter and pass it to
1894 the ListViewTable() constructor.
1895 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1896 setCellTable() in the base interface, because that is how ListViewImpl
1899 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1900 Add a String quickFind member variable.
1901 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1902 Constructor: Add a String quickFind parameter, storing it in the
1903 base ListTable's member variable.
1904 onRangeChanged(): Pass quickFind to the
1905 OnlineGlomServiceAsync.getSortedListViewData() and
1906 OnlineGlomServiceAsync.getListViewData() methods.
1908 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1909 getListViewData(), getSortedListViewData(): Add a String quickFind
1910 parameter, passing it to ConfiguredDocument.getListViewData().
1911 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1912 Change getListViewData(), getSortedListViewData() in the base interface,
1913 because that is how OnlineGlomServiceImpl is used, via this:
1914 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1915 Change getListViewData(), getSortedListViewData() here too.
1916 This class can apparently be used to asynchronously call methods on
1917 OnlineGlomService, and GWT seems to implement that after recognizing
1918 just the *Async name convention and the extra AsyncCallback parameters.
1920 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1921 getListViewData(): Add a String quickFind parameter, and pass it to
1922 ListViewDBAccess.getData().
1923 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1924 getListData(): Add a String quickFind parameter and pass it to
1926 getSelectQuery(): Add a String quickFind parameter.
1927 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1928 getSelectQuery(): Add a String quickFind parameter and use it with
1929 Glom.get_find_where_clause_quick() to pass a where_clause to
1930 Glom.build_sql_select_with_where_clause(), to actually filter the
1932 getData(): Add a String quickFind parameter, passing it to getListData().
1933 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1934 va: getData(): Pass an empty string to getListData() for the
1935 quickFind parameter.
1937 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1939 ListTable: Minor change.
1941 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1942 createCellTable(): Make this protected instead of public.
1944 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1946 Many files: Use final for the parameters and use the @override attribute.
1948 2012-01-22 Ben Konrath <ben@bagu.org>
1950 Add anchor links for single line text that starts with http, ftp and www.
1954 2012-01-22 Ben Konrath <ben@bagu.org>
1956 Add ellipsis to single line text in details view.
1960 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1962 Remove all javadoc author tags.
1964 Because they are awkward and meaningless when many people touch
1966 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1968 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1970 Revert the COPYING.LESSER to COPYING rename.
1972 Apparently both should be there if it is LGPL.
1974 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1976 *View: Remove unused imports.
1978 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1979 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1980 * src/main/java/org/glom/web/client/ui/ListView.java:
1981 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1982 Remove unused imports, as suggested by Eclipse.
1984 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1986 Move the *View::Presenter types, and some API into one base View.
1988 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1989 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1990 * src/main/java/org/glom/web/client/ui/ListView.java:
1991 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1992 Presenter, setPresenter() and clear() into a shared base interface,
1993 to avoid the unnecessary duplicate Presenter types and to more clearly
1994 show how the *Views share the same structure, even if they are not
1995 used polymorphically.
1997 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1998 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2000 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2001 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2002 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2004 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2007 Feel free to revert this if there is a good reason for the duplicate
2010 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2012 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2014 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2015 a class member instead of a local variable in the method.
2016 This lets us use it to get the view instances, for use in tests.
2017 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2018 beforeOnlineGlom(): Test some more details of the initial view.
2019 Again, this is not very useful.
2021 To really test gwt-glom we will need to start a local postgresql
2022 instance with local data, like the Glom tests in C++.
2024 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2026 pom.xml: Mention the LGPL license.
2028 * pom.xml: Add a licenses section.
2029 * COPYING.LESSER: Move this to COPYING, which
2030 previously contained the GPL. But gwt-glom is all LGPL.
2032 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2034 Add project information to README and pom.xml.
2036 * README: Add a brief description and mention some mvn
2038 * pom.xml: This extra information shows up in mvn site
2041 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2043 Use the latest java-libglom version.
2045 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2047 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2049 GwtTestOnlineGlom: Test a little more.
2051 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2052 protected rather than private, as suggested by the gwt-test-utils
2054 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2055 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2056 Test the initial visibility of the panels.
2058 However, this is not a very useful test.
2059 And I wonder how we should generally test using this idea for an
2060 activity/places app like ours where the real changes happen implicitly
2061 based on the history token/URL.
2063 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2065 Slight modification to *Mapper comments.
2067 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2068 (DataActivityMapper)
2069 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2071 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2073 Remove comments mentioning GIN because they are just copied from
2074 the example code and are apparently not helpful:
2075 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2076 Also change the mention of a class that is only in the example code.
2078 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2080 GwtTestOnlineGlom test: Minor changes.
2082 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2083 Avoid the long qualified class name and modify the comment
2084 because it is now obvious to me that the mocked class is the only
2085 custom one created via GWT.create().
2087 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2089 Tests: Added the beginnings of a test using gwt-test-utils.
2091 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2092 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2093 which tells gwt-test-utils what class will be tested.
2094 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2095 Add a simple (but empty) test case. One class, used by the OnlineGlom
2096 class, is mocked so that it can be created. However, I am not sure
2097 why only this class needs to be mocked.
2099 Note that mockito seems more popular, and clearer, than easymock,
2100 but I have not got that working yet. It might be a matter of the
2103 This test is run during mvn integration-test.
2105 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2107 Tests: Use junit4-style syntax instead of junit3-style.
2109 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2110 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2111 * src/test/java/org/glom/web/shared/DataItemTest.java:
2112 Use the @Test annotation rather than relying on the test*() prefix.
2113 Also no longer implement TestCase, to avoid triggering support for
2114 the junit3-way, which stops the annotations from working.
2115 Change the imports from import junit.framework.* to
2116 import org.junit.*, which is apparently the new way.
2118 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2120 Added a test for ListPlace token parsing and creation.
2122 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2123 This is much the same as DetailsPlaceTest.
2125 I wonder how we could test the other parts of the *Place API.
2127 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2129 DetailsPlace test: Also test getToken() and recreation via getPlace().
2131 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2132 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2133 recreate it, testing the recreated DetailsPlace for the same parameter
2136 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2138 Use the surefire-report plugin.
2140 * pom.xml: This generates a HTML report about the tests in
2141 target/site/surefire-report.html
2142 when you do mvn surefire-report:report. It seems to be popular/normal.
2144 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2146 Added a test for DetailsPlace.
2148 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2149 Test the getPlace() token parsing.
2151 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2153 Added a first unit test.
2155 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2156 * src/test/java/org/glom/web/shared/DataItemTest.java:
2157 This is a silly test but it is just to get things started. Note that
2158 maven/junit finds the test because it looks in src/test by default.
2160 2011-12-22 Ben Konrath <ben@bagu.org>
2162 Change charsetName to "UTF-8" when replacing line breaks.
2164 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2165 that work in Java (such as "UTF8") will not work when compiled to
2168 This fixes a problem with multi-line details view fields that have hard
2169 line breaks. The "License Text" field on this page demonstrates the
2172 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2174 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2176 2011-12-22 Ben Konrath <ben@bagu.org>
2178 Fix another bug with related list navigation.
2180 I've tested all the navigation buttons in all of the related lists
2181 so things should be good now.
2183 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2185 2011-12-22 Ben Konrath <ben@bagu.org>
2187 Fix a crasher when refreshing the list view with the default table.
2189 This crash will also happen when loading the list view with the default
2190 table from a link or bookmark.
2192 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2193 to the main document selection page when the document id hasn't been
2195 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2196 the main document selection page when the document id hasn't been
2198 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2199 values for the details place when the document id hasn't been set.
2200 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2201 values for the list place when the document id hasn't been set.
2203 2011-12-21 Ben Konrath <ben@bagu.org>
2205 Protect against NPE when glom.document.locale is not in config.
2207 This patch protects against an NPE when glom.document.locale is not in
2208 the config file. This NPE will also happen if glom.document.locale is
2211 The patch also updates the error message to display the class name when
2212 the getMessage() returns null. This was happening when the NPE was
2213 thrown and I had "Configuration Error: null". If an NPE is encountered
2214 with this patch, "Configuration Error: NullPointerException " will be
2217 This commit closes this bug:
2219 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2221 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2223 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2225 Rename onlineglom.properties to onlineglom.properties.sample.
2227 * src/main/resources/onlineglom.properties: Rename to:
2228 * src/main/resources/onlineglom.properties.sample:
2229 * src/main/resources/README: And add this file explaining that people
2230 should rename it back when deploying.
2232 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2234 Allow choosing the translation in the .properties file.
2236 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2237 init(): Read a glom.document.locale value from the configuration file
2238 and call Glom's TransatableItem::set_current_locale() method.
2239 * src/main/resources/onlineglom.properties: Add a commented-out
2240 example of this new setting.
2242 It would be better to add &lang=de_DE to the URL, but the current
2243 libglom API does not allow us to do this easily. I am working on that.
2245 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2247 Avoid a crash in parsing of token parameters.
2249 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2250 ava: getTokenParams(): Do not crash if a parameter has a key but no
2251 value, and ignore parameters with neither.
2253 2011-12-17 Murray Cumming <murrayc@murayc.com>
2255 History token building/handling: Improve use of token parameters.
2257 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2258 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2259 and buildParamsToken(HashMap), for use by derived classes.
2260 Make the separator private because it is no longer be needed.
2261 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2262 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2263 instead of manual string concatenation.
2264 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2265 of hardcoded indices and awkward splitting code.
2266 * src/main/java/org/glom/web/client/place/ListPlace.java
2267 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2268 instead of manual string concatenation.
2269 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2270 of hardcoded indices and awkward splitting code.
2271 This should fix bug #666420
2273 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2275 Fix a Navgiation->Navigation typo in the code.
2277 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2278 Rename processNavgiation() to processNavigation().
2280 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2282 Fix a seperator->separator typo in the code.
2284 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2285 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2286 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2289 2011-12-15 Ben Konrath <ben@bagu.org>
2291 Cleanup some comments.
2293 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2295 2011-12-14 Ben Konrath <ben@bagu.org>
2297 Replace \n with <br/> for multiline text in the details view.
2299 Vertical scrollbars are added when needed as well.
2301 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2303 2011-12-14 Ben Konrath <ben@bagu.org>
2305 Specify the font for document selection links.
2307 * src/main/webapp/style.css:
2309 2011-12-14 Ben Konrath <ben@bagu.org>
2311 Fix bouncy CellTable while paging.
2313 This doesn't currently work with related list tables in unselected
2316 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2318 2011-12-14 Ben Konrath <ben@bagu.org>
2320 Revamp the appearance of the document selection page.
2322 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2323 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2324 * src/main/webapp/style.css:
2326 2011-12-13 Ben Konrath <ben@bagu.org>
2328 Set navigation button column to the smallest size possible.
2330 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2332 2011-12-13 Ben Konrath <ben@bagu.org>
2334 Change OpenButton nomenclature to NavigationButton.
2336 Using NavigtionButton makes things more generic. Classes, methods and
2337 variables have been changed.
2339 This is a rename-only refactor.
2341 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2342 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2343 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2344 Renamed from OpenButtonCell.
2345 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2346 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2347 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2349 2011-12-12 Ben Konrath <ben@bagu.org>
2351 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2353 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2354 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2355 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2356 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2358 2011-12-12 Ben Konrath <ben@bagu.org>
2360 Update variable names and comments.
2362 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2363 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2365 2011-12-12 Ben Konrath <ben@bagu.org>
2367 Properly initialize numNonEmptyRows variable to zero.
2369 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2370 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2372 2011-12-05 Ben Konrath <ben@bagu.org>
2374 Add latest mockup with HTML tables.
2376 Features of this mockup:
2378 -> HTML table for flowtable
2379 -> HTML table for flowtable column
2380 -> Example of how related lists would look
2381 -> Not using text entries for data items
2383 The current version of Online Glom doesn't use HTML tables for the
2386 This mockup has been sent to the glom-devel mailing list but it's good
2387 to have it here as well.
2389 * mockups/details-view-html-tables.html:
2391 2011-12-05 Ben Konrath <ben@bagu.org>
2393 Remove unnecessary getPrimaryKeyField() method.
2395 getPrimaryKeyFieldForTable(String) has been renamed to
2396 getPrimaryKeyField(String).
2398 * src/main/java/org/glom/web/server/database/DBAccess.java:
2399 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2400 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2402 2011-12-05 Ben Konrath <ben@bagu.org>
2404 Add string representation of TypedDataItem value to conversion error message.
2406 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2407 message was extracted into its own method to avoid duplication.
2409 2011-12-05 Ben Konrath <ben@bagu.org>
2411 Add type checking to navigation primary key value creation.
2413 Create navigation primary key only if the expected type from the Glom
2414 document matches the type returned by the SQL query.
2416 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2418 2011-12-05 Ben Konrath <ben@bagu.org>
2420 Rename a couple of variables in RelatedListNavigation.
2422 This is a rename-only refactor.
2424 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2426 2011-12-05 Ben Konrath <ben@bagu.org>
2428 Move getListLayoutGroup() into getListViewLayoutGroup().
2430 This removes getListLayoutGroup(). It was only being called by
2431 getListViewLayoutGroup().
2433 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2435 2011-12-05 Ben Konrath <ben@bagu.org>
2437 Remove check for LayoutItem_Portal in list table method.
2439 This check is no longer necessary because the method isn't being used
2440 to create the LayoutItemPortal DTO.
2442 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2444 2011-12-05 Ben Konrath <ben@bagu.org>
2446 Properly support related list navigation.
2448 Navigation from the "Repository Analyzer -> Package Scans ->
2449 Dependencies" related table wasn't working because the primary key for
2450 related tables wasn't being set properly. This commit fixes the
2453 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2454 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2455 doesn't set the primary key properly for related list tables.
2456 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2457 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2458 useful for getting the primary key for list view tables and for related
2460 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2461 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2462 Move code to set the primary key for the table from the abstract
2463 ListDBAccess class to ListViewDBAccess as it's only correct for list
2465 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2466 Properly add primary key to related list tables.
2468 2011-12-02 Ben Konrath <ben@bagu.org>
2470 Properly set the horizontal alignment of fields.
2472 This fix is for both the list tables and the details view.
2474 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2475 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2476 to set the horizontal alignment of fields.
2478 2011-12-02 Ben Konrath <ben@bagu.org>
2480 Display currency codes in the details view.
2482 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2484 2011-12-02 Ben Konrath <ben@bagu.org>
2486 Avoid duplicate JNI call.
2488 JNI is not as efficient as pure Java and this is an easy (and small)
2491 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2492 Use previously retrieved value for whereClauseToTableName instead of
2495 2011-12-02 Ben Konrath <ben@bagu.org>
2497 Rename a couple of variables in RelatedListNavigation.
2499 This is a rename-only refactor.
2501 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2503 2011-12-02 Ben Konrath <ben@bagu.org>
2505 Indicate clearly that a mismatched primary key type is a bug.
2507 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2508 warning to error. Add 'This is a bug.' to message.
2510 2011-12-02 Ben Konrath <ben@bagu.org>
2512 Update / fix some comments.
2514 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2516 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2518 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2519 Fix comments. Add some TODOs.
2521 2011-12-02 Ben Konrath <ben@bagu.org>
2523 Enable navigation to details view with string primary key from related list.
2525 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2526 Create a text primary key value when return type of result is
2527 java.sql.Types.VARCHAR.
2529 2011-12-02 Ben Konrath <ben@bagu.org>
2531 Use checkboxes for booleans in the details view.
2533 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2535 2011-12-01 Ben Konrath <ben@bagu.org>
2537 Improve performance of related list height calculation.
2539 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2540 Put code to calculate the expected height in a static initializer so
2541 that that it's only called once.
2543 2011-12-01 Ben Konrath <ben@bagu.org>
2545 Show related list tables in notebooks (again).
2547 Calculate the height of the related list tables so the Notebook can be
2548 set the correct height. The height of the related list table is also needed by
2549 FlowTable to be able decide how to create the layout.
2551 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2552 and set the Portal height based on the height of the related list
2553 table and the Portal container.
2554 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2555 Add method to calculate the height of the related list tables.
2556 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2557 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2558 calculate the height of the Pager widget.
2560 2011-12-01 Ben Konrath <ben@bagu.org>
2562 Use CellTable API for table property instead of setting style on Element.
2564 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2566 2011-12-01 Ben Konrath <ben@bagu.org>
2568 Make ListViewTable and RelatedListTable a consistent height.
2570 The tables are now a consistent height regardless of the contents of
2571 the table. A hidden button is added to empty rows to ensure that the
2572 height of these rows will match the height of rows with data.
2574 A navigation button column is now added to every table. The width of
2575 the navigation column is set to 0px when a RelatedListTable shouldn't
2576 have navigation buttons. This maintains the a consistent row height in
2577 tables that don't show the navigation buttons.
2579 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2580 navigation column when not needed.
2581 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2582 arguments for navigation button to constructor of ListViewTable.
2583 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2584 hidden button for empty data rows.
2585 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2586 arguments for navigation button to constructor.
2587 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2588 create navigation buttons. Add hideNavigationButtons() method.
2589 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2590 arguments for navigation button to constructor.
2592 2011-12-01 Ben Konrath <ben@bagu.org>
2594 Use 'visibility: hidden' in Utils.getWidgetHeight().
2596 This is better choice because hidden elements are invisible, don't
2597 respond to events and are not part of the tab order. They will,