1 2012-06-08 Murray Cumming <murrayc@murrayc.com>
3 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
5 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
6 Make this actually test the cloning again, though it is not very useful
7 now that we do not use the part that had a problem with cloning before.
9 2012-06-08 Murray Cumming <murrayc@murrayc.com>
11 SelfHoster: Keep trying pg_ctl after starting postgres.
13 * src/test/java/org/glom/web/server/SelfHoster.java
14 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
15 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
16 regular Glom. This seems mad but it seems to work because the first
17 command would fail if pg_ctl would eventually fail.
19 2012-06-08 Murray Cumming <murrayc@murrayc.com>
21 SelfHoster: Wait until the server is really ready.
23 * src/test/java/org/glom/web/server/SelfHoster.java
24 selfHost(): Attempt the connection after starting the server, retrying
25 a few times if necessary, so that the server is really ready already when
26 we return from this method.
27 The regular Glom code does this too because pg_ctl reports success too soon.
29 2012-06-08 Murray Cumming <murrayc@murrayc.com>
31 ConfiguredDocument: Do not add a primary key to portals each time.
33 * src/main/java/org/glom/web/server/ConfiguredDocument.java
34 updatePortalsExtras(): Only add an extra primary key field if there is
35 none, to avoid adding one each time we retrieve the details layout from the
37 This should fix bug #676986 (Ben Konrath)
39 2012-05-25 Murray Cumming <murrayc@murrayc.com>
41 Document.load(): Support version 7 documents.
43 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
44 database_title attribute if the title attribute is not there.
47 2012-05-24 Ben Konrath <ben@bagu.org>
49 Add configuration for auto-generating mvn:i18n from with Eclipse.
51 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
53 2012-05-24 Murray Cumming <murrayc@murrayc.com>
55 Update translations, adding French.
57 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
58 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
59 Add a French translation, using the translation from Glom.
61 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
62 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
63 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
64 Update these based on the translations from Glom.
66 2012-05-24 Murray Cumming <murrayc@murrayc.com>
68 SelfHoster: Add some debug println messages to help when things fail.
70 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
71 System.out.println() lines.
73 2012-05-23 Murray Cumming <murrayc@murrayc.com>
75 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
77 * src/test/java/org/glom/web/server/SelfHoster.java:
78 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
79 instance) instead of just /usr/bin (as on Fedora). Check the result when
82 2012-05-23 Murray Cumming <murrayc@murrayc.com>
84 Remove LayoutItemPortal.get/setNavigationTable().
86 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
87 Remove get/setNavigationTable(), which is only a cache, because it is not
88 used, and does not need to be used, because that decision should be made on
90 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
91 updatePortalsExtras():
92 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
93 getNavigationRecord():
94 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
97 2012-05-21 Murray Cumming <murrayc@murrayc.com>
99 Initial self-hosting for tests.
101 * pom.xml: Change the scope for log4j, to hopefully make it
102 available to the test code which uses it indirectly via jOOQ.
103 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
104 self-hosting, though we only use it for testing.
106 * src/main/java/org/glom/web/server/libglom/Document.java:
107 example rows: Use a map instead of a list for each row of values,
108 so we know what field they are for, instead of relying on the sequence
109 being correct. This is not very efficient, but it does not really need
111 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
112 testReadTableExampleRows(): Adapted.
114 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
115 that returns an Object, for generic use. Note that Object seems to be
116 the implicit base even of double.
117 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
118 for use in CREATE TABLE SQL queries.
119 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
120 to do self-hosting of PostgreSQL databases via its command-line
121 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
122 backends/postgres_self.cc. This is incomplete - it needs more
123 warnings about failures and it needs to clean up properly when things
125 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
126 test of this new class.
128 2012-05-21 Murray Cumming <murrayc@murrayc.com>
130 Document: loading example data: Handle exceptions.
132 * src/main/java/org/glom/web/server/libglom/Document.java:
133 DateFormat.parse() and Double.valueOf() can throw exceptions, though
134 Eclipse did not warn about that.
136 2012-05-20 Murray Cumming <murrayc@murrayc.com>
138 Document: load(), save(): Handle the example rows.
140 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
142 * src/main/java/org/glom/web/server/libglom/Document.java:
143 load(), save(): Load and save the example rows, though the date, time
144 and image types are not handled properly yet.
145 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
146 Add testReadTableExampleRows() just to check that something is read.
148 2012-05-20 Murray Cumming <murrayc@murrayc.com>
150 Document: Add save().
152 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
153 Added getTranslationsMap() for use while saving.
154 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
155 Adedd getUseDefaultFormatting() for use while saving.
156 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
157 and several private methods that it uses.
159 This will be useful while testing via self-hosting.
160 It is not complete, but should be complete enough for testing.
162 2012-05-17 Murray Cumming <murrayc@murrayc.com>
164 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
166 * src/main/java/org/glom/web/client/OnlineGlomService.java
167 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
168 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
169 Remove getSortedListViewData() and getSortedRelatedListData(), adding
170 the sort column index and ascending bool to the regular method.
171 Instead, a sort column index of -1 now means no sort.
172 This is less explicit, but it's fairly simple, reduces the amount of
173 code, and makes the OnlineGlomService API slightly smaller.
174 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
175 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
177 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
178 getListViewData(), getRelatedListData():
179 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
180 getListViewData(), getRelatedListData():
181 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
183 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
185 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
190 2012-05-16 Murray Cumming <murrayc@murrayc.com>
192 Use translations for top-level groups too.
194 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
195 updateTitlesForLocale(): Use the translation for the group
196 as well as for child items.
200 Just recompiled to fix a problem in the released .tar.gz file.
204 2012-05-15 Murray Cumming <murrayc@murrayc.com>
206 Corrections to navigation to related records.
208 * src/main/java/org/glom/web/client/OnlineGlomService.java:
209 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
210 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
211 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
212 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
213 relationship name, because the relationship name is not necessarily unique
215 TOOD: This is inefficient, because it passes the whole list of
216 child field items back to the server, but it is more correct, and happens
217 to fix a bug with the primary key being lost after a few navigations.
218 There is probably a chance to make this more efficient anyway in some
221 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
222 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
223 * src/main/java/org/glom/web/server/ConfiguredDocument.java
224 * src/main/java/org/glom/web/server/database/DBAccess.java
225 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
226 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
229 2012-05-15 Murray Cumming <murrayc@murrayc.com>
231 Fix the use of translations.
233 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
234 Add updateTitlesForLocale().
235 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
236 Call it to discard unwanted translations and to make getTitle() return
237 the wanted translation wihout the need for the client code to specify a locale.
238 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
239 getTitle(): Fallback to the original title, as libglom does.
241 2012-05-15 Murray Cumming <murrayc@murrayc.com>
243 Document: Correctly report the number of available translation locales.
245 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
246 the available locale IDs list.
247 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
248 testLocales: Test this.
250 2012-05-15 Murray Cumming <murrayc@murrayc.com>
252 SqlUtils: Use camelCase.
254 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
255 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
256 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
257 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
258 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
259 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
261 2012-05-15 Murray Cumming <murrayc@murrayc.com>
263 Use jOOQ's tableByName() and fieldByName.
265 * pom.xml: Use jOOQ 2.3.1 to get the new API.
266 * src/main/java/org/glom/web/server/SqlUtils.java:
267 build_sql_select_step_with_where_clause(), .createField(),
268 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
269 so we can get correct quoting and escaping. Thanks to Lukas Eder for
270 adding this, and other things, to jOOQ.
272 2012-05-15 Murray Cumming <murrayc@murrayc.com>
274 SqlUtils: Remove the Connection parameters.
276 * src/main/java/org/glom/web/server/SqlUtils.java:
277 build_sql_select_with_key(), build_sql_select_with_where_clause(),
278 createSelect(), build_sql_select_step_with_where_clause(),
279 build_sql_count_select_with_where_clause(),
280 build_sql_select_count_rows(): Remove the Connection parameter because
281 jOOQ does not actually need a connectionwhen it is just used to build
283 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
285 * src/main/java/org/glom/web/server/ReportGenerator.java:
287 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
289 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
290 Constructor, getListData(), getResultSizeOfSQLQuery():
291 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
292 getSelectQuery(), getCountQuery():
293 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
294 getSelectQuery(), getCountQuery():
295 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
296 getNavigationRecord(): Adapted.
298 2012-05-14 Murray Cumming <murrayc@murrayc.com>
302 * src/main/java/org/glom/web/server/SqlUtils.java:
303 get_find_where_clause_quick(): Use a comparison of
304 lowercase values, instead of a simple equals. Regular Glom
305 uses the PostgreSQL ILIKE operator but jOOQ does not
306 support that just yet, though it will soon.
308 2012-05-14 Murray Cumming <murrayc@murrayc.com>
310 TableToViewDetails: Use a real serialization ID.
312 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
313 Though this does not fix the serialization problem.
315 2012-05-12 Murray Cumming <murrayc@murrayc.com>
317 Added LayoutItemPortalDeepCloneTest.
319 2012-05-11 Murray Cumming <murrayc@murrayc.com>
321 Make navigation work again.
323 * src/main/java/org/glom/web/server/libglom/Document.java:
324 Add getLayoutItemFieldShouldHaveNavigation().
325 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
326 Replace get/setAddNavigation() with the partly-existing
327 get/setNavigationTableName(), with an empty string being no navigation,
328 because this is simpler. Use the new
329 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
331 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
332 Add updateFieldsExtras() and call setNavigationTableName in it.
333 getDetailsLayoutGroup(),
334 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
335 createLayout(): Adapted.
336 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
337 Constructor: Adapted.
339 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
340 Replace get/setAddNavigation() with get/setNavigation(), returning a
341 TableToViewDetails class with both the table name and UsesRelationship,
342 because both are need. The previous code used java-libglom's output
343 variable (strangely, via sharedptr) to return both, but we cannot really
345 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
346 getNavigationRecord(): Adapt. However, we cannot actually use the cache
347 here because it somehow gets set to null during deepCopy(). I must test this.
348 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
349 testGetSuitableTableToViewDetails(): Adapted.
351 TODO: Find out why deepClone() is not quite working.
353 2012-05-11 Murray Cumming <murrayc@murrayc.com>
355 DBAccess: Simplify the retrievel of full field details.
357 * src/main/java/org/glom/web/server/database/DBAccess.java
358 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
359 because the Document loading should have done this.
361 2012-05-11 Murray Cumming <murrayc@murrayc.com>
363 Document: Correct loading of doubly-related layout fields.
365 * src/main/java/org/glom/web/server/libglom/Document.java:
366 loadUsesRelationship(): Actually set the related relationship, instead
367 of only setting it if it's not found.
369 2012-05-09 Murray Cumming <murrayc@murrayc.com>
371 Replace all appearances of Colour with color.
373 Because US English is dominant.
375 2012-05-09 Murray Cumming <murrayc@murrayc.com>
377 Use colors in HTML format, solving a warning about an unused function.
379 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
380 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
381 Add *asHTMLColor() versions of methods.
382 TODO: However, we should create and cache the results on the server.
383 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
384 * src/main/java/org/glom/web/client/ui/list/ListTable.java
385 * src/main/java/org/glom/web/server/ConfiguredDocument.java
386 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
387 Use the asHTMLcolor() versions.
389 2012-05-09 Murray Cumming <murrayc@murrayc.com>
391 ListViewTable: Constructor: Take the table name as a parameter.
393 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
394 Constructor: Take the tableName, and set the member variable, because
396 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
397 setCellTable(): Pass the table name.
398 This makes navigation to non-default tables work again. I don't know
399 why it worked before in the master branch.
401 2012-05-07 Murray Cumming <murrayc@murrayc.com>
403 ConfiguredDocument: Restore correct addition of hidden primary key items.
405 * src/main/java/org/glom/web/client/ui/list/ListTable.java
406 (ListTable.createCellTable): Uncomment out the check for the hidden
408 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
409 add primary key items for top-level lists and portals, as before,
410 instead of adding them to each group.
411 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
412 Actually implement the extra methods such as setHiddenPrimaryKey() and
413 comment that these are used only for top-level list groups and in portals.
414 This strangeness suggests even more that this should not be squeezed
415 into the LayoutGroup class.
417 2012-05-07 Murray Cumming <murrayc@murrayc.com>
419 Fix Formatting loading.
421 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
422 getFormattingUsed(): Remove the duplicate Formatting member variable
423 in favour of the one from the base class.
424 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
425 Initialize a new Formatting instead of using null by default, so we
426 have some defaults, instead of having to initialize one later just to
427 get the same defaults. This also makes loading of formatting from the
428 document work, because that expected a non-null.
430 2012-05-07 Murray Cumming <murrayc@murrayc.com>
432 RelatedListTable: Make sure that the tableName is set.
434 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
435 Constructor: Take the tableName so it is available later. Otherwise,
436 the server assumes that we mean the default table and cannot find the
438 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
439 setData(): Pass the tableName to the RelatedListTable constructor.
441 2012-05-07 Murray Cumming <murrayc@murrayc.com>
445 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
446 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
447 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
449 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
451 * src/main/java/org/glom/web/server/database/DBAccess.java:
452 convertResultSetToDTO(), getPortal():
453 * src/main/java/org/glom/web/server/database/ListDBAccess.java
455 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
456 Add checks for null objects and out of range access, with log messages to
457 give hints so we can fix these properly.
459 2012-05-07 Murray Cumming <murrayc@murrayc.com>
461 Portals: some corrections.
463 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
465 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
466 constructor: Use getRelationshipNameUsed() instead of getName(), because
467 that is what is meant.
468 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
469 getFromField(): Fix a typo, to get the field name, not the table name.
470 * src/main/java/org/glom/web/server/database/DBAccess.java:
471 getPortal(): Fix a typo that stopped this from working.
473 2012-05-07 Murray Cumming <murrayc@murrayc.com>
475 LayoutItemPortal: Also override getTitleOriginal().
477 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
478 This lets the base getTitle() with no parameters work.
479 TODO: Test this properly.
481 2012-05-06 Murray Cumming <murrayc@murrayc.com>
483 LayoutItemPortal: getTitle*(): Use the relationship title.
485 2012-05-06 Murray Cumming <murrayc@murrayc.com>
487 LayoutItemField: Fix loading of custom titles.
489 * src/main/java/org/glom/web/server/libglom/Document.java
490 loadDataLayoutItemField(): The title, if any, instead of the field
491 title, is stored in a title_custom node. Load it from there.
492 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
494 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
495 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
496 getTitle*() overrides.
497 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
500 2012-05-06 Murray Cumming <murrayc@murrayc.com>
502 LayoutItemField: Fall back to field titles, so some are really shown.
504 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
505 Override getTitleOriginal() and getTitle(), as in java-libglom.
506 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
509 2012-05-06 Murray Cumming <murrayc@murrayc.com>
511 Correct use of setExpectedResultSize().
513 * src/main/java/org/glom/web/server/ConfiguredDocument.java
514 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
515 Use setExpectedResultSize only on top-level groups (for instance, the
516 list layout) or on child portals (in details views).
517 Use the correct table name for portals to avoid SQL errors.
518 Update the expected counts when returning cached layouts.
520 2012-05-06 Murray Cumming <murrayc@murrayc.com>
522 Document: Interpret no group column count as 1.
524 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
525 default, though we now check for this in the UI code anyway.
527 2012-05-06 Murray Cumming <murrayc@murrayc.com>
531 2012-05-06 Murray Cumming <murrayc@murrayc.com>
533 Translatable: Use Hashmap instead of Treemap because GWT supports it.
535 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
536 The use of Treemap lead to this error from async methods, with no
538 "The response could not be deserialized"
540 2012-05-06 Murray Cumming <murrayc@murrayc.com>
542 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
544 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
545 when using the Google -> GWT Compile, or
546 g toolbar button -> GWT Compile Project... feature in Eclipse.
548 2012-05-06 Murray Cumming <murrayc@murrayc.com>
550 ListTable.addColumn(): Protect against a null Formatting.
552 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
553 Create a default Formatting if it is null, because that is the simplest
556 2012-05-06 Murray Cumming <murrayc@murrayc.com>
558 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
560 * src/main/java/org/glom/web/server/ConfiguredDocument.java
561 updateLayoutGroup(): Check that the field is not null.
563 2012-05-06 Murray Cumming <murrayc@murrayc.com>
565 ListViewImpl: Protected against a bad cast error.
567 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
568 onEnterKeyDown(): Do not cast without an instanceof check.
570 2012-05-06 Murray Cumming <murrayc@murrayc.com>
572 ListTable: Protect against an out of range error.
574 * src/main/java/org/glom/web/client/ui/list/ListTable.java
575 createCellTable(): This is unlikely, but can happen while debugging.
577 2012-05-06 Murray Cumming <murrayc@murrayc.com>
579 AsyncMessage onFailure() callbacks: Log the exception message.
581 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
582 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
583 * src/main/java/org/glom/web/client/activity/ListActivity.java:
584 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
585 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
586 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
587 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
588 These are useful clues when something is wrong.
590 2012-05-06 Murray Cumming <murrayc@murrayc.com>
592 ConfiguredDocument: Avoid a null dereference.
594 * src/main/java/org/glom/web/server/ConfiguredDocument.java
595 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
596 details maps are created.
598 2012-05-06 Murray Cumming <murrayc@murrayc.com>
600 Document: Correct the port number parsing.
602 * src/main/java/org/glom/web/server/libglom/Document.java:
603 This lets us actually connect to the database and show the document.
605 2012-05-05 Murray Cumming <murrayc@murrayc.com>
609 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
610 user-interaction, asking us to load a temporary URL in a browser.s
611 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
612 which is apparently necessary for testing the service. See the comment.
613 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
614 Show the exception, if any. This is how I saw the 404 in the HTML in
617 2012-05-05 Murray Cumming <murrayc@murrayc.com>
619 DocumentTest: Move the .glom files into the resources directory.
621 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
622 URI via getResource().
624 2012-05-05 Murray Cumming <murrayc@murrayc.com>
626 Document: Remove the FieldIdentifies inner class.
628 * src/main/java/org/glom/web/server/libglom/Document.java: We only
629 use the Relationship (though the same function in libglom is maybe
630 used in other ways) and so this removes a compiler warning.
632 2012-05-05 Murray Cumming <murrayc@murrayc.com>
634 Document.load() Remove the error code parameter.
636 * src/main/java/org/glom/web/server/libglom/Document.java: load():
637 Remove the parameter. We do not set it yet and it could never have
638 worked as an output parameter (though maybe it did in java-libglom).
639 We could use an exception if we really want the failure reason.
640 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
642 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
643 setUp(), testGetSuitableTableToViewDetails(): Adapt.
645 2012-05-05 Murray Cumming <murrayc@murrayc.com>
647 Make some inner classes static.
649 * src/main/java/org/glom/web/server/ConfiguredDocument.java
650 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
651 * src/main/java/org/glom/web/server/ReportGenerator.java
652 * src/main/java/org/glom/web/server/libglom/Document.java
653 Make all inner classes static that can be static.
655 2012-05-05 Murray Cumming <murrayc@murrayc.com>
657 OnlineGlomServiceImpl: Do not load and check for java-libglom.
659 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
660 init(): We do not use java-libglom any more.
662 2012-05-05 Murray Cumming <murrayc@murrayc.com>
664 Remove mentions of java-libglom.
666 * README: Remove mention of java-libglom, because it no longer needed.
667 * utils/build-onlineglom-war.sh:
668 * utils/check-and-recover-tomcat.py:
669 * utils/install-onlineglom-war.sh: Remove these as they are no longer
670 useful. Building is now far easier, with no need for jhbuild.
672 2012-05-05 Murray Cumming <murrayc@murrayc.com>
674 Fix the build (mvn package)
676 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
677 (LayoutGroup): Make the LayoutItemList inner class static and protected.
678 Otherwise the GWT Java->Javascript compilation fails with just this
679 error, during mvn package or when attempting to view in a browser,
680 in the GWT developer mode in Eclipse.
682 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
683 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
684 [INFO] Compiling module org.glom.web.OnlineGlom
685 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
686 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
687 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
688 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
689 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
690 [INFO] [ERROR] Cannot proceed due to previous errors
692 It has taken me 2 days to find out what was causing that. After reducing
693 the code, the compiler eventually showed me the full error message.
695 2012-05-04 Murray Cumming <murrayc@murrayc.com>
697 ConfiguredDocument: Cache the cloned and stripped layouts.
699 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
700 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
701 layout in a map, so we can retrieve it again without rebuilding it.
703 2012-05-04 Murray Cumming <murrayc@murrayc.com>
705 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
707 2012-05-04 Murray Cumming <murrayc@murrayc.com>
709 libglom classes: Implement some auto-generated emthods.
711 2012-05-04 Murray Cumming <murrayc@murrayc.com>
713 Add GwtTestOnlineGlomService.
715 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
716 However, this (and the other GwtTest*) does not seem to run during
719 2012-05-04 Murray Cumming <murrayc@murrayc.com>
721 Remove use of unsupported features from client code.
723 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
724 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
725 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
726 Use our client version of StringUtils instead of the apache commons one.
728 However, the GWT Javascript compliation still fails.
730 2012-04-25 Murray Cumming <murrayc@murrayc.com>
732 Add a Field class and implement some loading of it in Document.
734 2012-04-25 Murray Cumming <murrayc@murrayc.com>
736 Initial Document loading implementation, instead of libglom.
738 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
739 and Translatable classes, and adapt the rest of the code to use them.
740 However, this is still missing Layout and Field classes and loading.
742 2012-04-24 Murray Cumming <murrayc@murrayc.com>
744 Use of jOOQ: Move Field creation into a utility method.
746 * src/main/java/org/glom/web/server/SqlUtils.java:
747 This lets us improve it more easily.
749 2012-04-24 Murray Cumming <murrayc@murrayc.com>
751 Use of jOOQ: Improve the code to COUNT a sub-select.
753 * src/main/java/org/glom/web/server/SqlUtils.java:
754 Move initial query creation into
755 build_sql_select_step_with_where_clause().
756 build_sql_select_count_rows(): Use the jOOQ API instead of
757 concatentating text, because a jOOQ Select*Step is a TableLike,
758 which is what from() takes.
760 2012-04-23 Murray Cumming <murrayc@murrayc.com>
762 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
764 * pom.xml: Depend on jooq.
765 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
766 methods with jOOQ, based on the C++ implementations in libglom,
767 with some changes to the logic required by jooQ.
768 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
770 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
771 * src/main/java/org/glom/web/server/ReportGenerator.java:
772 * src/main/java/org/glom/web/server/SqlUtils.java:
773 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
774 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
775 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
776 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
777 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
778 Adapt. In particular, the SqlUtils methods now need to take a Connection,
779 because jOOQ needs that, though it seems unnecessary.
781 This is not quite finished. Ideally jOOQ would help us to build
782 table_name.field_name names, quoting and escaping them properly.
783 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
785 2012-04-21 Murray Cumming <murrayc@murrayc.com>
787 Move use of Glom.build_sql*() into a new SqlUtils class.
789 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
790 to wrap Glom.build_sql*(). The parameter types are still Glom one,
791 but this will make it easier to start using something other than
792 libglom or SqlBuilder.
794 2012-04-21 Murray Cumming <murrayc@murrayc.com>
796 Update the project URL.
798 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
800 2012-04-21 Murray Cumming <murrayc@murrayc.com>
802 Main layout: Use a FlowTable instead of absolute positioning.
804 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
805 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
806 child panels/widgets must have an absolute position. But that is annoying, so
807 this adds a FlowTable and puts the child panels in there.
809 2012-04-21 Murray Cumming <murrayc@murrayc.com>
811 GwtTestOnlineGlom: Comment out unused code.
813 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
814 Eclipse has started to say that some code is unused.
816 2012-04-21 Murray Cumming <murrayc@murrayc.com>
818 Update to the latest versions of dependencies.
820 * pom.xml: Update version numbers of dependencies to the latest
822 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
823 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
824 * src/main/java/org/glom/web/server/ReportGenerator.java:
825 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
826 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
827 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
829 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
830 Modify the imports where necessary.
832 2012-04-17 Murray Cumming <murrayc@murrayc.com>
834 Style: Remove overflow:hidden from searchbox
836 * src/main/webapp/style.css: Because this pushes the Back To Link
837 label/link on to the next row, which is then hidden due to the
838 hard-coded (in ems) height.
840 2012-04-20 Murray Cumming <murrayc@murrayc.com>
842 Remove some duplicate code.
844 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
845 getDocumentInfo(): This must have been duplicated during the merge from the
850 2012-04-19 Murray Cumming <murrayc@murrayc.com>
852 Reports: Localize the waiting for report message.
854 * src/main/java/org/glom/web/client/activity/ReportActivity.java
855 start(): Get the message from the contants.
856 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
858 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
859 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
860 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
861 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
862 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
863 Update these files with the English text for newer strings for now.
865 2012-04-19 Murray Cumming <murrayc@murrayc.com>
867 Reports: Show a message while waiting for the report.
869 * src/main/java/org/glom/web/client/ui/ReportView.java
870 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
871 Add setWaitingText(), to show a message saying that we are
872 waiting for the report to be ready.
873 * src/main/java/org/glom/web/client/activity/ReportActivity.java
874 start(): Call setWaitingText() before calling the async
877 2012-04-19 Murray Cumming <murrayc@murrayc.com>
879 ReportGenerator: Specify date and time formats.
881 * src/main/java/org/glom/web/server/ReportGenerator.java:
882 createFieldValueElement(): Use the default (and localized)
883 short formats, though we still need a way to show 4-digit
884 years without providing the format for every locale.
885 * src/main/java/org/glom/web/server/database/DBAccess.java:
886 convertResultSetToDTO(): Use the short formats here too.
888 2012-04-18 Murray Cumming <murrayc@murrayc.com>
890 ReportGenerator: Use the correct numeric formatting.
892 * src/main/java/org/glom/web/server/ReportGenerator.java
893 createFieldExpression(), createFieldValueElement(): Take the
894 whole LayoutItem_Field instead of just the field name, so
895 we have access to the formatting.
896 createFieldValueElement(): Use JRTextField.setPattern() to
897 specify the numeric formatting, with the help of a
898 regular DecimalFormat.
900 2012-04-18 Murray Cumming <murrayc@murrayc.com>
902 ReportGenerator: Avoid showing null for group by titles.
904 * src/main/java/org/glom/web/server/ReportGenerator.java
905 generateReport(): Use setBlankWhenNull() on the field title
906 style too, because this is used for values in group by
909 2012-04-18 Murray Cumming <murrayc@murrayc.com>
911 ReportGenerator: Add a colon to titles in vertical groups.
913 * src/main/java/org/glom/web/server/ReportGenerator.java
914 addFieldToDetailBandVertical(): Pass true for the withColon
917 2012-04-18 Murray Cumming <murrayc@murrayc.com>
919 ReportGenerator: Simplify the code by using Position more.
921 2012-04-18 Murray Cumming <murrayc@murrayc.com>
923 Reports: Support vertical groups, roughly.
925 * src/main/java/org/glom/web/server/ReportGenerator.java:
926 addToReport(): Rename to addGroupToReport() and, if necessary,
927 call the new addVerticalGroupToReport() method.
928 createFieldValueElement(): Let the caller specify the Y position
931 2012-04-17 Murray Cumming <murrayc@murrayc.com>
933 Reports: Allow a second report to be shown.
935 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
936 clear(): Do not remove the HTML widget, which broke the whole layout.
938 2012-04-17 Murray Cumming <murrayc@murrayc.com>
940 Locales drop-down: Show that we use English by default.
942 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
943 fillView(): When we use English, just because that is the default, when
944 no locale is specified, show that in the Locales drop-down instead of
945 just showing the first item.
947 2012-04-17 Murray Cumming <murrayc@murrayc.com>
949 Unselect the Report/Locale/Table combo item when appropriate.
951 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
952 setPlace(): clear reportName if this is not a ReportPlace.
953 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
954 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
955 When the provided name is empty, unselect all items, so that none are
956 indicated. This uses a for loop because I cannot find a single method
959 2012-04-17 Murray Cumming <murrayc@murrayc.com>
961 Report: Give the user a way to get back to the list.
963 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
964 start(), setPlace(): Show the Back To List link on reports, and also
965 interpret selecting the empty report item as back to list.
967 2012-04-13 Murray Cumming <murrayc@murrayc.com>
969 Really show the selected Report name.
971 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
972 setPlace(): Store the reportName here, if it is that kind of Place.
973 fillView(): Set the selected Report after filling the list of reports.
974 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
975 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
976 null Strings, though we need some way to unselect all ListBox items
979 2012-04-13 Murray Cumming <murrayc@murrayc.com>
981 ReportGenerator: Try to avoid some problems.
983 * src/main/java/org/glom/web/server/ReportGenerator.java
984 addField(): Try to avoid duplicates, and avoid using a null
987 2012-04-13 Murray Cumming <murrayc@murrayc.com>
989 Reports: Use quickFind.
991 * src/main/java/org/glom/web/client/OnlineGlomService.java;
992 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
993 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
994 getReportHTML(): Add a quickFind parameter.
995 * src/main/java/org/glom/web/client/activity/ReportActivity.java
996 start(): Pass the quickFind parameter.
997 * src/main/java/org/glom/web/server/ReportGenerator.java
998 generateReport(): Take a quickFind parameter.
1000 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1002 ReportPlace: Actually use the report name.
1004 * src/main/java/org/glom/web/client/place/ReportPlace.java
1005 getPlace(): Do not assign the report name to the quickfind.
1007 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1009 Show java.library.path when complaining.
1011 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1012 init(): When telling us to check java.library.path, show the
1015 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1017 ReportGenerator: Do not show nulls.
1019 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1021 ReportGenerator: Make the title font larger.
1023 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1025 ReportGenerator: Put field titles inside groups, if there are groups.
1027 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1029 ReportGenerator: Take the Report itself instead of the name and group.
1031 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1032 Remove getReportLayoutGroup().
1033 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1034 getReportHTML(): Pass the report instead
1035 of its name and layout group.
1036 * src/main/java/org/glom/web/server/ReportGenerator.java
1037 generateReport(): Use the report object to use the title
1038 instead of the name.
1040 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1042 ReportGenerator: Remove designBand parameters.
1044 * src/main/java/org/glom/web/server/ReportGenerator.java:
1045 Make designBand a class member instead of passing it to all
1048 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1050 ReportGenerator: Add lines, a bit like in the desktop version.
1052 * src/main/java/org/glom/web/server/ReportGenerator.java
1053 addToReport(): Use JRDesignLine.
1055 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1057 ReportGenerator: Correct the title positions and use some bold style.
1059 * src/main/java/org/glom/web/server/ReportGenerator.java:
1060 Break the code up into reusable functions, correct the placement of
1061 titles, and use normal/bold styles as in the reports in the desktop
1064 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1066 ReportGenerator: Add a header band to show the field titles.
1068 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1069 getReportHTML(): Pass the localeId to the ReportGenerator
1071 * src/main/java/org/glom/web/server/ReportGenerator.java
1072 constructor: Take the localeID so we can get translated field
1074 generateReport(), addToReport(), addFieldToBand(): Add field
1075 titles in a column header band.
1077 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1079 Reports drop-down list: Some improvement.
1081 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1082 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1083 Adedd setSelectedReport(),
1084 setReportList(): Add a blank line so that the user can select the
1086 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1087 start(): Show the current report by calling setSelectedReport().
1088 This does not seem to work yet.
1090 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1092 DetailsActivity, ListActivity: Move some variables into a base class.
1094 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1095 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1096 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1097 the clientFactory, documentID, tableName and authenticationPopup into
1098 a base class, to avoid duplication.
1100 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1102 Translate the Reports label.
1104 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1105 Get the "Reports" label string from the constants.
1106 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1107 perties: Add Reports to the constants.
1109 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1111 Reports: Implement grouping.
1113 * src/main/java/org/glom/web/server/ReportGenerator.java:
1114 Handle LayoutItem_GroupBy items and try to do the right thing
1115 with JRDesignGroup. It seems to work.
1117 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1119 Actually show some data with JasperReports.
1121 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1122 getReportHTML(): Move most code into a ReportGenerator class.
1123 * src/main/java/org/glom/web/server/ReportGenerator.java:
1124 Recurse into sub-groups, adding fields to the JasperDesign's details
1125 band. Note that we must set an arbitrary width and height, or it just
1126 will not show any data.
1128 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1130 Reports Chooser: Show the titles, not the names.
1132 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1133 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1134 and the names as the values.
1135 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1136 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1137 group now that we provide the report name, so it should always
1140 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1142 Depend on jasperreports.
1144 * pom.xml: Add the dependency. My plan is to use this on the
1147 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1149 Implement navigation to report places.
1151 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1152 start(): Do not bother to handle all events here.
1153 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1154 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1155 Added getSelectedReport().
1156 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1157 .java: start(): When handling a change to the reports chooser,
1158 call getSelectedReport() and goTo() its ReportPlace.
1159 * src/main/java/org/glom/web/client/ui/ReportView.java
1160 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1161 Added setReportHTML() which puts the html in a gwt HTML widget.
1162 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1163 getReportHTML(): Return "TODO" just to show that this works.
1165 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1167 Make ReportPlace usable.
1169 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1170 Mention ReportPlace.
1171 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1172 Correct the @prefix annotation.
1174 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1176 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1178 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1179 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1180 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1181 Change getReportLayout() to getReportHMTL() because we will not need to
1182 parse or render the report layout on the client side.
1183 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1184 getReportLayout(): Return the libglom LayoutGroup type because we will
1185 not need to convert to a shared type, because this will not be used on
1187 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1190 Note that there is still no implementation for this.
1193 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1195 Add a (empty) Report Place, View, and Activity.
1197 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1199 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1200 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1201 this into a superclass:
1202 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1203 and also use it as the base of this new ReportPlace:
1204 * src/main/java/org/glom/web/client/place/ReportPlace.java
1206 * src/main/java/org/glom/web/client/ui/ReportView.java
1207 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1208 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1209 Add these, containing mostly boiler-plate for now.
1211 * src/main/java/org/glom/web/client/OnlineGlomService.java
1212 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1213 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1214 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1215 Add API to get the LayoutGroup for the report.
1217 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1219 Add and fill a Reports drop-down list box.
1221 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1223 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1224 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1225 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1226 Added getReports(document, table, localeID), calling
1227 ConfiguredDocument.getReports().
1228 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1229 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1230 Added setReportsList() and a list widget.
1231 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1232 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1237 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1239 Translations: Add Esperanto.
1241 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1242 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1243 properties: Add this translation because someone took the time to make it.
1245 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1247 Adapt to the java-libglom 1.21.7 API.
1249 * src/main/java/org/glom/web/server/ReportGenerator.java:
1250 addToReport(): get_group_secondary_fields() is now
1251 get_secondary_fields().
1254 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1256 Use the latest java-libglom version.
1258 * pom.xml: Use java-libglom 1.21.7.
1260 2012-03-03 Ben Konrath <ben@bagu.org>
1262 Display date and time in details view.
1264 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1266 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1268 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1270 Require the latest java-libglom.
1272 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1274 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1276 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1278 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1279 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1280 an empty quickfind string. I also corrected libglom to create only
1281 empty where clauses for empty quickfind strings, but this avoids the
1284 2012-02-24 Ben Konrath <ben@bagu.org>
1286 Improve the tabs in the Notebook widget.
1290 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1292 Translations: Try to translate the strings.
1294 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1295 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1296 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1297 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1298 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1299 Take the Open translation from GTK+'s .po files.
1300 Take the Details translation from Glom's po files.
1301 I have added the other strings to Glom so we can get translations that way:
1302 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1304 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1306 TableSelectionViewImpl: Put the search label and entry in a div.
1308 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1309 Put the search widgets in a FlowTable so that the CSS can be used to
1310 style them while keeping them together.
1311 * src/main/webapp/style.css: Mention the new div.
1313 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1315 Translate more strings in more locales.
1317 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1318 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1319 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1320 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1321 Translate the "Details" and "Open" string too.
1323 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1324 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1325 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1326 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1327 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1328 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1329 Add these new locales as placeholders though they currently contain English.
1331 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1333 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1335 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1336 Check the ConfiguredDocument* for null before using it.
1338 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1340 Tell Eclipse about the generated java files.
1342 * .classpath: This lets it find OnlineGlomConstants.java.
1343 It would be nice if Eclipse just used the maven build files.
1345 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1347 Prevent a crash when no locale is specified in the URL.
1349 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1350 Avoid returning a null string, obtained from
1351 Window.Location.getParameter(). This caused a crash when it was
1352 later passed to libglom's API.
1353 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1354 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1355 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1356 guard against future null strings.
1358 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1360 Use the ?locale= query param instead of the &lang= token param.
1362 * src/main/java/org/glom/web/client/place/ListPlace.java
1363 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1364 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1365 Remove the lang token key and value.
1367 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1368 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1369 When the user selects a different locale from the chooser, use
1370 Window.Location.assign() to change the URL, which then causes a reload.
1372 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1373 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1374 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1375 * src/main/java/org/glom/web/client/activity/ListActivity.java
1376 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1377 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1378 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1379 * src/main/java/org/glom/web/client/ui/ListView.java:
1380 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1382 Remove localeID member variables and method/constructor parameters, instead
1383 using Utils.getCurrentLocaleID() when we need a localID to pass to
1386 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1388 Internationalize the UI strings.
1390 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1391 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1392 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1393 because it is unused. Messages are apparently strings that can have
1394 parameters, but we do not need that yet, so Contants will be enough for now.
1395 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1396 to say that we support the en and de locales.
1397 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1398 The original English strings.
1399 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1400 Some German translations of the English strings.
1401 The i18n goal then uses the .properties file to generate an
1402 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1403 returns an implementation that returns the translated strings.
1404 The documentation suggests putting these in src/java/*/client/, but it seems
1405 best to put it in src/resources/*/client/.
1406 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1407 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1408 instead of hard-coding them.
1409 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1410 but that does not seem to stop the build, though it confuses Eclipse.
1412 You can see the translated string by adding ?locale=de to the URL, like so:
1413 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1415 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1417 Improve null/empty String checks.
1419 * pom.xml: Add a dependency on commons-lang, to use
1420 org.apache.commons.lang.StringUtils.
1421 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1422 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1423 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1424 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1425 Use StringUtils.isEmpty().
1427 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1428 StringUtils class with a static isEmpty() function because we
1429 cannot use org.apache.commons.lang.StringUtils in client-side
1430 GWT code because it (apparently) cannot be compiled to javascript.
1431 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1432 * src/main/java/org/glom/web/client/activity/ListActivity.java
1433 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1434 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1435 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1436 * src/main/java/org/glom/web/client/place/ListPlace.java
1437 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1438 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1439 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1440 * src/main/java/org/glom/web/client/ui/details/Group.java
1441 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1442 our StringUtils.isEmpty() function.
1444 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1446 Update to the latest java-libglom API.
1448 * pom.xml: Require java-libglom 1.21.4.
1449 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1450 getDocumentInfo(), getListViewLayoutGroup():
1451 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1453 * src/main/java/org/glom/web/server/database/DBAccess.java
1454 getFieldsToShowForSQLQueryAddGroup(),
1455 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1456 with either get_database_title_original() or
1457 get_database_title(localeID).
1459 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1461 ConfiguredDocument: Avoid a null pointer exception.
1463 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1464 Initialize localeID to "" to avoid returning a null String which
1465 causes a crash in java-libglom's swing-generated code.
1467 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1469 Some simple renaming.
1471 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1472 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1473 for localeChooser. This seems more appropriate and is less ambiguous
1474 particularly in the .css file.
1476 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1478 ConfiguredDocument: Rename the localedID private member variable.
1480 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1482 Adapt to the latest java-libglom API from git master.
1484 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1485 libglom now uses only Vector instead of List, which uses add() instead of
1488 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1490 ConfiguredDocument: Rename the localedID private member variable.
1492 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1494 Build a source tarball with mvn assembly:single
1496 * assembly.xml: Add this file.
1497 * pom.xml: Use the maven-assembly-plugin and tell it to use
1498 our assembly.xml file.
1500 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1502 OnlineGlomServiceImpl: Get .glom files recursively.
1504 * pom.xml: Depend on commons-io from org.apache.commons.
1505 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1506 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1507 files recursively, and with the easier filter for the extension.
1508 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1509 simplify that code too.
1511 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1513 README: Mention that you must install java-libglom packages separately.
1515 But then it works, because java-libglom is now in the central maven
1518 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1520 locales drop-down: Show the correct selected locale when the URL changes.
1522 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1523 .java: setPlace(): Move some code into fillView().
1525 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1527 locales drop-down: Do not lose the primary key.
1529 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1530 start(): onLocaleChange(): Pass the current primary key value,
1531 instead of an empty value.
1533 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1535 locales drop-down: Do not lose the drop-down selection.
1537 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1538 .java (TableSelectionActivity.fillView): Set the selected locale
1539 after changing the drop-down items (though we do not really need
1540 to change them just because the locale changes.)
1542 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1544 locales drop-down: Change the tables list when this changes.
1546 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1547 .java: TableSelectionActivity.start(): Move the async table titles
1548 retrieval into a private fillView() method and also call this when
1549 the chosen locale changes.
1550 Note that the document title is not actually translatable yet, but
1551 that is a problem that I should fix soon in libglom.
1553 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1555 Improve the placement of the locales drop-down.
1557 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1558 Put the title and locales drop-down in a div (gwt.FlowTable).
1559 * src/main/webapp/style.css: Add magic css properties to make this work.
1560 Also remove the left margin from the title so that it lines up with the
1563 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1565 locales selector: Show human-readable locale titles.
1567 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1568 getDocumentInfo(): Use java.util.Locale to show a real title of
1569 each locale, in the locale's own language.
1571 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1573 Add a language/locale selector drop-down.
1575 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1576 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1577 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1578 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1579 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1580 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1581 Add a ListBox to show the available locales. Add getLocaleSelector(),
1582 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1583 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1584 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1585 java: Add these classes.
1586 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1587 start(): Fill the locales ListBox. Handle its change event, firing a
1589 setPlace(): Show the selected locale as specified by the URL token.
1590 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1591 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1592 Handle LocaleChangeEvent, going to a new *Place with that locale.
1594 The placement of the ListBox is not pretty, and it currently uses the ID
1595 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1599 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1601 Search box: Show the search text from the URL token.
1603 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1604 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1605 Add setQuickFindText().
1606 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1607 .java: setPlace(): Store the queryText if the place is a ListPlace,
1608 and call TableSelectionView.setQuickFindText().
1610 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1612 Allow use of translations via, for instance, &lang=de in the URL.
1614 * pom.xml: Use the unstable java-libglom 1.21 version.
1616 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1617 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1618 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1619 init(): Instead of calling TranslatableItem.set_current_locale()
1620 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1621 However, this is only for default locales, which are not needed to
1622 change the locale in the URL.
1623 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1624 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1625 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1626 layout for a particular locale.
1627 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1628 Add get/setDefaultLocaleID().
1629 getDocumentInfo(), getListViewData(), getRelatedListData(),
1630 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1631 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1632 localeID parameter, so we can get the layout for a particular locale.
1634 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1635 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1636 * src/main/java/org/glom/web/client/place/ListPlace.java:
1637 Parse and construct a lang parameter too.
1639 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1640 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1641 passed to subsequent methods and constructors.
1642 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1643 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1644 Store the localeID from the *Place and pass it to other constructors
1645 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1647 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1648 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1649 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1650 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1651 * src/main/java/org/glom/web/client/ui/ListView.java:
1652 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1653 Take localeID parameters and pass them to subsequent constructors and
1654 methods, so that the layout is always retrieved for that locale.
1656 This is rather repetitive.
1658 Note that "" means the original (default) locale of the Glom document,
1659 which is usually English.
1661 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1663 Documents: Remove final keyword to fix startup configuration.
1665 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1666 final keywords on the private member variables because that breaks
1667 the startup, apparently (there are warnings) because it stops them
1668 from being serialized. I added these in the previous commit.
1670 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1672 Documents: Add some final keywords.
1674 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1677 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1679 OnlineGlomServiceImpl: Add to overview comments.
1681 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1682 Note that this is where all the document are loaded. They are not
1683 loaded freshly for each page.
1685 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1689 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1690 Add a TextBox for the text of a quick find.
1691 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1693 setBackLink(): Add a String quickFind parameter.
1694 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1695 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1696 to the base interface, because that is how TableSelectionViewImpl is used.
1697 * src/main/webapp/style.css: Add style for the search box and its label.
1699 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1700 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1701 Add these files, based on the existing TableChangeEvent and
1702 TableChangeEventHandlers.
1703 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1704 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1705 a ListPlace() that the user should be taken to.
1706 * src/main/java/org/glom/web/client/activity/ListActivity.java
1707 start(): Handle it here too and adapt the TableChangeEvent handler to
1708 pass the extra "" quickFind parameter to ListPlace.
1709 * src/main/java/org/glom/web/client/place/ListPlace.java:
1710 Constructor: Take an extra String quickFind parameter and store it,
1711 returning it from a new getQuickFind() method.
1712 getToken(): Put the quickFind text in the URL token.
1713 getPlace(): Parse the quickFind text from the URL token.
1714 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1715 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1716 ListPlace constructor.
1717 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1718 .java: start(): Add a Change handler for the TableSelectionView's
1719 TextBox (via its base HasChangeHandlers interface), firing the new
1720 QuickFindChangeEvent.
1721 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1722 pass the extra "" quickFind parameter.
1724 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1725 setCellTable(): Add a String quickFind parameter and pass it to
1726 the ListViewTable() constructor.
1727 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1728 setCellTable() in the base interface, because that is how ListViewImpl
1731 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1732 Add a String quickFind member variable.
1733 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1734 Constructor: Add a String quickFind parameter, storing it in the
1735 base ListTable's member variable.
1736 onRangeChanged(): Pass quickFind to the
1737 OnlineGlomServiceAsync.getSortedListViewData() and
1738 OnlineGlomServiceAsync.getListViewData() methods.
1740 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1741 getListViewData(), getSortedListViewData(): Add a String quickFind
1742 parameter, passing it to ConfiguredDocument.getListViewData().
1743 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1744 Change getListViewData(), getSortedListViewData() in the base interface,
1745 because that is how OnlineGlomServiceImpl is used, via this:
1746 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1747 Change getListViewData(), getSortedListViewData() here too.
1748 This class can apparently be used to asynchronously call methods on
1749 OnlineGlomService, and GWT seems to implement that after recognizing
1750 just the *Async name convention and the extra AsyncCallback parameters.
1752 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1753 getListViewData(): Add a String quickFind parameter, and pass it to
1754 ListViewDBAccess.getData().
1755 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1756 getListData(): Add a String quickFind parameter and pass it to
1758 getSelectQuery(): Add a String quickFind parameter.
1759 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1760 getSelectQuery(): Add a String quickFind parameter and use it with
1761 Glom.get_find_where_clause_quick() to pass a where_clause to
1762 Glom.build_sql_select_with_where_clause(), to actually filter the
1764 getData(): Add a String quickFind parameter, passing it to getListData().
1765 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1766 va: getData(): Pass an empty string to getListData() for the
1767 quickFind parameter.
1769 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1771 ListTable: Minor change.
1773 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1774 createCellTable(): Make this protected instead of public.
1776 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1778 Many files: Use final for the parameters and use the @override attribute.
1780 2012-01-22 Ben Konrath <ben@bagu.org>
1782 Add anchor links for single line text that starts with http, ftp and www.
1786 2012-01-22 Ben Konrath <ben@bagu.org>
1788 Add ellipsis to single line text in details view.
1792 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1794 Remove all javadoc author tags.
1796 Because they are awkward and meaningless when many people touch
1798 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1800 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1802 Revert the COPYING.LESSER to COPYING rename.
1804 Apparently both should be there if it is LGPL.
1806 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1808 *View: Remove unused imports.
1810 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1811 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1812 * src/main/java/org/glom/web/client/ui/ListView.java:
1813 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1814 Remove unused imports, as suggested by Eclipse.
1816 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1818 Move the *View::Presenter types, and some API into one base View.
1820 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1821 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1822 * src/main/java/org/glom/web/client/ui/ListView.java:
1823 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1824 Presenter, setPresenter() and clear() into a shared base interface,
1825 to avoid the unnecessary duplicate Presenter types and to more clearly
1826 show how the *Views share the same structure, even if they are not
1827 used polymorphically.
1829 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1830 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1832 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1833 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1834 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1836 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1839 Feel free to revert this if there is a good reason for the duplicate
1842 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1844 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1846 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1847 a class member instead of a local variable in the method.
1848 This lets us use it to get the view instances, for use in tests.
1849 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1850 beforeOnlineGlom(): Test some more details of the initial view.
1851 Again, this is not very useful.
1853 To really test gwt-glom we will need to start a local postgresql
1854 instance with local data, like the Glom tests in C++.
1856 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1858 pom.xml: Mention the LGPL license.
1860 * pom.xml: Add a licenses section.
1861 * COPYING.LESSER: Move this to COPYING, which
1862 previously contained the GPL. But gwt-glom is all LGPL.
1864 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1866 Add project information to README and pom.xml.
1868 * README: Add a brief description and mention some mvn
1870 * pom.xml: This extra information shows up in mvn site
1873 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1875 Use the latest java-libglom version.
1877 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1879 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1881 GwtTestOnlineGlom: Test a little more.
1883 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1884 protected rather than private, as suggested by the gwt-test-utils
1886 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1887 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1888 Test the initial visibility of the panels.
1890 However, this is not a very useful test.
1891 And I wonder how we should generally test using this idea for an
1892 activity/places app like ours where the real changes happen implicitly
1893 based on the history token/URL.
1895 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1897 Slight modification to *Mapper comments.
1899 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1900 (DataActivityMapper)
1901 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1903 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1905 Remove comments mentioning GIN because they are just copied from
1906 the example code and are apparently not helpful:
1907 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1908 Also change the mention of a class that is only in the example code.
1910 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1912 GwtTestOnlineGlom test: Minor changes.
1914 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1915 Avoid the long qualified class name and modify the comment
1916 because it is now obvious to me that the mocked class is the only
1917 custom one created via GWT.create().
1919 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1921 Tests: Added the beginnings of a test using gwt-test-utils.
1923 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1924 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1925 which tells gwt-test-utils what class will be tested.
1926 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1927 Add a simple (but empty) test case. One class, used by the OnlineGlom
1928 class, is mocked so that it can be created. However, I am not sure
1929 why only this class needs to be mocked.
1931 Note that mockito seems more popular, and clearer, than easymock,
1932 but I have not got that working yet. It might be a matter of the
1935 This test is run during mvn integration-test.
1937 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1939 Tests: Use junit4-style syntax instead of junit3-style.
1941 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1942 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1943 * src/test/java/org/glom/web/shared/DataItemTest.java:
1944 Use the @Test annotation rather than relying on the test*() prefix.
1945 Also no longer implement TestCase, to avoid triggering support for
1946 the junit3-way, which stops the annotations from working.
1947 Change the imports from import junit.framework.* to
1948 import org.junit.*, which is apparently the new way.
1950 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1952 Added a test for ListPlace token parsing and creation.
1954 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1955 This is much the same as DetailsPlaceTest.
1957 I wonder how we could test the other parts of the *Place API.
1959 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1961 DetailsPlace test: Also test getToken() and recreation via getPlace().
1963 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1964 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1965 recreate it, testing the recreated DetailsPlace for the same parameter
1968 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1970 Use the surefire-report plugin.
1972 * pom.xml: This generates a HTML report about the tests in
1973 target/site/surefire-report.html
1974 when you do mvn surefire-report:report. It seems to be popular/normal.
1976 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1978 Added a test for DetailsPlace.
1980 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1981 Test the getPlace() token parsing.
1983 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1985 Added a first unit test.
1987 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1988 * src/test/java/org/glom/web/shared/DataItemTest.java:
1989 This is a silly test but it is just to get things started. Note that
1990 maven/junit finds the test because it looks in src/test by default.
1992 2011-12-22 Ben Konrath <ben@bagu.org>
1994 Change charsetName to "UTF-8" when replacing line breaks.
1996 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1997 that work in Java (such as "UTF8") will not work when compiled to
2000 This fixes a problem with multi-line details view fields that have hard
2001 line breaks. The "License Text" field on this page demonstrates the
2004 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2006 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2008 2011-12-22 Ben Konrath <ben@bagu.org>
2010 Fix another bug with related list navigation.
2012 I've tested all the navigation buttons in all of the related lists
2013 so things should be good now.
2015 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2017 2011-12-22 Ben Konrath <ben@bagu.org>
2019 Fix a crasher when refreshing the list view with the default table.
2021 This crash will also happen when loading the list view with the default
2022 table from a link or bookmark.
2024 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2025 to the main document selection page when the document id hasn't been
2027 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2028 the main document selection page when the document id hasn't been
2030 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2031 values for the details place when the document id hasn't been set.
2032 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2033 values for the list place when the document id hasn't been set.
2035 2011-12-21 Ben Konrath <ben@bagu.org>
2037 Protect against NPE when glom.document.locale is not in config.
2039 This patch protects against an NPE when glom.document.locale is not in
2040 the config file. This NPE will also happen if glom.document.locale is
2043 The patch also updates the error message to display the class name when
2044 the getMessage() returns null. This was happening when the NPE was
2045 thrown and I had "Configuration Error: null". If an NPE is encountered
2046 with this patch, "Configuration Error: NullPointerException " will be
2049 This commit closes this bug:
2051 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2053 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2055 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2057 Rename onlineglom.properties to onlineglom.properties.sample.
2059 * src/main/resources/onlineglom.properties: Rename to:
2060 * src/main/resources/onlineglom.properties.sample:
2061 * src/main/resources/README: And add this file explaining that people
2062 should rename it back when deploying.
2064 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2066 Allow choosing the translation in the .properties file.
2068 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2069 init(): Read a glom.document.locale value from the configuration file
2070 and call Glom's TransatableItem::set_current_locale() method.
2071 * src/main/resources/onlineglom.properties: Add a commented-out
2072 example of this new setting.
2074 It would be better to add &lang=de_DE to the URL, but the current
2075 libglom API does not allow us to do this easily. I am working on that.
2077 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2079 Avoid a crash in parsing of token parameters.
2081 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2082 ava: getTokenParams(): Do not crash if a parameter has a key but no
2083 value, and ignore parameters with neither.
2085 2011-12-17 Murray Cumming <murrayc@murayc.com>
2087 History token building/handling: Improve use of token parameters.
2089 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2090 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2091 and buildParamsToken(HashMap), for use by derived classes.
2092 Make the separator private because it is no longer be needed.
2093 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2094 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2095 instead of manual string concatenation.
2096 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2097 of hardcoded indices and awkward splitting code.
2098 * src/main/java/org/glom/web/client/place/ListPlace.java
2099 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2100 instead of manual string concatenation.
2101 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2102 of hardcoded indices and awkward splitting code.
2103 This should fix bug #666420
2105 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2107 Fix a Navgiation->Navigation typo in the code.
2109 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2110 Rename processNavgiation() to processNavigation().
2112 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2114 Fix a seperator->separator typo in the code.
2116 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2117 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2118 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2121 2011-12-15 Ben Konrath <ben@bagu.org>
2123 Cleanup some comments.
2125 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2127 2011-12-14 Ben Konrath <ben@bagu.org>
2129 Replace \n with <br/> for multiline text in the details view.
2131 Vertical scrollbars are added when needed as well.
2133 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2135 2011-12-14 Ben Konrath <ben@bagu.org>
2137 Specify the font for document selection links.
2139 * src/main/webapp/style.css:
2141 2011-12-14 Ben Konrath <ben@bagu.org>
2143 Fix bouncy CellTable while paging.
2145 This doesn't currently work with related list tables in unselected
2148 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2150 2011-12-14 Ben Konrath <ben@bagu.org>
2152 Revamp the appearance of the document selection page.
2154 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2155 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2156 * src/main/webapp/style.css:
2158 2011-12-13 Ben Konrath <ben@bagu.org>
2160 Set navigation button column to the smallest size possible.
2162 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2164 2011-12-13 Ben Konrath <ben@bagu.org>
2166 Change OpenButton nomenclature to NavigationButton.
2168 Using NavigtionButton makes things more generic. Classes, methods and
2169 variables have been changed.
2171 This is a rename-only refactor.
2173 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2174 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2175 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2176 Renamed from OpenButtonCell.
2177 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2178 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2179 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2181 2011-12-12 Ben Konrath <ben@bagu.org>
2183 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2185 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2186 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2187 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2188 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2190 2011-12-12 Ben Konrath <ben@bagu.org>
2192 Update variable names and comments.
2194 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2195 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2197 2011-12-12 Ben Konrath <ben@bagu.org>
2199 Properly initialize numNonEmptyRows variable to zero.
2201 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2202 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2204 2011-12-05 Ben Konrath <ben@bagu.org>
2206 Add latest mockup with HTML tables.
2208 Features of this mockup:
2210 -> HTML table for flowtable
2211 -> HTML table for flowtable column
2212 -> Example of how related lists would look
2213 -> Not using text entries for data items
2215 The current version of Online Glom doesn't use HTML tables for the
2218 This mockup has been sent to the glom-devel mailing list but it's good
2219 to have it here as well.
2221 * mockups/details-view-html-tables.html:
2223 2011-12-05 Ben Konrath <ben@bagu.org>
2225 Remove unnecessary getPrimaryKeyField() method.
2227 getPrimaryKeyFieldForTable(String) has been renamed to
2228 getPrimaryKeyField(String).
2230 * src/main/java/org/glom/web/server/database/DBAccess.java:
2231 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2232 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2234 2011-12-05 Ben Konrath <ben@bagu.org>
2236 Add string representation of TypedDataItem value to conversion error message.
2238 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2239 message was extracted into its own method to avoid duplication.
2241 2011-12-05 Ben Konrath <ben@bagu.org>
2243 Add type checking to navigation primary key value creation.
2245 Create navigation primary key only if the expected type from the Glom
2246 document matches the type returned by the SQL query.
2248 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2250 2011-12-05 Ben Konrath <ben@bagu.org>
2252 Rename a couple of variables in RelatedListNavigation.
2254 This is a rename-only refactor.
2256 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2258 2011-12-05 Ben Konrath <ben@bagu.org>
2260 Move getListLayoutGroup() into getListViewLayoutGroup().
2262 This removes getListLayoutGroup(). It was only being called by
2263 getListViewLayoutGroup().
2265 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2267 2011-12-05 Ben Konrath <ben@bagu.org>
2269 Remove check for LayoutItem_Portal in list table method.
2271 This check is no longer necessary because the method isn't being used
2272 to create the LayoutItemPortal DTO.
2274 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2276 2011-12-05 Ben Konrath <ben@bagu.org>
2278 Properly support related list navigation.
2280 Navigation from the "Repository Analyzer -> Package Scans ->
2281 Dependencies" related table wasn't working because the primary key for
2282 related tables wasn't being set properly. This commit fixes the
2285 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2286 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2287 doesn't set the primary key properly for related list tables.
2288 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2289 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2290 useful for getting the primary key for list view tables and for related
2292 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2293 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2294 Move code to set the primary key for the table from the abstract
2295 ListDBAccess class to ListViewDBAccess as it's only correct for list
2297 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2298 Properly add primary key to related list tables.
2300 2011-12-02 Ben Konrath <ben@bagu.org>
2302 Properly set the horizontal alignment of fields.
2304 This fix is for both the list tables and the details view.
2306 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2307 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2308 to set the horizontal alignment of fields.
2310 2011-12-02 Ben Konrath <ben@bagu.org>
2312 Display currency codes in the details view.
2314 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2316 2011-12-02 Ben Konrath <ben@bagu.org>
2318 Avoid duplicate JNI call.
2320 JNI is not as efficient as pure Java and this is an easy (and small)
2323 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2324 Use previously retrieved value for whereClauseToTableName instead of
2327 2011-12-02 Ben Konrath <ben@bagu.org>
2329 Rename a couple of variables in RelatedListNavigation.
2331 This is a rename-only refactor.
2333 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2335 2011-12-02 Ben Konrath <ben@bagu.org>
2337 Indicate clearly that a mismatched primary key type is a bug.
2339 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2340 warning to error. Add 'This is a bug.' to message.
2342 2011-12-02 Ben Konrath <ben@bagu.org>
2344 Update / fix some comments.
2346 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2348 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2350 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2351 Fix comments. Add some TODOs.
2353 2011-12-02 Ben Konrath <ben@bagu.org>
2355 Enable navigation to details view with string primary key from related list.
2357 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2358 Create a text primary key value when return type of result is
2359 java.sql.Types.VARCHAR.
2361 2011-12-02 Ben Konrath <ben@bagu.org>
2363 Use checkboxes for booleans in the details view.
2365 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2367 2011-12-01 Ben Konrath <ben@bagu.org>
2369 Improve performance of related list height calculation.
2371 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2372 Put code to calculate the expected height in a static initializer so
2373 that that it's only called once.
2375 2011-12-01 Ben Konrath <ben@bagu.org>
2377 Show related list tables in notebooks (again).
2379 Calculate the height of the related list tables so the Notebook can be
2380 set the correct height. The height of the related list table is also needed by
2381 FlowTable to be able decide how to create the layout.
2383 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2384 and set the Portal height based on the height of the related list
2385 table and the Portal container.
2386 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2387 Add method to calculate the height of the related list tables.
2388 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2389 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2390 calculate the height of the Pager widget.
2392 2011-12-01 Ben Konrath <ben@bagu.org>
2394 Use CellTable API for table property instead of setting style on Element.
2396 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2398 2011-12-01 Ben Konrath <ben@bagu.org>
2400 Make ListViewTable and RelatedListTable a consistent height.
2402 The tables are now a consistent height regardless of the contents of
2403 the table. A hidden button is added to empty rows to ensure that the
2404 height of these rows will match the height of rows with data.
2406 A navigation button column is now added to every table. The width of
2407 the navigation column is set to 0px when a RelatedListTable shouldn't
2408 have navigation buttons. This maintains the a consistent row height in
2409 tables that don't show the navigation buttons.
2411 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2412 navigation column when not needed.
2413 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2414 arguments for navigation button to constructor of ListViewTable.
2415 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2416 hidden button for empty data rows.
2417 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2418 arguments for navigation button to constructor.
2419 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2420 create navigation buttons. Add hideNavigationButtons() method.
2421 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2422 arguments for navigation button to constructor.
2424 2011-12-01 Ben Konrath <ben@bagu.org>
2426 Use 'visibility: hidden' in Utils.getWidgetHeight().
2428 This is better choice because hidden elements are invisible, don't
2429 respond to events and are not part of the tab order. They will,
2430 however, take up space which is required to be able to calculate the
2431 height of the widget.
2433 * src/main/java/org/glom/web/client/Utils.java:
2435 2011-12-01 Ben Konrath <ben@bagu.org>
2437 Use Utils.getWidgetHeight() in FlowTable.
2439 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2441 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2443 2011-12-01 Ben Konrath <ben@bagu.org>
2445 Put the details css class name on the correct table column.
2447 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2449 2011-11-30 Ben Konrath <ben@bagu.org>
2451 Update for java-libglom API change.
2453 The getters and setters on FieldFormatting and NumericFormat were
2454 changed to remove the 'M'.
2456 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2458 2011-11-29 Ben Konrath <ben@bagu.org>
2460 Only allow RelatedListTables in Portals.
2462 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2464 2011-11-29 Ben Konrath <ben@bagu.org>
2466 Only create a contents panel for Portals when title is being set.
2468 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2470 2011-11-29 Ben Konrath <ben@bagu.org>
2472 Set TabLayoutPanel height based on calculated height its widgets.
2474 This is a potential fix for this bug:
2476 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2478 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2480 2011-11-29 Ben Konrath <ben@bagu.org>
2482 Align details field labels and data with the Open buttons.
2484 * src/main/webapp/style.css:
2486 2011-11-29 Ben Konrath <ben@bagu.org>
2488 Remove unnecessary <div> in the Notebook widget.
2490 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2491 method to get container FlowPanel (<div>).
2492 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2493 initWidget() method directly on the TabLayoutPanel widget instead of
2494 Group's container widget.
2496 2011-11-29 Ben Konrath <ben@bagu.org>
2498 Don't add group titles for Portals in Notebooks.
2500 This reverts the previous patch and fixes a bug I introduced with
2501 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2503 * src/main/java/org/glom/web/client/ui/details/Group.java:
2504 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2506 2011-11-28 Ben Konrath <ben@bagu.org>
2508 Remove unused boolean argument in Portal constructor.
2510 Just a code cleanup.
2512 * src/main/java/org/glom/web/client/ui/details/Group.java:
2513 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2515 2011-11-28 Ben Konrath <ben@bagu.org>
2517 Remove hack for glom 1.18 style glom files.
2519 * src/main/java/org/glom/web/client/ui/details/Group.java:
2520 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2521 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2523 2011-11-28 Ben Konrath <ben@bagu.org>
2525 Use Gda Value version of primary key to log result too large error.
2527 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2529 2011-11-28 Ben Konrath <ben@bagu.org>
2531 Don't use TypedDataItem.getText() for Unknown types from the URL.
2533 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2534 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2535 instead of getText().
2536 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2537 String field and getUnknown() method.
2539 2011-11-28 Ben Konrath <ben@bagu.org>
2541 Log an error message when the java-libglom .so is not present.
2543 The error message was being set in the exception but not logged.
2545 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2547 2011-11-28 Ben Konrath <ben@bagu.org>
2549 Ignore LayoutItem_CalendarPortals.
2551 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2552 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2554 2011-11-28 Ben Konrath <ben@bagu.org>
2556 Extract method for creating the LayoutItemPortal DTO.
2558 Just breaking the code up into smaller chunks.
2560 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2562 2011-11-28 Ben Konrath <ben@bagu.org>
2566 This should have been added with the refactor. Oops!
2568 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2570 2011-11-28 Ben Konrath <ben@bagu.org>
2572 Create primary key value from URL string using type from Glom document.
2574 See this bug, comments 19 - 25:
2576 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2578 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2579 create a TypeDataItem for the primary key here when loading from a
2580 URL. Show the same string for the primary key value as was received
2581 from the URL string (when loading from a URL).
2582 * src/main/java/org/glom/web/server/Utils.java: Update method for
2583 creating the Gda Value from the TypeDataItem to properly deal with
2584 creating a Gda Value based on the Glom document type for the primary
2585 key value string when loading from a URL.
2586 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2587 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2588 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2589 Update for changed method name.
2591 2011-11-27 Ben Konrath <ben@bagu.org>
2593 Rename PrimaryKeyItem to TypedDataItem.
2595 The name PrimaryKeyItem suggests what the class should be used for.
2596 TypedDataItem is a neutral name that describes the class better.
2598 This is a rename-only refactor.
2600 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2601 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2602 * src/main/java/org/glom/web/client/Utils.java:
2603 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2604 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2605 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2606 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2607 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2608 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2609 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2610 * src/main/java/org/glom/web/server/Utils.java:
2611 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2612 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2613 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2614 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2616 2011-11-25 Ben Konrath <ben@bagu.org>
2618 Improve Gda Value conversion from PrimaryKeyItem.
2620 The value from the PrimaryKeyItem is only used if its type match the
2621 type from the glom document.
2623 * src/main/java/org/glom/web/server/Utils.java:
2625 2011-11-25 Ben Konrath <ben@bagu.org>
2627 Manually check if the java-liblgom .so is visible to the JVM.
2629 It seems that Tomcat has problems when a static initializer throws an
2630 exception. This check is done before the first method call into
2631 java-libglom so that execution doesn't continue if the .so is not
2634 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2636 2011-11-25 Ben Konrath <ben@bagu.org>
2638 Improve browser configuration error messages.
2642 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2644 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2645 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2646 getConfigurationErrorMessage() method.
2647 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2648 Get and display a specific configuration error message when no Glom
2649 documents are found.
2650 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2651 Implement getConfigurationErrorMessage() method. Surround configuration
2652 code in the init() method with a try/catch block. This allows the
2653 errors to be caught while keeping the servlet available to retrieve the
2654 configuration error message.
2656 2011-11-25 Ben Konrath <ben@bagu.org>
2658 Don't use Strings to hold primary key values.
2660 The primary key values are now held in a new data object
2661 (PrimaryKeyItem) that holds type information and the primary key value
2662 using the correct type.
2664 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2665 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2666 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2667 PrimaryKeyItem instead of String to hold the primary key value.
2668 * src/main/java/org/glom/web/client/Utils.java: Remove
2669 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2670 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2671 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2672 PrimaryKeyItem instead of String to hold the primary key value. Load
2673 document selection page when the documentID has not been set correctly.
2674 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2675 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2677 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2678 Return empty string for URL instead of "null".
2679 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2680 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2681 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2682 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2683 PrimaryKeyItem instead of String to hold primary key values.
2684 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2685 PrimaryKeyValue to a Gda Value.
2686 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2687 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2688 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2689 Replace temporary database access code that uses the PrimaryKeyValue to
2690 Gda Value conversion.
2691 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2692 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2693 PrimaryKeyItem instead of String.
2694 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2695 hold primary key values.
2697 2011-11-24 Ben Konrath <ben@bagu.org>
2699 Use newly added java-libglom API to create queries.
2701 This isn't finished. I still need to stop using Strings for primary key
2702 values in the client code.
2704 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2705 libglom to use fake connections so that retrieving the query string will
2707 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2708 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2709 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2710 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2711 Use the newly added libglom sql methods and classes to create the
2712 query. Add temporary hack to convert primary value strings to Gda
2715 2011-11-23 Ben Konrath <ben@bagu.org>
2717 Don't explicitly set the height of Portals.
2719 See comments 6 - 10 of this bug for details:
2721 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2723 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2725 2011-11-23 Ben Konrath <ben@bagu.org>
2727 Use an HTML table instead of CSS for the FlowTable layout.
2729 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2730 GWT's FlexTable to implement the FlowTable.
2731 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2733 2011-11-18 Ben Konrath <ben@bagu.org>
2735 Add boolean example to HTML table mockup.
2737 * mockups/details-view-html-tables-text-entries.html:
2739 2011-11-17 Ben Konrath <ben@bagu.org>
2741 Ensure the pager buttons are always visible for related lists.
2743 To accomplish this, I've turned off text wrapping in the list view and
2744 related list tables for both the header and data text. The related list
2745 table now has a fixed layout so the it doesn't overflow its container.
2746 This is required to ensure that the cell text is clipped when it
2747 overflows the cell and an ellipsis is added to the right side of the
2748 cell when text is clipped.
2750 A fixed table layout for the related list table in the details view
2751 seems what we want for the details view anyway, so the side-effect is
2754 The ellipsis will only be displayed in Firefox >= 7.
2758 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2760 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2761 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2762 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2764 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2765 Set the 'table-layout: fixed' CSS property to the related list table.
2766 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2767 'white-space: nowrap;' CSS property on both the list view and the
2768 related list tables.
2770 2011-11-16 Ben Konrath <ben@bagu.org>
2772 Rework the fix for empty notebook tab labels.
2774 Setting the empty group titles with its name caused problems for the
2775 details layout. Instead of using libglom's
2776 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2777 to the client when the title is empty. This allows the Notebook to use
2778 the name when the title is empty without affecting anything else.
2780 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2781 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2783 2011-11-16 Ben Konrath <ben@bagu.org>
2785 Set group titles with name when title is empty.
2787 This fixes a problem with an empty notebook tab label in the Lesson
2788 Planner document. The forth tab in the notebook should be "Internet":
2790 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2792 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2793 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2796 2011-11-16 Ben Konrath <ben@bagu.org>
2798 Remove whitespace from the configured username properties.
2800 This assumes that usernames won't have whitespace at the beginning
2801 or end. But I think this is a reasonable assumption.
2803 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2804 String.trim() to remove the whitespace from the username properties.
2806 2011-11-15 Ben Konrath <ben@bagu.org>
2808 Add details view mockup with HTML tables and text entries.
2810 This is from the attachment on this bug:
2812 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2814 * mockups/details-view-html-tables-text-entries.html:
2816 2011-11-15 Ben Konrath <ben@bagu.org>
2818 Add space between the columns of the flow table.
2822 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2824 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2825 space between columns in the flow table.
2827 2011-11-15 Ben Konrath <ben@bagu.org>
2829 Add backup files to the .gitignore.
2831 * .gitignore: Ignore files that end with ~.
2833 2011-11-09 Ben Konrath <ben@bagu.org>
2835 Use latest release of gwt-log.
2837 Gwt-log releases are now being submitted to the maven central
2838 repository so manual installation of the jar is no longer required.
2840 * pom.xml: Update version and groupId of gwt-log dependency.
2842 2011-10-31 Ben Konrath <ben@bagu.org>
2844 Don't use GWT numeric formatting to override the glom currency formatting.
2846 Currencies are now displayed like they are in Glom. See this bug:
2848 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2850 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2852 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2853 currency code to constructor and set it when the cell is rendered.
2854 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2855 currency code to the constructor of the NumericCell.
2857 2011-10-27 Ben Konrath <ben@bagu.org>
2859 Require the latest release of java-libglom (1.17.4).
2863 2011-10-26 Ben Konrath <ben@bagu.org>
2865 Add style to Notebook that matches current theme.
2867 It's not the best style in the world but it's better than the default.
2869 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2870 padding at the bottom of the child widgets.
2871 * src/main/webapp/style.css: Add style for the Notebook.
2873 2011-10-26 Ben Konrath <ben@bagu.org>
2875 Move servlet initialization code to overridden init method.
2877 This is half of the solution to getting proper error messages
2878 displayed when configuration errors occur. Here's the relevant bug:
2880 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2882 The rest of the solution involves surrounding the init method with a
2883 try/catch block and setting a global variable with the error /
2884 exception. A new async method should be created to retrieve and display
2885 the error message / exception.
2887 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2888 code from constructor to init method adding exceptions as needed.