5 years ago[SV #38442] Add library names to the string cache. master
Paul Smith [Sun, 26 May 2013 20:53:17 +0000 (16:53 -0400)]
[SV #38442] Add library names to the string cache.

5 years ago[SV #38945] Copy the entire buffer back when overwriting CR
Paul Smith [Sun, 26 May 2013 18:41:45 +0000 (14:41 -0400)]
[SV #38945] Copy the entire buffer back when overwriting CR

5 years ago[SV #39028] Fix some small typos in messages.
Paul Smith [Sun, 26 May 2013 18:06:25 +0000 (14:06 -0400)]
[SV #39028] Fix some small typos in messages.

5 years ago[SV #39035] Compare OUT to the beginning of the OUT var/func, not IN.
Paul Smith [Sun, 26 May 2013 17:56:51 +0000 (13:56 -0400)]
[SV #39035] Compare OUT to the beginning of the OUT var/func, not IN.

5 years agoAdd dates to the NEWS file to make things simpler.
Paul Smith [Sun, 26 May 2013 17:53:21 +0000 (13:53 -0400)]
Add dates to the NEWS file to make things simpler.

5 years agoFix regression tests after MAKEFLAGS enhancements.
Paul Smith [Wed, 22 May 2013 11:51:46 +0000 (07:51 -0400)]
Fix regression tests after MAKEFLAGS enhancements.

5 years agoForce version printing whenever we print the database.
Paul Smith [Wed, 22 May 2013 06:51:45 +0000 (02:51 -0400)]
Force version printing whenever we print the database.

5 years agoMake MFLAGS and MAKEFLAGS more reliable and predictable.
Paul Smith [Wed, 22 May 2013 06:14:19 +0000 (02:14 -0400)]
Make MFLAGS and MAKEFLAGS more reliable and predictable.

Ensure all simple flags are kept in the initial batch of flags.
Do not allow any flags with options in that batch.
If there are only non-simple flags ensure MAKEFLAGS begins with " ".
Don't let MFLAGS start with "- ".

5 years agoFix the MS-Windows build using the Posix configury.
Alexey Pavlov [Sat, 18 May 2013 14:58:10 +0000 (17:58 +0300)]
Fix the MS-Windows build using the Posix configury.

 w32/ (libw32_a_SOURCES): Add compat/posixfcn.c. (OUTPUT_SYNC): Define for mingw32 target.

5 years agoSupport "move" as internal shell command on Windows with cmd.exe.
Eli Zaretskii [Sat, 18 May 2013 11:07:36 +0000 (14:07 +0300)]
Support "move" as internal shell command on Windows with cmd.exe.

 job.c (construct_command_argv_internal) <sh_cmds_dos> [WINDOWS32]: Add
 "move".  Fixes Savannah bug #30714.

5 years agoFix MS-Windows build with Guile.
Eli Zaretskii [Sat, 18 May 2013 11:03:26 +0000 (14:03 +0300)]
Fix MS-Windows build with Guile.

 guile.c: Move inclusion of makeint.h before gnumake.h.  This
 order must be observed when building Make, because gnumake.h must
 be included with GMK_BUILDING_MAKE defined, which makeint.h
 already does.  Otherwise, the linker will look for, and fail to
 find, gmk_* functions in some external dynamic library.

5 years agoFix MS-Windows compilation when OUTPUT_SYNC is not defined.
Eli Zaretskii [Fri, 17 May 2013 13:24:13 +0000 (16:24 +0300)]
Fix MS-Windows compilation when OUTPUT_SYNC is not defined.

 main.c (prepare_mutex_handle_string): Define conditioned on OUTPUT_SYNC.

5 years agoFix a bug in build_w32.bat when building a released tarball.
Eli Zaretskii [Fri, 17 May 2013 10:34:24 +0000 (13:34 +0300)]
Fix a bug in build_w32.bat when building a released tarball.

 build_w32.bat: Copy config.h.W32 to config.h regardless of
 whether or not we are building from SCM.

5 years agoUpdate for GNU make release candidate 3.99.90. 3.99.90
Paul Smith [Fri, 17 May 2013 06:40:37 +0000 (02:40 -0400)]
Update for GNU make release candidate 3.99.90.

5 years agoUpdate source file format: remove TABs, use GNU coding styles.
Paul Smith [Fri, 17 May 2013 06:29:46 +0000 (02:29 -0400)]
Update source file format: remove TABs, use GNU coding styles.

5 years agoUpdate copyright for changes in 2013.
Paul Smith [Fri, 17 May 2013 05:46:11 +0000 (01:46 -0400)]
Update copyright for changes in 2013.

5 years agoUse xcalloc() in hash.c to handle out of memory errors.
Paul Smith [Fri, 17 May 2013 05:24:19 +0000 (01:24 -0400)]
Use xcalloc() in hash.c to handle out of memory errors.

5 years agoRemove the dlopen() pointer from struct filedef.
Paul Smith [Fri, 17 May 2013 05:20:39 +0000 (01:20 -0400)]
Remove the dlopen() pointer from struct filedef.

This pointer is almost never needed, and it increases the size of the filedef
struct for all files (of which there are a huge number for large builds).
Instead keep a bit field marking whether the file is a loaded object and if so
call a new function to unload it.  In load.c we keep a simple linked list of
loaded objects (of which there will be very few typically) and their dlopen()

5 years agoAdd requirement for plugin_is_GPL_compatible symbol in loaded objects.
Paul Smith [Wed, 15 May 2013 02:53:42 +0000 (22:53 -0400)]
Add requirement for plugin_is_GPL_compatible symbol in loaded objects.

5 years ago[Savannah #20501] Handle adding -r/-R to MAKEFLAGS in the makefile.
Paul Smith [Mon, 13 May 2013 08:29:35 +0000 (04:29 -0400)]
[Savannah #20501] Handle adding -r/-R to MAKEFLAGS in the makefile.

If -R is set in the makefile and not the command line, then go through all the
default variables and undefine them.  If -r is set in the makefile and not in
the command line, then remove all .SUFFIX prefixes (unless the user set it)
and SUFFIX variable setting.  In -p mode don't print builtins.

5 years agoAdd a new variable: GNUMAKEFLAGS
Paul Smith [Mon, 13 May 2013 06:48:04 +0000 (02:48 -0400)]
Add a new variable: GNUMAKEFLAGS

This allows you to write portable makefiles that set GNU make-specific command
line options in the environment or makefile: add them to GNUMAKEFLAGS instead
of MAKEFLAGS and they will be seen by GNU make but ignored by other
implementations of make.

5 years agoUse level o_env_override for MAKEFLAGS so it's reset even with -e.
Paul Smith [Mon, 13 May 2013 06:17:29 +0000 (02:17 -0400)]
Use level o_env_override for MAKEFLAGS so it's reset even with -e.

Fixes Savannah bug #2216.

5 years agoAdd new --trace[=MODE] flags, with --trace=dir
Paul Smith [Mon, 13 May 2013 05:30:24 +0000 (01:30 -0400)]
Add new --trace[=MODE] flags, with --trace=dir

This mode replaces the previous heuristic setting enabled with -O, where we
would log directory enter/leave for each synchronized output.  Now we only
do that if --trace=dir is given.

5 years agoAvoid printing stdout and stderr messages without a newline between them.
Eli Zaretskii [Sat, 11 May 2013 14:42:56 +0000 (17:42 +0300)]
Avoid printing stdout and stderr messages without a newline between them.

 job.c (child_out): Output the newline following the message
 before fllush-ing the stream.  Avoids displaying the following
 failure message, which goes to stderr, on the same line.

5 years agoRearrange dllimport/dllexport declarations for MS-Windows.
Eli Zaretskii [Mon, 6 May 2013 17:18:58 +0000 (20:18 +0300)]
Rearrange dllimport/dllexport declarations for MS-Windows.

 gnumake.h (GMK_EXPORT) [_WIN32]: Move the dllexport declaration
 here from makeint.h.
 makeint.h (GMK_BUILDING_MAKE) [WINDOWS32]: Define before
 including gnumake.h.

5 years agodoc/make.texi (Loaded Object Example): Add a note about building
Eli Zaretskii [Mon, 6 May 2013 17:16:40 +0000 (20:16 +0300)]
doc/make.texi (Loaded Object Example): Add a note about building
 shared objects on MS-Windows.

5 years agobuild: enable 'subdir-objects' and 'silent-rules' automake options
Stefano Lattarini [Tue, 30 Apr 2013 15:19:04 +0000 (17:19 +0200)]
build: enable 'subdir-objects' and 'silent-rules' automake options

On 04/30/2013 05:11 PM, Stefano Lattarini wrote:
> * (AM_INIT_AUTOMAKE): Here.  The future major Automake
> version 2.0 (ETA about one, one and half year from now) will likely
> enable them by default, so better prepare ourselves.
Please drop this patch.  Enabling 'subdir-objects' would require
sublter changes to several other parts of the build system that I
don't know how to test properly.  We should only enable the
'silent-rules' option for the moment.  The updated patch below
does this.

Sorry for the noise,

---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ----

>From 46623411f017a447caa8fe75b3b42ec2fbeac458 Mon Sep 17 00:00:00 2001
Message-Id: <>
From: Stefano Lattarini <>
Date: Tue, 30 Apr 2013 16:30:04 +0200
Subject: [PATCH] build: enable the 'silent-rules' automake options

* (AM_INIT_AUTOMAKE): Here.  The future major Automake
version 2.0 (ETA about one, one and half year from now) will enable
it by default, so better prepare ourselves.

Signed-off-by: Stefano Lattarini <>
5 years agobuild: require Autoconf >= 2.62 and Automake >= 1.11.1
Stefano Lattarini [Tue, 30 Apr 2013 15:11:16 +0000 (17:11 +0200)]
build: require Autoconf >= 2.62 and Automake >= 1.11.1

Older versions of those tools should be considered fully obsolete.
Also, GNU make already requires Gettext >= 0.18.1, which has been
released six months after Automake 1.11.1 and two years after
Autoconf 2.62; so the new requirement shouldn't be problematic
for people already bootstrapping GNU make from the Git repository.

* (AC_PREREQ): Require Autoconf 2.62 or later.
(AM_INIT_AUTOMAKE): Require Automake 1.11.1 or later (1.11 had
some serious bugs, and should not be used).

Copyright-paperwork-exempt: yes
Signed-off-by: Stefano Lattarini <>
5 years agoRemove use of vfork().
Paul Smith [Mon, 6 May 2013 04:22:27 +0000 (00:22 -0400)]
Remove use of vfork().

GCC was giving us warnings, most OS's now just run fork() when you call
vfork(), and looking at the standard definition of vfork() we are a long way
from using it safely anyway: you're not allowed to even call a function before
you exec().

5 years agodocs: port manual to Texinfo 5.x
Stefano Lattarini [Sat, 4 May 2013 22:44:41 +0000 (00:44 +0200)]
docs: port manual to Texinfo 5.x

* doc/make.texi: Here.  It was sufficient to change an '@itemx'
into an '@item'.

Copyright-paperwork-exempt: yes
Signed-off-by: Stefano Lattarini <>
5 years agocosmetics: fix few innocuous typos
Stefano Lattarini [Tue, 30 Apr 2013 13:37:03 +0000 (15:37 +0200)]
cosmetics: fix few innocuous typos

Most of these were found using Lucas De Marchi's 'codespell' tool.

* ChangeLog: Fix minor typos.
* ChangeLog.2: Likewise.
* README.Amiga: Likewise.
* TODO.private: Likewise.
* function.c: Likewise.
* glob/glob.h: Likewise.
* job.c: Likewise.
* main.c: Likewise.
* readme.vms: Likewise.
* remake.c: Likewise.
* tests/ChangeLog: Likewise.
* tests/NEWS: Likewise.
* tests/README: Likewise.
* tests/scripts/variables/private: Likewise.
* vmsdir.h: Likewise.
* signame.c: Likewise.  While at it, improve line wrapping in the
touched comment.

Copyright-paperwork-exempt: yes
Signed-off-by: Stefano Lattarini <>
5 years agobuild: get rid of 'HAVE_ANSI_COMPILER' C preprocessor conditional
Stefano Lattarini [Tue, 30 Apr 2013 15:11:18 +0000 (17:11 +0200)]
build: get rid of 'HAVE_ANSI_COMPILER' C preprocessor conditional

GNU make already assume C89 or later throughout the codebase, and
that preprocessor conditional was no longer used anyway.

* config.ami.template: Remove #define of HAVE_ANSI_COMPILER.
* config.h-vms.template: Likewise.
* config.h.W32.template: Likewise.
* configh.dos.template: Likewise.

Signed-off-by: Stefano Lattarini <>
5 years agoRename the -O "job" mode to "line" and "make" to "recurse".
Paul Smith [Mon, 6 May 2013 00:19:00 +0000 (20:19 -0400)]
Rename the -O "job" mode to "line" and "make" to "recurse".

5 years agoEnsure command lines are written synchronously with -O.
Paul Smith [Sun, 5 May 2013 21:03:51 +0000 (17:03 -0400)]
Ensure command lines are written synchronously with -O.

If output-sync is enabled, have make write the command line to the temp file
instead of printing it directly to the screen to ensure that the output is
ordered properly.  Also, remove extraneous enter/leave operations by having
them printed directly when dumping temp file output.

5 years agoAdd memory allocation cleanup to loadable objects.
Paul Smith [Sat, 4 May 2013 21:38:53 +0000 (17:38 -0400)]
Add memory allocation cleanup to loadable objects.

Add gmk_alloc() and gmk_free() functions so loadable objects can access our
memory model.  Also provide a more extensive example in the manual.

5 years agoDon't pump output to the descriptor, as we use FILE* elsewhere.
Paul Smith [Sat, 4 May 2013 21:31:20 +0000 (17:31 -0400)]
Don't pump output to the descriptor, as we use FILE* elsewhere.

5 years agoMinor portabiulity fixes for MS-Windows.
Eli Zaretskii [Sat, 4 May 2013 18:03:55 +0000 (21:03 +0300)]
Minor portabiulity fixes for MS-Windows.

 makeint.h (ftruncate) [_MSC_VER]: Redirect to _chsize.
 (_S_ISDIR): If not defined (MinGW64), define to S_ISDIR.

5 years agoMerge branch 'master' of
Paul Smith [Sat, 4 May 2013 17:14:39 +0000 (13:14 -0400)]
Merge branch 'master' of

5 years agoImprove sync handling for -Ojob/-Otarget and recursion.
Paul Smith [Sat, 4 May 2013 17:10:56 +0000 (13:10 -0400)]
Improve sync handling for -Ojob/-Otarget and recursion.

If we are not going to sync a command line then dump any collected output
first to preserve ordering.  Do some code cleanup:
  * Move the handle init to a separate function.
  * Move the temp file truncation to the output function.
  * Remember whether we sync in a variable for readability.
  * Handle EINTR and short writes in child_out().
  * Always call sync_output() in case output_sync was changed due to error.

5 years agoFix a typo in the manual.
Eli Zaretskii [Sat, 4 May 2013 14:19:56 +0000 (17:19 +0300)]
Fix a typo in the manual.

5 years agoFix a possibly confusing comment at end of pump_from_tmp_fd.
Eli Zaretskii [Sat, 4 May 2013 07:56:32 +0000 (10:56 +0300)]
Fix a possibly confusing comment at end of pump_from_tmp_fd.

5 years agoFix the MS-Windows branch of output_sync code.
Eli Zaretskii [Sat, 4 May 2013 07:41:11 +0000 (10:41 +0300)]
Fix the MS-Windows branch of output_sync code.

 job.c (start_job_command): Make the condition for creating a
 temporary output file be identical to the Posix code branch.
 Suggested by Frank Heckenbach <>.

5 years agoFix invocation of Windows batch files with whitespace in their names.
Eli Zaretskii [Fri, 3 May 2013 13:24:24 +0000 (16:24 +0300)]
Fix invocation of Windows batch files with whitespace in their names.

 w32/subproc/sub_proc.c: Include makeint.h.  Remove a private
 incompatible prototype of xmalloc.
 (batch_file_with_spaces): New function, detects Windows batch
 files whose names include whitespace characters.
 (process_begin): If exec_name is a batch file with whitespace
 characters in its name, pass NULL as the first argument to
 CreateProcess.  This avoids weird failures due to buggy quoting by
 CreateProcess.  For the details, see the discussion starting at

5 years agoFix interfacing with and remaking dynamic objects on MS-Windows.
Eli Zaretskii [Fri, 3 May 2013 13:09:12 +0000 (16:09 +0300)]
Fix interfacing with and remaking dynamic objects on MS-Windows.

 load.c (load_object, load_file): Accept an additional argument
 DLP and return in it a pointer that can be used to unload the
 dynamic object.
 read.c (eval): Call load_file with an additional argument, and
 record the pointer returned there in the 'struct file' object of
 dynamic objects in that object's 'struct file'.
 commands.c (execute_file_commands): Unload dynamic objects
 before remaking them, to avoid failure to remake if the OS doesn't
 allow overwriting objects that are in use.
 filedef.h (struct file): New member dlopen_ptr.
 gnumake.h (GMK_EXPORT): Define to dllexport/dllimport
 decorations for Windows and to nothing on other platforms.
 (gmk_eval, gmk_expand, gmk_add_function): Add GMK_EXPORT qualifier
 to prototypes.
 makeint.h (MAIN): Define before including gnumake.h, to give
 correct dllexport decorations to exported functions.
 (load_file): Adjust prototype.
 loadapi.c: Don't include gnumake.h, since makeint.h already
 includes it, and takes care of defining MAIN before doing so.
 build_w32.bat (LinkGCC): Produce an import library for functions
 exported by Make for loadable dynamic objects.

 w32/compat/posixfcn.c (dlclose): New function.
 w32/include/dlfcn.h (dlclose): Add prototype.

 scripts/features/load: Fix signatures of testload_gmk_setup and
 explicit_setup, to bring them in line with the documentation.

5 years agoMention in NEWS change on Windows with quotes in command lines.
Eli Zaretskii [Wed, 1 May 2013 15:41:14 +0000 (18:41 +0300)]
Mention in NEWS change on Windows with quotes in command lines.

5 years agoFix treatment of whitespace after a backslash on MS-Windows.
Eli Zaretskii [Wed, 1 May 2013 15:31:53 +0000 (18:31 +0300)]
Fix treatment of whitespace after a backslash on MS-Windows.

 job.c (construct_command_argv_internal): Don't treat a backslash as an
 escape character before whitespace, if the shell is not a Posix
 shell.   For the description of the problem, see

5 years agojob.c (start_job_command) [WINDOWS32]: Make the same fix for
Eli Zaretskii [Wed, 1 May 2013 15:15:16 +0000 (18:15 +0300)]
job.c (start_job_command) [WINDOWS32]: Make the same fix for
 MS-Windows as the previous commit did for Posix platforms.

5 years agoDon't synchronize output for recursive make unless -Omake
Paul Smith [Wed, 1 May 2013 11:59:24 +0000 (07:59 -0400)]
Don't synchronize output for recursive make unless -Omake

5 years agoSupport dynamic object loading on MS-Windows.
Eli Zaretskii [Mon, 29 Apr 2013 16:26:06 +0000 (19:26 +0300)]
Support dynamic object loading on MS-Windows.

 w32/include/dlfcn.h: New file.
 w32/compat/posixfcn.c: Include dlfcn.h.
 (dlopen, dlerror, dlsym) [MAKE_LOAD]: New functions, in support of
 dynamic loading.

 config.h.W32.template (MAKE_LOAD): Define.
 load.c (load_object) [HAVE_DOS_PATHS]: Support backslashes and
 drive letters in file names of dynamic objects.

5 years agoFix the .ONESHELL operation on MS-Windows.
Eli Zaretskii [Mon, 29 Apr 2013 16:17:07 +0000 (19:17 +0300)]
Fix the .ONESHELL operation on MS-Windows.

 job.c (construct_command_argv_internal) [WINDOWS32]: Return
 right after generating new_argv for one_shell case.  This fixes
 the Windows build for both Unixy shell and stock Windows shells.

5 years agoMerge branch 'master' of
Paul Smith [Sun, 28 Apr 2013 23:25:24 +0000 (19:25 -0400)]
Merge branch 'master' of

5 years agoEnsure error messages are printed with sync'd output.
Paul Smith [Sun, 28 Apr 2013 23:09:20 +0000 (19:09 -0400)]
Ensure error messages are printed with sync'd output.

Enhance the child_error() function so that it will write error output to the
child's sync output buffer, if it exists.  If it doesn't the output goes to

5 years agoRemove support for pre-ANSI variadic function calls.
Paul Smith [Sun, 28 Apr 2013 21:59:28 +0000 (17:59 -0400)]
Remove support for pre-ANSI variadic function calls.

We've required support for ANSI C (ISO C 89) or better for quite a while.  Get
rid of the old varags.h, doprnt() stuff and simply assume ANSI C variadic
function capability and basic C runtime library support (vfprintf, vsprintf,

5 years agoSmall cleanups and fixes.
Paul Smith [Sun, 28 Apr 2013 21:31:46 +0000 (17:31 -0400)]
Small cleanups and fixes.

5 years agoFix Savannah bug #37065 with $(wildcard foo/*/.) returning non-directories.
Eli Zaretskii [Sun, 28 Apr 2013 17:53:36 +0000 (20:53 +0300)]
Fix Savannah bug #37065 with $(wildcard foo/*/.) returning non-directories.

 dir.c (local_stat) [WINDOWS32]: Use the wrapper on MS-Windows.
 If the argument ends in "dir/.", make sure the parent dir exists
 and is indeed a directory.  Fixes Savannah bug #37065.

5 years agoFix a few compiler warnings found by Eli.
Paul Smith [Sun, 28 Apr 2013 05:41:47 +0000 (01:41 -0400)]
Fix a few compiler warnings found by Eli.

5 years agoAdd support for per-job output sync.
Paul Smith [Sun, 28 Apr 2013 05:19:19 +0000 (01:19 -0400)]
Add support for per-job output sync.

A new flag to the -O/--output-sync, "job", selects a per-job (that is, per
line of a recipe) output synchronization.  To support this move the close of
the temp file out of the sync_output() function and don't do it until we free
the child, since we may call sync_output() multiple times in a given recipe.
When we set up for a new temp file, if we're in per-job mode we truncate the
file and seek to the beginning to re-use it for every job.

5 years agoFix support for .ONESHELL when dealing with non-POSIX shells.
Paul Smith [Sat, 27 Apr 2013 21:28:05 +0000 (17:28 -0400)]
Fix support for .ONESHELL when dealing with non-POSIX shells.

5 years agoRework the implementation of load.c to increase portability.
Paul Smith [Sat, 27 Apr 2013 20:57:05 +0000 (16:57 -0400)]
Rework the implementation of load.c to increase portability.

It should be sufficient, now, to write a new version of the load_object()
function.  That function won't be called unless we really want to load, so all
checking and parsing is taken care of before that.

5 years agoMerge branch 'master' of
Paul Smith [Sat, 27 Apr 2013 20:24:08 +0000 (16:24 -0400)]
Merge branch 'master' of

5 years agoSupport .ONESHELL on MS-Windows, for default Windows shells.
Eli Zaretskii [Sat, 27 Apr 2013 16:12:01 +0000 (19:12 +0300)]
Support .ONESHELL on MS-Windows, for default Windows shells.

 read.c (record_files): Pay attention to .ONESHELL in MS-Windows.
 job.c (construct_command_argv_internal): Support .ONESHELL on
 MS-Windows, when the shell is not a Unixy shell.

5 years ago job.c: Fix compilation error on GNU/Linux due to "label at end of compound statement".
Eli Zaretskii [Sat, 27 Apr 2013 11:30:01 +0000 (14:30 +0300)]
 job.c: Fix compilation error on GNU/Linux due to "label at end of compound statement".

5 years agoSupport --output-sync on MS-Windows.
Eli Zaretskii [Sat, 27 Apr 2013 11:20:49 +0000 (14:20 +0300)]
Support --output-sync on MS-Windows.

 w32/compat/posixfcn.c: New file, with emulations of Posix
 functions and Posix functionality for MS-Windows.
 w32/subproc/sub_proc.c: Include io.h.
 (process_noinherit): New function, forces a file descriptor to not
 be inherited by child processes.
 (process_easy): Accept two additional arguments, and use them to
 set up the standard output and standard error handles of the child
 w32/include/sub_proc.h (process_easy): Adjust prototype.
 (process_noinherit): Add prototype.

 read.c [WINDOWS32]: Include windows.h and sub_proc.h.
 makeint.h (LOCALEDIR) [WINDOWS32}: Define to NULL if not
 defined.  This is needed because the MS-Windows build doesn't have
 a canonical place for LOCALEDIR.
 (WIN32_LEAN_AND_MEAN) [WINDOWS32]: Define, to avoid getting from
 windows.h header too much stuff that could conflict with the code.
 main.c <sync_mutex>: New static variable.
 <switches>: Add support for "--sync-mutex" switch.
 (decode_output_sync_flags): Decode the --sync-mutex= switch.
 (prepare_mutex_handle_string) [WINDOWS32]: New function.
 (main): Add "output-sync" to .FEATURES.
 job.h (CLOSE_ON_EXEC) [WINDOWS32]: Define to call
 (F_GETFD, F_SETLKW, F_WRLCK, F_UNLCK, struct flock) [WINDOWS32]:
 New macros.
 (RECORD_SYNC_MUTEX): New macro, a no-op for Posix platforms.
 (sync_handle_t): New typedef.
 job.c <sync_handle>: Change type to sync_handle_t.
 (FD_NOT_EMPTY): Seek to the file's end.  Suggested by Frank
 Heckenbach <>.
 (pump_from_tmp_fd) [WINDOWS32]: Switch to_fd to binary mode for
 the duration of this function, and then change back before
 (start_job_command) [WINDOWS32]: Support output_sync mode on
 MS-Windows.  Use a system-wide mutex instead of locking
 stdout/stderr.  Call process_easy with two additional arguments:
 child->outfd and child->errfd.
 (exec_command) [WINDOWS32]: Pass two additional arguments, both
 -1, to process_easy, to adjust for the changed function signature.
 function.c (windows32_openpipe) [WINDOWS32]: This function now
 returns an int, which is -1 if it fails and zero otherwise.  It
 also calls 'error' instead of 'fatal', to avoid exiting
 (func_shell_base) [WINDOWS32]: Call perror_with_name if
 windows32_openpipe fails, now that it always returns.  This avoids
 a compiler warning that error_prefix is not used in the MS-Windows
 config.h.W32.template (OUTPUT_SYNC): Define.
 build_w32.bat: Add w32/compat/posixfcn.c to compilation and
 linking commands.

 From Frank Heckenbach <>:
 job.c (sync_output): Don't discard the output if
 acquire_semaphore fails; instead, dump the output unsynchronized.

5 years agoImprove MS-Windows build scripts.
Eli Zaretskii [Thu, 25 Apr 2013 17:41:53 +0000 (20:41 +0300)]
Improve MS-Windows build scripts.

 build_w32.bat: Improve.  Remove 'setlocal', as it isn't
 supported on Windows 9X.  Add --help and usage instructions.
 Support both debug and optimized builds with GCC under --debug.
 If building out of Git repo, always produce config.h, and edit
 gmk-default.scm into gmk-default.h.
 w32/subproc/build.bat: Support debug and optimized builds with

5 years agoReflect the '' -> '' rename throughout
Stefano Lattarini [Sat, 20 Apr 2013 20:18:16 +0000 (22:18 +0200)]
Reflect the '' -> '' rename throughout

In README, code comments, and auxiliary files.

Copyright-paperwork-exempt: yes
Signed-off-by: Stefano Lattarini <>
5 years agoSome cleanups for Windows builds after the output-sync option.
Paul Smith [Tue, 16 Apr 2013 23:51:29 +0000 (19:51 -0400)]
Some cleanups for Windows builds after the output-sync option.

Note currently output-sync is not supported on Windows.

5 years agoCleanup some source and fix autoconf warnings.
Paul Smith [Tue, 16 Apr 2013 05:47:05 +0000 (01:47 -0400)]
Cleanup some source and fix autoconf warnings.

5 years agoCreate an open_tmpfd() function to return temp files by FD. Use it.
Paul Smith [Tue, 16 Apr 2013 04:35:48 +0000 (00:35 -0400)]
Create an open_tmpfd() function to return temp files by FD.  Use it.

5 years agoSave the output from the entire recipe, not per-job.
Paul Smith [Mon, 15 Apr 2013 23:17:19 +0000 (19:17 -0400)]
Save the output from the entire recipe, not per-job.

5 years agoChange the arg option for -O from numeric to string.
Paul Smith [Mon, 15 Apr 2013 17:22:51 +0000 (13:22 -0400)]
Change the arg option for -O from numeric to string.

5 years agoModify output-sync tests to be more reliable.
Paul Smith [Sun, 14 Apr 2013 23:13:42 +0000 (19:13 -0400)]
Modify output-sync tests to be more reliable.

5 years agoHandle test timeouts in a more understandable way.
Paul Smith [Sun, 14 Apr 2013 23:09:16 +0000 (19:09 -0400)]
Handle test timeouts in a more understandable way.

5 years agoRename the "parallel-sync" option to "output-sync".
Paul Smith [Sun, 14 Apr 2013 20:31:18 +0000 (16:31 -0400)]
Rename the "parallel-sync" option to "output-sync".

5 years agoInitial patch for output synchronization. See Savannah bug #33138.
Frank Heckenbach [Sun, 14 Apr 2013 19:38:07 +0000 (15:38 -0400)]
Initial patch for output synchronization.  See Savannah bug #33138.

Based on work by David Boyce <>.

5 years agoClarify LDFLAGS vs. LDLIBS. Fixes Savannah bug #37970.
Paul Smith [Sat, 6 Apr 2013 14:51:57 +0000 (10:51 -0400)]
Clarify LDFLAGS vs. LDLIBS.  Fixes Savannah bug #37970.

5 years agoReconsider targets waiting for prerequisites. Fixes Savannah bug #37703.
Paul Smith [Sat, 6 Apr 2013 14:29:20 +0000 (10:29 -0400)]
Reconsider targets waiting for prerequisites.  Fixes Savannah bug #37703.

5 years agoUse ENULLLOOP to handle EINTR during realpath(). Fixes Savannah bug #38420
Paul Smith [Thu, 28 Feb 2013 05:55:15 +0000 (00:55 -0500)]
Use ENULLLOOP to handle EINTR during realpath().  Fixes Savannah bug #38420

5 years agoExpand the loadable object support.
Paul Smith [Mon, 25 Feb 2013 06:38:36 +0000 (01:38 -0500)]
Expand the loadable object support.

Provide a simple API for loaded objects to interact with GNU make.  I still
won't guarantee that this API won't change but it's much closer to something
that's supported and provides easy-to-use interfaces with a public header

5 years agoAdding new file.
Paul Smith [Sun, 20 Jan 2013 21:36:28 +0000 (16:36 -0500)]
Adding new file.

5 years agoCreate externally referencable header file "gnumake.h".
Paul Smith [Sun, 20 Jan 2013 18:39:54 +0000 (13:39 -0500)]
Create externally referencable header file "gnumake.h".
Move the gmk_floc type to gnumake.h.

5 years agoRename struct floc to typedef gmk_floc as an externally scoped symbol.
Paul Smith [Sun, 20 Jan 2013 18:16:46 +0000 (13:16 -0500)]
Rename struct floc to typedef gmk_floc as an externally scoped symbol.

5 years agoRename the make.h file to makeint.h for internal use only.
Paul Smith [Sun, 20 Jan 2013 16:01:01 +0000 (11:01 -0500)]
Rename the make.h file to makeint.h for internal use only.

5 years agoAllow dynamically loaded objects to be rebuilt by make.
Paul Smith [Sun, 20 Jan 2013 05:55:57 +0000 (00:55 -0500)]
Allow dynamically loaded objects to be rebuilt by make.

5 years agoAdd more documentation on Git workflow and rules.
Paul Smith [Sat, 19 Jan 2013 22:11:23 +0000 (17:11 -0500)]
Add more documentation on Git workflow and rules.

5 years agoFix a typo in ChangeLog.
Eli Zaretskii [Fri, 18 Jan 2013 16:02:16 +0000 (18:02 +0200)]
Fix a typo in ChangeLog.

5 years ago[SV #37878] Add a check for targets with parens that are not archives.
Paul Smith [Sun, 13 Jan 2013 17:40:13 +0000 (12:40 -0500)]
[SV #37878] Add a check for targets with parens that are not archives.

5 years ago[SV #38051] Recover all MAKEFLAGS after makefile rebuild step is complete.
Paul Smith [Sun, 13 Jan 2013 17:21:01 +0000 (12:21 -0500)]
[SV #38051] Recover all MAKEFLAGS after makefile rebuild step is complete.

Patch suggested by Frank Heckenbach <>.

5 years agoAdd ChangeLog entries for Git migration.
Paul Smith [Sun, 13 Jan 2013 17:17:03 +0000 (12:17 -0500)]
Add ChangeLog entries for Git migration.

5 years agoChange to, and other Git fixes.
Paul Smith [Sun, 13 Jan 2013 03:38:17 +0000 (22:38 -0500)]
Change to, and other Git fixes.

5 years agoEnsure parallel test works properly.
Paul Smith [Sun, 13 Jan 2013 02:54:41 +0000 (21:54 -0500)]
Ensure parallel test works properly.

5 years agoFix clean rules.
Paul Smith [Sun, 13 Jan 2013 02:53:15 +0000 (21:53 -0500)]
Fix clean rules.

5 years agoModify instructions, etc. for Git support.
Paul Smith [Sun, 13 Jan 2013 00:31:13 +0000 (19:31 -0500)]
Modify instructions, etc. for Git support.

5 years agoModify .gitignore for proper formatting.
Paul Smith [Sat, 12 Jan 2013 22:56:25 +0000 (17:56 -0500)]
Modify .gitignore for proper formatting.

5 years agoRename CVS ignore files to .gitignore
Paul Smith [Sat, 12 Jan 2013 22:48:58 +0000 (17:48 -0500)]
Rename CVS ignore files to .gitignore

5 years agoAdd missing load.c file to moved-to-git
Paul Smith [Sun, 6 Jan 2013 15:37:07 +0000 (15:37 +0000)]
Add missing load.c file to

5 years ago job.c (create_batch_file): Fix last change: always increment the
Eli Zaretskii [Sat, 8 Dec 2012 10:26:36 +0000 (10:26 +0000)]
 job.c (create_batch_file): Fix last change: always increment the
 counter of batch files before trying to use it.

5 years ago job.c (construct_command_argv_internal): Remove " from
Eli Zaretskii [Fri, 7 Dec 2012 14:23:39 +0000 (14:23 +0000)]
 job.c (construct_command_argv_internal): Remove " from
 sh_chars_dos[].  Ignore an escaped backslash inside a string
 quoted with "..".  This lifts the 4KB or 8KB command-line length
 limitation imposed by the Windows shell when a command uses quoted
 strings, because we now don't call the shell in that case.

5 years ago job.c (reap_children): Add debug message for when removal of a temporary
Eli Zaretskii [Fri, 7 Dec 2012 14:13:16 +0000 (14:13 +0000)]
 job.c (reap_children): Add debug message for when removal of a temporary
 batch file fails.

5 years agoAvoid leaving temporary batch files in the temporary directory.
Eli Zaretskii [Fri, 7 Dec 2012 14:11:15 +0000 (14:11 +0000)]
Avoid leaving temporary batch files in the temporary directory.

 job.c (create_batch_file): Declare the counter of batch files
 static, to avoid having 2 jobs using the same file name and
 stepping on each other's toes.  When all 64K names are used up,
 make one more loop looking for slots that became vacant.  This
 avoids leaving behind temporary batch files in the temporary
 directory, which happens frequently on a fast machine when using
 parallel builds.

5 years agoImplement new "load" directive.
Paul Smith [Mon, 29 Oct 2012 07:05:21 +0000 (07:05 +0000)]
Implement new "load" directive.

Provides support for dynamically loadable objects in GNU make, as a
"technology preview".