5 years agoimplement systemd support for PowerDevil Policy Agent
Lukas Tinkl [Fri, 21 Sep 2012 12:58:32 +0000 (14:58 +0200)]
implement systemd support for PowerDevil Policy Agent

This enables PowerDevil to react on active session changes
(correct locking, screen brightness) on systems w/o ConsoleKit,
like Fedora 18

Fixes e.g. https://bugzilla.redhat.com/show_bug.cgi?id=849334

REVIEW: 106506

6 years agopropagate changes from the Date/Time control module (kcmclock)
Lukas Tinkl [Fri, 21 Sep 2012 12:50:56 +0000 (14:50 +0200)]
propagate changes from the Date/Time control module (kcmclock)

by sending a DBUS signal "clockUpdated" which interested parties
can react to.

Fix the "time" dataengine to react to that signal.

Also tweak the analog/digital clocks so that they react
on updated data (I made sure no unnecessary repaints are made).

Fix the analog clock to update every minute at most (60000 milliseconds,
not 6000 ;)

6 years agoFix the kwin KCM to read cascaded configs
Rohan Garg [Thu, 20 Sep 2012 17:52:17 +0000 (23:22 +0530)]
Fix the kwin KCM to read cascaded configs

REVIEW: 106498

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Thu, 20 Sep 2012 14:18:41 +0000 (16:18 +0200)]
SVN_SILENT made messages (.desktop file)

6 years agoplasmaclock: Fix calendar resizing
Ralf Jung [Fri, 14 Sep 2012 09:35:13 +0000 (11:35 +0200)]
plasmaclock: Fix calendar resizing

BUG: 306762
FIXED-IN: 4.9.2
REVIEW: 106441

6 years agoDo not autoraise a window unless the mouse has been moved.
Michael Hohmuth [Tue, 4 Sep 2012 21:36:39 +0000 (23:36 +0200)]
Do not autoraise a window unless the mouse has been moved.

Fixes unintended autoraises when switching workspaces.

BUG: 306281
FIXED-IN: 4.9.2

6 years agoDo not unlist Unmanaged when released onShutdown
Thomas Lübking [Fri, 14 Sep 2012 14:10:04 +0000 (16:10 +0200)]
Do not unlist Unmanaged when released onShutdown

BUG: 303244
FIXED-IN: 4.9.2
REVIEW: 106382

6 years agoSync script loading, KConfGroup is not thread safe
Thomas Lübking [Fri, 14 Sep 2012 14:08:45 +0000 (16:08 +0200)]
Sync script loading, KConfGroup is not thread safe

REVIEW: 106377
BUG: 305361
FIXED-IN: 4.9.2

6 years agoDo not add extra padding to Client::visibleRect()
Thomas Lübking [Fri, 14 Sep 2012 14:07:41 +0000 (16:07 +0200)]
Do not add extra padding to Client::visibleRect()

REVIEW: 106376

6 years agofix desktopgrid window manage on VD amount change
Thomas Lübking [Sun, 9 Sep 2012 12:24:06 +0000 (14:24 +0200)]
fix desktopgrid window manage on VD amount change

BUG: 289747
FIXED-IN: 4.9.2
REVIEW: 106391

6 years agoUse expandedGeometry to calc thumbnail geometry
Thomas Lübking [Fri, 7 Sep 2012 13:57:28 +0000 (15:57 +0200)]
Use expandedGeometry to calc thumbnail geometry

BUG: 301730
REVIEW: 106336
FIXED-IN: 4.9.2

6 years agofix ignoring dektop related windows for showing desktop state
Thomas Lübking [Tue, 4 Sep 2012 13:55:35 +0000 (15:55 +0200)]
fix ignoring dektop related windows for showing desktop state

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Tue, 18 Sep 2012 23:16:25 +0000 (01:16 +0200)]
SVN_SILENT made messages (.desktop file)

6 years agoUse cascaded configs for other modules as well
Rohan Garg [Tue, 18 Sep 2012 18:33:59 +0000 (00:03 +0530)]
Use cascaded configs for other modules as well

In addition to commit d0343319fcfc249a38c79171be727d7133984eeb, one also
needs this commit to get cascaded configs to work

6 years agoUse the CascadeConfig flag as this allows the KCM to read values shipped by
Rohan Garg [Tue, 18 Sep 2012 16:04:40 +0000 (21:34 +0530)]
Use the CascadeConfig flag as this allows the KCM to read values shipped by
distributions and system administrators

6 years agoFix free space information in the device notifier
Alberto Villa [Tue, 18 Sep 2012 13:46:54 +0000 (15:46 +0200)]
Fix free space information in the device notifier

The device notifier is using model["Free Space( Text)"] to show
information which is not always available. As per Qt documentation,
QML models need their roles defined at the beginning, thus, when the
plasmoid is loaded with no accessible drives on the system, those two
roles are not created
(plasma/generic/dataengines/soliddevice/soliddeviceengine.cpp), and
the plasmoid will always show "undefined" for its whole lifetime.

REVIEW: 106490
FIXED-IN: 4.9.2

6 years agoImprove performance of Scene::Window
Martin Gräßlin [Fri, 7 Sep 2012 07:40:44 +0000 (09:40 +0200)]
Improve performance of Scene::Window

Replace dynamic_casts to check the type for for Toplevel by isFoo()
calls and use static_casts in such blocks.

Furthermore method shape() returns now a constant reference instead of a
copy of the QRegion.

REVIEW: 106364

6 years agomingw compile fix, disable crazy exports also on mingw
Patrick von Reth [Thu, 13 Sep 2012 17:06:57 +0000 (19:06 +0200)]
mingw compile fix, disable crazy exports also on mingw
(cherry picked from commit 52103394ba52f0d61068fc02f810b0b7fb4c1650)

6 years agowindows x64 fix
Patrick von Reth [Thu, 13 Sep 2012 17:05:03 +0000 (19:05 +0200)]
windows x64 fix
(cherry picked from commit 84010ac841926d0fade23c883b631cd3cd972535)

6 years agomake the plasma python scripts work with python 3
Martin T. H. Sandsmark [Tue, 11 Sep 2012 23:02:53 +0000 (01:02 +0200)]
make the plasma python scripts work with python 3

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Tue, 11 Sep 2012 22:08:54 +0000 (00:08 +0200)]
SVN_SILENT made messages (.desktop file)

6 years agoPrevent divide by Zero in backlighthelper (patch by Thomas Jablin)
Alex Fiestas [Mon, 10 Sep 2012 13:46:00 +0000 (15:46 +0200)]
Prevent divide by Zero in backlighthelper (patch by Thomas Jablin)
(cherry picked from commit 6e38322477215e04d9cd59bb1666ce0493be6d7b)

6 years agoDo not unnecessarily show "Restart Computer" button and remove excess of
Lamarque V. Souza [Sun, 9 Sep 2012 18:24:51 +0000 (15:24 -0300)]
Do not unnecessarily show "Restart Computer" button and remove excess of
free space in shutdown dialog.

BUG: 306489
FIXED-IN: 4.9.2
(cherry picked from commit fab7292269777ed2e46cf444a47a9e8da950fcbe)

6 years agoInitialize m_vBlankTime in Options
Martin Gräßlin [Sat, 8 Sep 2012 17:47:03 +0000 (19:47 +0200)]
Initialize m_vBlankTime in Options

Thanks to Albert for spotting this issue.

BUG: 306457
FIXED-IN: 4.9.2

6 years agoDrop supperfluous and wrong inactive check in translucency effect
Martin Gräßlin [Sat, 8 Sep 2012 17:43:01 +0000 (19:43 +0200)]
Drop supperfluous and wrong inactive check in translucency effect

Left over from the cleanup which basically resulted in the active window
being put to the inactive's window opacity.

Thanks for the early notification of that issue.

BUG: 306449
FIXED-IN: 4.9.2

6 years agoCheck transitionWidget validity before setting duration.
Hugo Pereira Da Costa [Fri, 7 Sep 2012 13:58:36 +0000 (15:58 +0200)]
Check transitionWidget validity before setting duration.
CCBUG: 304629

6 years agoDrop openoffice.org 1.x related hack for windowType detection
Martin Gräßlin [Thu, 6 Sep 2012 06:11:47 +0000 (08:11 +0200)]
Drop openoffice.org 1.x related hack for windowType detection

The oo.o related hack can be removed for several reasons:
1. The dialog in question from bug 66065 is nowadays a utility
2. The window class name changed to libreoffice
3. It's not the task of the window manager to workaround bugs in Clients

CCBUG: 66065
BUG: 306383
FIXED-IN: 4.9.2

6 years agoDrop hack for NET::Menu means NET::TopMenu
Martin Gräßlin [Thu, 6 Sep 2012 06:02:41 +0000 (08:02 +0200)]
Drop hack for NET::Menu means NET::TopMenu

KDE has not supported the TopMenu in any 4.x release and most of the
TopMenu related code has already been dropped from KWin. It is extremely
unlikely that there is still a window around which would need this
specific check. And even if there were such a check it would be broken.

So let's just remove this hack which means less checks in one of the
hottest code pathes of KWin.

CCBUG: 306383

6 years agoRemove animations from Translucency effect
Martin Gräßlin [Wed, 5 Sep 2012 19:35:36 +0000 (21:35 +0200)]
Remove animations from Translucency effect

The effect should have had two animations:
* on move resize
* on active/inactive change

But the timeline was adjusted in the prePaintWindow call and the timeline
is effect global and not per window. Which means that for each window the
same time is added. So instead of adding time t each frame t*n with n
being the number of windows got added. So in most cases the animation
ended in the first or second frame which means its not visible.

Through git blame I was able to track down that this incorrect behavior
was introduced in 2008. An animation broken for more than four years
without anybody noticing is probably not required. Because of that it's
dropped from the effect. As this includes quite some code and performance
improvements it goes into the release branch.

A better solution could be implemented, but that should be for 4.10.

BUG: 306263
FIXED-IN: 4.9.2
REVIEW: 106335

6 years agoImprove the various checks in Translucency Effect
Martin Gräßlin [Wed, 5 Sep 2012 19:13:33 +0000 (21:13 +0200)]
Improve the various checks in Translucency Effect

There were quite some useless checks like e.g. first checking whether
a window is the desktop and taking a different code path for that case
and in the other code path checking again.

Also using the new introduced boolean values for the checks instead of
comparing floating point numbers all the time.

6 years agoTranslucency Effect supports isActive hook
Martin Gräßlin [Tue, 4 Sep 2012 19:02:41 +0000 (21:02 +0200)]
Translucency Effect supports isActive hook

The effect gets a set of boolean values to check whether it is active for
one of the categories (e.g. move resize, decorations).

This allows to easily check whether the effect is active at all, that is
if all values are at 1.0 the effect will never affect a window.

In all other cases it can be combined with looking at the available
windows to e.g. enable the effect for move resize only when there is a
window which is either moved or resized. This check is performed whenever
an action happens which could cause a window to become inactive.

BUG: 306262
FIXED-IN: 4.9.2

6 years agoEnsure that the start Client to build up the ClientModel is in the Focus Chain
Martin Gräßlin [Wed, 5 Sep 2012 18:55:07 +0000 (20:55 +0200)]
Ensure that the start Client to build up the ClientModel is in the Focus Chain

If the start Client is not part of the focus chain the call to
nextClientFocusChain() cannot return the Client again. So the loop break
condition is never reached and as the focus chain is not empty the call
always returns a not null Client which means KWin is caught in an endless

This change checks that the starting Client is in the focus chain and if
not the first Client of the focus chain is used.

BUG: 306260
BUG: 306275
FIXED-IN: 4.9.2

6 years agofix setLocation behavior
Marco Martin [Wed, 5 Sep 2012 09:48:54 +0000 (11:48 +0200)]
fix setLocation behavior

fixes widgets explorer tooltip location

6 years agoDo not use hardcoded font family and size
Christoph Feck [Tue, 4 Sep 2012 10:09:06 +0000 (12:09 +0200)]
Do not use hardcoded font family and size

BUG: 306222
FIXED-IN: 4.9.2

6 years agoReturn displayHeight for property displayHeight and not displayWidth
Martin Gräßlin [Tue, 4 Sep 2012 04:26:39 +0000 (06:26 +0200)]
Return displayHeight for property displayHeight and not displayWidth

Typo in the scripting bindings.

BUG: 306225
FIXED-IN: 4.9.2

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sun, 2 Sep 2012 13:54:29 +0000 (15:54 +0200)]
SVN_SILENT made messages (.desktop file)

6 years agoImprove contrast of Oxygen colors
Aurélien Gâteau [Fri, 31 Aug 2012 14:07:29 +0000 (16:07 +0200)]
Improve contrast of Oxygen colors

It mainly improves readability of ActiveText over Window background

BUG: 216599
BUG: 303974
CCMAIL: nuno@oxygen-icons.org
FIXED-IN: 4.9.2

6 years agoMake sure the plasma desktop scripts are sorted in the correct order
Rohan Garg [Fri, 31 Aug 2012 09:51:11 +0000 (15:21 +0530)]
Make sure the plasma desktop scripts are sorted in the correct order

Instead of sorting the scripts according to their absolute paths,
which would cause scripts installed by packages to always end at
the top, scripts should be sorted by their relative path i.e.
plasma scripts from each directory that occurs in the path
should be sorted and then merged together to form a super list

REVIEWED BY: Marco Martin

6 years agoAdd keyboard navigation to Kickoff GUI (within and among all Views)
Gregor Tätzner [Fri, 31 Aug 2012 06:34:56 +0000 (08:34 +0200)]
Add keyboard navigation to Kickoff GUI (within and among all Views)

Fixes regression in KDE 4.9. Enables movement between views with tab
BUG: 276932 297842
FIXED-IN: 4.9.1
REVIEW: 106125

6 years agoUpdate version for 4.9.1
Albert Astals Cid [Wed, 29 Aug 2012 17:44:00 +0000 (19:44 +0200)]
Update version for 4.9.1

6 years agoproperly deal with invalid colors when calculating cache keys.
Hugo Pereira Da Costa [Wed, 29 Aug 2012 12:51:14 +0000 (14:51 +0200)]
properly deal with invalid colors when calculating cache keys.
using color.rgba() for an invalid color corresponds to solid black, which in turns conflicts with the cache
value for such color. We use "transparent black" instead.
CCBUG: 304868

6 years agoFix bug when resetting motions to -1 on enter event (stupid !)
Hugo Pereira Da Costa [Wed, 29 Aug 2012 11:44:06 +0000 (13:44 +0200)]
Fix bug when resetting motions to -1 on enter event (stupid !)
CCBUG: 302364

6 years agoadd a delegate image for the drag
Marco Martin [Wed, 29 Aug 2012 11:18:57 +0000 (13:18 +0200)]
add a delegate image for the drag

6 years agoReturn correct SH_MessageBox_TextInteractionFlags otherwise in
Montel Laurent [Wed, 29 Aug 2012 09:25:36 +0000 (11:25 +0200)]
Return correct SH_MessageBox_TextInteractionFlags otherwise in

QMessageBox::about when we have a href we can't open it.
(cherry picked from commit 89825b1656e84646ef06407ac7e17abca0f75800)

6 years agoEnsure main.qml presence
Thomas Lübking [Fri, 17 Aug 2012 11:19:21 +0000 (13:19 +0200)]
Ensure main.qml presence

BUG: 304881
REVIEW: 106062
FIXED-IN: 4.9.1

6 years agofix flicker with fullscreen effects
Thomas Lübking [Thu, 23 Aug 2012 14:51:40 +0000 (16:51 +0200)]
fix flicker with fullscreen effects

BUG: 304375
FIXED-IN: 4.9.1
REVIEW: 106142

6 years agokill killhelper in client destructor
Thomas Lübking [Tue, 14 Aug 2012 19:22:30 +0000 (21:22 +0200)]
kill killhelper in  client destructor

BUG: 305157
FIXED-IN: 4.9.1
REVIEW: 106022

6 years agodo not show clientmenu if button is down for 2nd click
Thomas Lübking [Sun, 26 Aug 2012 21:18:33 +0000 (23:18 +0200)]
do not show clientmenu if button is down for 2nd click

if one clicks very fast, the timeout will coincident with the
second downtime (between press and release) what was used to be
interpreted as "still down"

BUG: 305738
REVIEW: 106227
FIXED-IN: 4.9.1

6 years agoignore dockers for showingDesktop state
Thomas Lübking [Sun, 26 Aug 2012 14:16:38 +0000 (16:16 +0200)]
ignore dockers for showingDesktop state

also use a common funciton to decide whether or
not to break the state

BUG: 305874
FIXED-IN: 4.9.1

6 years agofix untabbing position
Thomas Lübking [Sat, 25 Aug 2012 16:20:34 +0000 (18:20 +0200)]
fix untabbing position

the geometry setting needs to happen out of recursion,
has to be smarter for unmaximizing and also no real
place in TabGroup - the client is no longer tabbed thus
it's not the groups task to manage it's geometry.

BUG: 226881
REVIEW: 106182
FIXED-IN: 4.9.1

6 years agodelay unsynced window ready_for_painting state
Thomas Lübking [Fri, 24 Aug 2012 21:03:58 +0000 (23:03 +0200)]
delay unsynced window ready_for_painting state

by at max 50ms (and thus trigger a full repaint with the state change)

BUG: 295254
REVIEW: 106173
FIXED-IN: 4.9.1

6 years agoFixed positioning of tabs when manually reordering with right mouse button
Hugo Pereira Da Costa [Tue, 28 Aug 2012 07:26:04 +0000 (09:26 +0200)]
Fixed positioning of tabs when manually reordering with right mouse button
Made 'drop target' animation consistent with where tab is actually dropped
Cleanup code.
CCBUG: 305443

6 years agoFix endless recursion with MDI shadows
Hugo Pereira Da Costa [Mon, 27 Aug 2012 21:11:24 +0000 (23:11 +0200)]
Fix endless recursion with MDI shadows
Thanks Christoph Feck !
REVIEW: 106240
CCBUG: 305590

6 years agoDon't associate an app to a launcher if both have valid but different launcher URLs.
Craig Drummond [Mon, 27 Aug 2012 19:30:31 +0000 (20:30 +0100)]
Don't associate an app to a launcher if both have valid but different launcher URLs.
BUG: 303162

6 years agoMake Startup Feedback Effect aka Bouncing Cursor respect global size for small icons
Kai Uwe Broulik [Mon, 27 Aug 2012 09:14:03 +0000 (11:14 +0200)]
Make Startup Feedback Effect aka Bouncing Cursor respect global size for small icons

BUG: 305611
REVIEW: 106166
FIXED-IN: 4.9.1

6 years agoStart building up of ClientModel with the first Client to include
Martin Gräßlin [Thu, 23 Aug 2012 06:39:07 +0000 (08:39 +0200)]
Start building up of ClientModel with the first Client to include

So far the first Client to be shown in the list (that is the
currently active window) was inserted as the last client into
the list by prepending it to the list.

This meant that if another Client actually blocks the inclusion
of the currently selected Client (e.g. only one window per app)
the currently active Client never got included in this list.

This change ensures that the recently used model switching has
the starting Client as the first Client in the list and also
simplifies the code.

Stacking order switching mode is not adjusted as it seems rather
broken, like the comment already says.

BUG: 304950
FIXED-IN: 4.9.1
REVIEW: 106139

6 years agoUse the first client as entrance to the focus chain if no active window
Martin Gräßlin [Sun, 19 Aug 2012 17:32:56 +0000 (19:32 +0200)]
Use the first client as entrance to the focus chain if no active window

The recently used mode of TabBox uses the active window as the entrance
into the focus chain. If there is no active window it does not find any
Clients. To solve this issue the ClientModel now uses the first entry
of the focus chain in case there is no active window.

BUG: 305449
FIXED-IN: 4.9.1
REVIEW: 106088

6 years agoReserve space for text and free space bar
Jacopo De Simoi [Sun, 26 Aug 2012 11:22:58 +0000 (13:22 +0200)]
Reserve space for text and free space bar

Reserve the height for the text and the
free space bar while invisible, to avoid jumpyness


6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sat, 25 Aug 2012 15:58:14 +0000 (17:58 +0200)]
SVN_SILENT made messages (.desktop file)

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Thu, 23 Aug 2012 19:17:30 +0000 (21:17 +0200)]
SVN_SILENT made messages (.desktop file)

6 years agoDelay setting passive status
Jacopo De Simoi [Wed, 22 Aug 2012 17:51:59 +0000 (19:51 +0200)]
Delay setting passive status

Set passive status after some delay
to allow users to be notified that it is safe to
remove the device before the applet becomes hidden


6 years agoChange icon to reflect (un)mount success/failure
Jacopo De Simoi [Wed, 22 Aug 2012 17:27:24 +0000 (19:27 +0200)]
Change icon to reflect (un)mount success/failure

This finally fixes a regression introduced with the
QML version of the device notifier.
After a mount or unmount request, change the systray icon
to reflect success or failure of the operation

6 years agomake the client shutdown timeout configurable
Martin Koller [Wed, 22 Aug 2012 14:49:04 +0000 (16:49 +0200)]
make the client shutdown timeout configurable

sometimes the timeout for applications to shutdown is too short, e.g.
when running on old hardware, having lots of applications open,
browsers with many tabs, etc.
This patch adds two config entries with which you can define the
timeout before ksmserver kills the apps.
In the [General] section of ksmserverrc you can define:
legacySaveTimeoutSecs (default = 4 seconds)
clientShutdownTimeoutSecs (default = 15 seconds; was 10 before)

BUG: 248459
BUG: 273326
FIXED-IN: 4.9.1
REVIEW: 106090

6 years agoAdd missing icon (thanks to Ludovic Grossard for spotting).
Yuri Chornoivan [Wed, 22 Aug 2012 14:11:03 +0000 (17:11 +0300)]
Add missing icon (thanks to Ludovic Grossard for spotting).

6 years agoFix multiple issues in colors KCM
Christoph Feck [Tue, 21 Aug 2012 19:09:38 +0000 (21:09 +0200)]
Fix multiple issues in colors KCM

- do not offer "Current" (or "Default") name for saving
- update preview icon when a colors gets changed
- write "Current" as scheme name, when the temporary theme is used
- upon loading the "Current" scheme, mark it as "needs saving"
- update preview icon for "Current" scheme when it is applied

See review description for details.

REVIEW: 106066
BUG: 305350
FIXED-IN: 4.9.1

6 years agoUse forward declaration
Christoph Feck [Mon, 13 Aug 2012 14:41:37 +0000 (16:41 +0200)]
Use forward declaration

Instead of including a file from another target, which might
not have been generated yet.

BUG: 304987
FIXED-IN: 4.9.1
(cherry picked from commit 46b9acb42eed48f0fd3b9d2391dc8a217003cafc)

6 years agoReset shader state in TrackMouse effect prior to render it
Martin Gräßlin [Thu, 16 Aug 2012 06:19:45 +0000 (08:19 +0200)]
Reset shader state in TrackMouse effect prior to render it

The Shader might have left-overs from last usage which might
cause the effect to not work properly.

BUG: 304404
FIXED-IN: 4.9.1
Reviewed By: Thomas Lübking

6 years agoShow menu instead of triggering default action when clicking on
Lamarque V. Souza [Sat, 18 Aug 2012 17:06:25 +0000 (14:06 -0300)]
Show menu instead of triggering default action when clicking on
KSMButton.qml's icon in shutdown dialog.

CCBUG: 304907

6 years agoInclude <signal.h> for kill(2)
Raphael Kubo da Costa [Fri, 17 Aug 2012 23:34:07 +0000 (20:34 -0300)]
Include <signal.h> for kill(2)

6 years agoUse C-style comments after kdelibs commit 49c4f6c.
Raphael Kubo da Costa [Fri, 17 Aug 2012 22:47:40 +0000 (19:47 -0300)]
Use C-style comments after kdelibs commit 49c4f6c.

Now that -std=iso9899:1990 is passed to gcc on FreeBSD, C++-style
comments are not accepted anymore.
(cherry picked from commit 043e3473d31598e7675f91f638ce21c9a5b8cd3c)

6 years agoEnsure that titleHeight is at least height of buttons
Martin Gräßlin [Wed, 8 Aug 2012 21:14:51 +0000 (23:14 +0200)]
Ensure that titleHeight is at least height of buttons

Required to properly lay out the title in case of vertical or
bottom alignment.

BUG: 304822
FIXED-IN: 4.9.1
REVIEW: 105937

6 years agoEffects can provide support information through properties
Martin Gräßlin [Sat, 11 Aug 2012 09:24:37 +0000 (11:24 +0200)]
Effects can provide support information through properties

The supportInformation is extended to also read the properties
on all effects. In addition each effect can be queried just for
itself through D-Bus, e.g.:
qdbus org.kde.kwin /KWin supportInformationForEffect kwin4_effect_blur

All effects are extended to provide their configured and read
settings through properties. In some cases also important
runtime information is exposed.

REVIEW: 105977
BUG: 305338
FIXED-IN: 4.9.1

6 years agoVerify QVariant is valid before casting to Client*
Martin Gräßlin [Wed, 8 Aug 2012 20:28:22 +0000 (22:28 +0200)]
Verify QVariant is valid before casting to Client*

If the ClientModel does not contain any Clients, which can
happen if there is no desktop window, accessing the data of a
ModelIndex returns an invalid QVariant. Because of that it
needs to be ensured that the QVariant is valid before trying to
cast it to a Client Pointer.

BUG: 304620
FIXED-IN: 4.9.1
REVIEW: 105935

6 years agoProperly elide text in large icons TabBox theme
Martin Gräßlin [Thu, 9 Aug 2012 11:26:43 +0000 (13:26 +0200)]
Properly elide text in large icons TabBox theme

Using the same elide adjustments as in Thumbnails theme.

BUG: 304847
FIXED-IN: 4.9.1
REVIEW: 105959

6 years agoHonor the decoration font in Aurorae
Martin Gräßlin [Thu, 9 Aug 2012 07:44:40 +0000 (09:44 +0200)]
Honor the decoration font in Aurorae

Adding two properties to the AuroraeFactory to read the active
and inactive title font.

BUG: 304791
FIXED-IN: 4.9.1
REVIEW: 105956

6 years agoFix menu items not clickable problem in QML shutdown dialog.
Lamarque V. Souza [Fri, 17 Aug 2012 13:09:37 +0000 (10:09 -0300)]
Fix menu items not clickable problem in QML shutdown dialog.

BUG: 304907
FIXED-IN: 4.9.1

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Fri, 17 Aug 2012 13:03:17 +0000 (15:03 +0200)]
SVN_SILENT made messages (.desktop file)

6 years agoMake the brightness OSD adjust its size to the used DPIs.
Michael Zanetti [Mon, 6 Aug 2012 22:10:13 +0000 (00:10 +0200)]
Make the brightness OSD adjust its size to the used DPIs.

This makes the OSD look nice on high resolution screens (e.g Retina Displays) and aligns it with the Volume OSD.

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Thu, 16 Aug 2012 14:00:56 +0000 (16:00 +0200)]
SVN_SILENT made messages (.desktop file)

6 years agoincrease the width of group items in the popup
Martin Koller [Wed, 15 Aug 2012 21:45:07 +0000 (23:45 +0200)]
increase the width of group items in the popup

this patch changes the width of the task group popup to be able
to read the full title of the window.
The minimum width is like it was before, but if the title is wider,
it will increase the width up to 80% of the available corona width.

BUG: 302125
FIXED-IN: 4.9.1
REVIEW: 105849

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Tue, 14 Aug 2012 21:40:10 +0000 (23:40 +0200)]
SVN_SILENT made messages (.desktop file)

6 years agofix wrong panel positioning, especially when more than one monitor is present
Rolf Eike Beer [Mon, 16 Jul 2012 16:27:12 +0000 (18:27 +0200)]
fix wrong panel positioning, especially when more than one monitor is present

This workaround was found by Kai Dombrowe. This is likely just papering over a
deeper issue, but for the time being this just makes the panel work.


6 years agoDo not trigger krunner when the Space key is pressed
Jekyll Wu [Tue, 14 Aug 2012 12:35:04 +0000 (20:35 +0800)]
Do not trigger krunner when the Space key is pressed

BUG: 304805
FIXED-IN: 4.9.1
REVIEW: 105889

6 years agoShow the whole picture in shutdown dialog.
Lamarque V. Souza [Tue, 14 Aug 2012 01:48:53 +0000 (22:48 -0300)]
Show the whole picture in shutdown dialog.

BUG: 303435
FIXED-IN: 4.9.1

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Mon, 13 Aug 2012 16:22:10 +0000 (18:22 +0200)]
SVN_SILENT made messages (.desktop file)

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sun, 12 Aug 2012 13:57:38 +0000 (15:57 +0200)]
SVN_SILENT made messages (.desktop file)

6 years agouse virtual screen size when desktop is resized
Thomas Lübking [Sat, 11 Aug 2012 19:32:27 +0000 (21:32 +0200)]
use virtual screen size when desktop is resized

QDesktopWidget::screenGeometry() fails if there's a panning or overlapping screen setup

REVIEW: 105974
BUG: 302783
FIXED-IN: 4.9.1

6 years agohide horizontal wheel events from the deco list
Thomas Lübking [Wed, 8 Aug 2012 17:52:38 +0000 (19:52 +0200)]
hide horizontal wheel events from the deco list

BUG: 304799
FIXED-IN: 4.9.1
REVIEW: 105934

6 years agoensure the feedbackRect is always up-to-date
Thomas Lübking [Wed, 8 Aug 2012 17:51:00 +0000 (19:51 +0200)]
ensure the feedbackRect is always up-to-date

BUG: 304253
REVIEW: 105786
FIXED-IN: 4.9.1

6 years agoFix tabboxconfig copy operator
Thomas Lübking [Wed, 8 Aug 2012 17:49:32 +0000 (19:49 +0200)]
Fix tabboxconfig copy operator

REVIEW: 105880
FIXED-IN: 4.9.1

6 years agocheck desktopNameFrame pointer in cube effect
Thomas Lübking [Wed, 8 Aug 2012 17:48:35 +0000 (19:48 +0200)]
check desktopNameFrame pointer in cube effect

REVIEW: 105840
BUG: 304340
FIXED-IN: 4.9.1

6 years agoFix problem with menus not clickable in QML shutdown dialog.
Lamarque V. Souza [Sat, 11 Aug 2012 00:09:38 +0000 (21:09 -0300)]
Fix problem with menus not clickable in QML shutdown dialog.

BUG: 304907
FIXED-IN: 4.9.1
(cherry picked from commit 14b0486208ac9f362d98d7948270d2b6295e1575)

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Fri, 10 Aug 2012 15:29:15 +0000 (17:29 +0200)]
SVN_SILENT made messages (.desktop file)

6 years agoMove blur behind setting for dashboard to windowAdded slot
Martin Gräßlin [Fri, 10 Aug 2012 08:01:23 +0000 (10:01 +0200)]
Move blur behind setting for dashboard to windowAdded slot

We always want to have blur behind the Dashboard window not
just after the activitation.

BUG: 304564
FIXED-IN: 4.9.1
REVIEW: 105962

6 years agoProperly calculate the offset between multiple screens in FlipSwitch
Martin Gräßlin [Thu, 9 Aug 2012 10:51:12 +0000 (12:51 +0200)]
Properly calculate the offset between multiple screens in FlipSwitch

The code assumed that screens border to each other. That is the height
of the one screen is the y position of the other screen.

BUG: 304520
FIXED-IN: 4.9.1
REVIEW: 105958

6 years agoDelay maximize operation by one event cycle
Martin Gräßlin [Fri, 10 Aug 2012 06:52:11 +0000 (08:52 +0200)]
Delay maximize operation by one event cycle

The result of maximizing a window might be the decoration
going away. Because of that we need to delay the handling of
maximize and title bar double click by one cycle as had been
done for other close operations in 0fea5325

BUG: 304870
FIXED-IN: 4.9.1
REVIEW: 105961

6 years agoMPRIS2: assume the position is 0 when stopped
Alex Merry [Thu, 9 Aug 2012 18:45:06 +0000 (19:45 +0100)]
MPRIS2: assume the position is 0 when stopped

MPRIS2 does not require the Seeked() signal to be emitted when stopping
a track.  It does, however, require it to be emitted if the position is
not 0 when going from Stopped to Playing (or Paused).

So we should assume the position is 0 when Stopped.

This fixes an issue I noticed with gmusicbrowser, where stopping a track
and starting it again would show the wrong time in the Now Playing

Backport of dc7074f9f503aac54007952d7429d8f1eb6a80c2

FIXED-IN: 4.9.1

6 years agoFix calculation of notification timeout
Martin Koller [Wed, 8 Aug 2012 21:29:59 +0000 (23:29 +0200)]
Fix calculation of notification timeout

BUG: 178411
FIXED-IN: 4.9.1
REVIEW: 105858

6 years agoMerge branch 'KDE/4.9' of git://anongit.kde.org/kde-workspace into KDE/4.9
Martin Koller [Wed, 8 Aug 2012 10:06:29 +0000 (12:06 +0200)]
Merge branch 'KDE/4.9' of git://anongit.kde.org/kde-workspace into KDE/4.9

6 years agoFix namespace usage; remove obsolete member var
Martin Koller [Wed, 8 Aug 2012 10:05:02 +0000 (12:05 +0200)]
Fix namespace usage; remove obsolete member var