From 4a6aa872e6055d283e81f4306d8850d9b5b57a16 Mon Sep 17 00:00:00 2001
From: =?utf8?q?V=C3=ADctor=20Manuel=20J=C3=A1quez=20Leal?=
 <vjaquez@igalia.com>
Date: Tue, 2 Jun 2009 16:56:22 +0200
Subject: [PATCH] Implemented 3rd party package policy to no break SSU.

* src/apt-worker-proto.h: Added status_incompatible_thirdparty installable
  package status.
* src/apt-worker.cc (package_policy_status): New function.
  (cmd_get_package_info): Set the installable status given the new function.
---
 src/apt-worker-proto.h |  3 +-
 src/apt-worker.cc      | 75 +++++++++++++++++++++++++++++++++++++++++++++-----
 2 files changed, 70 insertions(+), 8 deletions(-)

diff --git a/src/apt-worker-proto.h b/src/apt-worker-proto.h
index 2c0ad85..9b21c75 100644
--- a/src/apt-worker-proto.h
+++ b/src/apt-worker-proto.h
@@ -284,7 +284,8 @@ enum apt_proto_able_status {
   status_incompatible,             // incompatible in general
   status_incompatible_current,     // incompatible with current OS
   status_system_update_unremovable,// could be removed but it's a bad idea
-  status_not_found                 // there is no such package
+  status_not_found,                // there is no such package
+  status_incompatible_thirdparty   // package that breaks the SSU policy
 };
 
 enum apt_proto_install_flags {
diff --git a/src/apt-worker.cc b/src/apt-worker.cc
index 2902358..96884ee 100644
--- a/src/apt-worker.cc
+++ b/src/apt-worker.cc
@@ -2680,7 +2680,7 @@ get_description (int summary_kind,
 
   return res;
 }
-	 
+
 static string
 get_short_description (int summary_kind,
 		       pkgCache::PkgIterator &pkg,
@@ -3003,7 +3003,7 @@ installable_status ()
   AptWorkerCache *awc = AptWorkerCache::GetCurrent ();
   pkgDepCache &cache = *(awc->cache);
   int installable_status = status_unable;
-  
+
   for (pkgCache::PkgIterator pkg = cache.PkgBegin();
        pkg.end() != true;
        pkg++)
@@ -3033,6 +3033,67 @@ installable_status ()
 }
 
 static int
+package_policy_status (pkgCache::PkgIterator pkg, bool only_user)
+{
+  AptWorkerCache *awc = AptWorkerCache::GetCurrent ();
+  pkgDepCache &cache = *(awc->cache);
+  pkgCache::VerIterator candidate = cache[pkg].CandidateVerIter (cache);
+
+  if (only_user
+      && (candidate.end () || !is_user_package (candidate)))
+    return status_able;
+
+  // skip system update meta-packages that are not installed
+  if (only_user && !candidate.end ())
+    {
+      package_record rec (candidate);
+      int flags = get_flags (rec);
+      if (flags & pkgflag_system_update)
+	return status_able;
+    }
+
+  for (pkgCache::DepIterator Dep = candidate.DependsList ();
+       Dep.end () != true;
+       Dep++)
+    {
+      pkgCache::PkgIterator dpkg = Dep.TargetPkg ();
+      pkgCache::VerIterator verdpkg = cache[dpkg].CandidateVerIter (cache);
+
+      // Check only non-user packages
+      if (verdpkg.end () || is_user_package (verdpkg))
+	continue;
+
+
+      int op = Dep->CompareOp & 0x0F;
+
+      if (Dep->Type == pkgCache::Dep::Depends)
+	{
+	  if (op == pkgCache::Dep::NoOp
+	      || op == pkgCache::Dep::GreaterEq
+	      || op == pkgCache::Dep::Greater)
+	    continue;
+
+	  log_stderr ("%s breaks 3rd party dependencies policy:",
+		      pkg.Name ());
+	  return status_incompatible_thirdparty;
+	}
+      else if (Dep->Type == pkgCache::Dep::Conflicts)
+	{
+	  if (op == pkgCache::Dep::NoOp
+	      || op == pkgCache::Dep::Less
+	      || op == pkgCache::Dep::LessEq
+	      || op == pkgCache::Dep::Equals)
+	    continue;
+
+	  log_stderr ("%s breaks 3rd party conflicts policy", pkg.Name ());
+	  return status_incompatible_thirdparty;
+	}
+    }
+
+  return status_able;
+}
+
+static int
 removable_status ()
 {
   AptWorkerCache *awc = AptWorkerCache::GetCurrent ();
@@ -3044,7 +3105,7 @@ removable_status ()
       if (cache[pkg].InstBroken())
 	return status_needed;
     }
-  
+
   return status_unable;
 }
 
@@ -3071,12 +3132,12 @@ cmd_get_package_info ()
       pkgCache::PkgIterator pkg = cache.FindPkg (package);
 
       // simulate install
-      
+
       mark_named_package_for_install (package);
       if (any_newly_or_related_broken ())
 	info.installable_status = installable_status ();
       else
-	info.installable_status = status_able;
+	info.installable_status = package_policy_status (pkg, true);
       info.download_size = (int64_t) cache.DebSize ();
       info.install_user_size_delta = (int64_t) cache.UsrSize ();
 
@@ -3098,7 +3159,7 @@ cmd_get_package_info ()
       if (!only_installable_info)
 	{
 	  // simulate remove
-	  
+
 	  if (!strcmp (package, "magic:sys"))
 	    {
 	      info.removable_status = status_system_update_unremovable;
@@ -3137,7 +3198,7 @@ cmd_get_package_info ()
 	    }
 	}
     }
-  
+
   response.encode_mem (&info, sizeof (apt_proto_package_info));
 }
 
-- 
2.1.4