crawl:crawl.git
3 years agoChangelog through 0.16-a0-4134-g2ca243f 0.16-b1
Nicholas Feinberg [Tue, 3 Mar 2015 02:29:03 +0000 (18:29 -0800)]
Changelog through 0.16-a0-4134-g2ca243f

3 years agoLet Ashenzari's skill boost handle unrandart staves
Chris Campbell [Tue, 3 Mar 2015 01:53:20 +0000 (01:53 +0000)]
Let Ashenzari's skill boost handle unrandart staves

Instead of just boosting staves skill when wielding unrandart staves, treat
them like regular magical staves (boosting both evocations and staves for
those with a melee effect such as the Elemental Staff, evocations only for
staves with an evokable ability such as the staff of Wucad Mu, etc).

3 years agoMerge branch 'zotdef_removal'
Chris Campbell [Mon, 2 Mar 2015 22:27:32 +0000 (22:27 +0000)]
Merge branch 'zotdef_removal'

3 years agoMention Bend Time on ^ when worshipping Chei (Tuxi[Qyou])
Chris Campbell [Mon, 2 Mar 2015 22:25:29 +0000 (22:25 +0000)]
Mention Bend Time on ^ when worshipping Chei (Tuxi[Qyou])

And display a message when gaining Chei's slowed metabolism.

3 years agoUpdate some hints mode messages
Chris Campbell [Sun, 1 Mar 2015 23:06:00 +0000 (23:06 +0000)]
Update some hints mode messages

3 years agoUpdate some tutorial messages
Chris Campbell [Sun, 1 Mar 2015 20:02:48 +0000 (20:02 +0000)]
Update some tutorial messages

3 years agoMake catoblepas speed 10 and reduce their breath spam a bit (minmay)
gammafunk [Mon, 2 Mar 2015 03:39:38 +0000 (21:39 -0600)]
Make catoblepas speed 10 and reduce their breath spam a bit (minmay)

Them having both low-damage breath and slow action means they were very
easy to escape. They're now speed 10, and their breath weighting has
been reduced so that they'll use it about 20% less often than they did
at speed 8, since it was too frequent even then.

3 years agoSimplify (wheals)
Neil Moore [Mon, 2 Mar 2015 00:38:38 +0000 (19:38 -0500)]
Simplify (wheals)

3 years agoDon't include (inert) in the action table for xp evokers (9486)
Edgar A. Bering IV [Mon, 2 Mar 2015 00:31:10 +0000 (18:31 -0600)]
Don't include (inert) in the action table for xp evokers (9486)

3 years agoBe a little more careful.
Neil Moore [Mon, 2 Mar 2015 00:20:40 +0000 (19:20 -0500)]
Be a little more careful.

I didn't mean to replace all those checks, just the base_type part.

3 years agoStop vampire feeding when a corpse skeletonises.
Neil Moore [Mon, 2 Mar 2015 00:00:26 +0000 (19:00 -0500)]
Stop vampire feeding when a corpse skeletonises.

See for example:
    http://crawl.akrasiac.org/rawdata/Kitty/crash-Kitty-20150301-233403.txt

And improve a related message.

3 years agoFix debug mode compilation (oops)
Neil Moore [Sun, 1 Mar 2015 22:58:03 +0000 (17:58 -0500)]
Fix debug mode compilation (oops)

Introduced by my "improvement" in 0.16-a0-4120-gb205902.

3 years agoRemove unique annotations for god gifts and pacification (dpeg, #9475)
Edgar A. Bering IV [Sun, 1 Mar 2015 21:56:12 +0000 (15:56 -0600)]
Remove unique annotations for god gifts and pacification (dpeg, #9475)

If you convert Saint Roka his annotation follows you around even though
he's an ally. Additionally, prior to this patch, a annotation was only
removed for a pacified unique if the player saw the unique leave. This
has been changed to remove the annotation on pacification.

This has a possible edge case that I don't think can actually happen. If
the unique is pacified and then becomes hostile again before leaving out
of the player's sight the annotation won't be re-added, which could lead
to a player being surprised. If this can happen (maybe with clouds?)
it's far less frequent than an annotation remaining because the player
did not see the monster leave.

[Committer's note: removed a set of braces. -nfm]

3 years agoDon't use typedef with anonymous structs (minmay)
Neil Moore [Sun, 1 Mar 2015 22:08:32 +0000 (17:08 -0500)]
Don't use typedef with anonymous structs (minmay)

This isn't C.

3 years agoPrevent infinite recursion via frenzied twins (#9137)
Zannick [Sat, 31 Jan 2015 21:58:07 +0000 (13:58 -0800)]
Prevent infinite recursion via frenzied twins (#9137)

- Don't attempt to make a frenzied twin hostile since it won't work.
- Don't convert one twin if the other dies insane.
- Refactor some common twin-finding code into a separate function.
- Hold off on upgrading them until after they come out of it. Duvessa
  won't be able to berserk while insane or exhausted anyways, and Dowan
  can't really cast while insane, so this mostly affects when Dowan's
  spell set changes and the message printed.
- A twin that comes out of frenzy reverts to the same attitude as their
  twin (or hostile if that twin is still frenzied or dead). This, I think,
  makes the most sense, since the only sources of frenzy are: the monster
  spell (which neither has), the AoE player spell, and the needle. And,
  let's face it, if both get frenzied by a monster using needles, it's
  probably the player's fault.
- Add "frenzied and insane" to monsters' debug descriptions.

[Committer's note: Lifted a comma_separated_line call out of both sides
 of an if; and fixed braces. -nfm]

3 years agoAmbrosia no longer heals more when performing fast actions (#9504)
Edgar A. Bering IV [Fri, 27 Feb 2015 16:58:09 +0000 (10:58 -0600)]
Ambrosia no longer heals more when performing fast actions (#9504)

3 years agoDon't suppress textinput events for AltGr on Windows (#9306)
Neil Moore [Sun, 1 Mar 2015 20:41:30 +0000 (15:41 -0500)]
Don't suppress textinput events for AltGr on Windows (#9306)

Ignore the keydown events entirely.  Thanks to Lasty for helping find the
right combination of modifiers to look for.

3 years agoDon't put an extra newline after wrapcprintf.
Neil Moore [Sun, 1 Mar 2015 20:06:06 +0000 (15:06 -0500)]
Don't put an extra newline after wrapcprintf.

This put the cursor in the wrong place when editing a pre-filled
input line (modifying an inscription, for example).

Introduced in 0.16-a0-4058-ga3e9557, oops.

3 years agoExtend auto-pickup behavior to inert evokables (minmay)
Corin Buchanan-Howland [Sun, 1 Mar 2015 19:21:58 +0000 (14:21 -0500)]
Extend auto-pickup behavior to inert evokables (minmay)

3 years agoMake ARTP_CURSED less recursive.
Neil Moore [Sun, 1 Mar 2015 03:38:14 +0000 (22:38 -0500)]
Make ARTP_CURSED less recursive.

3 years agoUpdate test/stress/qw.rc.
elliptic [Sun, 1 Mar 2015 00:12:55 +0000 (19:12 -0500)]
Update test/stress/qw.rc.

With many fixes and improvements. The main home for qw.rc is
https://github.com/elliptic/qw, and just two changes have been made to it
for inclusion here: AUTO_START = true and clear_messages = false.

3 years agoBone dragon tile (CanOfWorms)
ontoclasm [Fri, 27 Feb 2015 19:52:33 +0000 (13:52 -0600)]
Bone dragon tile (CanOfWorms)

3 years agoGelatinous tiles (CanOfWorms)
ontoclasm [Thu, 26 Feb 2015 05:56:53 +0000 (23:56 -0600)]
Gelatinous tiles (CanOfWorms)

3 years agoDon't butt-lify "fly" (PleasingFungus)
Neil Moore [Thu, 26 Feb 2015 04:34:05 +0000 (23:34 -0500)]
Don't butt-lify "fly" (PleasingFungus)

3 years agoTweak the % title when space is low (ChrisOelmueller)
Neil Moore [Thu, 26 Feb 2015 03:48:30 +0000 (22:48 -0500)]
Tweak the % title when space is low (ChrisOelmueller)

If the character name etc. are wide enough that there is no room for
the name + char abbreviation + title, at least leave a space between
the name and the char abbreviation.

3 years agoRefactor _overview_screen_title (wheals)
Neil Moore [Thu, 26 Feb 2015 03:41:16 +0000 (22:41 -0500)]
Refactor _overview_screen_title (wheals)

Remove the for-switch, as it is just Too Powerful. Also use strings instead
of fixed buffers.

3 years agoSync manual from wiki
Chris Campbell [Wed, 25 Feb 2015 20:45:01 +0000 (20:45 +0000)]
Sync manual from wiki

3 years agoUse ITEM_IN_INVENTORY more.
Neil Moore [Wed, 25 Feb 2015 19:07:25 +0000 (14:07 -0500)]
Use ITEM_IN_INVENTORY more.

3 years agoUndangle an else.
Neil Moore [Wed, 25 Feb 2015 18:48:02 +0000 (13:48 -0500)]
Undangle an else.

Yes, the standard says it parses as we want it to, but still...

3 years agoSimplify.
Shmuale Mark [Wed, 25 Feb 2015 18:34:39 +0000 (13:34 -0500)]
Simplify.

3 years agoEncapsulate a hack somewhat.
Shmuale Mark [Wed, 25 Feb 2015 18:15:06 +0000 (13:15 -0500)]
Encapsulate a hack somewhat.

3 years agoCall link_items before unmarshalling monster (#9350).
Shmuale Mark [Wed, 25 Feb 2015 18:04:12 +0000 (13:04 -0500)]
Call link_items before unmarshalling monster (#9350).

This should fix a rare crash with an Enslave Soul'd Ilsuiw.

3 years agoProperly inherit colour when reviving dead cats
gammafunk [Wed, 25 Feb 2015 18:00:06 +0000 (12:00 -0600)]
Properly inherit colour when reviving dead cats

3 years agoRemove some dead bennu code.
Shmuale Mark [Wed, 25 Feb 2015 17:33:58 +0000 (12:33 -0500)]
Remove some dead bennu code.

3 years agoMake bennu revival a fineff (#6401)
Neil Moore [Wed, 25 Feb 2015 16:58:03 +0000 (11:58 -0500)]
Make bennu revival a fineff (#6401)

This fixes some tornado-related crashes.  Felid revival should get the
same treatment, but that is harder because of the need to preserve items.

3 years agoNew reaper tile (CanOfWorms)
gammafunk [Wed, 25 Feb 2015 03:26:54 +0000 (21:26 -0600)]
New reaper tile (CanOfWorms)

Also add worms to CREDITS.txt

3 years agoDon't claim sensed monsters have rN+++ (#9505)
Neil Moore [Wed, 25 Feb 2015 02:31:10 +0000 (21:31 -0500)]
Don't claim sensed monsters have rN+++ (#9505)

Maybe it would have been simpler to make MONS_SENSED_* natural holiness.

3 years agoReplace Qazlal's lava wrath effect with noise
Chris Campbell [Tue, 24 Feb 2015 12:09:31 +0000 (12:09 +0000)]
Replace Qazlal's lava wrath effect with noise

Creating lava around the player was more likely to be helpful than harmful.

3 years agoLet lava monsters flop around on dry land
Chris Campbell [Tue, 24 Feb 2015 17:23:34 +0000 (17:23 +0000)]
Let lava monsters flop around on dry land

Possible by creating temporary lava and having it expire from underneath a
lava-only monster - previously it would just happily start walking around on
dry land. Now it will flop around and try and dive back into lava, as water
monsters do.

3 years agoRevert "The triumphant return of the blowgun of the Assassin"
Chris Campbell [Tue, 24 Feb 2015 16:17:14 +0000 (16:17 +0000)]
Revert "The triumphant return of the blowgun of the Assassin"

Sadly nogen was never actually removed from the blowgun, so this change never
even saw the light of day. Blowgun stabbing is a fairly obscure mechanic and
this seems unlikely to have made the unrand particularly worthwhile if it had
been able to generate, though.

This reverts commit c6df229c84c6.

3 years agoFunction-ise a duplicated formula
Chris Campbell [Tue, 24 Feb 2015 01:38:49 +0000 (01:38 +0000)]
Function-ise a duplicated formula

3 years agoDisallow reaching with clubs (nicolae-).
Shmuale Mark [Tue, 24 Feb 2015 16:26:37 +0000 (11:26 -0500)]
Disallow reaching with clubs (nicolae-).

3 years agoReduce the number of temporary mutations cured at a time
Chris Campbell [Mon, 23 Feb 2015 20:32:42 +0000 (20:32 +0000)]
Reduce the number of temporary mutations cured at a time

With a low number of temporary mutations afflicting the player - with lots of
temporary mutations more still expire at a time.

3 years agoFix temporary mutations after the first expiring more quickly
Chris Campbell [Mon, 23 Feb 2015 20:19:06 +0000 (20:19 +0000)]
Fix temporary mutations after the first expiring more quickly

Broken since 0f3ca609f91bac, woops!

3 years agoDon't deal HP damage when losing an XL (|amethyst)
Chris Campbell [Mon, 23 Feb 2015 19:48:00 +0000 (19:48 +0000)]
Don't deal HP damage when losing an XL (|amethyst)

Relevant only for Ru's Sacrifice Experience, and made it possible to die by
taking the sacrifice with 8hp or less.

3 years agoDisable Zot Defence zotdef_removal
Chris Campbell [Thu, 19 Feb 2015 20:22:56 +0000 (20:22 +0000)]
Disable Zot Defence

It's very broken in a large variety of ways, and has been for a very long time.
Disable the mode, pending full removal in the near future unless some brave
soul volunteers to get it back into a playable condition.

3 years agoChangelog through 0.16-a0-4088-g7c8221e
Nicholas Feinberg [Mon, 23 Feb 2015 05:05:10 +0000 (21:05 -0800)]
Changelog through 0.16-a0-4088-g7c8221e

3 years agoRemove a redundant if
Nicholas Feinberg [Sun, 22 Feb 2015 18:13:41 +0000 (10:13 -0800)]
Remove a redundant if

Pointless since 73173809 (2012).

3 years agoRemove zap_type_to_spell()
Nicholas Feinberg [Sun, 22 Feb 2015 18:08:10 +0000 (10:08 -0800)]
Remove zap_type_to_spell()

Added by 708e7799 in 2009; redundant since spl-zap.cc was created
by 16abcfaea6b (2010). Also, only used in one place.

3 years agoMake fleshy orifices much more obvious
Nicholas Feinberg [Sun, 22 Feb 2015 05:39:14 +0000 (21:39 -0800)]
Make fleshy orifices much more obvious

With a crude contrast/brightness hack.

They were pretty stealthy before.

3 years agoMoved door tiles into their own directory
Nicholas Feinberg [Sun, 22 Feb 2015 05:34:36 +0000 (21:34 -0800)]
Moved door tiles into their own directory

Fleshy doors were in gateways, probably due to a misunderstanding.

3 years agoRemove Nem & Ely from arena sprint
Nicholas Feinberg [Sun, 22 Feb 2015 05:16:27 +0000 (21:16 -0800)]
Remove Nem & Ely from arena sprint

Exploration gods.

Not sure if there are other sprints that they cause trouble in?

3 years agoDon't crash when thorn hunters poly into oklobs.
Neil Moore [Sun, 22 Feb 2015 00:46:22 +0000 (19:46 -0500)]
Don't crash when thorn hunters poly into oklobs.

The assert would trigger when a spellcasting monster (thorn hunter)
polymorphed into an oklob plant, because we were calling set_hit_dice
before changing the spell list.

3 years agoRemove secret oklobs from bazaar_minmay_oklob.
elliptic [Sun, 22 Feb 2015 00:29:44 +0000 (19:29 -0500)]
Remove secret oklobs from bazaar_minmay_oklob.

And give it a more fitting name (contributed by |amethyst).

3 years agoRemove a redundant comment
Nicholas Feinberg [Sat, 21 Feb 2015 06:40:54 +0000 (22:40 -0800)]
Remove a redundant comment

3 years agoRemove _is_random_name_space
Nicholas Feinberg [Sat, 21 Feb 2015 06:11:49 +0000 (22:11 -0800)]
Remove _is_random_name_space

Come on.

3 years agoDeclare a make_name constant
Nicholas Feinberg [Sat, 21 Feb 2015 06:07:42 +0000 (22:07 -0800)]
Declare a make_name constant

3 years agoRemove a non-functional subst.
Neil Moore [Sat, 21 Feb 2015 21:59:40 +0000 (16:59 -0500)]
Remove a non-functional subst.

The Lua subst() call, unlike the SUBST: keyword in the des format, does
not accept a comma-separated list, but only a single substitution.  But it
appears the line wouldn't have done anything anyway, since HIJKL aren't
generated until later substs a few lines down.

Not changing to the "intended" behaviour (splitting the subst call and
moving it later) because that would be a difficulty nerf:

<st_> I didn't realise it was wrong so it can't have been too wrong :p

3 years agoRepeat viable selections more correctly (#9498)
Neil Moore [Sat, 21 Feb 2015 19:04:34 +0000 (14:04 -0500)]
Repeat viable selections more correctly (#9498)

If you selected background first, then chose viable race, you would as
expected get a viable race for that background.  But then when repeating
that selection for the next game (with Tab), you would have a 50% chance
of first selecting a viable race, then selecting the background,
resulting in a completely random race selection.  Now, if one selection
was 'viable', do the other one first.  If both were viable, continue to
use a random order.

If the player's selection was in fact viable race first, then background,
it was already being remembered as "random race", so that case isn't
affected.

3 years agoDon't assert when a monster kills itself then starts a fire.
Neil Moore [Sat, 21 Feb 2015 18:48:01 +0000 (13:48 -0500)]
Don't assert when a monster kills itself then starts a fire.

E.g. with a bounced lightning bolt:
  http://crawl.lantea.net/crawl/morgue/cribozai/crash-cribozai-20150221-183021.txt

The resulting cloud will be credited incorrectly: KC_OTHER even for
friendly creatures, and KILL_MISC rather than KILL_MON_MISSILE.  But
that's better than crashing.

3 years agoGive the correct corpse for polymorphed dracos/DS (PF)
Neil Moore [Sat, 21 Feb 2015 18:33:55 +0000 (13:33 -0500)]
Give the correct corpse for polymorphed dracos/DS (PF)

3 years agoCheckwhite
Nicholas Feinberg [Sat, 21 Feb 2015 05:04:16 +0000 (21:04 -0800)]
Checkwhite

3 years agoAdd a doxygen comment for ake_name
Nicholas Feinberg [Sat, 21 Feb 2015 05:03:51 +0000 (21:03 -0800)]
Add a doxygen comment for ake_name

3 years agoTweak hydra description
Nicholas Feinberg [Sat, 21 Feb 2015 02:14:40 +0000 (18:14 -0800)]
Tweak hydra description

Fix grammar ("hydra's") and try to improve a run-on sentence.

3 years agoRemove a duplicate faun spellbook (elliptic)
Chris Campbell [Fri, 20 Feb 2015 23:51:01 +0000 (23:51 +0000)]
Remove a duplicate faun spellbook (elliptic)

It existed as a hacky way to reduce confuse's frequency, before it was possible
to do that in spellbook definitions, and before spellbooks showed up on xv.
Just reduce confuse weight slightly instead.

3 years agoCorrectly display Gozag penance on Ctrl-O
Chris Campbell [Fri, 20 Feb 2015 22:51:21 +0000 (22:51 +0000)]
Correctly display Gozag penance on Ctrl-O

3 years agoMerge branch 'gozag_wrath'
Chris Campbell [Fri, 20 Feb 2015 23:14:23 +0000 (23:14 +0000)]
Merge branch 'gozag_wrath'

Conflicts:
crawl-ref/source/tag-version.h

3 years agoDon't crash when a raiju dies during blinkbolt (#9297)
Neil Moore [Fri, 20 Feb 2015 21:04:18 +0000 (16:04 -0500)]
Don't crash when a raiju dies during blinkbolt (#9297)

As Grunt points out at that bug, it would be better to place the raiju
off-map while it's blinkbolting, so it won't die to inner flame etc. at
its original position.  But this will at least prevent the crash.

3 years agoDon't crash when instakilling TSO summons (#9233)
Neil Moore [Fri, 20 Feb 2015 20:50:48 +0000 (15:50 -0500)]
Don't crash when instakilling TSO summons (#9233)

A daction might still be better, but this at least prevents the crash
and leaves us in a consistent state.

3 years agoDon't word wrap in the line reader.
Neil Moore [Fri, 20 Feb 2015 19:30:22 +0000 (14:30 -0500)]
Don't word wrap in the line reader.

This behaviour change, introduced in 0.8.0-a0-6162-g597a4ca, wasn't
reflected in the redrawing and cursor positioning code. Go back to the
space-agnostic column wrapping, but not to the old wrapcprintf code,
which didn't handle double-width or even multibyte characters.

There are still bugs related to cursor positioning and redrawing when a
double-width character wraps when there was still a single space on the
line.

This doesn't solve #5554 (reproducible crash in the line reader),
but probably does make it easier to fix.

3 years agoDisplay when potion petition is free in the extended desc
Chris Campbell [Fri, 20 Feb 2015 17:35:19 +0000 (17:35 +0000)]
Display when potion petition is free in the extended desc

3 years agoUpdate hydra description for short blade changes (magicpoints)
Chris Campbell [Fri, 20 Feb 2015 17:23:10 +0000 (17:23 +0000)]
Update hydra description for short blade changes (magicpoints)

3 years agoRemove a tile from rltiles/UNUSED now that it's in the player tileset
gammafunk [Thu, 19 Feb 2015 23:39:33 +0000 (17:39 -0600)]
Remove a tile from rltiles/UNUSED now that it's in the player tileset

3 years agoTHE GIAGGOSTUONO
gammafunk [Thu, 19 Feb 2015 22:51:44 +0000 (16:51 -0600)]
THE GIAGGOSTUONO

Legends say THE GIAGGOSTUONO came into being when some poor adventurer
read a scroll of the same...

Adding the tile and weapon/shield offsets for use with tile_player_tile.

3 years agoProperly handle UTF-8 in crawl.sendkeys()
Neil Moore [Thu, 19 Feb 2015 23:22:13 +0000 (18:22 -0500)]
Properly handle UTF-8 in crawl.sendkeys()

3 years agoUse %zu, not %Iu, when using mingw's (s)printf (johnny0)
Neil Moore [Thu, 19 Feb 2015 18:48:18 +0000 (13:48 -0500)]
Use %zu, not %Iu, when using mingw's (s)printf (johnny0)

Which we enable in our Makefile.

Also revert "Don't warn about %Iu in mingw (gammafunk)", since we in
fact don't want %Iu in MinGW builds.

This reverts commit b20b1ff792f4f6570047384dc3ee27ebc1f5794b.

3 years agoDon't warn about %Iu in mingw (gammafunk)
Neil Moore [Thu, 19 Feb 2015 18:20:26 +0000 (13:20 -0500)]
Don't warn about %Iu in mingw (gammafunk)

3 years agoShow MR chance for Tukima's (PF, #9496)
Neil Moore [Thu, 19 Feb 2015 18:10:53 +0000 (13:10 -0500)]
Show MR chance for Tukima's (PF, #9496)

3 years agoFix <Del> in the line reader (wheals)
Neil Moore [Thu, 19 Feb 2015 16:33:19 +0000 (11:33 -0500)]
Fix <Del> in the line reader (wheals)

Pressing delete with the cursor in the middle of the string doubled the
last character, and could also leave half a UTF-8 character at the
cursor.

There are still problems with wrapping: line_reader::cursorto assumes
raw wrapping, but we use wrapcprintf, which does word wrapping.

3 years agoHush a sign warning.
Neil Moore [Thu, 19 Feb 2015 15:02:02 +0000 (10:02 -0500)]
Hush a sign warning.

Tempted to use a #define, since a literal 3 would work in both places
without casts or warnings.

3 years agoTemporarily revert some mimic stuff (elliptic, wheals)
Neil Moore [Thu, 19 Feb 2015 14:26:08 +0000 (09:26 -0500)]
Temporarily revert some mimic stuff (elliptic, wheals)

"Refactor some mimic generation." and "Let Pan/Hell/Slime/Tomb have
mimics.", and techically also "Fix item mimics (travis, geekosaur,
wheals)".

elliptic reported a dungeon without a real Vaults entrance, and
Travis-CI noted a Hell branch level missing an exit.

At least part of those bugs could be fixed by changing:

if (feat_is_branch_entrance(feat)
     && level_id::current() != brentry[get_branch_at(pos)]
    || one_chance_in(FEATURE_MIMIC_CHANCE))

into:

if (feat_is_branch_entrance(feat)
    ? level_id::current() != brentry[get_branch_at(pos)]
    : one_chance_in(FEATURE_MIMIC_CHANCE))

But other bugs probably lurk.  Re-revert and fix that after
0.16 is released.

In reverse order:

This reverts commit f7bb3003942bc3e95c302d1acd36f2778069d04f.
This reverts commit 6cc37e00f954ea1edeea78d89ac3c9ed916fa784.
This reverts commit caa303aa219f4afee6d6518a96eeefc0c37c27e0.

3 years agoC++11ify.
Neil Moore [Thu, 19 Feb 2015 05:42:06 +0000 (00:42 -0500)]
C++11ify.

Now that the loop starts at the beginning, make it range-based.

3 years agoDon't delete wrong items from shopping list page two (hy-on-github)
Neil Moore [Thu, 19 Feb 2015 05:18:59 +0000 (00:18 -0500)]
Don't delete wrong items from shopping list page two (hy-on-github)

Menu::get_entry_index started counting at the beginning of the current
page, not the beginning of the list.  Since this shopping list code
is its only user, make it work as expected (and documented).

3 years agoDon't shuffle the shopping list when removing an item.
Neil Moore [Thu, 19 Feb 2015 04:43:04 +0000 (23:43 -0500)]
Don't shuffle the shopping list when removing an item.

3 years agoRename spell_fail() to raw_spell_fail().
elliptic [Thu, 19 Feb 2015 04:04:49 +0000 (23:04 -0500)]
Rename spell_fail() to raw_spell_fail().

Hopefully this reduces confusion.

3 years agoFix ghosts being far less likely to have spells than intended.
elliptic [Thu, 19 Feb 2015 03:52:02 +0000 (22:52 -0500)]
Fix ghosts being far less likely to have spells than intended.

The formula was using spell_fail(spell), which unfortunately is not the
actual failure rate...

3 years agoUpdate INSTALL.txt instructions for using Win-builds GCC under Windows
gammafunk [Wed, 18 Feb 2015 02:45:32 +0000 (20:45 -0600)]
Update INSTALL.txt instructions for using Win-builds GCC under Windows

3 years agoAdd a lava worm corpse tile (9492)
Nicholas Feinberg [Thu, 19 Feb 2015 01:39:02 +0000 (17:39 -0800)]
Add a lava worm corpse tile (9492)

Since it's trivial, even if it will never actually happen in
practice.

An extremely powerful prize will be awarded to the first person
who emails me with an in-game, ***NON-WIZMODE*** screenshot of
this corpse. Cheating will not be taken lightly!!!

3 years agoDon't trample water-/lava-bound creatures onto land (#9492)
Neil Moore [Thu, 19 Feb 2015 01:07:15 +0000 (20:07 -0500)]
Don't trample water-/lava-bound creatures onto land (#9492)

3 years agoFix item mimics (travis, geekosaur, wheals)
Neil Moore [Thu, 19 Feb 2015 00:31:51 +0000 (19:31 -0500)]
Fix item mimics (travis, geekosaur, wheals)

3 years agoRevert "Move some feature substitutions to the end of levelgen."
Neil Moore [Thu, 19 Feb 2015 00:00:38 +0000 (19:00 -0500)]
Revert "Move some feature substitutions to the end of levelgen."

The order matters here: _fixup_branch_stairs makes different
substitutions; it originally came after the Pan- and Hell-specific stair
fixups, but this commit made it come after.  As a result, Pan had a lot
more exits, and would occasionally generate a level without transits,
triggering an assert.

It might work to instead move _fixup_branch_stairs into
_apply_branch_substitutions (after the others), but I am not certain
there aren't other implications of that.  It would be worth trying after
0.16 is released.

This reverts commit d7eee1f81efc638608b48d67acf3ee1a3df8fbcf.

3 years agoQuote CREDITS.txt more consistently (mauris)
Neil Moore [Wed, 18 Feb 2015 23:32:42 +0000 (18:32 -0500)]
Quote CREDITS.txt more consistently (mauris)

3 years agoDoxx.
Neil Moore [Wed, 18 Feb 2015 23:23:26 +0000 (18:23 -0500)]
Doxx.

3 years agoReorder a member.
Neil Moore [Wed, 18 Feb 2015 22:15:21 +0000 (17:15 -0500)]
Reorder a member.

Not sure why I stuck this static method between two constructors.

3 years agoMove some feature substitutions to the end of levelgen.
Shmuale Mark [Wed, 18 Feb 2015 21:49:25 +0000 (16:49 -0500)]
Move some feature substitutions to the end of levelgen.

3 years agoLet Pan/Hell/Slime/Tomb have mimics.
Shmuale Mark [Wed, 18 Feb 2015 21:38:57 +0000 (16:38 -0500)]
Let Pan/Hell/Slime/Tomb have mimics.

3 years agoRefactor some mimic generation.
Shmuale Mark [Wed, 18 Feb 2015 21:33:06 +0000 (16:33 -0500)]
Refactor some mimic generation.

Including moving both passes to the very last stage of level generation.
I can't see anything obvious that could go wrong because of this (except
for Gozag shops, which have been set as no-mimic).

3 years agoRemove an apparent vestige of the shop hack.
Shmuale Mark [Wed, 18 Feb 2015 21:15:01 +0000 (16:15 -0500)]
Remove an apparent vestige of the shop hack.

3 years agoRemove some randart names that duplicate unrands
Chris Campbell [Wed, 18 Feb 2015 21:25:52 +0000 (21:25 +0000)]
Remove some randart names that duplicate unrands

Or nearly duplicate, in the case of "the robe of the Clouds".

3 years agoDon't claim that evoking the horn of Geryon makes other items of its kind inert
Chris Campbell [Wed, 18 Feb 2015 21:24:37 +0000 (21:24 +0000)]
Don't claim that evoking the horn of Geryon makes other items of its kind inert

Possibly the whole "spirits" thing could do with rewording for the horn (or
for evokers generally).