amarok:stecchinos-amarok.git
8 years agoBump plugin framework version. v2.2.0
Mark Kretschmann [Mon, 28 Sep 2009 13:01:01 +0000 (15:01 +0200)]
Bump plugin framework version.

8 years agoMake fading effect the default animation for Photo applet
Simon Esneault [Mon, 28 Sep 2009 14:55:14 +0000 (16:55 +0200)]
Make fading effect the default animation for Photo applet

8 years agoA little more hackishness to work around Phonon Xine 4.3 bugs.
Alex Merry [Mon, 28 Sep 2009 14:46:53 +0000 (15:46 +0100)]
A little more hackishness to work around Phonon Xine 4.3 bugs.

Phonon Xine in trunk has been fixed, and doesn't need these workarounds.

8 years agoformatting
Mark Kretschmann [Mon, 28 Sep 2009 12:07:07 +0000 (14:07 +0200)]
formatting

8 years agoadd fadeout fix
Mark Kretschmann [Mon, 28 Sep 2009 11:56:31 +0000 (13:56 +0200)]
add fadeout fix

8 years agoFix fadeout-on-stop
Alex Merry [Mon, 28 Sep 2009 11:45:20 +0000 (12:45 +0100)]
Fix fadeout-on-stop

8 years agoFix regression where the last album to be scanned might not have its cover set.
Jeff Mitchell [Sun, 27 Sep 2009 19:37:17 +0000 (15:37 -0400)]
Fix regression where the last album to be scanned might not have its cover set.

8 years agodebug--
Maximilian Kossick [Sun, 27 Sep 2009 15:31:50 +0000 (17:31 +0200)]
debug--

8 years agocorrectly emit data pointers even if there is o result
Maximilian Kossick [Sun, 27 Sep 2009 15:22:29 +0000 (17:22 +0200)]
correctly emit data pointers even if there is o result

8 years agoit might sound odd, but Amarok does not work better when escaping strings twice
Maximilian Kossick [Sun, 27 Sep 2009 11:22:26 +0000 (13:22 +0200)]
it might sound odd, but Amarok does not work better when escaping strings twice
(cherry picked from commit 062cafd3a4ad601d92b62b0044f56230e757a2a4)

8 years agodebug--
Maximilian Kossick [Sun, 27 Sep 2009 11:20:46 +0000 (13:20 +0200)]
debug--
(cherry picked from commit d868583ccfa5ce57237dfff1d3800a885b773f47)

8 years agoescaping a string once should be enough
Maximilian Kossick [Sun, 27 Sep 2009 09:54:54 +0000 (11:54 +0200)]
escaping a string once should be enough

8 years agofix string escaping for service collections
Maximilian Kossick [Sun, 27 Sep 2009 09:53:22 +0000 (11:53 +0200)]
fix string escaping for service collections

8 years agoChangeLog++
Nikolaj Hald Nielsen [Sun, 27 Sep 2009 12:23:26 +0000 (14:23 +0200)]
ChangeLog++

8 years agoMake sorting by track length in the playlist work.
Nikolaj Hald Nielsen [Sun, 27 Sep 2009 12:20:00 +0000 (14:20 +0200)]
Make sorting by track length in the playlist work.
BUG: 205963

8 years agoChangeLog++
Nikolaj Hald Nielsen [Sun, 27 Sep 2009 11:46:27 +0000 (13:46 +0200)]
ChangeLog++

8 years agoImmediately remove track bookmarks from progress slider when deleted from the bookmar...
Nikolaj Hald Nielsen [Sun, 27 Sep 2009 11:41:49 +0000 (13:41 +0200)]
Immediately remove track bookmarks from progress slider when deleted from the bookmark manager.

8 years agoDe-singltonify the ProgressWidget as it is now used in several toolbars.
Nikolaj Hald Nielsen [Sun, 27 Sep 2009 11:34:35 +0000 (13:34 +0200)]
De-singltonify the ProgressWidget as it is now used in several toolbars.
The progressWidgets now register themselves with the AmarokUrlHandler which takes care of making sure that they all update their bookmarks correctly.
This fixes bug 207091 and also takes care of new bookmarks not always correclt showing up immediately.
BUG: 207091

8 years agoSpelling++
Jeff Mitchell [Sun, 27 Sep 2009 02:59:36 +0000 (22:59 -0400)]
Spelling++

8 years agoSince the main incremental scanning bug is likely fixed, move Rescan Collection back...
Jeff Mitchell [Sat, 26 Sep 2009 23:59:38 +0000 (19:59 -0400)]
Since the main incremental scanning bug is likely fixed, move Rescan Collection back into the Collection Settings dialog.

markey -- this Bud's for you.

(I won't guarantee I won't change this back again before release if we still see/get reports of  wonkiness   :-) )

8 years agoChangeLog++
Jeff Mitchell [Sat, 26 Sep 2009 20:39:30 +0000 (16:39 -0400)]
ChangeLog++

8 years agoFix various incremental scanning problems by correcting the SQL used to determine...
Jeff Mitchell [Sat, 26 Sep 2009 20:34:53 +0000 (16:34 -0400)]
Fix various incremental scanning problems by correcting the SQL used to determine which tracks get dropped from the tracks table. It was getting urls.id values, but then deleting where 'id' from tracks
matched instead of where 'url' matched

8 years agostep 1 in my secret plan: provide a wrapper around playlists that makes them behave...
Maximilian Kossick [Sat, 26 Sep 2009 18:20:09 +0000 (20:20 +0200)]
step 1 in my secret plan: provide a wrapper around playlists that makes them behave like collections
provide a querymaker to query collections and a CollectionLocation that allows adding and removing of tracks.

8 years agoAlso allow muting by middle-clicking volume icon in standard toolbar.
Mark Kretschmann [Sat, 26 Sep 2009 10:43:59 +0000 (12:43 +0200)]
Also allow muting by middle-clicking volume icon in standard toolbar.

This is for great justice. And also for consistency. Middle-click muting
is a standard that worked everywhere else in Amarok/KMix, except here.

8 years agotypo--
Mark Kretschmann [Sat, 26 Sep 2009 09:29:27 +0000 (11:29 +0200)]
typo--

8 years agostyle++
Mark Kretschmann [Sat, 26 Sep 2009 09:17:47 +0000 (11:17 +0200)]
style++

8 years agoPedantic: Past tense for ChangeLog, please.
Mark Kretschmann [Sat, 26 Sep 2009 09:07:58 +0000 (11:07 +0200)]
Pedantic: Past tense for ChangeLog, please.

8 years agochangelog++
Mark Kretschmann [Sat, 26 Sep 2009 09:06:41 +0000 (11:06 +0200)]
changelog++

8 years agoRestore config dialog to acceptable size on KDE 4.3, hiding EQ settings.
Mark Kretschmann [Sat, 26 Sep 2009 08:57:15 +0000 (10:57 +0200)]
Restore config dialog to acceptable size on KDE 4.3, hiding EQ settings.

As the equalizer only works with KDE 4.4 and its GUI takes
up too much space, and as we don't have the time or means (string
freeze) to fix it properly for 2.2.0, I reckoned the next best thing
is to hide the GUI completely on KDE 4.3. This should help the majority
of our users for now.

We're still showing the "Equalizer not supported" line, so it shouldn't
hurt discoverability.

8 years agocleanup
Maximilian Kossick [Sat, 26 Sep 2009 08:30:00 +0000 (10:30 +0200)]
cleanup

8 years agoonly requery children if the node is currently expanded,
Maximilian Kossick [Sat, 26 Sep 2009 08:27:17 +0000 (10:27 +0200)]
only requery children if the node is currently expanded,
otherwise that will be handled by fetchMore

8 years agoreturn a dbus error if Amarok's internal query does not finish in a given period...
Maximilian Kossick [Fri, 25 Sep 2009 21:27:55 +0000 (23:27 +0200)]
return a dbus error if Amarok's internal query does not finish in a given period of time
currently it is set to 15 seconds, which is probably way too long, but a bit better than keeping
the DBusqueryHelper around forever (although the client will likely timeout on its own)

8 years agodeprecate XML query method that does not use the MPRIS metadata format
Maximilian Kossick [Fri, 25 Sep 2009 21:17:44 +0000 (23:17 +0200)]
deprecate XML query method that does not use the MPRIS metadata format

8 years agoprovide a second dbus method to query Amarok's collection that returns the metadata...
Maximilian Kossick [Fri, 25 Sep 2009 21:09:40 +0000 (23:09 +0200)]
provide a second dbus method to query Amarok's collection that returns the metadata in a MPRIS compatible format
keeping two different formats to return metadata in a map around is pretty stupid

8 years agocorrectly reset filter for all expanded nodes
Maximilian Kossick [Fri, 25 Sep 2009 20:23:38 +0000 (22:23 +0200)]
correctly reset filter for all expanded nodes
BUG: 208267

8 years agodo not freeze the whole browser when a query does not return (probably because of...
Maximilian Kossick [Fri, 25 Sep 2009 17:48:02 +0000 (19:48 +0200)]
do not freeze the whole browser when a query does not return (probably because of a broken querymaker).
continue filtering the remaining nodes

8 years agowhen the playlist model has to be recompiled because taglib changed it's a sure sign...
Maximilian Kossick [Fri, 25 Sep 2009 16:53:39 +0000 (18:53 +0200)]
when the playlist model has to be recompiled because taglib changed it's a sure sign that somewhere an include is not in the place where it should be

8 years agoPedantry
Jeff Mitchell [Fri, 25 Sep 2009 17:50:48 +0000 (13:50 -0400)]
Pedantry

8 years agoSend MBIDs along with Last.fm scrobbles if a MBID is found.
Jeff Mitchell [Fri, 25 Sep 2009 12:49:59 +0000 (08:49 -0400)]
Send MBIDs along with Last.fm scrobbles if a MBID is found.

8 years agoFix up the README. Say that TagLib-Extras 1.0.1 is "required" to fix linking errors...
Jeff Mitchell [Fri, 25 Sep 2009 12:46:35 +0000 (08:46 -0400)]
Fix up the README. Say that TagLib-Extras 1.0.1 is "required" to fix linking errors in many cases; give source path for TagLib too; remove information about libmp4v2 as we don't support it anymore since TagLib
has native MP4/AAC support.

8 years agoFixed taglib project URL in README.
Teo Mrnjavac [Fri, 25 Sep 2009 08:50:46 +0000 (10:50 +0200)]
Fixed taglib project URL in README.

8 years agoAs proposed (with no objection) on the ML and discussed on IRC with many parties...
Jeff Mitchell [Thu, 24 Sep 2009 15:45:09 +0000 (11:45 -0400)]
As proposed (with no objection) on the ML and discussed on IRC with many parties agreeing, move Rescan Collection back into Tools menu. It's unfortunately still just too necessary to have it so hidden away.

8 years agoWhy *is* this so obtuse?
Jeff Mitchell [Thu, 24 Sep 2009 00:48:09 +0000 (20:48 -0400)]
Why *is* this so obtuse?

8 years agoFix photos applet not working after resuming playback
Simon Esneault [Wed, 23 Sep 2009 17:08:45 +0000 (19:08 +0200)]
Fix photos applet not working after resuming playback
Sanitize the applet collapsing animation logic, do not try to collapse again if we're are already doing it.
Some comment here and there
Changelog++

8 years agoReplace one hack with another, more focused one. The root problem can be addressed...
Jeff Mitchell [Wed, 23 Sep 2009 15:51:49 +0000 (11:51 -0400)]
Replace one hack with another, more focused one. The root problem can be addressed after 2.2.

8 years agoFix regression where the genre field of the Tag Dialog shows the composer.
Jeff Mitchell [Wed, 23 Sep 2009 12:05:12 +0000 (08:05 -0400)]
Fix regression where the genre field of the Tag Dialog shows the composer.

~lart maxx_k

BUG: 208255

8 years agoFixed crash in the fix I just committed for the playlist random order.
Teo Mrnjavac [Wed, 23 Sep 2009 11:49:50 +0000 (13:49 +0200)]
Fixed crash in the fix I just committed for the playlist random order.

8 years agoChangeLog++
Teo Mrnjavac [Wed, 23 Sep 2009 11:32:24 +0000 (13:32 +0200)]
ChangeLog++

8 years agoRemoved 1px left/bottom/right white borders from the current splash screen.
Teo Mrnjavac [Wed, 23 Sep 2009 11:29:48 +0000 (13:29 +0200)]
Removed 1px left/bottom/right white borders from the current splash screen.

8 years agoDon't reshuffle the playlist on active track changed.
Teo Mrnjavac [Wed, 23 Sep 2009 11:13:18 +0000 (13:13 +0200)]
Don't reshuffle the playlist on active track changed.

8 years agoFix the VA node being shown in the case where the actual result from the database...
Jeff Mitchell [Wed, 23 Sep 2009 10:54:23 +0000 (06:54 -0400)]
Fix the VA node being shown in the case where the actual result from the database is entirely NULL.

8 years agoWhy on earth was this ever spelled with a C? :-)
Jeff Mitchell [Wed, 23 Sep 2009 05:05:09 +0000 (01:05 -0400)]
Why on earth was this ever spelled with a C?  :-)

8 years agoChangeLog++
Jeff Mitchell [Wed, 23 Sep 2009 01:08:12 +0000 (21:08 -0400)]
ChangeLog++

8 years agoReorder checks in the order they're likely to match, for some miniscule performance...
Jeff Mitchell [Wed, 23 Sep 2009 01:04:56 +0000 (21:04 -0400)]
Reorder checks in the order they're likely to match, for some miniscule performance improvement.

8 years agoReorder variable instantiation
Jeff Mitchell [Tue, 22 Sep 2009 21:07:17 +0000 (17:07 -0400)]
Reorder variable instantiation

8 years agoDon't do nothing when there is nothing to do...
Jeff Mitchell [Tue, 22 Sep 2009 21:04:17 +0000 (17:04 -0400)]
Don't do nothing when there is nothing to do...

8 years agoNow that zizzifizzix has been able to reproduce issues, try putting the final optimiz...
Jeff Mitchell [Tue, 22 Sep 2009 20:42:56 +0000 (16:42 -0400)]
Now that zizzifizzix has been able to reproduce issues, try putting the final optimization back

8 years agoRemove a lot of duplicate code and sanitize variable names.
Jeff Mitchell [Tue, 22 Sep 2009 20:24:48 +0000 (16:24 -0400)]
Remove a lot of duplicate code and sanitize variable names.

8 years agoMoar optimizations + safety
Jeff Mitchell [Tue, 22 Sep 2009 20:03:21 +0000 (16:03 -0400)]
Moar optimizations + safety

8 years agoMove albumId call to after the other SQL lookups for easier debugging of the VA issue
Jeff Mitchell [Tue, 22 Sep 2009 17:58:42 +0000 (13:58 -0400)]
Move albumId call to after the other SQL lookups for easier debugging of the VA issue

8 years agoSVN_SILENT made messages (.desktop file)
CVS deamon [Tue, 22 Sep 2009 09:11:29 +0000 (11:11 +0200)]
SVN_SILENT made messages (.desktop file)

8 years agoRemove totally unnecessary brackets
Jeff Mitchell [Tue, 22 Sep 2009 01:35:56 +0000 (21:35 -0400)]
Remove totally unnecessary brackets

8 years agoChangeLog++ v2.1.90
Jeff Mitchell [Mon, 21 Sep 2009 21:02:08 +0000 (17:02 -0400)]
ChangeLog++

8 years agoI am very silly.
Jeff Mitchell [Mon, 21 Sep 2009 20:25:01 +0000 (16:25 -0400)]
I am very silly.

8 years agobump plug-in version for RC release
Lydia Pintscher [Mon, 21 Sep 2009 19:53:48 +0000 (21:53 +0200)]
bump plug-in version for RC release

8 years agoOops, another compile fix.
Jeff Mitchell [Mon, 21 Sep 2009 19:32:34 +0000 (15:32 -0400)]
Oops, another compile fix.

8 years agoFix build of previous commit
Jeff Mitchell [Mon, 21 Sep 2009 19:28:22 +0000 (15:28 -0400)]
Fix build of previous commit

8 years agoMake some changes to ease testing of new patches for weird VA bug. This commit does...
Jeff Mitchell [Mon, 21 Sep 2009 19:26:55 +0000 (15:26 -0400)]
Make some changes to ease testing of new patches for weird VA bug. This commit does not compile; will not be pushed until it does.

8 years agoMake sure XSPF's have a decent name when saving.
Bart Cerneels [Mon, 21 Sep 2009 19:24:42 +0000 (21:24 +0200)]
Make sure XSPF's have a decent name when saving.

8 years agoGet rid of the "Sorry" dialog when saving XSPF playlist.
Bart Cerneels [Mon, 21 Sep 2009 19:06:38 +0000 (21:06 +0200)]
Get rid of the "Sorry" dialog when saving XSPF playlist.

BUG:206659

8 years agoFilter out non-mediadevice tracks when saving a playlist to a mediadevice.
Bart Cerneels [Mon, 21 Sep 2009 18:39:44 +0000 (20:39 +0200)]
Filter out non-mediadevice tracks when saving a playlist to a mediadevice.

In 2.3 we should start a collectionlocation copy to the device for any non-MD track. But for now we are out of time and in string freeze.
The best sollution I could come up with is show the user the playlist is empty without any warning (a.k.a. non-translated string).

Possible prevents crash.

CCBUG:205951

8 years agoAdd some safety against multiple keys matching the same value
Jeff Mitchell [Mon, 21 Sep 2009 18:38:34 +0000 (14:38 -0400)]
Add some safety against multiple keys matching the same value

8 years agoChangeLog++
Nikolaj Hald Nielsen [Mon, 21 Sep 2009 18:34:27 +0000 (20:34 +0200)]
ChangeLog++

8 years agoFix playlist grouping mode not getting correctly applied on amarok startup.
Nikolaj Hald Nielsen [Mon, 21 Sep 2009 18:31:45 +0000 (20:31 +0200)]
Fix playlist grouping mode not getting correctly applied on amarok startup.
Also make "None" the keyword used for no grouping as this is much more intuitive than just having an empty string (which will still work though)
BUG: 208087

8 years agoImmport itpc:// urls.
Bart Cerneels [Mon, 21 Sep 2009 17:52:22 +0000 (19:52 +0200)]
Immport itpc:// urls.

8 years agoFix playlist actions when multiple playlists are selected.
Bart Cerneels [Mon, 21 Sep 2009 17:06:58 +0000 (19:06 +0200)]
Fix playlist actions when multiple playlists are selected.

8 years agoMark podcasts as !new when starting playback.
Bart Cerneels [Mon, 21 Sep 2009 15:47:28 +0000 (17:47 +0200)]
Mark podcasts as !new when starting playback.

Also added changelog for indicator icons.

8 years agoUse "rating" icon for new episodes.
Bart Cerneels [Mon, 21 Sep 2009 14:23:52 +0000 (16:23 +0200)]
Use "rating" icon for new episodes.

8 years agoMake Current Track applet statistic more readable by reducing opacity.
Mark Kretschmann [Mon, 21 Sep 2009 14:13:31 +0000 (16:13 +0200)]
Make Current Track applet statistic more readable by reducing opacity.

I've extended the ToolBoxIcon ctor with an "opacity" argument, so that we
can use different values in different places (menu vs applet).

8 years agochangelog++
Mark Kretschmann [Mon, 21 Sep 2009 12:53:15 +0000 (14:53 +0200)]
changelog++

8 years agoRemove Shoutcast Directory service for now (technical and other issues).
Mark Kretschmann [Mon, 21 Sep 2009 12:48:47 +0000 (14:48 +0200)]
Remove Shoutcast Directory service for now (technical and other issues).

Nightrose: Please remember to run bump_plugin_version.rb before tagging, or else
the service will still hang around as a zombie.

8 years agoChangeLog++
Nikolaj Hald Nielsen [Mon, 21 Sep 2009 12:29:08 +0000 (14:29 +0200)]
ChangeLog++

8 years agoFix track queue getting "lost" when switching track navigator.
Nikolaj Hald Nielsen [Mon, 21 Sep 2009 12:26:23 +0000 (14:26 +0200)]
Fix track queue getting "lost" when switching track navigator.
BUG: 205920

8 years agoNew splash screen, thanks to Lee Olson for providing it.
Myriam [Mon, 21 Sep 2009 12:11:17 +0000 (14:11 +0200)]
New splash screen, thanks to Lee Olson for providing it.

8 years agoMake explicit use of qreal in qMax...hopefully this will fix build failures on ARM.
Jeff Mitchell [Mon, 21 Sep 2009 11:14:06 +0000 (07:14 -0400)]
Make explicit use of qreal in qMax...hopefully this will fix build failures on ARM.

8 years agoUse usertags rather than globaltags for "My Tags" in last.fm browser.
Modestas Vainius [Sun, 20 Sep 2009 23:51:45 +0000 (02:51 +0300)]
Use usertags rather than globaltags for "My Tags" in last.fm browser.

When a tag is picked from "My Tags" in last.fm browser, construct usertags URL
rather than globaltags one. I believe current code worked fine as long as
usertag matched a globaltag. Thanks to Євгеній Мещеряков for the patch.

8 years agoFixed the "subscribe" command line switch that was not working correctly.
Bart Cerneels [Sun, 20 Sep 2009 21:33:15 +0000 (23:33 +0200)]
Fixed the "subscribe" command line switch that was not working correctly.

Also added to the changelog though was technically already there.

8 years agoAttempt to fix current track applet showing "Last played: xxxxx days"
Kevin Funk [Sun, 20 Sep 2009 20:38:52 +0000 (22:38 +0200)]
Attempt to fix current track applet showing "Last played: xxxxx days"
ago. Please review. I18n string reused.
BUG: 203522

8 years agoTreat mp4 audiobook files as valid in directory filter when scanning
Jeff Mitchell [Sun, 20 Sep 2009 18:38:06 +0000 (14:38 -0400)]
Treat mp4 audiobook files as valid in directory filter when scanning

8 years agoFix playlist items accepting and reacting to clicks, even when inline controls are...
Nikolaj Hald Nielsen [Sun, 20 Sep 2009 18:11:50 +0000 (20:11 +0200)]
Fix playlist items accepting and reacting to clicks, even when inline controls are not shown.

8 years agoCorrectly handle the case of empty MusicBrainz identifiers in files. Fixes bug 206783.
Jeff Mitchell [Sun, 20 Sep 2009 18:06:46 +0000 (14:06 -0400)]
Correctly handle the case of empty MusicBrainz identifiers in files. Fixes bug 206783.

8 years agoChangeLog++ and add some comment in App.cpp
Kevin Funk [Sun, 20 Sep 2009 18:01:19 +0000 (20:01 +0200)]
ChangeLog++ and add some comment in App.cpp

8 years agoTry #2 at reverting some of the artist/album changes that seem to screw up VA for...
Jeff Mitchell [Sun, 20 Sep 2009 17:50:09 +0000 (13:50 -0400)]
Try #2 at reverting some of the artist/album changes that seem to screw up VA for some people.

8 years agoRevert earlier patch, it seemed to apply weirdly and caused compilation issues. Will...
Jeff Mitchell [Sun, 20 Sep 2009 17:44:08 +0000 (13:44 -0400)]
Revert earlier patch, it seemed to apply weirdly and caused compilation issues. Will try again shortly.

8 years agoRevert Mamarok's breakage
Jeff Mitchell [Sun, 20 Sep 2009 17:37:07 +0000 (13:37 -0400)]
Revert Mamarok's breakage

8 years agoProper check for running instance options on the command line.
Kevin Funk [Sun, 20 Sep 2009 16:19:20 +0000 (18:19 +0200)]
Proper check for running instance options on the command line.
BUG: 207988

8 years agoAdding patch provided by Matej Repinc. Fixes building problems.
Myriam [Sun, 20 Sep 2009 16:18:03 +0000 (18:18 +0200)]
Adding patch provided by Matej Repinc. Fixes building problems.

8 years agoMerge branch 'master' of git@gitorious.org:amarok/amarok
Nikolaj Hald Nielsen [Sun, 20 Sep 2009 14:41:15 +0000 (16:41 +0200)]
Merge branch 'master' of git@gitorious.org:amarok/amarok

8 years agoDo a 1:1 conversion of the new handbook draft to the dockbook format.
Nikolaj Hald Nielsen [Sun, 20 Sep 2009 14:38:40 +0000 (16:38 +0200)]
Do a 1:1 conversion of the new handbook draft to the dockbook format.
It is a bit harder to edit manually, but using serna free (http://www.syntext.com/downloads/serna-free/) it is doable.

8 years agoNew splash screen, thanks to Seb Ruiz' great work. We still need to add the author...
Myriam [Sun, 20 Sep 2009 14:28:14 +0000 (16:28 +0200)]
New splash screen, thanks to Seb Ruiz' great work. We still need to add the author of the original pic. But I am sure Seb will provide it :)