9 years agobump plugin version v2.0.96
Lydia Pintscher [Sun, 10 May 2009 22:09:40 +0000 (22:09 -0000)]
bump plugin version

svn path=/trunk/extragear/multimedia/amarok/; revision=966306

9 years agoDon't crash because the view is requesting data with wrong index.
Bart Cerneels [Sun, 10 May 2009 21:06:20 +0000 (21:06 -0000)]
Don't crash because the view is requesting data with wrong index.

svn path=/trunk/extragear/multimedia/amarok/; revision=966280

9 years agoMake drop on root work as well.
Bart Cerneels [Sun, 10 May 2009 21:06:13 +0000 (21:06 -0000)]
Make drop on root work as well.

svn path=/trunk/extragear/multimedia/amarok/; revision=966278

9 years agoDraging on folders now works.
Bart Cerneels [Sun, 10 May 2009 21:05:58 +0000 (21:05 -0000)]
Draging on folders now works.

svn path=/trunk/extragear/multimedia/amarok/; revision=966277

9 years agoredo commit, this time with the correct join
Maximilian Kossick [Sun, 10 May 2009 18:51:49 +0000 (18:51 -0000)]
redo commit, this time with the correct join

svn path=/trunk/extragear/multimedia/amarok/; revision=966250

9 years agoadd dublicate playlist on collection scan fix
Lydia Pintscher [Sun, 10 May 2009 18:24:14 +0000 (18:24 -0000)]
add dublicate playlist on collection scan fix

svn path=/trunk/extragear/multimedia/amarok/; revision=966239

9 years agoRevert Max's r966005. Max, tons of reports of tags correlating incorrectly with...
Jeff Mitchell [Sun, 10 May 2009 16:11:00 +0000 (16:11 -0000)]
Revert Max's r966005.  Max, tons of reports of tags correlating incorrectly with tracks and all sorts of general brokenness.  Can you take another look at this?


svn path=/trunk/extragear/multimedia/amarok/; revision=966206

9 years agoGuys, if there is a static variable holding the current version number, why are peopl...
Jeff Mitchell [Sun, 10 May 2009 16:06:23 +0000 (16:06 -0000)]
Guys, if there is a static variable holding the current version number, why are people hardcoding it?

BUG: 187126

svn path=/trunk/extragear/multimedia/amarok/; revision=966203

9 years agoImplement drag'n'drop for the grouped playlists.
Bart Cerneels [Sun, 10 May 2009 14:48:38 +0000 (14:48 -0000)]
Implement drag'n'drop for the grouped playlists.

It's not working because I don't know QDrag'n'Drop yet this is a release blocker.
Please look at it.

svn path=/trunk/extragear/multimedia/amarok/; revision=966174

9 years agomake compile
Seb Ruiz [Sun, 10 May 2009 12:28:57 +0000 (12:28 -0000)]
make compile

svn path=/trunk/extragear/multimedia/amarok/; revision=966033

9 years agofuck it, just delete the sources that we havent used in 6 months
Seb Ruiz [Sun, 10 May 2009 12:10:57 +0000 (12:10 -0000)]
fuck it, just delete the sources that we havent used in 6 months

svn path=/trunk/extragear/multimedia/amarok/; revision=966028

9 years agoDont compile unused classes
Seb Ruiz [Sun, 10 May 2009 12:10:36 +0000 (12:10 -0000)]
Dont compile unused classes

svn path=/trunk/extragear/multimedia/amarok/; revision=966027

9 years agoRemove unused method (which was broken anyhow)
Seb Ruiz [Sun, 10 May 2009 12:10:26 +0000 (12:10 -0000)]
Remove unused method (which was broken anyhow)

svn path=/trunk/extragear/multimedia/amarok/; revision=966026

9 years agoPressing the return key in the playlist search activates the selected result
Seb Ruiz [Sun, 10 May 2009 12:04:29 +0000 (12:04 -0000)]
Pressing the return key in the playlist search activates the selected result
BUG: 192126

svn path=/trunk/extragear/multimedia/amarok/; revision=966024

9 years agodebug--
Seb Ruiz [Sun, 10 May 2009 11:58:11 +0000 (11:58 -0000)]

svn path=/trunk/extragear/multimedia/amarok/; revision=966023

9 years agoPressing the escape key in the playlist search clears it's contents.
Seb Ruiz [Sun, 10 May 2009 11:57:57 +0000 (11:57 -0000)]
Pressing the escape key in the playlist search clears it's contents.
nb: this isn't actually how QLineEdits work, but i like the
functionality and it works well.
BUG: 192123

svn path=/trunk/extragear/multimedia/amarok/; revision=966022

9 years agoadd max's fix to the changelog
Seb Ruiz [Sun, 10 May 2009 11:10:10 +0000 (11:10 -0000)]
add max's fix to the changelog

svn path=/trunk/extragear/multimedia/amarok/; revision=966010

9 years agoFixed incorrect count of tracks in collection.
Maximilian Kossick [Sun, 10 May 2009 10:43:56 +0000 (10:43 -0000)]
Fixed incorrect count of tracks in collection.
urls contains rows for tracks that are not in the collection anymore too, so do not left join on that table.


svn path=/trunk/extragear/multimedia/amarok/; revision=966005

9 years agoChangeLog++
Nikolaj Hald Nielsen [Sun, 10 May 2009 10:29:25 +0000 (10:29 -0000)]

svn path=/trunk/extragear/multimedia/amarok/; revision=966002

9 years agoMake a special helper function for clearing all tracks in the playlist. By triggering...
Nikolaj Hald Nielsen [Sun, 10 May 2009 10:23:48 +0000 (10:23 -0000)]
Make a special helper function for clearing all tracks in the playlist. By triggering this when then amount of tracks to clear equals the amount of tracks in the playlist, thus avoiding all the special
code in removeTracksCommand that takes care of removing non contigous sets of tracks, this speeds up the clearing of a large ( 20k track ) playlist on my system from 9.3 seconds to 0.029 seconds, that
is a 300+ times speedup!! I also have some ideas for speeding up the removeTracksCommand function in general, but these are non trivial and requires some more work, and the results are going to be
less spectacular.

svn path=/trunk/extragear/multimedia/amarok/; revision=965999

9 years agoMake the Dynamic Playlist category the default in the playlist browser once again.
Nikolaj Hald Nielsen [Sun, 10 May 2009 09:25:02 +0000 (09:25 -0000)]
Make the Dynamic Playlist category the default in the playlist browser once again.

svn path=/trunk/extragear/multimedia/amarok/; revision=965992

9 years agoPossibly fix the strange "moving mouse off overlay causes entire PUD to go away"...
Jeff Mitchell [Sat, 9 May 2009 23:22:10 +0000 (23:22 -0000)]
Possibly fix the strange "moving mouse off overlay causes entire PUD to go away" bug.  I can't be sure it's fixed because I can never reliably reproduce it anyways, and neither can xevix.  Please do let me know if you're running post-this-commit code and you still see it.

svn path=/trunk/extragear/multimedia/amarok/; revision=965851

9 years agoWhoops. Font pointSize should never go negative.
Jeff Mitchell [Sat, 9 May 2009 22:27:07 +0000 (22:27 -0000)]
Whoops.  Font pointSize should never go negative.

BUG: 192077

svn path=/trunk/extragear/multimedia/amarok/; revision=965837

9 years agoPart 2 of fix for bug 187126. This will update your database, which is necessary...
Jeff Mitchell [Sat, 9 May 2009 22:03:34 +0000 (22:03 -0000)]
Part 2 of fix for bug 187126.  This will update your database, which is necessary because it's a two-part fix.  First, it prevents multiple entries with the same UUID from being in the devices table in the database.  Second, it fixes code to actually find those entries.

I got a crash the first time I opened Amarok after this, but then I re-opened and it was fine.  Might be something crashy with the DatabaseUpdater when it actually does something, but dunno.

BUG: 187126

svn path=/trunk/extragear/multimedia/amarok/; revision=965828

9 years agoPart 1 of fix for bug 187126. Following parts to be committed soon. This also fixes...
Jeff Mitchell [Sat, 9 May 2009 21:51:04 +0000 (21:51 -0000)]
Part 1 of fix for bug 187126.  Following parts to be committed soon.  This also fixes a compile oops with my previous commit.

CCBUG: 187126

svn path=/trunk/extragear/multimedia/amarok/; revision=965825

9 years agoDon't know who bothered making the dbVersion variable and then not using it -- but...
Jeff Mitchell [Sat, 9 May 2009 21:30:48 +0000 (21:30 -0000)]
Don't know who bothered making the dbVersion variable and then not using it -- but we should actually use it.

svn path=/trunk/extragear/multimedia/amarok/; revision=965822

9 years agoThe directory (and its subs) are totally empty and not being built...remove for clean...
Jeff Mitchell [Sat, 9 May 2009 18:49:41 +0000 (18:49 -0000)]
The directory (and its subs) are totally empty and not being built...remove for cleanliness

svn path=/trunk/extragear/multimedia/amarok/; revision=965777

9 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sat, 9 May 2009 15:32:20 +0000 (15:32 -0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/extragear/multimedia/amarok/; revision=965709

9 years agodont break if lyrics site has multiple inline lyrics
Leo Franchi [Sat, 9 May 2009 10:08:10 +0000 (10:08 -0000)]
dont  break if lyrics site has multiple inline lyrics

svn path=/trunk/extragear/multimedia/amarok/; revision=965549

9 years agomake compile
Maximilian Kossick [Fri, 8 May 2009 17:02:33 +0000 (17:02 -0000)]
make compile

svn path=/trunk/extragear/multimedia/amarok/; revision=965350

9 years agomark as track as transfer error when we cannot create the target directory.
Maximilian Kossick [Fri, 8 May 2009 16:54:00 +0000 (16:54 -0000)]
mark as track as transfer error when we cannot create the target directory.
CCBUG: 189581

svn path=/trunk/extragear/multimedia/amarok/; revision=965347

9 years agoOnly use that hack in single-click mode. AFAICT only regression remaining is figurin...
Jeff Mitchell [Thu, 7 May 2009 19:49:40 +0000 (19:49 -0000)]
Only use that hack in single-click mode.  AFAICT only regression remaining is figuring out how to play a track on double-click of the track (need Max to look at that one I think).  If that works for everyone, can make this work for all collections by moving the logic into CollectionTreeView.

svn path=/trunk/extragear/multimedia/amarok/; revision=965006

9 years agoThis fixes the "clicking on the + sign makes a collection item bounce" problem. ...
Jeff Mitchell [Thu, 7 May 2009 19:41:16 +0000 (19:41 -0000)]
This fixes the "clicking on the + sign makes a collection item bounce" problem.  This is probably the dirtiest hack I've ever made in my life.  Maybe the most clever, too.

svn path=/trunk/extragear/multimedia/amarok/; revision=965002

9 years agoFix regressions with right-clicking, dragging, and multi-selecting, but now we're...
Jeff Mitchell [Thu, 7 May 2009 19:16:32 +0000 (19:16 -0000)]
Fix regressions with right-clicking, dragging, and multi-selecting, but now we're back to the double-bounce if you click on the + and have single-click mode selected in KDE.  Investigating alternatives...

svn path=/trunk/extragear/multimedia/amarok/; revision=964987

9 years agoRemove hugely chatty debug
Jeff Mitchell [Thu, 7 May 2009 19:07:21 +0000 (19:07 -0000)]
Remove hugely chatty debug

svn path=/trunk/extragear/multimedia/amarok/; revision=964979

9 years agoSignificantly speed up the insertion of large sets of tracks into the playlist. As...
Nikolaj Hald Nielsen [Thu, 7 May 2009 18:55:32 +0000 (18:55 -0000)]
Significantly speed up the insertion of large sets of tracks into the playlist. As beginInsertRows/endInsertRows causes the proxies to get notified of the change, calling them for each track when they can be called once for the
entire batch seems overkill.

svn path=/trunk/extragear/multimedia/amarok/; revision=964976

9 years agoFix right-click
Jeff Mitchell [Thu, 7 May 2009 18:41:26 +0000 (18:41 -0000)]
Fix right-click

svn path=/trunk/extragear/multimedia/amarok/; revision=964971

9 years agoWAY too verbose debug
Leo Franchi [Thu, 7 May 2009 18:06:35 +0000 (18:06 -0000)]
WAY too verbose debug

svn path=/trunk/extragear/multimedia/amarok/; revision=964954

9 years agoFix a bug, but also turn on mouse tracking -- now when the mouse is moved more than...
Jeff Mitchell [Thu, 7 May 2009 18:05:23 +0000 (18:05 -0000)]
Fix a bug, but also turn on mouse tracking -- now when the mouse is moved more than the KDE drag distance, an expand/collapse happens instantly instead of waiting the full double-click timeout...this makes it feel much more natural in many of the scenarios I test it with...still have issues with double-clicking tracks though

svn path=/trunk/extragear/multimedia/amarok/; revision=964953

9 years agoThis commit mostly finishes making double-clicking act appropriately in collection...
Jeff Mitchell [Thu, 7 May 2009 17:33:35 +0000 (17:33 -0000)]
This commit mostly finishes making double-clicking act appropriately in collection browser, by which I mean it follows the KDE system settings.  There are two remaining problems:

1) If you have your mouse set to double-click and you double-click on a track, it does nothing, because I can't seem to find a way (that works!) to detect if it's a track or not.  See comment in the code.

2) If in single-click mode, double-clicking still adds to the playlist; however the length of time it tries to detect a double-click follows the KDE system settings.  So if your double-click timeout is 300ms, and you click once, it'll take 300ms for the node to expand/collapse.  The only other obvious way to do it is to do a quick expand/collapse when double-clicking, but this is noticeable visually.  Any ideas, anyone?  Or is this okay?

svn path=/trunk/extragear/multimedia/amarok/; revision=964945

9 years agoAck, didn't mean to check in this particular debug block
Jeff Mitchell [Thu, 7 May 2009 16:18:01 +0000 (16:18 -0000)]
Ack, didn't mean to check in this particular debug block

svn path=/trunk/extragear/multimedia/amarok/; revision=964905

9 years agoBetter fix for + signs in collection browser; now they work normally, but clicking...
Jeff Mitchell [Thu, 7 May 2009 16:17:11 +0000 (16:17 -0000)]
Better fix for + signs in collection browser; now they work normally, but clicking on actual artists obeys double/single click settings.  Still working on proper single/double-click detection.

svn path=/trunk/extragear/multimedia/amarok/; revision=964902

9 years agoFix regression -- clicking on the + sign no longer does an expand/collapses but inste...
Jeff Mitchell [Thu, 7 May 2009 13:36:05 +0000 (13:36 -0000)]
Fix regression -- clicking on the + sign no longer does an expand/collapses but instead works as expected

svn path=/trunk/extragear/multimedia/amarok/; revision=964826

9 years agoAh hah! Fix crash.
Jeff Mitchell [Thu, 7 May 2009 13:28:19 +0000 (13:28 -0000)]
Ah hah!  Fix crash.

svn path=/trunk/extragear/multimedia/amarok/; revision=964816

9 years agoForced the collection browser's search QToolBar to take the sizehint of the SearchWid...
Teo Mrnjavac [Thu, 7 May 2009 13:15:23 +0000 (13:15 -0000)]
Forced the collection browser's search QToolBar to take the sizehint of the SearchWidget, exactly like the playlist's search toolbar.
Visual consistency++

svn path=/trunk/extragear/multimedia/amarok/; revision=964796

9 years agoSafety fixes
Jeff Mitchell [Thu, 7 May 2009 13:00:32 +0000 (13:00 -0000)]
Safety fixes

svn path=/trunk/extragear/multimedia/amarok/; revision=964766

9 years agoFix un-i18n
Jeff Mitchell [Wed, 6 May 2009 22:37:05 +0000 (22:37 -0000)]
Fix un-i18n

svn path=/trunk/extragear/multimedia/amarok/; revision=964581

9 years agoAdd songkick engine/applet. Not built by default, but leo is going to help me figure...
Jeff Mitchell [Wed, 6 May 2009 22:22:16 +0000 (22:22 -0000)]
Add songkick engine/applet.  Not built by default, but leo is going to help me figure out why it's crashing Amarok on exit (if you do build it).  No i18ns, so doesn't affect string freeze.

svn path=/trunk/extragear/multimedia/amarok/; revision=964573

9 years agoSprint TODO Item: Automatically scroll to newly inserted tracks in the Playlist.
Nikolaj Hald Nielsen [Wed, 6 May 2009 21:25:52 +0000 (21:25 -0000)]
Sprint TODO Item: Automatically scroll to newly inserted tracks in the Playlist.

svn path=/trunk/extragear/multimedia/amarok/; revision=964549

9 years agoThis fixes part of the "expand when double-clicked, not add to playlist" TODO item...
Jeff Mitchell [Wed, 6 May 2009 19:56:54 +0000 (19:56 -0000)]
This fixes part of the "expand when double-clicked, not add to playlist" TODO item.  There are a few things to tweak, but first, one bigger problem: it no longer adds individual track items to the playlist on double-click on the track itself.  The culprit seems to be that isTrackItem() fails to perform correctly, always returning false, even on tracks.  Seb, Max, you guys showed up in svn blame...


svn path=/trunk/extragear/multimedia/amarok/; revision=964515

9 years agoTODO item: Prevent duplicates when importing playlist-files.
Bart Cerneels [Wed, 6 May 2009 19:47:29 +0000 (19:47 -0000)]
TODO item: Prevent duplicates when importing playlist-files.

svn path=/trunk/extragear/multimedia/amarok/; revision=964511

9 years agoTODO item: start playing immediately when "Play Media" is used
Leo Franchi [Wed, 6 May 2009 18:45:56 +0000 (18:45 -0000)]
TODO item: start playing immediately when "Play Media" is used

svn path=/trunk/extragear/multimedia/amarok/; revision=964493

9 years agoReplace Dynamic Playlists on/off button with checkbox. Note: tooltip should be made...
Jeff Mitchell [Wed, 6 May 2009 18:35:42 +0000 (18:35 -0000)]
Replace Dynamic Playlists on/off button with checkbox.  Note: tooltip should be made better once past string freeze.

Fixes a Sprint TODO item.

svn path=/trunk/extragear/multimedia/amarok/; revision=964484

9 years agoactually fix this lyrics and javascript escaping madness.
Leo Franchi [Wed, 6 May 2009 18:33:04 +0000 (18:33 -0000)]
actually fix this lyrics and javascript escaping madness.

BUG: 190690


svn path=/trunk/extragear/multimedia/amarok/; revision=964479

9 years agowork on using utf qbytearray passing to solve lyrics encoding issues
Leo Franchi [Wed, 6 May 2009 18:32:48 +0000 (18:32 -0000)]
work on using utf qbytearray passing to solve lyrics encoding issues

svn path=/trunk/extragear/multimedia/amarok/; revision=964478

9 years agoUpdate PUD to have ability to resize fonts (default) or wrap lines if a line of text...
Jeff Mitchell [Wed, 6 May 2009 18:23:53 +0000 (18:23 -0000)]
Update PUD to have ability to resize fonts (default) or wrap lines if a line of text is too long.  Some other bug fixes too.

svn path=/trunk/extragear/multimedia/amarok/; revision=964473

9 years ago2.1.0 TODO item: Use "document-new" icon for creating new playlist layouts.
Nikolaj Hald Nielsen [Wed, 6 May 2009 17:34:09 +0000 (17:34 -0000)]
2.1.0 TODO item: Use "document-new" icon for creating new playlist layouts.

svn path=/trunk/extragear/multimedia/amarok/; revision=964455

9 years agoChange icon to folder-new.
Bart Cerneels [Wed, 6 May 2009 17:18:20 +0000 (17:18 -0000)]
Change icon to folder-new.

svn path=/trunk/extragear/multimedia/amarok/; revision=964451

9 years agoRemove plasma directory as it's just an empty shell with no files in it, not even...
Jeff Mitchell [Wed, 6 May 2009 12:23:00 +0000 (12:23 -0000)]
Remove plasma directory as it's just an empty shell with no files in it, not even CMakeLists.txt

svn path=/trunk/extragear/multimedia/amarok/; revision=964256

9 years agoRemove this entry as feature is not yet exposed to the UI (todo once the string freez...
Nikolaj Hald Nielsen [Wed, 6 May 2009 09:52:04 +0000 (09:52 -0000)]
Remove this entry as feature is not yet exposed to the UI (todo once the string freeze is lifted)

svn path=/trunk/extragear/multimedia/amarok/; revision=964180

9 years agoDon't use bold font style in the Current Track widget, as recommended by
Mark Kretschmann [Wed, 6 May 2009 05:07:37 +0000 (05:07 -0000)]
Don't use bold font style in the Current Track widget, as recommended by

Nuno said that the bold font gives the font a blurry appearance and that
it's generally better not to use bold a lot, and also not to mix
different styles. Let me know what you guys think.

svn path=/trunk/extragear/multimedia/amarok/; revision=964133

9 years agoadd Frederik's bugfix and fix typo
Lydia Pintscher [Tue, 5 May 2009 21:15:38 +0000 (21:15 -0000)]
add Frederik's bugfix and fix typo

svn path=/trunk/extragear/multimedia/amarok/; revision=964054

9 years agoPossibly fix crash when collectionscanner finds and tries to import a playlist.
Bart Cerneels [Tue, 5 May 2009 19:36:49 +0000 (19:36 -0000)]
Possibly fix crash when collectionscanner finds and tries to import a playlist.
I can not test since the collectionscanner is not working here. But lfranchi can reproduce.

svn path=/trunk/extragear/multimedia/amarok/; revision=963994

9 years agoadd a 'bindingstest' target for packagers etc. to test out what is missing
Ian Monroe [Tue, 5 May 2009 02:37:58 +0000 (02:37 -0000)]
add a 'bindingstest' target for packagers etc. to test out what is missing
for their qt script bindings

svn path=/trunk/extragear/multimedia/amarok/; revision=963639

9 years agoMake user playlists the default selected category in the playlist browser.
Nikolaj Hald Nielsen [Mon, 4 May 2009 22:34:40 +0000 (22:34 -0000)]
Make user playlists the default selected category in the playlist browser.

svn path=/trunk/extragear/multimedia/amarok/; revision=963585

9 years ago- Order affects link in some gcc releases
Helio Chissini de Castro [Mon, 4 May 2009 22:19:03 +0000 (22:19 -0000)]
- Order affects link in some gcc releases

svn path=/trunk/extragear/multimedia/amarok/; revision=963572

9 years ago- Fix test compile against -Wformat -Werror=format-security
Helio Chissini de Castro [Mon, 4 May 2009 22:05:01 +0000 (22:05 -0000)]
- Fix test compile against -Wformat -Werror=format-security

svn path=/trunk/extragear/multimedia/amarok/; revision=963563

9 years agoPartially implement deleting anything in the UserPlaylistCategory through QABstractIt...
Bart Cerneels [Mon, 4 May 2009 20:28:49 +0000 (20:28 -0000)]
Partially implement deleting anything in the UserPlaylistCategory through QABstractItemModel::removeRows().
Not implemented in the UserPlaylistModel yet.

svn path=/trunk/extragear/multimedia/amarok/; revision=963507

9 years agoRename the addToiGroupAction.
Bart Cerneels [Mon, 4 May 2009 20:28:44 +0000 (20:28 -0000)]
Rename the addToiGroupAction.

This means the new string from 2 commits back has been reverted.

svn path=/trunk/extragear/multimedia/amarok/; revision=963506

9 years agoMake the "Add Folder" button do something egain.
Bart Cerneels [Mon, 4 May 2009 20:28:39 +0000 (20:28 -0000)]
Make the "Add Folder" button do something egain.
This is just a temporary hack that allows me to reuse an existing string.
After the 2.1 release I'll probably change the string and reimplement it.

svn path=/trunk/extragear/multimedia/amarok/; revision=963505

9 years agoAdd an action to add a playlist to a group.
Bart Cerneels [Mon, 4 May 2009 20:28:34 +0000 (20:28 -0000)]
Add an action to add a playlist to a group.

Grouping is actually a PlaylistProvider action and group is a property of a playlist.
So there is no real way to create an empty group and add a playlist to it.

This commit introduces the new string "Add to group".

svn path=/trunk/extragear/multimedia/amarok/; revision=963504

9 years agoChangeLog++
Nikolaj Hald Nielsen [Mon, 4 May 2009 14:26:54 +0000 (14:26 -0000)]

svn path=/trunk/extragear/multimedia/amarok/; revision=963326

9 years agoWhen deleting one or more of the "upcomming" tracks in an active dynamic playlist...
Nikolaj Hald Nielsen [Mon, 4 May 2009 14:26:50 +0000 (14:26 -0000)]
When deleting one or more of the "upcomming" tracks in an active dynamic playlist, add a corrosponding number of new track so that the dynamic playlist does not "dry out" if the user removes unwanted tracks.

svn path=/trunk/extragear/multimedia/amarok/; revision=963325

9 years agomake setLyricsForTrack actually work. unimplemented API functions is bad
Leo Franchi [Mon, 4 May 2009 08:53:43 +0000 (08:53 -0000)]
make setLyricsForTrack actually work. unimplemented API functions is bad

svn path=/trunk/extragear/multimedia/amarok/; revision=963231

9 years agonot ready for prime-time yet
Leo Franchi [Mon, 4 May 2009 08:40:42 +0000 (08:40 -0000)]
not ready for prime-time yet

svn path=/trunk/extragear/multimedia/amarok/; revision=963224

9 years agoadd track.url() function to the scripting API, so scripts can properly
Leo Franchi [Mon, 4 May 2009 08:35:49 +0000 (08:35 -0000)]
add track.url() function to the scripting API, so scripts can properly
use the setLyricsForTrack function which already exists (although it
doesn't work yet)

svn path=/trunk/extragear/multimedia/amarok/; revision=963223

9 years agomake playlistbrowser usably fast by removing last vestiges of debug
Leo Franchi [Mon, 4 May 2009 08:33:56 +0000 (08:33 -0000)]
make playlistbrowser usably fast by removing last vestiges of debug

svn path=/trunk/extragear/multimedia/amarok/; revision=963222

9 years agomake the install work when the scripted applet already exists, gotta
Leo Franchi [Mon, 4 May 2009 08:33:52 +0000 (08:33 -0000)]
make the install work when the scripted applet already exists, gotta
first remove it if it is there.

svn path=/trunk/extragear/multimedia/amarok/; revision=963221

9 years agomake it work
Leo Franchi [Mon, 4 May 2009 08:33:48 +0000 (08:33 -0000)]
make it work

svn path=/trunk/extragear/multimedia/amarok/; revision=963220

9 years agoMake the gitignore work for me.
Bart Cerneels [Sun, 3 May 2009 20:23:15 +0000 (20:23 -0000)]
Make the gitignore work for me.


svn path=/trunk/extragear/multimedia/amarok/; revision=963055

9 years agouse the Awsome AmarokUrl to open the correct browser and category.
Bart Cerneels [Sun, 3 May 2009 20:23:10 +0000 (20:23 -0000)]
use the Awsome AmarokUrl to open the correct browser and category.
Thanks to Nikolaj for live the live howto.

svn path=/trunk/extragear/multimedia/amarok/; revision=963054

9 years agoMake inline renaming work with groups enabled.
Bart Cerneels [Sun, 3 May 2009 20:23:03 +0000 (20:23 -0000)]
Make inline renaming work with groups enabled.

svn path=/trunk/extragear/multimedia/amarok/; revision=963053

9 years agoReimplement inline playlist renaming.
Bart Cerneels [Sun, 3 May 2009 18:47:59 +0000 (18:47 -0000)]
Reimplement inline playlist renaming.
This got removed when I implemented the UserPlaylistProvider.

It does not work yet with the GroupingProxy.

The F2 key also works now.


svn path=/trunk/extragear/multimedia/amarok/; revision=963028

9 years agocleanup
Sven Krohlas [Sun, 3 May 2009 16:06:40 +0000 (16:06 -0000)]

svn path=/trunk/extragear/multimedia/amarok/; revision=962960

9 years agoRemove Queue PuD action, as discussed.
Sven Krohlas [Sun, 3 May 2009 15:38:41 +0000 (15:38 -0000)]
Remove Queue PuD action, as discussed.

svn path=/trunk/extragear/multimedia/amarok/; revision=962948

9 years agoDisable debug in critical paths.
Bart Cerneels [Sun, 3 May 2009 13:35:33 +0000 (13:35 -0000)]
Disable debug in critical paths.
Enable where it's usefull and doesn't hurt.

svn path=/trunk/extragear/multimedia/amarok/; revision=962923

9 years agoChangeLog++
Nikolaj Hald Nielsen [Sun, 3 May 2009 13:12:39 +0000 (13:12 -0000)]

svn path=/trunk/extragear/multimedia/amarok/; revision=962902

9 years agoRemove play/pause actions from the playlist context menu for the currently playing...
Nikolaj Hald Nielsen [Sun, 3 May 2009 13:12:35 +0000 (13:12 -0000)]
Remove play/pause actions from the playlist context menu for the currently playing tracks as per the results of study/discussion at the Berlin dev. sprint.

svn path=/trunk/extragear/multimedia/amarok/; revision=962901

9 years agoAdd a little more stuff to .gitignore
Nikolaj Hald Nielsen [Sun, 3 May 2009 12:54:05 +0000 (12:54 -0000)]
Add a little more stuff to .gitignore

svn path=/trunk/extragear/multimedia/amarok/; revision=962874

9 years agoWhen clearing the playlist, also clear the search/filter edit.
Nikolaj Hald Nielsen [Sun, 3 May 2009 12:52:09 +0000 (12:52 -0000)]
When clearing the playlist, also clear the search/filter edit.

svn path=/trunk/extragear/multimedia/amarok/; revision=962871

9 years agoChangeLog++
Nikolaj Hald Nielsen [Sun, 3 May 2009 12:23:48 +0000 (12:23 -0000)]

svn path=/trunk/extragear/multimedia/amarok/; revision=962794

9 years agoAdd config option for hiding the context view. It is currently not shown in the setti...
Nikolaj Hald Nielsen [Sun, 3 May 2009 10:35:18 +0000 (10:35 -0000)]
Add config option for hiding the context view. It is currently not shown in the settings dialog due to string freeze (Will be for 2.1.1) but setting "Show Context View=false" in the General group in the amarokrc file will hide it conpletely.

svn path=/trunk/extragear/multimedia/amarok/; revision=962771

9 years agoBoolean might have been used uninitialized.
Bart Cerneels [Sun, 3 May 2009 05:21:38 +0000 (05:21 -0000)]
Boolean might have been used uninitialized.

svn path=/trunk/extragear/multimedia/amarok/; revision=962733

9 years agoAdd bug num
Seb Ruiz [Sun, 3 May 2009 04:14:10 +0000 (04:14 -0000)]
Add bug num

svn path=/trunk/extragear/multimedia/amarok/; revision=962730

9 years agoQT_QTCORE_LIBS does not exist, only QT_QTCORE_LIBRARY. It is also redundant because...
Andreas Hartmetz [Sat, 2 May 2009 20:16:45 +0000 (20:16 -0000)]
QT_QTCORE_LIBS does not exist, only QT_QTCORE_LIBRARY. It is also redundant because KDE4_KDECORE_LIBS includes all necessary Qt libraries.

svn path=/trunk/extragear/multimedia/amarok/; revision=962655

9 years agoFix drag and drop to the outside world.
Frederik Gladhorn [Sat, 2 May 2009 16:47:21 +0000 (16:47 -0000)]
Fix drag and drop to the outside world.
(Support QByteArray in QMimeData)
BUG: 177415

svn path=/trunk/extragear/multimedia/amarok/; revision=962601

9 years agolet the applet toolbar elide and shrink instead of hiding the toggle
Leo Franchi [Sat, 2 May 2009 15:00:48 +0000 (15:00 -0000)]
let the applet toolbar elide and shrink instead of hiding the toggle
button which is bad

svn path=/trunk/extragear/multimedia/amarok/; revision=962571

9 years agoabort db queries when we want to show the current info, otherwise the
Leo Franchi [Sat, 2 May 2009 15:00:44 +0000 (15:00 -0000)]
abort db queries when we want to show the current info, otherwise the
results could come in while buffering and override it. this would leave
us with a Home state while a track was playing

svn path=/trunk/extragear/multimedia/amarok/; revision=962570

9 years agoremove stale code
Leo Franchi [Sat, 2 May 2009 15:00:39 +0000 (15:00 -0000)]
remove stale code

svn path=/trunk/extragear/multimedia/amarok/; revision=962569

9 years agoAdded a bash prompt configuration for a more colorful git and SVN aware prompt.
Teo Mrnjavac [Sat, 2 May 2009 11:43:59 +0000 (11:43 -0000)]
Added a bash prompt configuration for a more colorful git and SVN aware prompt.

svn path=/trunk/extragear/multimedia/amarok/; revision=962392