9 years agobump plugin versions for 2.1 beta 1 v2.0.90
Lydia Pintscher [Mon, 6 Apr 2009 20:47:48 +0000 (20:47 -0000)]
bump plugin versions for 2.1 beta 1

svn path=/trunk/extragear/multimedia/amarok/; revision=950330

9 years agoActually emit results if not sorting them...
Nikolaj Hald Nielsen [Mon, 6 Apr 2009 19:49:46 +0000 (19:49 -0000)]
Actually emit results if not sorting them...

svn path=/trunk/extragear/multimedia/amarok/; revision=950304

9 years agoMake numbers less "magical".
Mark Kretschmann [Mon, 6 Apr 2009 16:42:13 +0000 (16:42 -0000)]
Make numbers less "magical".

svn path=/trunk/extragear/multimedia/amarok/; revision=950215

9 years agoTaglib audioProperties pointers can be null...
Jeff Mitchell [Mon, 6 Apr 2009 13:23:46 +0000 (13:23 -0000)]
Taglib audioProperties pointers can be null...

svn path=/trunk/extragear/multimedia/amarok/; revision=950051

9 years agocodingstyle++
Mark Kretschmann [Mon, 6 Apr 2009 11:31:42 +0000 (11:31 -0000)]

svn path=/trunk/extragear/multimedia/amarok/; revision=949981

9 years agowarnings--
Mark Kretschmann [Mon, 6 Apr 2009 11:31:37 +0000 (11:31 -0000)]

svn path=/trunk/extragear/multimedia/amarok/; revision=949980

9 years agoRemove unneeded includes.
Mark Kretschmann [Mon, 6 Apr 2009 11:31:31 +0000 (11:31 -0000)]
Remove unneeded includes.

svn path=/trunk/extragear/multimedia/amarok/; revision=949979

9 years agoActually sort items in descending order when requested.
Maximilian Kossick [Sun, 5 Apr 2009 19:06:19 +0000 (19:06 -0000)]
Actually sort items in descending order when requested.
qCopyBackwards does not actually do what I thought it did.
Why is there no qReverse in QtAlgorithms?

svn path=/trunk/extragear/multimedia/amarok/; revision=949702

9 years agoimplemented orderBy() in MemoryQueryMaker. This should handle normal cases like sorti...
Maximilian Kossick [Sun, 5 Apr 2009 17:14:20 +0000 (17:14 -0000)]
implemented orderBy() in MemoryQueryMaker. This should handle normal cases like sorting albums by name or tracks by filesize. More complex sorting like sorting artists by track scores is not supported.

svn path=/trunk/extragear/multimedia/amarok/; revision=949655

9 years agomake test compile
Ian Monroe [Sun, 5 Apr 2009 16:26:16 +0000 (16:26 -0000)]
make test compile

svn path=/trunk/extragear/multimedia/amarok/; revision=949643

9 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sun, 5 Apr 2009 13:47:49 +0000 (13:47 -0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/extragear/multimedia/amarok/; revision=949571

9 years agoPatch for possibly fixing the Scrobbling problems with
Mark Kretschmann [Sun, 5 Apr 2009 10:58:40 +0000 (10:58 -0000)]
Patch for possibly fixing the Scrobbling problems with

Seems to work here (but then it always worked for me) - at least I can't see
any negative side effects. Thanks to for this patch

CCBUG: 188678

svn path=/trunk/extragear/multimedia/amarok/; revision=949421

9 years agoAdd custom icons to 5 playlist layout tokens that were so far missing. Thanks to...
Nikolaj Hald Nielsen [Sat, 4 Apr 2009 18:11:31 +0000 (18:11 -0000)]
Add custom icons to 5 playlist layout tokens that were so far missing. Thanks to Lee Olson for the icons!

svn path=/trunk/extragear/multimedia/amarok/; revision=949246

9 years agoimplemented all custom return functions for MQM and most custom return values.
Maximilian Kossick [Sat, 4 Apr 2009 13:18:22 +0000 (13:18 -0000)]
implemented all custom return functions for MQM and most custom return values.

svn path=/trunk/extragear/multimedia/amarok/; revision=949073

9 years agoFix MQM which sometimes thought it had a return function applied, causing total breakage.
Seb Ruiz [Sat, 4 Apr 2009 07:21:09 +0000 (07:21 -0000)]
Fix MQM which sometimes thought it had a return function applied, causing total breakage.

svn path=/trunk/extragear/multimedia/amarok/; revision=948900

9 years agoRecount collection tracks when the collection is updated.
Seb Ruiz [Sat, 4 Apr 2009 07:20:54 +0000 (07:20 -0000)]
Recount collection tracks when the collection is updated.
BUG: 188452

svn path=/trunk/extragear/multimedia/amarok/; revision=948899

9 years agoCleanup, and show verbose time since
Seb Ruiz [Sat, 4 Apr 2009 07:20:42 +0000 (07:20 -0000)]
Cleanup, and show verbose time since

svn path=/trunk/extragear/multimedia/amarok/; revision=948898

9 years agoAlways show stats, even when a track has never been played before
Seb Ruiz [Sat, 4 Apr 2009 07:20:22 +0000 (07:20 -0000)]
Always show stats, even when a track has never been played before

svn path=/trunk/extragear/multimedia/amarok/; revision=948897

9 years agocase-sensitivity issue
Benjamin Reed [Fri, 3 Apr 2009 18:16:50 +0000 (18:16 -0000)]
case-sensitivity issue

svn path=/trunk/extragear/multimedia/amarok/; revision=948771

9 years agoAll descriptions seem to end without a dot.
Sven Krohlas [Fri, 3 Apr 2009 17:16:06 +0000 (17:16 -0000)]
All descriptions seem to end without a dot.

svn path=/trunk/extragear/multimedia/amarok/; revision=948750

9 years agobuilding on OSX with Qt/X11 does not have these mac-specific features enabled; do...
Benjamin Reed [Fri, 3 Apr 2009 15:49:00 +0000 (15:49 -0000)]
building on OSX with Qt/X11 does not have these mac-specific features enabled; do not compile them

svn path=/trunk/extragear/multimedia/amarok/; revision=948731

9 years agoFake implementation of the MemoryQueryMaker COUNT function. This is an
Seb Ruiz [Fri, 3 Apr 2009 11:13:34 +0000 (11:13 -0000)]
Fake implementation of the MemoryQueryMaker COUNT function. This is an
incomplete and incorrect solution which I have written because I did not
know how to correctly implement the MemoryQueryMaker CUSTOM type. Any
advice on writing this would be appreciated (Max?).

MQM currently assumes all Custom types to want to apply a function on
all tracks. This lets us count the number of tracks in a MQM, and shows
track counts correctly for ipod/daap/mtp devices.


svn path=/trunk/extragear/multimedia/amarok/; revision=948614

9 years agoToggle collections on a single click by reimplementing
Seb Ruiz [Fri, 3 Apr 2009 11:13:18 +0000 (11:13 -0000)]
Toggle collections on a single click by reimplementing
mouseReleaseEvent. This works nicely with context menu and drag events,
but not with double click event. Overall gain however.

svn path=/trunk/extragear/multimedia/amarok/; revision=948613

9 years agouse toLocalFile, as otherwise passes "/C:/foo/bar..." to Qt, which it cannot handle
Patrick Spendrin [Thu, 2 Apr 2009 18:29:48 +0000 (18:29 -0000)]
use toLocalFile, as otherwise passes "/C:/foo/bar..." to Qt, which it cannot handle

svn path=/trunk/extragear/multimedia/amarok/; revision=948302

9 years agoFixed some bugs in the playlist layout editor :
Valentin Rouet [Thu, 2 Apr 2009 16:22:17 +0000 (16:22 -0000)]
Fixed some bugs in the playlist layout editor :
1) all layout modifications now set isDirty to true
2) after trying to apply changes on a default layout it's configuration is being reloaded
3) the error message now displays the actual name of the default layout one tried to edit, not the last one edited

svn path=/trunk/extragear/multimedia/amarok/; revision=948247

9 years agoupdate
Seb Ruiz [Thu, 2 Apr 2009 11:10:50 +0000 (11:10 -0000)]

svn path=/trunk/extragear/multimedia/amarok/; revision=948132

9 years agoStyle fixes
Seb Ruiz [Thu, 2 Apr 2009 10:58:45 +0000 (10:58 -0000)]
Style fixes

svn path=/trunk/extragear/multimedia/amarok/; revision=948130

9 years agoImprove compilation detection in the collection scanner. This builds
Seb Ruiz [Thu, 2 Apr 2009 10:58:29 +0000 (10:58 -0000)]
Improve compilation detection in the collection scanner. This builds
upon Michael Quinn's patch, with various improvements. It finds all
albums with the same name and disregards any album which is not in the
same directory. Consequently this makes the checkExistingAlbums() method
obsolete. There is probably still room for improvement here. Testing is
CCMAIL: Michael Quinn <>
CCBUG: 172953

svn path=/trunk/extragear/multimedia/amarok/; revision=948129

9 years agoLet's give the dialog a title. :)
Sven Krohlas [Wed, 1 Apr 2009 14:29:14 +0000 (14:29 -0000)]
Let's give the dialog a title. :)

Greetings from OpenExpo.

svn path=/trunk/extragear/multimedia/amarok/; revision=947885

9 years agotry to fix wiki locale properly
Leo Franchi [Wed, 1 Apr 2009 12:44:48 +0000 (12:44 -0000)]
try to fix wiki locale properly

svn path=/trunk/extragear/multimedia/amarok/; revision=947784

9 years agoFix taglib includes
Jeff Mitchell [Wed, 1 Apr 2009 04:01:53 +0000 (04:01 -0000)]
Fix taglib includes

svn path=/trunk/extragear/multimedia/amarok/; revision=947662

9 years agomissing include dir for Qt/X11 on mac
Benjamin Reed [Wed, 1 Apr 2009 04:01:47 +0000 (04:01 -0000)]
missing include dir for Qt/X11 on mac

svn path=/trunk/extragear/multimedia/amarok/; revision=947661

9 years agoTry to fix RangerRick's loudmouth issues too
Jeff Mitchell [Wed, 1 Apr 2009 03:57:50 +0000 (03:57 -0000)]
Try to fix RangerRick's loudmouth issues too

svn path=/trunk/extragear/multimedia/amarok/; revision=947660

9 years agoFix taglib includes to avoid build breakage on some systems
Jeff Mitchell [Wed, 1 Apr 2009 03:52:59 +0000 (03:52 -0000)]
Fix taglib includes to avoid build breakage on some systems

svn path=/trunk/extragear/multimedia/amarok/; revision=947659

9 years agoTry to fix RangerRick's Gdk include problem more correctly. Works for him, hopefully...
Jeff Mitchell [Wed, 1 Apr 2009 03:50:42 +0000 (03:50 -0000)]
Try to fix RangerRick's Gdk include problem more correctly.  Works for him, hopefully doesn't break for anyone else

svn path=/trunk/extragear/multimedia/amarok/; revision=947658

9 years agoBest way to fix a missing include? Nope. But it works, and other ways are failing...
Jeff Mitchell [Wed, 1 Apr 2009 03:39:42 +0000 (03:39 -0000)]
Best way to fix a missing include?  Nope. But it works, and other ways are failing for some reason right now

svn path=/trunk/extragear/multimedia/amarok/; revision=947657

9 years agorevert part of my previous commit that broke eliding
Leo Franchi [Tue, 31 Mar 2009 20:45:07 +0000 (20:45 -0000)]
revert part of my previous commit that broke eliding

svn path=/trunk/extragear/multimedia/amarok/; revision=947595

9 years agoFix progressbar being to tall while doing multiple tasks (reverting
Kevin Funk [Tue, 31 Mar 2009 13:40:42 +0000 (13:40 -0000)]
Fix progressbar being to tall while doing multiple tasks (reverting
some of my previous commits, basically)

svn path=/trunk/extragear/multimedia/amarok/; revision=947422

9 years agoby default use en_US as the locale. somehow it's not picking up my
Leo Franchi [Tue, 31 Mar 2009 12:38:33 +0000 (12:38 -0000)]
by default use en_US as the locale. somehow it's not picking up my
system one so fails toconnect to wikipedia

svn path=/trunk/extragear/multimedia/amarok/; revision=947349

9 years agoremove super excessive debug from applet layout code. i think it's
Leo Franchi [Tue, 31 Mar 2009 12:38:25 +0000 (12:38 -0000)]
remove super excessive debug from applet layout code. i think it's
pretty solid atm...

svn path=/trunk/extragear/multimedia/amarok/; revision=947347

9 years agoclean up more cruft, don't re-set all the info each time we redraw the
Leo Franchi [Mon, 30 Mar 2009 22:51:31 +0000 (22:51 -0000)]
clean up more cruft, don't re-set all the info each time we redraw the
also, equalize the vertical position of the title/artist/album text.

svn path=/trunk/extragear/multimedia/amarok/; revision=947112

9 years agofix cover issue properly
Leo Franchi [Mon, 30 Mar 2009 11:49:11 +0000 (11:49 -0000)]
fix cover issue properly

svn path=/trunk/extragear/multimedia/amarok/; revision=946793

9 years agoattempt 1 at dealing with weirdly shaped covers
Leo Franchi [Mon, 30 Mar 2009 11:22:19 +0000 (11:22 -0000)]
attempt 1 at dealing with weirdly shaped covers

svn path=/trunk/extragear/multimedia/amarok/; revision=946784

9 years agomake track items more contrasty and stick out more
Leo Franchi [Mon, 30 Mar 2009 09:23:03 +0000 (09:23 -0000)]
make track items more contrasty and stick out more
also, add my copyright

svn path=/trunk/extragear/multimedia/amarok/; revision=946753

9 years agochangelog++
Mark Kretschmann [Mon, 30 Mar 2009 07:38:48 +0000 (07:38 -0000)]

svn path=/trunk/extragear/multimedia/amarok/; revision=946732

9 years agoGo ahead and commit one of Wade Olson's new splash screens.
Mark Kretschmann [Mon, 30 Mar 2009 07:25:39 +0000 (07:25 -0000)]
Go ahead and commit one of Wade Olson's new splash screens.

After some real-life testing with different images, I chose #6, which
really looks awesome, and especially also harmonizes well with many
desktop color schemes.

svn path=/trunk/extragear/multimedia/amarok/; revision=946727

9 years agofinally fix the weird artefacts-on-startup thing in the top-left corner
Leo Franchi [Sun, 29 Mar 2009 18:43:21 +0000 (18:43 -0000)]
finally fix the weird artefacts-on-startup thing in the top-left corner
of the current track applet
also, remove the weird space in the parens. this is not code, doesn't
need to follow the amarok coding guidelines ;)

svn path=/trunk/extragear/multimedia/amarok/; revision=946593

9 years agoantialias
Leo Franchi [Sun, 29 Mar 2009 18:31:11 +0000 (18:31 -0000)]

svn path=/trunk/extragear/multimedia/amarok/; revision=946590

9 years agomake the not-playing status of the current applet also fit the mockup.
Leo Franchi [Sun, 29 Mar 2009 18:22:58 +0000 (18:22 -0000)]
make the not-playing status of the current applet also fit the mockup.
again, comments appreciated

svn path=/trunk/extragear/multimedia/amarok/; revision=946585

9 years agoAdd to fix apparently license issue.
Jeff Mitchell [Sun, 29 Mar 2009 17:50:29 +0000 (17:50 -0000)]
Add to fix apparently license issue.

svn path=/trunk/extragear/multimedia/amarok/; revision=946575

9 years agoAs discussed, change Overwrite to Replace
Jeff Mitchell [Sun, 29 Mar 2009 17:38:11 +0000 (17:38 -0000)]
As discussed, change Overwrite to Replace

svn path=/trunk/extragear/multimedia/amarok/; revision=946569

9 years agoproperly place source emblem... but it's tiny :( we need bigger pixmaps
Leo Franchi [Sun, 29 Mar 2009 16:01:10 +0000 (16:01 -0000)]
properly place source emblem... but it's tiny :( we need bigger pixmaps

svn path=/trunk/extragear/multimedia/amarok/; revision=946550

9 years agoRemove white edges from CV toolbar (again). This time with some comment.
Kevin Funk [Sun, 29 Mar 2009 14:46:22 +0000 (14:46 -0000)]
Remove white edges from CV toolbar (again). This time with some comment.

svn path=/trunk/extragear/multimedia/amarok/; revision=946519

9 years agoCut down excessive string length
Nikolaj Hald Nielsen [Sun, 29 Mar 2009 14:35:33 +0000 (14:35 -0000)]
Cut down excessive string length

svn path=/trunk/extragear/multimedia/amarok/; revision=946504

9 years agoCreate a system for having unique system defined bookmark groups that are crfeated...
Nikolaj Hald Nielsen [Sun, 29 Mar 2009 14:33:26 +0000 (14:33 -0000)]
Create a system for having unique system defined bookmark groups that are crfeated or loaded as needed to ensure that there is only one of a given
type. Store all automatically generated timecodes in such a group to avoid cluttering the list of bookmarks.

svn path=/trunk/extragear/multimedia/amarok/; revision=946501

9 years agoAgain increase saturation slightly: 50% -> 60%.
Mark Kretschmann [Sun, 29 Mar 2009 14:32:49 +0000 (14:32 -0000)]
Again increase saturation slightly: 50% -> 60%.

(Yes, getting such details right is important :P)

svn path=/trunk/extragear/multimedia/amarok/; revision=946498

9 years agoIncrease saturation level slightly, from 40% to 50%, to be more
Mark Kretschmann [Sun, 29 Mar 2009 13:11:38 +0000 (13:11 -0000)]
Increase saturation level slightly, from 40% to 50%, to be more
consistent with the rest of Amarok.

svn path=/trunk/extragear/multimedia/amarok/; revision=946421

9 years agodraw source emblem
Leo Franchi [Sun, 29 Mar 2009 12:59:34 +0000 (12:59 -0000)]
draw source emblem

svn path=/trunk/extragear/multimedia/amarok/; revision=946409

9 years agoMake Amarok::highlightColor() actually work as expected. Was a stupid
Mark Kretschmann [Sun, 29 Mar 2009 12:26:23 +0000 (12:26 -0000)]
Make Amarok::highlightColor() actually work as expected. Was a stupid
bug, sorry.

PS: Feel free to experiment with the saturation factor, if you think
it's not perfect.

svn path=/trunk/extragear/multimedia/amarok/; revision=946390

9 years agoTrying to make the saturation reduction actually work (it doesn't seem
Mark Kretschmann [Sun, 29 Mar 2009 11:51:15 +0000 (11:51 -0000)]
Trying to make the saturation reduction actually work (it doesn't seem
to have any impact currently).

Anyone familiar with QColor and HSV able to help here?

svn path=/trunk/extragear/multimedia/amarok/; revision=946381

9 years agoMove definition of highlightColor() to App.cpp. Reduces compile times
Mark Kretschmann [Sun, 29 Mar 2009 11:51:09 +0000 (11:51 -0000)]
Move definition of highlightColor() to App.cpp. Reduces compile times
(also, changing Amarok.h is pure hell).

svn path=/trunk/extragear/multimedia/amarok/; revision=946380

9 years agoAs discussed with Leo Franchi, introduce a special
Mark Kretschmann [Sun, 29 Mar 2009 11:51:00 +0000 (11:51 -0000)]
As discussed with Leo Franchi, introduce a special
Amarok::highlightColor(), which returns the normal KDE highlight color,
but with slightly reduced saturation.

The point of this is to make the color a bit less "contrasty", and have
it harmonize better with the rest of Amarok. It should be used
everywhere instead of the direct color from KDE.

svn path=/trunk/extragear/multimedia/amarok/; revision=946378

9 years agouse relative font sizes
Leo Franchi [Sun, 29 Mar 2009 10:14:07 +0000 (10:14 -0000)]
use relative font sizes

svn path=/trunk/extragear/multimedia/amarok/; revision=946353

9 years agofix vertical distribution of artist and album lines
Leo Franchi [Sun, 29 Mar 2009 09:42:58 +0000 (09:42 -0000)]
fix vertical distribution of artist and album lines

svn path=/trunk/extragear/multimedia/amarok/; revision=946345

9 years agobit less intense gradient for the toolbar background
Leo Franchi [Sun, 29 Mar 2009 09:42:54 +0000 (09:42 -0000)]
bit less intense gradient for the toolbar background

svn path=/trunk/extragear/multimedia/amarok/; revision=946344

9 years agopart 2 of N of the spice up your life series.
Leo Franchi [Sun, 29 Mar 2009 09:42:49 +0000 (09:42 -0000)]
part 2 of N of the spice up your life series.
colorify the applet toolbar a little bit. thoughts appreciated, this is
a experimental commit :D

svn path=/trunk/extragear/multimedia/amarok/; revision=946343

9 years agomake background extend all the way to the border
Leo Franchi [Sun, 29 Mar 2009 09:42:42 +0000 (09:42 -0000)]
make background extend all the way to the border

svn path=/trunk/extragear/multimedia/amarok/; revision=946342

9 years agoAdd escaping to user visible urls
Nikolaj Hald Nielsen [Sun, 29 Mar 2009 08:53:48 +0000 (08:53 -0000)]
Add escaping to user visible urls

svn path=/trunk/extragear/multimedia/amarok/; revision=946333

9 years agoChangeLog++
Nikolaj Hald Nielsen [Sun, 29 Mar 2009 08:38:50 +0000 (08:38 -0000)]
Add some stuff that I had obviously forgotten...

svn path=/trunk/extragear/multimedia/amarok/; revision=946329

9 years agocruft--
Leo Franchi [Sun, 29 Mar 2009 00:12:37 +0000 (00:12 -0000)]
this was the first applet written and boy, it is showing it.

svn path=/trunk/extragear/multimedia/amarok/; revision=946275

9 years agofix right side margin properly
Leo Franchi [Sat, 28 Mar 2009 23:43:31 +0000 (23:43 -0000)]
fix right side margin properly

svn path=/trunk/extragear/multimedia/amarok/; revision=946267

9 years agospice up your life with some Guaranteed Color Love (tm)
Leo Franchi [Sat, 28 Mar 2009 23:43:27 +0000 (23:43 -0000)]
spice up your life with some Guaranteed Color Love (tm)
major UI work on the Current Track applet with Lee Olson. comments


svn path=/trunk/extragear/multimedia/amarok/; revision=946266

9 years agoOk, so its official, the EngineController is clincally insane, throwing around state...
Nikolaj Hald Nielsen [Sat, 28 Mar 2009 17:59:21 +0000 (17:59 -0000)]
Ok, so its official, the EngineController is clincally insane, throwing around state changes like there is no tomorrow! Fix small regression caused by
my commit 946057 causing propper info not to be shown in th CV when resuming playback on startup. This was caused by a Stopped->Paused->Playing state
progression for some obscure reason being emitted when starting playback the first time. Why a Paused state is needed in there is beyound me...

svn path=/trunk/extragear/multimedia/amarok/; revision=946109

9 years agoHere is a little hack I been meaning to do for a while. When downloading from magnatune,
Nikolaj Hald Nielsen [Sat, 28 Mar 2009 17:32:26 +0000 (17:32 -0000)]
Here is a little hack I been meaning to do for a while. When downloading from magnatune,
store the format and download path for next time and set as pre selected values in the

svn path=/trunk/extragear/multimedia/amarok/; revision=946101

9 years agoChangeLog++
Nikolaj Hald Nielsen [Sat, 28 Mar 2009 16:00:33 +0000 (16:00 -0000)]

svn path=/trunk/extragear/multimedia/amarok/; revision=946058

9 years agoDo not send a "Current" message to all applets when the engine changes from Paused...
Nikolaj Hald Nielsen [Sat, 28 Mar 2009 15:58:59 +0000 (15:58 -0000)]
Do not send a "Current" message to all applets when the engine changes from Paused to Playing state. In this case there is really no need for applets
to update their info and doing so can cause unwanted behaviour, such as the lyric applet scrolling to the top when a track is unpaused.
BUG: 182519

svn path=/trunk/extragear/multimedia/amarok/; revision=946057

9 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sat, 28 Mar 2009 15:51:15 +0000 (15:51 -0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/extragear/multimedia/amarok/; revision=946047

9 years agoChangeLog++
Nikolaj Hald Nielsen [Sat, 28 Mar 2009 14:53:00 +0000 (14:53 -0000)]

svn path=/trunk/extragear/multimedia/amarok/; revision=945979

9 years agoFix lyrics applet not automatically getting updated when relevant track metadata...
Nikolaj Hald Nielsen [Sat, 28 Mar 2009 14:51:20 +0000 (14:51 -0000)]
Fix lyrics applet not automatically getting updated when relevant track metadata has changed. This was caused by the cached lyrics being used even if
title or artist had been changed.
BUG: 185237

svn path=/trunk/extragear/multimedia/amarok/; revision=945975

9 years agoFix "Load" to "Overwrite Playlist" to fix confusion.
Jeff Mitchell [Sat, 28 Mar 2009 14:31:25 +0000 (14:31 -0000)]
Fix "Load" to "Overwrite Playlist" to fix confusion.

There are better ways to fix this as various things creating actions use varios strings, and I will try to fix globally for > 2.1, but for now this suffices to fix the most confusing wording we get complaints about.

svn path=/trunk/extragear/multimedia/amarok/; revision=945937

9 years agoChangelog++
Alejandro Daniel Wainzinger [Sat, 28 Mar 2009 14:05:40 +0000 (14:05 -0000)]

svn path=/trunk/extragear/multimedia/amarok/; revision=945881

9 years agoFix dupe-checking when copying tracks. Logic was correct in IpodHandler but not...
Alejandro Daniel Wainzinger [Sat, 28 Mar 2009 13:35:14 +0000 (13:35 -0000)]
Fix dupe-checking when copying tracks.  Logic was correct in IpodHandler but not here.  Copy+Paste--

svn path=/trunk/extragear/multimedia/amarok/; revision=945872

9 years agoTitle case the collection item byline
Seb Ruiz [Sat, 28 Mar 2009 04:02:21 +0000 (04:02 -0000)]
Title case the collection item byline

svn path=/trunk/extragear/multimedia/amarok/; revision=945717

9 years agoDelegates are only used by the collection browser
Seb Ruiz [Sat, 28 Mar 2009 04:02:08 +0000 (04:02 -0000)]
Delegates are only used by the collection browser

svn path=/trunk/extragear/multimedia/amarok/; revision=945716

9 years agocheck is not needed for now, I will work on that later and integrate a proper CMake...
Patrick Spendrin [Thu, 26 Mar 2009 21:45:25 +0000 (21:45 -0000)]
check is not needed for now, I will work on that later and integrate a proper CMake import then

svn path=/trunk/extragear/multimedia/amarok/; revision=945112

9 years agoRerender bookmarks when progressbar's length is changed. Patch by Simon Bühler <simon...
Valentin Rouet [Thu, 26 Mar 2009 16:52:35 +0000 (16:52 -0000)]
Rerender bookmarks when progressbar's length is changed. Patch by Simon Bühler <>, thanks :)
BUG: 184773

svn path=/trunk/extragear/multimedia/amarok/; revision=945000

9 years agorename to Counting as per seb's suggestion, it does fit better
Leo Franchi [Thu, 26 Mar 2009 10:37:24 +0000 (10:37 -0000)]
rename to Counting as per seb's suggestion, it does fit better

svn path=/trunk/extragear/multimedia/amarok/; revision=944854

9 years agoinstead of showing -1 or 1 track in the collection while loading, just
Leo Franchi [Thu, 26 Mar 2009 10:30:34 +0000 (10:30 -0000)]
instead of showing -1 or 1 track in the collection while loading, just
say Loading. can take a while on large collections (3-4 seconds here).

svn path=/trunk/extragear/multimedia/amarok/; revision=944851

9 years agoThis was a bit tricky... Fix issue where Position Markers would not be shown for...
Nikolaj Hald Nielsen [Thu, 26 Mar 2009 10:08:48 +0000 (10:08 -0000)]
This was a bit tricky... Fix issue where Position Markers would not be shown for the new track when moving from one track to another. Restarting playback of the new track would correctly show them. This was caused by the slider
not having figured out the actual length of the new track yet so the triangle x positions were _way_ off.

svn path=/trunk/extragear/multimedia/amarok/; revision=944846

9 years agodont use formatString when passing to i18np, it requires an int argument
Leo Franchi [Thu, 26 Mar 2009 09:52:15 +0000 (09:52 -0000)]
dont use formatString when passing to i18np, it requires an int argument
not a qstring. also, as we know the int is always -1 at that point
anyway it was a bogus check in the first place.

svn path=/trunk/extragear/multimedia/amarok/; revision=944838

9 years agoDo not automatically add a tiecode if less than a minute of the track has been played...
Nikolaj Hald Nielsen [Thu, 26 Mar 2009 09:44:59 +0000 (09:44 -0000)]
Do not automatically add a tiecode if less than a minute of the track has been played. This ensures that accidentally starting playback on a track and then quickly moving on will not cause a useless timecode to get added,
and it will not remove any valid auto timecodes further in the track.

svn path=/trunk/extragear/multimedia/amarok/; revision=944837

9 years ago"Bookmark Position" -> "Add Position Marker"
Nikolaj Hald Nielsen [Thu, 26 Mar 2009 09:40:18 +0000 (09:40 -0000)]
"Bookmark Position" -> "Add Position Marker"

svn path=/trunk/extragear/multimedia/amarok/; revision=944836

9 years agoWhen adding an auto timecode when stopping a long track, any previously auto added...
Nikolaj Hald Nielsen [Thu, 26 Mar 2009 09:36:16 +0000 (09:36 -0000)]
When adding an auto timecode when stopping a long track, any previously auto added timecodes for the same trac are now deleted. User added timecodes are left intact. Please test as this is required changes to the db scheme, which
should be upgraded transparently without deleting existing timecodes.

svn path=/trunk/extragear/multimedia/amarok/; revision=944834

9 years agoCollection cleanup pt. 3: As the finale of this small trilogy, add a custom Collectio...
Nikolaj Hald Nielsen [Wed, 25 Mar 2009 21:15:38 +0000 (21:15 -0000)]
Collection cleanup pt. 3: As the finale of this small trilogy, add a custom CollectionTreeView class for the CollectionBrowser where it can do as much event handling trickery as needed to suport the new collection headers without
adversely affecting any other users of the CollectionTreeView base class. And they all lived happily ever after! :-)

svn path=/trunk/extragear/multimedia/amarok/; revision=944638

9 years agoCollection cleanup pt. 2: Get rid of CollectionBrowser specific event handling in...
Nikolaj Hald Nielsen [Wed, 25 Mar 2009 20:58:42 +0000 (20:58 -0000)]
Collection cleanup pt. 2: Get rid of CollectionBrowser specific event handling in shared view class

svn path=/trunk/extragear/multimedia/amarok/; revision=944631

9 years agoCollection cleanup pt. 1: Move shared classes from src/browsers/collectionbrowser...
Nikolaj Hald Nielsen [Wed, 25 Mar 2009 20:54:29 +0000 (20:54 -0000)]
Collection cleanup pt. 1: Move shared classes from src/browsers/collectionbrowser to src/browser

svn path=/trunk/extragear/multimedia/amarok/; revision=944628

9 years agoFixed the reemplemented CollectionTreeView::mousePressEvent() that caused bad mouse...
Valentin Rouet [Wed, 25 Mar 2009 19:53:24 +0000 (19:53 -0000)]
Fixed the reemplemented CollectionTreeView::mousePressEvent() that caused bad mouse handling in the cool streams service (and problably some other services).
BUG: 188005

svn path=/trunk/extragear/multimedia/amarok/; revision=944595

9 years agoReally hide the tabbar (wrt SVN commit 944173 by markey)
Kevin Funk [Wed, 25 Mar 2009 16:55:00 +0000 (16:55 -0000)]
Really hide the tabbar (wrt SVN commit 944173 by markey)

svn path=/trunk/extragear/multimedia/amarok/; revision=944540

9 years agoRemove unneeded code
Kevin Funk [Wed, 25 Mar 2009 16:43:19 +0000 (16:43 -0000)]
Remove unneeded code

svn path=/trunk/extragear/multimedia/amarok/; revision=944536

9 years agoFix alignment of sliders in the MainToolbar
Kevin Funk [Wed, 25 Mar 2009 16:12:24 +0000 (16:12 -0000)]
Fix alignment of sliders in the MainToolbar

svn path=/trunk/extragear/multimedia/amarok/; revision=944520