amarok:rengelss-amarok.git
6 years agoAll AndBiases are now created empty
Ralf Engels [Wed, 9 Mar 2011 18:00:11 +0000 (19:00 +0100)]
All AndBiases are now created empty

6 years agoForgot the SearchQueryFiles
Ralf Engels [Wed, 9 Mar 2011 19:17:30 +0000 (20:17 +0100)]
Forgot the SearchQueryFiles

6 years agoBug fixing and improvements for DynamicModel
Ralf Engels [Wed, 9 Mar 2011 16:22:08 +0000 (17:22 +0100)]
Bug fixing and improvements for DynamicModel

6 years agoSmall improvements for QuizPlay and TagMatch bias
Ralf Engels [Wed, 9 Mar 2011 16:21:39 +0000 (17:21 +0100)]
Small improvements for QuizPlay and TagMatch bias

6 years agoParameter to create an empty bias
Ralf Engels [Wed, 9 Mar 2011 16:20:57 +0000 (17:20 +0100)]
Parameter to create an empty bias

6 years agoFix disabling of LikeBack
Ralf Engels [Mon, 7 Mar 2011 17:31:26 +0000 (18:31 +0100)]
Fix disabling of LikeBack

6 years agogeneric bias improvements
Ralf Engels [Sun, 6 Mar 2011 16:39:30 +0000 (17:39 +0100)]
generic bias improvements

6 years agoNew default bias for new playlist
Ralf Engels [Sun, 6 Mar 2011 16:39:11 +0000 (17:39 +0100)]
New default bias for new playlist

6 years agoLess debug output for QuizPlayBias
Ralf Engels [Sun, 6 Mar 2011 16:38:17 +0000 (17:38 +0100)]
Less debug output for QuizPlayBias

6 years agoLayout improvements for dynamic bias
Ralf Engels [Sun, 6 Mar 2011 16:37:45 +0000 (17:37 +0100)]
Layout improvements for dynamic bias

6 years agoReorder biases
Ralf Engels [Sun, 6 Mar 2011 16:36:40 +0000 (17:36 +0100)]
Reorder biases

6 years agoNo default bias for PartBias
Ralf Engels [Sun, 6 Mar 2011 16:36:07 +0000 (17:36 +0100)]
No default bias for PartBias

6 years agoNew test case for created and modified
Ralf Engels [Sun, 6 Mar 2011 15:14:12 +0000 (16:14 +0100)]
New test case for created and modified

6 years agoFix search bar with date
Ralf Engels [Sun, 6 Mar 2011 15:13:42 +0000 (16:13 +0100)]
Fix search bar with date

6 years agoLayout improvements for DynamicCategory
Ralf Engels [Sun, 6 Mar 2011 11:37:41 +0000 (12:37 +0100)]
Layout improvements for DynamicCategory

6 years agoCopy constructor for TrackSet
Ralf Engels [Sun, 6 Mar 2011 11:36:48 +0000 (12:36 +0100)]
Copy constructor for TrackSet

6 years agoNew SearchQueryBias
Ralf Engels [Sun, 27 Feb 2011 23:59:24 +0000 (00:59 +0100)]
New SearchQueryBias

6 years agoClone selected and add new playlist
Ralf Engels [Tue, 1 Mar 2011 16:32:17 +0000 (17:32 +0100)]
Clone selected and add new playlist

6 years agoA tree model for all the dynamic playlists
Ralf Engels [Tue, 1 Mar 2011 16:32:17 +0000 (17:32 +0100)]
A tree model for all the dynamic playlists

6 years agoA tree model for all the dynamic playlists
Ralf Engels [Tue, 1 Mar 2011 16:32:17 +0000 (17:32 +0100)]
A tree model for all the dynamic playlists

6 years agotoString for Bias
Ralf Engels [Mon, 28 Feb 2011 14:19:28 +0000 (15:19 +0100)]
toString for Bias

6 years agoNew IfElse Bias
Ralf Engels [Sun, 27 Feb 2011 18:53:43 +0000 (19:53 +0100)]
New IfElse Bias

6 years agoMerge branch 'kde-master' into dynamicplaylist
Ralf Engels [Sun, 27 Feb 2011 14:31:07 +0000 (15:31 +0100)]
Merge branch 'kde-master' into dynamicplaylist

Conflicts:
src/core-impl/collections/db/ScanResultProcessor.cpp
src/dynamic/TrackSet.h

6 years agoStupid bug deleting tracks.
Ralf Engels [Sun, 27 Feb 2011 10:52:35 +0000 (11:52 +0100)]
Stupid bug deleting tracks.
why didn't the auto tests catch that.

6 years agoReport Sql database errors during startup and scanning as error dialog.
Ralf Engels [Sat, 26 Feb 2011 23:45:23 +0000 (00:45 +0100)]
Report Sql database errors during startup and scanning as error dialog.
It seems that our focus group is not looking for the debug output when running Amarok or even when reporting errors.

Bug: 262086

6 years agoBetter handling of deleted tracks.
Ralf Engels [Sat, 26 Feb 2011 20:43:02 +0000 (21:43 +0100)]
Better handling of deleted tracks.
We need to ensure that the urls table entries of tracks don't block new tracks.
Also I added a check for duplicate tracks (no idea where I got them from)

Auto tests still run flawless

6 years agoDon't block preparing KDirWatch
Ralf Engels [Sat, 26 Feb 2011 20:39:17 +0000 (21:39 +0100)]
Don't block preparing KDirWatch
KDirWatch might take a while adding recursive collection directories. Now we use a job for that.

6 years agoAnother checkpoint crash
Ralf Engels [Sat, 26 Feb 2011 20:38:28 +0000 (21:38 +0100)]
Another checkpoint crash

6 years agoFix: Current Track Applet showed wrong tracks.
Mark Kretschmann [Sat, 26 Feb 2011 06:58:51 +0000 (07:58 +0100)]
Fix: Current Track Applet showed wrong tracks.

The Current Track Applet showed unplayed tracks (Meta::valLastPlayed = "2147483647").
The patch solves that problems by exclude that tracks.

Thanks to Conrad Hübler for this patch!

REVIEW: 100006

6 years agoFix crash in playlist generator checkpoint when starting Amarok
Ralf Engels [Sat, 26 Feb 2011 00:14:46 +0000 (01:14 +0100)]
Fix crash in playlist generator checkpoint when starting Amarok

6 years agoFix problem moving tracks from collections to SqlCollection
Ralf Engels [Fri, 25 Feb 2011 17:48:04 +0000 (18:48 +0100)]
Fix problem moving tracks from collections to SqlCollection

Bug: 265539

6 years agoFix some UMS podcast issues.
Bart Cerneels [Thu, 10 Feb 2011 11:47:27 +0000 (12:47 +0100)]
Fix some UMS podcast issues.

6 years agoImplement convenience functions addPlaylist/Track
Bart Cerneels [Thu, 10 Feb 2011 09:42:31 +0000 (10:42 +0100)]
Implement convenience functions addPlaylist/Track

6 years agoUpdate FindQJSON from the qjson project
Kevin Funk [Thu, 24 Feb 2011 10:59:24 +0000 (11:59 +0100)]
Update FindQJSON from the qjson project

We cannot rely on the original cmake module (v0.7.1) that is shipped
with qjson since it marks it as required.

Related to:
http://gitorious.org/qjson/qjson/commit/e96b7b0d55cbe5092b68be67bf19f12d4a74d0f3

6 years agoReally make QJson optional
Kevin Funk [Thu, 24 Feb 2011 10:45:35 +0000 (11:45 +0100)]
Really make QJson optional

6 years agoFix Bug: QJson was not optional
Stefan Derkits [Thu, 24 Feb 2011 10:36:22 +0000 (11:36 +0100)]
Fix Bug: QJson was not optional

6 years agoInline editor now can change rating for uneditable tracks.
Edward Hades [Wed, 23 Feb 2011 13:26:34 +0000 (14:26 +0100)]
Inline editor now can change rating for uneditable tracks.

To change rating, you do not need the EditCapability. However, inline
editor widget bailed out completely, when the track is uneditable.

This patch forces inline widget to apply track rating change (if any)
before checking for edit capability.

6 years agoRelicense our small debug library (GPL->LGPL)
Kevin Funk [Wed, 23 Feb 2011 12:33:01 +0000 (13:33 +0100)]
Relicense our small debug library (GPL->LGPL)

Every copyright holder agreed to this.

CCMAIL: kretschmann@kde.org
CCMAIL: max.howell@methylblue.com

6 years agoPorted PlaydarCollection from JsonQt to QJson
Stefan Derkits [Tue, 8 Feb 2011 00:07:32 +0000 (01:07 +0100)]
Ported PlaydarCollection from JsonQt to QJson

-) added cmake/modules/FindQJson.cmake
-) deleted external/JsonQt & adapted external/CmakeLists.txt
-) use QJson in collections/playdarcollection/support/
-) only compile PlaydarCollection if QJson is found

6 years agoFix potential crash in SetCustomCoverAction
Ralf Engels [Tue, 22 Feb 2011 20:19:06 +0000 (21:19 +0100)]
Fix potential crash in SetCustomCoverAction

6 years agoFix problem when using a splitter in a layout with moodbar
Ralf Engels [Tue, 22 Feb 2011 20:10:49 +0000 (21:10 +0100)]
Fix problem when using a splitter in a layout with moodbar

BUG: 231238

6 years agoPrevent threading problem when searching while in merged view
Ralf Engels [Mon, 21 Feb 2011 21:08:35 +0000 (22:08 +0100)]
Prevent threading problem when searching while in merged view

BUG: 266421

6 years agoMetaQueryWidget now compiles correct filter (field: text) for string fields
Sergey Ivanov [Tue, 22 Feb 2011 20:17:31 +0000 (23:17 +0300)]
MetaQueryWidget now compiles correct filter (field: text) for string fields
(Title, Album, etc.).

6 years agoPrevent crash in MediaDeviceTrack::prettyUrl() caused by infinite loop in case of...
Sergey Ivanov [Sun, 20 Feb 2011 18:35:55 +0000 (21:35 +0300)]
Prevent crash in MediaDeviceTrack::prettyUrl() caused by infinite loop in case of empty track name. Patch by Roman Malytskyy.
REVIEW: 100402

6 years agoBug 259675
Ralf Engels [Sun, 20 Feb 2011 23:20:51 +0000 (00:20 +0100)]
Bug 259675

6 years agoBug 247400
Ralf Engels [Sun, 20 Feb 2011 17:29:54 +0000 (18:29 +0100)]
Bug 247400

6 years agolabels applet: Minor ui improvement
Daniel Faust [Sun, 20 Feb 2011 18:33:06 +0000 (19:33 +0100)]
labels applet: Minor ui improvement

6 years agoAdded grabbing of the disc number from release title (MusicBrainz).
Sergey Ivanov [Sat, 19 Feb 2011 22:34:31 +0000 (01:34 +0300)]
Added grabbing of the disc number from release title (MusicBrainz).

6 years agoAdded kconf_update script to update Format strings stored in amarokrc according to
Sergey Ivanov [Sat, 19 Feb 2011 17:24:08 +0000 (20:24 +0300)]
Added kconf_update script to update Format strings stored in amarokrc according to
new token's syntax (%token% instead of %token).
Add "Update Preset" button to update currently selected preset.
Make Organize Collection dialog to store all changes to "Format Presets" on close
(doesn't matter if dialog was accepted or rejected).

6 years agoDo not remove HTML <pre> and </pre>-tags from tabs-data. Fix for bug 266171.
Rainer Sigle [Sat, 19 Feb 2011 12:25:28 +0000 (13:25 +0100)]
Do not remove HTML <pre> and </pre>-tags from tabs-data. Fix for bug 266171.

Thanks to Martin Kunkel for pointing this out!

6 years agoFix crash when aborting refill
Ralf Engels [Fri, 18 Feb 2011 18:52:24 +0000 (19:52 +0100)]
Fix crash when aborting refill

6 years agoRely on the playbackStateChanged() signal to emit the StatusChange dbus
Anthony Vital [Thu, 17 Feb 2011 01:10:04 +0000 (02:10 +0100)]
Rely on the playbackStateChanged() signal to emit the StatusChange dbus
signal
REVIEW: 100602

6 years agoFix includes as reported by Sergey
Ralf Engels [Sun, 13 Feb 2011 01:51:37 +0000 (02:51 +0100)]
Fix includes as reported by Sergey

6 years agoFix WeeklyTopBias
Ralf Engels [Sun, 13 Feb 2011 01:50:46 +0000 (02:50 +0100)]
Fix WeeklyTopBias

6 years agoFix replacement filter widget
Ralf Engels [Sun, 13 Feb 2011 01:50:04 +0000 (02:50 +0100)]
Fix replacement filter widget

6 years agofixuifiles
Pino Toscano [Sat, 12 Feb 2011 21:35:54 +0000 (22:35 +0100)]
fixuifiles

6 years agoFix licensing issues (change v3+ to v2+)
Kevin Funk [Fri, 11 Feb 2011 16:01:32 +0000 (17:01 +0100)]
Fix licensing issues (change v3+ to v2+)

Requested by Dan Meltzer.

Reference:
http://mail.kde.org/pipermail/amarok-devel/2011-February/008619.html

6 years agolabels applet: Hide the black list button if a label has already been used by the...
Daniel Faust [Fri, 11 Feb 2011 18:34:22 +0000 (19:34 +0100)]
labels applet: Hide the black list button if a label has already been used by the user

6 years agolabels applet: Adds an advanced option to replace downloaded labels with custom labels
Daniel Faust [Fri, 11 Feb 2011 18:21:03 +0000 (19:21 +0100)]
labels applet: Adds an advanced option to replace downloaded labels with custom labels

6 years agoFix the Applet::showMessage() for KDE 4.6/trunk.
Martin Blumenstingl [Wed, 9 Feb 2011 18:31:00 +0000 (19:31 +0100)]
Fix the Applet::showMessage() for KDE 4.6/trunk.

6 years agoBug 256380
Ralf Engels [Wed, 9 Feb 2011 20:26:32 +0000 (21:26 +0100)]
Bug 256380

6 years agoSmall debug output cleanup
Ralf Engels [Wed, 9 Feb 2011 19:27:20 +0000 (20:27 +0100)]
Small debug output cleanup

6 years agoFix wrong context in BiasedPlaylist
Ralf Engels [Wed, 9 Feb 2011 19:26:40 +0000 (20:26 +0100)]
Fix wrong context in BiasedPlaylist

6 years agoFix error in PartBias
Ralf Engels [Wed, 9 Feb 2011 19:26:15 +0000 (20:26 +0100)]
Fix error in PartBias

6 years agoAdditional function for TrackSet
Ralf Engels [Wed, 9 Feb 2011 19:25:58 +0000 (20:25 +0100)]
Additional function for TrackSet

6 years agoFix problem with TagMatchBias
Ralf Engels [Wed, 9 Feb 2011 15:44:48 +0000 (16:44 +0100)]
Fix problem with TagMatchBias

6 years agoFix incorrect ordering of AFT types
Jeff Mitchell [Wed, 9 Feb 2011 13:03:55 +0000 (08:03 -0500)]
Fix incorrect ordering of AFT types

6 years agoFixed track's statistics update in case of StopAfterCurrent playback mode (prevent...
Sergey Ivanov [Wed, 9 Feb 2011 12:32:39 +0000 (15:32 +0300)]
Fixed track's statistics update in case of StopAfterCurrent playback mode (prevent double statistics change).
BUG: 265654

6 years agoFixed bug which made OrganizeCollection dialog (TrackOrganizer class) return empty...
Sergey Ivanov [Wed, 9 Feb 2011 11:06:21 +0000 (14:06 +0300)]
Fixed bug which made OrganizeCollection dialog (TrackOrganizer class) return empty track's destination If scheme wasn't changed and Preview button wasn't pressed (initial dialog state).

6 years agoDelete .mood files when tracks got removed from collection via Collection view contex...
Sergey Ivanov [Wed, 9 Feb 2011 10:35:19 +0000 (13:35 +0300)]
Delete .mood files when tracks got removed from collection via Collection view context menu, and move them to new destination during Organize Collection process.
BUG: 261629

6 years agoTrackSet test
Ralf Engels [Tue, 8 Feb 2011 17:43:26 +0000 (18:43 +0100)]
TrackSet test

6 years agoFix amaroknowplaying.rb for data containing ':'
Kevin Funk [Mon, 7 Feb 2011 20:53:25 +0000 (21:53 +0100)]
Fix amaroknowplaying.rb for data containing ':'

Use str.partition instead of str.split for this.

6 years agoBug: 191240
Ralf Engels [Sun, 6 Feb 2011 20:01:14 +0000 (21:01 +0100)]
Bug: 191240

6 years agoSeveral bias bugfixes
Ralf Engels [Sun, 6 Feb 2011 18:49:06 +0000 (19:49 +0100)]
Several bias bugfixes

6 years agoImprove LastFM biases
Ralf Engels [Sun, 6 Feb 2011 18:48:55 +0000 (19:48 +0100)]
Improve LastFM biases

6 years agoCleanup TrayIcon class, update copyrights
Kevin Funk [Sun, 6 Feb 2011 02:44:14 +0000 (03:44 +0100)]
Cleanup TrayIcon class, update copyrights

6 years agoFix actions getting lost in tray menu.
Kevin Funk [Sun, 6 Feb 2011 02:17:25 +0000 (03:17 +0100)]
Fix actions getting lost in tray menu.

BUG: 258226

6 years agoCleanup includes in ScriptManager
Kevin Funk [Sun, 6 Feb 2011 01:11:58 +0000 (02:11 +0100)]
Cleanup includes in ScriptManager

6 years agoRemove redundant checks for kdeversion
Kevin Funk [Sun, 6 Feb 2011 00:50:15 +0000 (01:50 +0100)]
Remove redundant checks for kdeversion

We are depending on >= KDE 4.4 now, checks are out of date.

6 years agoPrevent possible double-delete
Kevin Funk [Sun, 6 Feb 2011 00:00:46 +0000 (01:00 +0100)]
Prevent possible double-delete

Possible fix for crashes while destructing objects.

BUG: 253676
BUG: 257407

6 years agoFix time labels showing the wrong tooltip
Kevin Funk [Sat, 5 Feb 2011 23:13:20 +0000 (00:13 +0100)]
Fix time labels showing the wrong tooltip

Make ProgressWidget modify the tooltip labels of its time labels.
Also remove ugly findParent() call from TimeLabel.

This included the patch from the review request.
Thanks to Alexander Potashev for the fix.

REVIEW: 100371

6 years agoRefactor TimeLabel class a bit
Kevin Funk [Sat, 5 Feb 2011 22:55:43 +0000 (23:55 +0100)]
Refactor TimeLabel class a bit

6 years agoPlayground: Make compile
Kevin Funk [Sat, 5 Feb 2011 21:59:11 +0000 (22:59 +0100)]
Playground: Make compile

REVIEW: 100395

6 years agoAdd .reviewboardrc
Kevin Funk [Sat, 5 Feb 2011 21:30:39 +0000 (22:30 +0100)]
Add .reviewboardrc

See: http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#reviewboardrc

6 years agoFix git repository cloning command.
Andrius Štikonas [Sat, 5 Feb 2011 11:18:36 +0000 (11:18 +0000)]
Fix git repository cloning command.

6 years agoRe-enable test login button in last.fm service settings.
Leo Franchi [Fri, 4 Feb 2011 22:31:07 +0000 (17:31 -0500)]
Re-enable test login button in last.fm service settings.

It was disabled if credentials are changed after successful login. Thanks to cyku and Sentynel for the patch.

6 years agoFixed empty folders removeing after collection organization.
Sergey Ivanov [Fri, 4 Feb 2011 17:08:54 +0000 (20:08 +0300)]
Fixed empty folders removeing after collection organization.
BUG: 190881

6 years agoFixed crash when trying to load cover for track/album without artist.
Sergey Ivanov [Fri, 4 Feb 2011 16:58:11 +0000 (19:58 +0300)]
Fixed crash when trying to load cover for track/album without artist.
BUG: 263256

6 years agoAuto tests for DynamicModel
Ralf Engels [Fri, 4 Feb 2011 15:55:59 +0000 (16:55 +0100)]
Auto tests for DynamicModel

6 years agoFix linking on Solaris 11
Kevin Funk [Thu, 3 Feb 2011 20:17:17 +0000 (21:17 +0100)]
Fix linking on Solaris 11

Not sure why this is needed, but another link target won't hurt.
"Redundant" link target marked with a hint to the initial bug report.

BUG: 264112
REVIEW: 100437

6 years agoPodcast dowwnload temporary names could be to long.
Bart Cerneels [Tue, 1 Feb 2011 09:15:23 +0000 (11:15 +0200)]
Podcast dowwnload temporary names could be to long.

Fixed by using MD5 hash as the name instead.
Patch by Frank Steinmetzger.

BUG:264813
REVIEW:100487

6 years agoAgain a fix for Phantom tracks
Ralf Engels [Mon, 31 Jan 2011 23:18:49 +0000 (00:18 +0100)]
Again a fix for Phantom tracks

6 years agoFix SqlAlbum and SqlScanManager auto tests
Ralf Engels [Mon, 31 Jan 2011 23:18:23 +0000 (00:18 +0100)]
Fix SqlAlbum and SqlScanManager auto tests

6 years agoFix year setting in SqlCollectionLocation
Ralf Engels [Mon, 31 Jan 2011 21:30:54 +0000 (22:30 +0100)]
Fix year setting in SqlCollectionLocation
Setting the album artist right away cannot be done directly but the
collection scanner is now really watching for changes so that
is fixed via the rescan.

Bug 263771

6 years agoAutomatically focus dropped tokens in EditFilterDialog
Ralf Engels [Mon, 31 Jan 2011 21:24:10 +0000 (22:24 +0100)]
Automatically focus dropped tokens in EditFilterDialog

6 years agoImprove ScanManager auto tests
Ralf Engels [Mon, 31 Jan 2011 17:15:47 +0000 (18:15 +0100)]
Improve ScanManager auto tests

6 years agoImprove WeeklyTopBias
Ralf Engels [Mon, 31 Jan 2011 19:43:52 +0000 (20:43 +0100)]
Improve WeeklyTopBias

6 years agoFix crash in BiasedPlaylist
Ralf Engels [Mon, 31 Jan 2011 19:43:38 +0000 (20:43 +0100)]
Fix crash in BiasedPlaylist

6 years agoFix BiasSolver endless loop
Ralf Engels [Mon, 31 Jan 2011 19:43:20 +0000 (20:43 +0100)]
Fix BiasSolver endless loop

6 years agoMerge branch 'dynamicplaylist' of gitorious.org:~rengels/amarok/rengelss-amarok into...
Ralf Engels [Mon, 31 Jan 2011 19:35:10 +0000 (20:35 +0100)]
Merge branch 'dynamicplaylist' of gitorious.org:~rengels/amarok/rengelss-amarok into dynamicplaylist