Make Meta::MetaBase::(un)subscribe() non-virtual, clean subclasses
authorMatěj Laitl <matej@laitl.cz>
Sat, 15 Sep 2012 14:54:42 +0000 (16:54 +0200)
committerMatěj Laitl <matej@laitl.cz>
Sat, 15 Sep 2012 14:54:42 +0000 (16:54 +0200)
commit7a8608f578644d06da2bfe68588d28ade16e00e0
treea2b8a3dd86dba688279135e6a5f627d1b57a71f2
parent5fca04063f2aa5ecd1c7fdf251469b721cbe7e01
Make Meta::MetaBase::(un)subscribe() non-virtual, clean subclasses

It is extremely unsafe not to use MetaBase::m_observers, to prevent
everyone from doing so. MetaProxy needlessly implemented its own
mechanism, ditch it.

This avoids many potential problems and one actual: testmetamultitrack
was failing for me because of custom MetaProxy observer implementation.

This also removes ~70 lines of code, nice.
src/core-impl/collections/audiocd/AudioCdMeta.cpp
src/core-impl/collections/audiocd/AudioCdMeta.h
src/core-impl/collections/daap/DaapMeta.cpp
src/core-impl/collections/daap/DaapMeta.h
src/core-impl/collections/upnpcollection/UpnpMeta.cpp
src/core-impl/collections/upnpcollection/UpnpMeta.h
src/core-impl/meta/proxy/MetaProxy.cpp
src/core-impl/meta/proxy/MetaProxy.h
src/core-impl/meta/proxy/MetaProxy_p.h
src/core/meta/Meta.cpp
src/core/meta/Meta.h