amarok:rengelss-amarok.git
7 years agoFix several problems with new DynamicBias dynamicplaylist
Ralf Engels [Fri, 27 May 2011 15:50:26 +0000 (17:50 +0200)]
Fix several problems with new DynamicBias

7 years agoPlaylistModelStack and PlaylistController refactoring
Ralf Engels [Wed, 25 May 2011 16:30:30 +0000 (18:30 +0200)]
PlaylistModelStack and PlaylistController refactoring
Use The::playlist wherever possible
Move The::playlistController to PlaylistController.cpp
Remove unneeded usage of QueryMaker

7 years agoImprove progress bar while scanning
Ralf Engels [Tue, 24 May 2011 13:49:15 +0000 (15:49 +0200)]
Improve progress bar while scanning

7 years agoMake dynamic playlist more robust in case of null pointers
Ralf Engels [Sat, 14 May 2011 16:15:59 +0000 (18:15 +0200)]
Make dynamic playlist more robust in case of null pointers

7 years agoImprove directory handling in collection scanner.
Ralf Engels [Fri, 6 May 2011 11:26:40 +0000 (13:26 +0200)]
Improve directory handling in collection scanner.
Now we determine the sub-directories as late as possible and also take the timestamp at exactly this time.
This will solve problems when directories are actively changing while we are scanning, which is happening at every big move.

On the other hand we can not longer claim to know the total number of sub-directories during scanning.

7 years agoFix problem with writing NAN ratings to jamendo database.
Ralf Engels [Fri, 6 May 2011 11:24:28 +0000 (13:24 +0200)]
Fix problem with writing NAN ratings to jamendo database.

7 years agoRemove unneeded parameter from biased playlist
Ralf Engels [Thu, 5 May 2011 17:13:58 +0000 (19:13 +0200)]
Remove unneeded parameter from biased playlist

7 years agoFix writing of xml with replacement bias
Ralf Engels [Thu, 5 May 2011 17:13:18 +0000 (19:13 +0200)]
Fix writing of xml with replacement bias

7 years agoMerge remote branch 'kde/master' into dynamicplaylist
Ralf Engels [Mon, 2 May 2011 18:23:53 +0000 (20:23 +0200)]
Merge remote branch 'kde/master' into dynamicplaylist

7 years agoFix problems with drag and drop
Ralf Engels [Mon, 2 May 2011 16:55:07 +0000 (18:55 +0200)]
Fix problems with drag and drop

7 years agoBetter texts for IfElseBias
Ralf Engels [Mon, 2 May 2011 16:25:19 +0000 (18:25 +0200)]
Better texts for IfElseBias

7 years agoImplement fourth example playlist
Ralf Engels [Mon, 2 May 2011 15:53:46 +0000 (17:53 +0200)]
Implement fourth example playlist

7 years agoMove PartBiasWidget to PartBias
Ralf Engels [Mon, 2 May 2011 15:52:58 +0000 (17:52 +0200)]
Move PartBiasWidget to PartBias

7 years agoSet type for destination track on Move/Copy to SqlCollection.
Sergey Ivanov [Mon, 2 May 2011 08:35:17 +0000 (12:35 +0400)]
Set type for destination track on Move/Copy to SqlCollection.

7 years agoProvide AlbumArtist name for FileView tracks.
Sergey Ivanov [Mon, 2 May 2011 08:33:32 +0000 (12:33 +0400)]
Provide AlbumArtist name for FileView tracks.

7 years agofix email address
Lydia Pintscher [Sat, 30 Apr 2011 12:08:50 +0000 (14:08 +0200)]
fix email address

7 years agoadd a MAINTAINERS file
Lydia Pintscher [Sat, 30 Apr 2011 12:04:27 +0000 (14:04 +0200)]
add a MAINTAINERS file

should help clarify where to go in case of development related questions

7 years agoFix text for replacement bias
Ralf Engels [Fri, 29 Apr 2011 15:55:07 +0000 (17:55 +0200)]
Fix text for replacement bias

7 years agoFix removing of bias and saving
Ralf Engels [Fri, 29 Apr 2011 15:54:48 +0000 (17:54 +0200)]
Fix removing of bias and saving

7 years agoFixed crash on saving playlist on ineligible device.
Sergey Ivanov [Wed, 27 Apr 2011 21:13:31 +0000 (01:13 +0400)]
Fixed crash on saving playlist on ineligible device.
BUG: 266899
FIXED-IN: 2.4.1

7 years agoFixed Photos applet crash on track metadata change.
Sergey Ivanov [Wed, 27 Apr 2011 20:52:11 +0000 (00:52 +0400)]
Fixed Photos applet crash on track metadata change.
BUG: 265395
FIXED-IN: 2.4.1

7 years agoFixed iPod mount detection issue.
Sergey Ivanov [Wed, 27 Apr 2011 20:26:40 +0000 (00:26 +0400)]
Fixed iPod mount detection issue.

7 years agoFixed crash on local collection search.
Sergey Ivanov [Wed, 27 Apr 2011 17:33:21 +0000 (21:33 +0400)]
Fixed crash on local collection search.
BUG: 270949

7 years agoFix crash during iPod track removal.
Sergey Ivanov [Wed, 27 Apr 2011 16:45:46 +0000 (20:45 +0400)]
Fix crash during iPod track removal.
BUG: 253088

7 years agoObvious typo in re-authenticate of Ampache account login.
Ralf Engels [Wed, 27 Apr 2011 19:17:07 +0000 (21:17 +0200)]
Obvious typo in re-authenticate of Ampache account login.
Fix needs to be verified.

BUG: 215750

FIXED-IN: 2.4.1

7 years agoFix for "Crash when browsing a category on Jamendo"
Ralf Engels [Wed, 27 Apr 2011 19:14:31 +0000 (21:14 +0200)]
Fix for "Crash when browsing a category on Jamendo"
This fix is consisent with the comments and stack traces in the bug
report but as I can't reproduce the crash I also can't verify the
fix.

BUG: 233170

FIXED-IN: 2.4.1

7 years agoFix invert flag
Ralf Engels [Wed, 27 Apr 2011 16:55:11 +0000 (18:55 +0200)]
Fix invert flag

7 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Wed, 27 Apr 2011 08:02:59 +0000 (10:02 +0200)]
SVN_SILENT made messages (.desktop file)

7 years agoDifferent handling for inverted bias
Ralf Engels [Tue, 26 Apr 2011 15:44:06 +0000 (17:44 +0200)]
Different handling for inverted bias

7 years agoAdd zeitgeist support through Phonon
Trever Fischer [Thu, 21 Apr 2011 00:49:14 +0000 (20:49 -0400)]
Add zeitgeist support through Phonon

7 years agoFix some actions for biases
Ralf Engels [Wed, 20 Apr 2011 16:58:44 +0000 (18:58 +0200)]
Fix some actions for biases

7 years agoMove prevention of duplicate tracks to amarok configuration and button bar
Ralf Engels [Wed, 20 Apr 2011 15:41:05 +0000 (17:41 +0200)]
Move prevention of duplicate tracks to amarok configuration and button bar

7 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Tue, 19 Apr 2011 08:00:35 +0000 (10:00 +0200)]
SVN_SILENT made messages (.desktop file)

7 years agomake tab search variations more powerful.
Rainer Sigle [Sat, 16 Apr 2011 11:53:39 +0000 (13:53 +0200)]
make tab search variations more powerful.

7 years agocorrect spelling of tab-sites
Rainer Sigle [Sat, 16 Apr 2011 11:28:10 +0000 (13:28 +0200)]
correct spelling of tab-sites

7 years agoIncrease compatibility with OPML directories.
Bart Cerneels [Fri, 15 Apr 2011 08:23:49 +0000 (10:23 +0200)]
Increase compatibility with OPML directories.

Just ignore the outline type and look for a usable url.

BUG:270206

7 years agoUI design updae of dynamic playlists
Ralf Engels [Thu, 14 Apr 2011 16:12:40 +0000 (18:12 +0200)]
UI design updae of dynamic playlists

7 years agoHopefully fix: Amarok crashed on exit
Ralf Engels [Mon, 11 Apr 2011 16:42:13 +0000 (18:42 +0200)]
Hopefully fix: Amarok crashed on exit

BUG: 261421

7 years agoFix Crash at start [@ StatusBar::shortMessage]
Ralf Engels [Mon, 11 Apr 2011 16:24:09 +0000 (18:24 +0200)]
Fix Crash at start [@ StatusBar::shortMessage]

BUG: 269070

7 years agoPrevent crash setting cover from current track applet
Ralf Engels [Mon, 11 Apr 2011 15:27:29 +0000 (17:27 +0200)]
Prevent crash setting cover from current track applet

BUG: 270012

7 years agoFix crash with upcomming events
Ralf Engels [Mon, 11 Apr 2011 15:18:50 +0000 (17:18 +0200)]
Fix crash with upcomming events

BUG: 269190

7 years agoFix: SEGFAULT when using filter field
Ralf Engels [Mon, 11 Apr 2011 13:42:16 +0000 (15:42 +0200)]
Fix: SEGFAULT when using filter field

BUG: 270496

7 years agoHopefully fix: Amarok crashed on exit
Ralf Engels [Mon, 11 Apr 2011 16:42:13 +0000 (18:42 +0200)]
Hopefully fix: Amarok crashed on exit

BUG: 261421

7 years agoFix Crash at start [@ StatusBar::shortMessage]
Ralf Engels [Mon, 11 Apr 2011 16:24:09 +0000 (18:24 +0200)]
Fix Crash at start [@ StatusBar::shortMessage]

BUG: 269070

7 years agoPrevent crash setting cover from current track applet
Ralf Engels [Mon, 11 Apr 2011 15:27:29 +0000 (17:27 +0200)]
Prevent crash setting cover from current track applet

BUG: 270012

7 years agoFix crash with upcomming events
Ralf Engels [Mon, 11 Apr 2011 15:18:50 +0000 (17:18 +0200)]
Fix crash with upcomming events

BUG: 269190

7 years agoFix: SEGFAULT when using filter field
Ralf Engels [Mon, 11 Apr 2011 13:42:16 +0000 (15:42 +0200)]
Fix: SEGFAULT when using filter field

BUG: 270496

7 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Mon, 11 Apr 2011 06:40:34 +0000 (08:40 +0200)]
SVN_SILENT made messages (.desktop file)

7 years agoAdd Peter Ndikuwera to authors for SMB & NFS functionality
Peter C. Ndikuwera [Thu, 7 Apr 2011 11:53:43 +0000 (14:53 +0300)]
Add Peter Ndikuwera to authors for SMB & NFS functionality

7 years agoOnly show the transcoding assistant dialog for those destination collections that...
Teo Mrnjavac [Wed, 6 Apr 2011 17:36:54 +0000 (19:36 +0200)]
Only show the transcoding assistant dialog for those destination collections that support transcoding.

7 years agoHandle non OPML 2.0 compliant directory correctly.
Bart Cerneels [Wed, 6 Apr 2011 09:48:20 +0000 (11:48 +0200)]
Handle non OPML 2.0 compliant directory correctly.

digitalpodcast is not using rssUrl attribute.

BUG:270206

7 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Tue, 5 Apr 2011 07:10:04 +0000 (09:10 +0200)]
SVN_SILENT made messages (.desktop file)

7 years agoReset meta filter condition if field changes
Ralf Engels [Sun, 3 Apr 2011 16:02:48 +0000 (18:02 +0200)]
Reset meta filter condition if field changes

7 years agoRelative paths support for XSPF playlists.
Sergey Ivanov [Sat, 2 Apr 2011 13:14:47 +0000 (17:14 +0400)]
Relative paths support for XSPF playlists.
BUG: 264147

7 years agoFixed some translatable strings as reported by our awesome translators team.
Teo Mrnjavac [Fri, 1 Apr 2011 11:29:25 +0000 (13:29 +0200)]
Fixed some translatable strings as reported by our awesome translators team.
CCMAIL:amarok-devel@kde.org
CCMAIL:kde-i18n-doc@kde.org

7 years agoFix incorrect handling of "Various Artists" node by Collection Browser, now selection...
Sergey Ivanov [Thu, 31 Mar 2011 13:19:17 +0000 (17:19 +0400)]
Fix incorrect handling of "Various Artists" node by Collection Browser, now selection of this node returns "Various Artists" tracks instead of whole collection.
BUG: 263255
BUG: 269717

7 years agoFix song scrobbling if It was paused.
Sergey Ivanov [Thu, 31 Mar 2011 12:06:58 +0000 (16:06 +0400)]
Fix song scrobbling if It was paused.
BUG: 267477

7 years agoAdded Christian Wagner & Felix Winter as Authors of the Gpodder Service
Stefan Derkits [Wed, 30 Mar 2011 23:31:45 +0000 (01:31 +0200)]
Added Christian Wagner & Felix Winter as Authors of the Gpodder Service

7 years agoREVIEW: 6639
Felix Winter [Wed, 30 Mar 2011 20:10:20 +0000 (22:10 +0200)]
REVIEW: 6639
Fixed invalid slotnames and removed some out-commented code.

7 years agoThis should sort out all nfs/cifs comparisons
Peter C. Ndikuwera [Wed, 30 Mar 2011 16:31:51 +0000 (19:31 +0300)]
This should sort out all nfs/cifs comparisons

7 years agoDrop Mime fix
Ralf Engels [Sun, 27 Mar 2011 13:31:53 +0000 (15:31 +0200)]
Drop Mime fix

7 years agoScreen escape characters in MusicBrainz request string.
Sergey Ivanov [Mon, 28 Mar 2011 13:37:33 +0000 (17:37 +0400)]
Screen escape characters in MusicBrainz request string.
BUG: 269455

7 years agoMerge remote branch 'kde/master' into dynamicplaylist
Ralf Engels [Mon, 28 Mar 2011 09:47:31 +0000 (11:47 +0200)]
Merge remote branch 'kde/master' into dynamicplaylist

7 years agoAgain fix unique ids. We prefere our own AFT ids
Ralf Engels [Sun, 27 Mar 2011 16:01:51 +0000 (18:01 +0200)]
Again fix unique ids. We prefere our own AFT ids

7 years agoFix auto test/Dynamic collection
Ralf Engels [Sun, 27 Mar 2011 16:00:03 +0000 (18:00 +0200)]
Fix auto test/Dynamic collection

7 years agoSVN_SILENT YANF: Yet another NFSv4 Fix
Peter C. Ndikuwera [Sun, 27 Mar 2011 08:13:55 +0000 (11:13 +0300)]
SVN_SILENT YANF: Yet another NFSv4 Fix

7 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sun, 27 Mar 2011 07:36:13 +0000 (09:36 +0200)]
SVN_SILENT made messages (.desktop file)

7 years agoSVN_SILENT spelling fix
Peter C. Ndikuwera [Sat, 26 Mar 2011 18:27:23 +0000 (21:27 +0300)]
SVN_SILENT spelling fix

7 years agoPossible null-pointer access in MP4TagHelper::embeddedCover.
Sergey Ivanov [Sat, 26 Mar 2011 14:13:25 +0000 (17:13 +0300)]
Possible null-pointer access in MP4TagHelper::embeddedCover.

7 years agoSVN_SILENT Missed line. Must be sleepy
Peter C. Ndikuwera [Sat, 26 Mar 2011 11:40:33 +0000 (14:40 +0300)]
SVN_SILENT Missed line. Must be sleepy

7 years agoMerge branch 'master' of git.kde.org:amarok
Peter C. Ndikuwera [Sat, 26 Mar 2011 11:35:38 +0000 (14:35 +0300)]
Merge branch 'master' of git.kde.org:amarok

7 years agoNFSv4 Fix++
Peter C. Ndikuwera [Sat, 26 Mar 2011 11:31:01 +0000 (14:31 +0300)]
NFSv4 Fix++

7 years agoDon't dequeue tracks hidden from view while searching, second try.
Andreas Hartmetz [Fri, 25 Mar 2011 21:03:51 +0000 (22:03 +0100)]
Don't dequeue tracks hidden from view while searching, second try.

This time while keeping bug 263308 closed.
We remove a track from the queue when it is removed from the *bottom*
model in the model stack, i.e. permanently.

BUG: 237300
CCBUG: 263308

7 years agoRecursive expand, collapse
Ralf Engels [Fri, 25 Mar 2011 17:22:15 +0000 (18:22 +0100)]
Recursive expand, collapse

7 years agoRecognized NFSv4 mounts as well
Peter C. Ndikuwera [Fri, 25 Mar 2011 09:29:08 +0000 (12:29 +0300)]
Recognized NFSv4 mounts as well

7 years agoFix const correctness in ProgressiveSearchWidget
Nikhil Marathe [Wed, 23 Mar 2011 06:30:06 +0000 (12:00 +0530)]
Fix const correctness in ProgressiveSearchWidget

7 years agoChanged Homepage & Version Number for libmygpo-qt Dependency
Stefan Derkits [Tue, 22 Mar 2011 23:57:08 +0000 (00:57 +0100)]
Changed Homepage & Version Number for libmygpo-qt Dependency

7 years agoFix deleting of redundant artist/album/etc.
Peter C. Ndikuwera [Tue, 22 Mar 2011 20:21:30 +0000 (23:21 +0300)]
Fix deleting of redundant artist/album/etc.

SQL Standard says that "WHERE id NOT IN (NULL)" always returns NULL
meaning that these SQL statements were never running if you had an
artist name that was NULL (well, at least I do).

http://dev.mysql.com/doc/refman/5.5/en/comparison-operators.html#function_in

7 years agominor style fix
Mark Kretschmann [Tue, 22 Mar 2011 18:52:37 +0000 (19:52 +0100)]
minor style fix

7 years agostyle
Mark Kretschmann [Tue, 22 Mar 2011 18:51:00 +0000 (19:51 +0100)]
style

7 years agoNikhil Marathe's fix for mysql 5.5.9
Ian Monroe [Tue, 22 Mar 2011 18:44:58 +0000 (13:44 -0500)]
Nikhil Marathe's fix for mysql 5.5.9

7 years agoUse filter token scheme suggested by Stefan Derkits (e.g. artist:"Akira Yamaoka").
Sergey Ivanov [Mon, 21 Mar 2011 18:27:51 +0000 (21:27 +0300)]
Use filter token scheme suggested by Stefan Derkits (e.g. artist:"Akira Yamaoka").
UnusedCode--

7 years agoRevert "MetaQueryWidget now compiles correct filter (field: text) for string fields"
Sergey Ivanov [Mon, 21 Mar 2011 12:20:34 +0000 (15:20 +0300)]
Revert "MetaQueryWidget now compiles correct filter (field: text) for string fields"

This reverts commit 38900be53b7eab4947b0b1ece4b1df2259351edb.

7 years agoMerge branch 'appmenu-fix'
Aurélien Gâteau [Mon, 21 Mar 2011 08:48:10 +0000 (09:48 +0100)]
Merge branch 'appmenu-fix'

CCMAIL: debfx-pkg@fobos.de

7 years agoFix changelog entries placement
Rick W. Chen [Sun, 20 Mar 2011 19:58:26 +0000 (08:58 +1300)]
Fix changelog entries placement

7 years agoFix detection of IPod Classic
Cristi Posoiu [Sun, 20 Mar 2011 10:23:03 +0000 (23:23 +1300)]
Fix detection of IPod Classic

REVIEW: 100889

7 years agoFix multiple issues with the lyrics applet/engine
Martin Blumenstingl [Sun, 20 Mar 2011 19:03:59 +0000 (08:03 +1300)]
Fix multiple issues with the lyrics applet/engine

This fixes the following lyrics related issues:

-Amarok crashed when the lyrics applet was removed and re-added while a
track was playing and the user pressed "ESC".

-If no lyrics script was running cached lyrics were not displayed (but
an error message that no scripts are running instead - might be a
regression).

-If the user edited the lyrics in TagDialog the changes were not
"synchronized" to the lyrics applet (this is probably a regression).

REVIEW: 100892

7 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sun, 20 Mar 2011 07:03:20 +0000 (08:03 +0100)]
SVN_SILENT made messages (.desktop file)

7 years agoFixed ChangeLog.
Teo Mrnjavac [Sat, 19 Mar 2011 18:06:08 +0000 (19:06 +0100)]
Fixed ChangeLog.

7 years agoMake lyrics editable when there's no currently no text
Rick W. Chen [Sat, 19 Mar 2011 02:39:37 +0000 (15:39 +1300)]
Make lyrics editable when there's no currently no text

BUG: 266722

7 years agoDon't make lyrics suggestion title bigger
Rick W. Chen [Mon, 14 Mar 2011 11:16:47 +0000 (00:16 +1300)]
Don't make lyrics suggestion title bigger

7 years agoSet correct year for destination track on Move/Copy to SqlCollection.
Sergey Ivanov [Fri, 18 Mar 2011 13:06:38 +0000 (16:06 +0300)]
Set correct year for destination track on Move/Copy to SqlCollection.
Fix odd checks for numerical fields.

7 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Fri, 18 Mar 2011 06:51:25 +0000 (07:51 +0100)]
SVN_SILENT made messages (.desktop file)

7 years agoFix typo.
Bart Cerneels [Thu, 17 Mar 2011 19:31:36 +0000 (20:31 +0100)]
Fix typo.

Thanks for spotting Riddell.

7 years agoLet the base class handle the regular drops.
Bart Cerneels [Fri, 11 Mar 2011 09:57:18 +0000 (10:57 +0100)]
Let the base class handle the regular drops.

Less code duplication.

7 years agoMerge branch 'master' of git.kde.org:amarok
Peter C. Ndikuwera [Thu, 17 Mar 2011 19:19:00 +0000 (22:19 +0300)]
Merge branch 'master' of git.kde.org:amarok

7 years agoFix Dynamic Collection/scanning of unmounted device
Peter C. Ndikuwera [Thu, 17 Mar 2011 19:12:18 +0000 (22:12 +0300)]
Fix Dynamic Collection/scanning of unmounted device

BUG: 268739

Ok, fixing my own bug report here. Collection Scanner should only scan
urls on mounted devices.

7 years agoDeviceHandler matches on udi not uuid
Peter C. Ndikuwera [Thu, 17 Mar 2011 18:30:14 +0000 (21:30 +0300)]
DeviceHandler matches on udi not uuid

7 years agoFix playback status for MPRIS2 interface
Alex Merry [Thu, 17 Mar 2011 17:56:07 +0000 (17:56 +0000)]
Fix playback status for MPRIS2 interface

Make use of the playbackStatusChanged EngineController signal to find
when we should update the playback status property, otherwise we set it
too early and get the wrong value.

BUG: 268282
FIXED-IN: 2.4.1

7 years agoFix wrong menubar when used with Plasma menubar.
Aurelien Gateau [Tue, 21 Sep 2010 13:32:15 +0000 (15:32 +0200)]
Fix wrong menubar when used with Plasma menubar.

Make sure the menubar inside ServiceBase does not replace the main menubar in
Plasma Menubar.