amarok:rengelss-amarok.git
6 years agoMediaDeviceArtist::albums() is not used, do not maintain album list
Matěj Laitl [Sat, 10 Dec 2011 12:46:50 +0000 (13:46 +0100)]
MediaDeviceArtist::albums() is not used, do not maintain album list

Code removal is good + it will allow us to rework compilation handling
in future.

6 years agoMedia device handler: remove debug stamps, not useful anymore
Matěj Laitl [Sat, 10 Dec 2011 11:18:51 +0000 (12:18 +0100)]
Media device handler: remove debug stamps, not useful anymore

6 years agoplaylist: show also albumArtist, BPM, labels, lastPlayed and bitrate in tooltip
Matěj Laitl [Mon, 8 Aug 2011 10:22:24 +0000 (12:22 +0200)]
playlist: show also albumArtist, BPM, labels, lastPlayed and bitrate in tooltip

All fields are only shown when meaningful/non-empty and not already
displayed in playlist.

Album artist in only shown when differs from artist. Tooltip is
generated on demand to this shouldn't hurt.

 * 16x16 version of the last played icon is made by editing 48x48 icon
   (sources included)
 * 16x16 version of the label icon is copied from
   [oxygen-icons]/status/mail-tagged (same as the 48x48 icon)

6 years agoiPod handler: raise libgpod dep to 0.7.93 and simplify iTunes db writing
Matěj Laitl [Wed, 19 Oct 2011 10:38:31 +0000 (12:38 +0200)]
iPod handler: raise libgpod dep to 0.7.93 and simplify iTunes db writing

Even Debian stable has libgpod-0.7.93 packaged in main repo, so this
shouldn't hurt and this version is more convenient to work with.

README is also adjusted.

6 years agoremove IpodHandler::slotInitializeIpod(), it was not used anywhere
Matěj Laitl [Tue, 18 Oct 2011 20:23:54 +0000 (22:23 +0200)]
remove IpodHandler::slotInitializeIpod(), it was not used anywhere

6 years agoAdd Version 2.6-Beta 1 ChangeLog entry
Matěj Laitl [Tue, 20 Dec 2011 10:26:28 +0000 (11:26 +0100)]
Add Version 2.6-Beta 1 ChangeLog entry

6 years agoRevert "FindMySQLAmarok.cmake fix argumets when calling mysql_config"
Christophe Giboudeaux [Sun, 18 Dec 2011 20:41:00 +0000 (21:41 +0100)]
Revert "FindMySQLAmarok.cmake fix argumets when calling mysql_config"
This reverts a fix for -Wmissing-include-dirs warnings.
MYSQL_INCLUDE_DIR *must* be a path and not contain -I<path>

CCMAIL: modax@debian.org
CCMAIL: matej@laitl.cz

This reverts commit 7588cfe2637edd1cd27094e3612fd17b53cf1897.

6 years agoFindMySQLAmarok.cmake fix argumets when calling mysql_config
Modestas Vainius [Sun, 18 Dec 2011 15:20:01 +0000 (16:20 +0100)]
FindMySQLAmarok.cmake fix argumets when calling mysql_config

This didn't break the build as MYSQL_CFLAGS already includes
-I/usr/include/mysql but at least prevents ugly warning when
calling cmake.

Patch by Modestas Vainius, thanks.

CCMAIL: modax@debian.org

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sun, 18 Dec 2011 08:50:06 +0000 (09:50 +0100)]
SVN_SILENT made messages (.desktop file)

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sat, 17 Dec 2011 08:41:44 +0000 (09:41 +0100)]
SVN_SILENT made messages (.desktop file)

6 years agoRevert "tag reading/writing support for mod, s3m, it and xm files"
Matěj Laitl [Wed, 14 Dec 2011 23:43:37 +0000 (00:43 +0100)]
Revert "tag reading/writing support for mod, s3m, it and xm files"

This reverts commit 3cae9ba4758c43092cd942a504ea43f5873960f4.
This was an erroneous push, Mathias Panzenböck wanted to push to his
own github repo, see his message in amarok-devel. :-)

CCMAIL: amarok-devel@kde.org

6 years agotag reading/writing support for mod, s3m, it and xm files
Mathias Panzenböck [Sun, 26 Jun 2011 21:56:55 +0000 (23:56 +0200)]
tag reading/writing support for mod, s3m, it and xm files

6 years agoUse Window color for the toolbar borders.
Bart Cerneels [Wed, 14 Dec 2011 18:14:06 +0000 (19:14 +0100)]
Use Window color for the toolbar borders.

6 years agoiPod handler: do not crash when master playlist is null
Matěj Laitl [Wed, 14 Dec 2011 10:37:26 +0000 (11:37 +0100)]
iPod handler: do not crash when master playlist is null

This is a late fix for bug 288936. I've added i18n( "Unknown" ) during
string freeze, but this exact string is already used elsewhere.

Sorry for such a last-minute commit, but this was an easy crashfix.

BUG: 288936
FIXED-IN: 2.5

6 years agoAmazon store artwork, part 3: cart icons
Sven Krohlas [Tue, 13 Dec 2011 20:33:39 +0000 (21:33 +0100)]
Amazon store artwork, part 3: cart icons

The shpping cart icons are there. :-) Wohoooooooo!

-> We are ready for release.

Popup dropper SVGs are not yet included, I have to check out how that
beast works. But that can be done for 2.6.

Thanks again Fabi for the great work.

Btw: I had to re-run cmake to make the build scripts fetch up those
new icons. So might you.

CCMAIL:fabidesu@googlemail.com

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Tue, 13 Dec 2011 14:48:28 +0000 (15:48 +0100)]
SVN_SILENT made messages (.desktop file)

6 years agoSo not show a frame around the Amazon view
Sven Krohlas [Mon, 12 Dec 2011 14:00:22 +0000 (15:00 +0100)]
So not show a frame around the Amazon view

Especially when selecting items this looks out of place.

6 years agoAmazon store artwork, part 2: service hover image
Sven Krohlas [Mon, 12 Dec 2011 13:27:25 +0000 (14:27 +0100)]
Amazon store artwork, part 2: service hover image

Based on Fabis icon.

6 years agoAmazon store artwork: source files for icon and emblem
Sven Krohlas [Mon, 12 Dec 2011 12:35:02 +0000 (13:35 +0100)]
Amazon store artwork: source files for icon and emblem

6 years agoAmazon store artwork, part 1: logo and emblem
Sven Krohlas [Mon, 12 Dec 2011 12:19:44 +0000 (13:19 +0100)]
Amazon store artwork, part 1: logo and emblem

Thanks to "Fabi" (whatever your real name is).

To make them show up I had to delete some caches:
  /var/tmp/kdecache-$USER/icon-cache.kcache
and
  /var/tmp/kdecache-$USER/Amarok-pixmaps.kcache

So if the icons don't show up try that.

License:
"since i dont know much about licences.. choose whatever you want :)"
So we make that GPLv2.1 or later.

CCMAIL:fabidesu@googlemail.com

6 years agoFix bogus logic when opening KWallet in Last.fm configuration
Matěj Laitl [Sun, 11 Dec 2011 15:15:50 +0000 (16:15 +0100)]
Fix bogus logic when opening KWallet in Last.fm configuration

The logic is still a bit convoluted, but at a last-minute fix this
suffices and should introduce no problems.

BUG: 286741
FIXED-IN: 2.5

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sun, 11 Dec 2011 07:35:16 +0000 (08:35 +0100)]
SVN_SILENT made messages (.desktop file)

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Fri, 9 Dec 2011 08:10:10 +0000 (09:10 +0100)]
SVN_SILENT made messages (.desktop file)

6 years agoReset donators list and add Rocktober donators.
Bart Cerneels [Thu, 8 Dec 2011 10:42:10 +0000 (11:42 +0100)]
Reset donators list and add Rocktober donators.

As promised in the Rocktober announcement, we reset the donors least yearly
so the Rocktober donators are the first in that list each year.

TODO: add donation info to the top of that about dialog tab.

6 years agoVisual changes to bottom toolbars.
Bart Cerneels [Fri, 25 Nov 2011 16:34:47 +0000 (17:34 +0100)]
Visual changes to bottom toolbars.

Changes:
- Align the dockwindow toolbars in all situations.
- Make all bottom toolbars 36 px high.
- Refactor MessageArea.
- Put a border around the bottom toolbars. Using QPalette::Shadow for border color.

BUG:277741
FIXED-IN:2.5

6 years agoLess code duplication in PaletteHandler.
Bart Cerneels [Fri, 2 Dec 2011 07:48:27 +0000 (08:48 +0100)]
Less code duplication in PaletteHandler.

6 years agoGet rid of some qDebug().
Bart Cerneels [Thu, 1 Dec 2011 10:56:18 +0000 (11:56 +0100)]
Get rid of some qDebug().

Using qDebug from amarok is not allowed. Breaks --debug and coloring.

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Thu, 8 Dec 2011 08:01:25 +0000 (09:01 +0100)]
SVN_SILENT made messages (.desktop file)

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Wed, 7 Dec 2011 08:19:40 +0000 (09:19 +0100)]
SVN_SILENT made messages (.desktop file)

6 years agoUpdated README to include correct libmygpo-qt version
Stefan Derkits [Tue, 6 Dec 2011 14:29:49 +0000 (15:29 +0100)]
Updated README to include correct libmygpo-qt version

6 years agoMake sure url is encoded when converting wikipedia click urls
Rick W. Chen [Tue, 6 Dec 2011 08:27:15 +0000 (21:27 +1300)]
Make sure url is encoded when converting wikipedia click urls

CCBUG: 268476

6 years agoScanResultProcessor: allow albums with empty name but nonempty artist
Matěj Laitl [Mon, 5 Dec 2011 22:58:39 +0000 (23:58 +0100)]
ScanResultProcessor: allow albums with empty name but nonempty artist

This fixes bug 272471, hope it doesn't break anything else. It was an
easy fix, I wonder no-one went for it sooner.

BUG: 272471
FIXED-IN: 2.5

6 years agoFix completely bogus MediaDeviceHandler::removeMediaDeviceTrackFromColl
Matěj Laitl [Sun, 4 Dec 2011 22:17:50 +0000 (23:17 +0100)]
Fix completely bogus MediaDeviceHandler::removeMediaDeviceTrackFromColl

That method did not work _at all_ because it used wrong key in the
trackMap forgot to actually write back other maps. :-)

As a result, dead tracks were never removed from memory collection and
thus the count was not updated, among other (worse) things.

BUG: 232093
FIXED-IN: 2.5
DIGEST: Capacity gauge is now always updated for iPods & MTP devices

6 years agoMediaDeviceCollection: do not cache used capacity w/out update mechanism
Matěj Laitl [Sun, 4 Dec 2011 22:00:38 +0000 (23:00 +0100)]
MediaDeviceCollection: do not cache used capacity w/out update mechanism

Relevant media device handler should do this caching, and even without
it, the calls aren't that expensive. Solves first part of bug 232093,
second part (that deals with track count) will follow shortly.

CCBUG: 232093

6 years agomedia device collection: normalize SIGNAL & SLOT macros
Matěj Laitl [Sun, 4 Dec 2011 20:41:38 +0000 (21:41 +0100)]
media device collection: normalize SIGNAL & SLOT macros

...to avoid invalid connection.

6 years agoFix crash at exit with Qt 4.8
Ralf Engels [Sun, 4 Dec 2011 17:38:37 +0000 (18:38 +0100)]
Fix crash at exit with Qt 4.8

BUG: 285951
FIXED-IN: 2.5

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sat, 3 Dec 2011 08:29:57 +0000 (09:29 +0100)]
SVN_SILENT made messages (.desktop file)

6 years agoAmazon store: More intelligent searching for album of a track
Sven Krohlas [Fri, 2 Dec 2011 14:44:43 +0000 (15:44 +0100)]
Amazon store: More intelligent searching for album of a track

If it's a compilation: don't add the artist name to the search string.

6 years agoSet compilation status for albums
Sven Krohlas [Fri, 2 Dec 2011 14:33:11 +0000 (15:33 +0100)]
Set compilation status for albums

The API is soon going to support this.

6 years agoForgot to make parameters const
Sven Krohlas [Fri, 2 Dec 2011 10:29:58 +0000 (11:29 +0100)]
Forgot to make parameters const

6 years agoAmazon parser optimizations: pass QStrings as references
Sven Krohlas [Fri, 2 Dec 2011 10:13:26 +0000 (11:13 +0100)]
Amazon parser optimizations: pass QStrings as references

6 years agoSmall Amazon parser optimizations
Sven Krohlas [Fri, 2 Dec 2011 08:38:36 +0000 (09:38 +0100)]
Small Amazon parser optimizations

6 years agolastfm: load friend/neighbour avatars on demand
Rick W. Chen [Fri, 2 Dec 2011 02:43:02 +0000 (15:43 +1300)]
lastfm: load friend/neighbour avatars on demand

Otherwise all your friends' and neighbours' avatars are downloaded every
time when starting amarok (cached and whatnot). May not be much of an
issue depending on how popular you are.

6 years agoUpdate tracks recently played widget only when needed
Rick W. Chen [Fri, 2 Dec 2011 00:12:26 +0000 (13:12 +1300)]
Update tracks recently played widget only when needed

 * if resuming playback on start the widget does not update
 * only update when stopped

6 years agoFix moving applets rightward in the context toolbar
Rick W. Chen [Tue, 29 Nov 2011 10:32:23 +0000 (23:32 +1300)]
Fix moving applets rightward in the context toolbar

6 years agoFix breadcrumbs not working for the file browser
Rick W. Chen [Mon, 7 Nov 2011 04:02:15 +0000 (17:02 +1300)]
Fix breadcrumbs not working for the file browser

The file browser updates the breadcrumbs depending on the current path.
When that happens the active category doesn't change, so setActiveCategory
needs to allow that possibility.

6 years agoShow cover for all tracks from the Amazon store in the playlist
Sven Krohlas [Thu, 1 Dec 2011 15:12:55 +0000 (16:12 +0100)]
Show cover for all tracks from the Amazon store in the playlist

The API is soon going to support this, this makes use of that change.

6 years agoServiceAlbumCoverDownloader: delete automatically when done
Rick W. Chen [Wed, 30 Nov 2011 03:55:14 +0000 (16:55 +1300)]
ServiceAlbumCoverDownloader: delete automatically when done

6 years agoMinor improvements/style fix
Rick W. Chen [Wed, 30 Nov 2011 03:45:10 +0000 (16:45 +1300)]
Minor improvements/style fix

6 years agoDisable cover fetching action for tracks not in the collection
Rick W. Chen [Thu, 1 Dec 2011 02:27:48 +0000 (15:27 +1300)]
Disable cover fetching action for tracks not in the collection

BUG: 287604
FIXED-IN: 2.5

6 years agoTagDialog: draw album cover with border
Rick W. Chen [Thu, 1 Dec 2011 00:48:28 +0000 (13:48 +1300)]
TagDialog: draw album cover with border

This also shows the "nocover" for tracks that are not in the collection,
which provided the null image.

6 years agoTagDialog: make sure krun opens at the right directory
Rick W. Chen [Wed, 30 Nov 2011 12:22:10 +0000 (01:22 +1300)]
TagDialog: make sure krun opens at the right directory

If the tag dialog is invoked with an album (as opposed to a track). The
path to open for krun should be the directory where the album's tracks are
located, instead of the parent directory.

6 years agoInfoParser: emit html qstring as const&
Rick W. Chen [Wed, 30 Nov 2011 04:49:45 +0000 (17:49 +1300)]
InfoParser: emit html qstring as const&

6 years agoInfoParser: don't dump entire html to debug
Rick W. Chen [Wed, 30 Nov 2011 04:49:02 +0000 (17:49 +1300)]
InfoParser: don't dump entire html to debug

6 years agoSvgHandler: use url() for image location key instead of path()
Rick W. Chen [Wed, 30 Nov 2011 03:35:24 +0000 (16:35 +1300)]
SvgHandler: use url() for image location key instead of path()

For albums from services the image location is a remote url. path() will
return something bogus. Usually a trimmed version of the actual url. That
can cause all the displayed covers (with border) from that service the same
as the one fetched first.

6 years agoFix service albums cover not being set after successful download
Rick W. Chen [Wed, 30 Nov 2011 01:25:41 +0000 (14:25 +1300)]
Fix service albums cover not being set after successful download

Weak qobject pointers cannot be promoted to qsharedpointer. So in
coverDownloadComplete() the downloaded cover is never used. Just use
ServiceAlbumWithCoverPtr which is available.

6 years agoFix crash in CoverFoundDialog if progress dialog is cancelled just before fetch is...
Rick W. Chen [Tue, 29 Nov 2011 15:21:12 +0000 (04:21 +1300)]
Fix crash in CoverFoundDialog if progress dialog is cancelled just before fetch is done

6 years agolyrics: remove unnecessary setCollapseOn on init
Rick W. Chen [Tue, 29 Nov 2011 14:48:45 +0000 (03:48 +1300)]
lyrics: remove unnecessary setCollapseOn on init

collapse state is set anyway later on when updated by the data engine

6 years agoRemove unused signal
Rick W. Chen [Tue, 29 Nov 2011 10:32:35 +0000 (23:32 +1300)]
Remove unused signal

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Wed, 30 Nov 2011 09:05:39 +0000 (10:05 +0100)]
SVN_SILENT made messages (.desktop file)

6 years agoWikipedia applet: regexp for German disambiguation pages
Sven Krohlas [Tue, 29 Nov 2011 15:45:41 +0000 (16:45 +0100)]
Wikipedia applet: regexp for German disambiguation pages

Why was that missing? That's one of our largest user bases...

Also, many, many more languages need to be added there.

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Tue, 29 Nov 2011 15:45:11 +0000 (16:45 +0100)]
SVN_SILENT made messages (.desktop file)

6 years agoCorrectly parse disambiguation pages for songs in the English Wikipedia
Sven Krohlas [Tue, 29 Nov 2011 15:12:16 +0000 (16:12 +0100)]
Correctly parse disambiguation pages for songs in the English Wikipedia

The regexp looks wrong, I gues it didn't work at all before...

BUG:270054
FIXED-IN:2.5.0

6 years agoUse en enum instead of hardcoded integer values in AmazonSettingsModule
Sven Krohlas [Tue, 29 Nov 2011 09:12:42 +0000 (10:12 +0100)]
Use en enum instead of hardcoded integer values in AmazonSettingsModule

As requested by Bart.

6 years agodocumentation++
Sven Krohlas [Mon, 28 Nov 2011 21:19:56 +0000 (22:19 +0100)]
documentation++

6 years agoAllow editing the SearchWidget during a search animation
Sven Krohlas [Mon, 28 Nov 2011 20:53:26 +0000 (21:53 +0100)]
Allow editing the SearchWidget during a search animation

This can be tested in the Amazon store. Before any changes during a
search were lost with every animation update. This sucked.
Now the search animation feature works pretty well imho.

6 years agoAmazonItemTreeModel refactoring
Sven Krohlas [Mon, 28 Nov 2011 14:43:25 +0000 (15:43 +0100)]
AmazonItemTreeModel refactoring

Hide more internals by offering a more convenient interface to get
item IDs:

  int idForIndex( const QModelIndex &index ) const;

use it wherever possible. Now the code is way easier to read and maintain.
This is the base for major model changes in Amarok 2.6.

6 years agoFix applets sometimes get the wrong size on starting up
Rick W. Chen [Mon, 28 Nov 2011 09:03:32 +0000 (22:03 +1300)]
Fix applets sometimes get the wrong size on starting up

On starting up applets may request collapsing/expanding before the
context view is finished constructing. That causes the applets not reach
their desired final size. This Fixes that by setting the size directly.

6 years agoFix infinite loop in context view eating CPU until main window is shown
Matěj Laitl [Sun, 27 Nov 2011 14:24:55 +0000 (15:24 +0100)]
Fix infinite loop in context view eating CPU until main window is shown

We used to use _scene_ sceneRect in
VerticalToolbarContainment::updateGeometry() to update applets and
geometry, but that leaded to infinite loop (across mainloop) -
m_applets->setGeometry(), refresh() would enlarge _scene_ sceneRect by
a few pixels which would trigger updateGeometry() and so on...

We now use _view_ sceneRect to update geometry. Rick W. Chen discovered
some glitches in applet collapsing when this patch is applied, but he
has a patch for that in the works and this is more serious problem, so
pushing this.

REVIEW: 103271
BUG: 278897
FIXED-IN: 2.5

6 years agoFix last.fm scrobble composer fallback to artist
Sam Lade [Mon, 28 Nov 2011 02:40:13 +0000 (02:40 +0000)]
Fix last.fm scrobble composer fallback to artist

Now correctly scrobbles with the artist name if the composer field is empty and
the scrobble composer option is enabled, rather than silently failing.

Patch by Ilya Kasnacheev.

BUG:286215
FIXED-IN:2.5
REVIEW:103279

6 years agoNow It's possible to use formated strings for prefix and suffix in Playlist's layout...
Sergey Ivanov [Sun, 27 Nov 2011 04:56:13 +0000 (08:56 +0400)]
Now It's possible to use formated strings for prefix and suffix in Playlist's layout items.

6 years agoSmiley.
Yuri Chornoivan [Sat, 26 Nov 2011 18:08:11 +0000 (20:08 +0200)]
Smiley.

6 years agoMore fixes + smiley.
Yuri Chornoivan [Sat, 26 Nov 2011 18:07:27 +0000 (20:07 +0200)]
More fixes + smiley.

6 years agoUse QLatin1String instead of QString where appropriate
Sven Krohlas [Sat, 26 Nov 2011 09:03:35 +0000 (10:03 +0100)]
Use QLatin1String instead of QString where appropriate

Small optimizations are better than no optimizations. ;-)

6 years agofixed windows build
Patrick von Reth [Fri, 25 Nov 2011 23:31:37 +0000 (00:31 +0100)]
fixed windows build

6 years agoAllow selecting no country in the Amazon store
Sven Krohlas [Fri, 25 Nov 2011 23:25:45 +0000 (00:25 +0100)]
Allow selecting no country in the Amazon store

This makes the service stop popping up on startup, asking for the
users location. That issue has been reported several times since
our beta release, so adding two more strings late is hopefully
justified.

CCMAIL:kde-i18n-doc@kde.org

6 years agoGive the Amazon store navigation the same design as in the file browser
Sven Krohlas [Fri, 25 Nov 2011 22:54:45 +0000 (23:54 +0100)]
Give the Amazon store navigation the same design as in the file browser

consistency++;

6 years agosome cleanups for Amazon store navigation
Sven Krohlas [Fri, 25 Nov 2011 22:18:15 +0000 (23:18 +0100)]
some cleanups for Amazon store navigation

Btw, all strings have been recycled from the file browser.

6 years agoAllow going back and forward in Amazon store.
Sven Krohlas [Fri, 25 Nov 2011 21:26:37 +0000 (22:26 +0100)]
Allow going back and forward in Amazon store.

Thanks to Google Code In student Nikola Miljkovic.

A patch with some cleanups from me follows shortly.

6 years agoFix volume control not working.
Bart Cerneels [Fri, 25 Nov 2011 14:17:57 +0000 (15:17 +0100)]
Fix volume control not working.

QA fail: should have been spotted in review and integration testing.

CCMAIL:amarok-devel@kde.org

6 years agoChangelogify bugfix.
Bart Cerneels [Fri, 25 Nov 2011 12:50:49 +0000 (13:50 +0100)]
Changelogify bugfix.

6 years agoFix playlist import bug because of one stupid char
Bart Cerneels [Fri, 25 Nov 2011 10:53:28 +0000 (11:53 +0100)]
Fix playlist import bug because of one stupid char

BUG:284761

6 years agoFix some outstanding issues in docs.
Yuri Chornoivan [Thu, 24 Nov 2011 13:34:58 +0000 (15:34 +0200)]
Fix some outstanding issues in docs.

6 years agoclean up & header sorting in Gpodder & PlaylistSync
Stefan Derkits [Thu, 24 Nov 2011 10:46:43 +0000 (11:46 +0100)]
clean up & header sorting in Gpodder & PlaylistSync

REVIEW: 103195

6 years agoSend a real reply message and don't crash.
Andras Mantia [Wed, 23 Nov 2011 20:31:41 +0000 (22:31 +0200)]
Send a real reply message and don't crash.

REVIEW: 103213

6 years agoUse non-blocking load for playlist files.
Bart Cerneels [Wed, 23 Nov 2011 12:53:14 +0000 (13:53 +0100)]
Use non-blocking load for playlist files.

CCBUG:284761

UI is still quite unresponsive with a lot of playlists on slow mounts
(like NFS).

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Mon, 21 Nov 2011 08:57:56 +0000 (09:57 +0100)]
SVN_SILENT made messages (.desktop file)

6 years agoAdd missing changelog message
Ralf Engels [Sun, 20 Nov 2011 15:25:39 +0000 (16:25 +0100)]
Add missing changelog message

6 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sun, 20 Nov 2011 08:01:35 +0000 (09:01 +0100)]
SVN_SILENT made messages (.desktop file)

6 years agoUse entities (fixed in script).
Yuri Chornoivan [Sat, 19 Nov 2011 17:51:59 +0000 (19:51 +0200)]
Use entities (fixed in script).

6 years agoAdd missing ChangeLog entry concerning the removal of fretplay.com within the tabs...
Rainer Sigle [Sat, 19 Nov 2011 12:20:10 +0000 (13:20 +0100)]
Add missing ChangeLog entry concerning the removal of fretplay.com within the tabs applet.

6 years agoTurn back keyboard tracking for TagDialog's spinBoxes. Seems like problem with
Sergey Ivanov [Fri, 18 Nov 2011 18:30:04 +0000 (22:30 +0400)]
Turn back keyboard tracking for TagDialog's spinBoxes. Seems like problem with
messed digit was resolved by Qt devs.
BUG: 286906
FIXED-IN: 2.5

6 years agoFix typos on UserBase and in DocBook
Yuri Chornoivan [Fri, 18 Nov 2011 18:00:16 +0000 (20:00 +0200)]
Fix typos on UserBase and in DocBook

6 years agoFix audio CD detection on Amarok start
Sam Lade [Fri, 18 Nov 2011 14:04:50 +0000 (14:04 +0000)]
Fix audio CD detection on Amarok start

Get a list of optical discs, rather than looking for optical discs in
StorageAccess devices.
This does not fix other audio CD issues such as "play audio CD with Amarok" not
working.

Patch by Luc Menut.

BUG:276032
CCBUG:266412
REVIEW:102580

6 years agoAdd ChangeLog entry for fixed bug 279813
Kevin Funk [Fri, 18 Nov 2011 10:38:37 +0000 (11:38 +0100)]
Add ChangeLog entry for fixed bug 279813

6 years agoChangeLog++
Sven Krohlas [Fri, 18 Nov 2011 10:35:24 +0000 (11:35 +0100)]
ChangeLog++

as requested

6 years agoChangeLog for 46704872bffb066d94d
Matěj Laitl [Fri, 18 Nov 2011 10:20:08 +0000 (11:20 +0100)]
ChangeLog for 46704872bffb066d94d

Yes, this really belongs to 2.5 beta 1.

CCMAIL: myriam@kde.org

6 years agoFix filename scheme problems for UMS.
Bart Cerneels [Fri, 18 Nov 2011 10:03:02 +0000 (11:03 +0100)]
Fix filename scheme problems for UMS.

BUG:285900

6 years agoChangeLog 2.5.0-Beta 1: Re-added old "Normal" moodbar theme.
Florian Eßer [Fri, 18 Nov 2011 08:52:33 +0000 (09:52 +0100)]
ChangeLog 2.5.0-Beta 1: Re-added old "Normal" moodbar theme.

CCMAIL: myriam@kde.org

6 years agoRemove some useless and spammy debug.
Bart Cerneels [Thu, 17 Nov 2011 09:53:53 +0000 (10:53 +0100)]
Remove some useless and spammy  debug.