amarok:history.git
8 years agoSave dynamic playlist weight values correctly with both "," and "." as
Dan Meltzer [Sat, 14 Feb 2009 16:06:41 +0000 (16:06 -0000)]
Save dynamic playlist weight values correctly with both "," and "." as
decimal separator.

Big thanks for the patch go to Georg Hennig <georg298@gmx.de>.

BUG: 184304

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=926058

8 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Wed, 11 Feb 2009 08:24:50 +0000 (08:24 -0000)]
SVN_SILENT made messages (.desktop file)

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=924607

8 years agoDon't crash if a script has uncaught exceptions.
Dan Meltzer [Tue, 10 Feb 2009 13:40:39 +0000 (13:40 -0000)]
Don't crash if a script has uncaught exceptions.

Backport r920386

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=924274

8 years agoFix i18n.
Dan Meltzer [Sun, 8 Feb 2009 21:57:59 +0000 (21:57 -0000)]
Fix i18n.

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=923529

8 years agoBackport r912280
Dan Meltzer [Sun, 8 Feb 2009 00:54:13 +0000 (00:54 -0000)]
Backport r912280

Display an error message when wikipedia info couldn't be retrieved

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=923011

8 years agoBackport r911001
Dan Meltzer [Sun, 8 Feb 2009 00:54:02 +0000 (00:54 -0000)]
Backport r911001

Fix crash on exit when collection scan has been aborted.

Crash was caused by dangling pointer. QPointer to the rescue.

BUG: 176870

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=923010

8 years agoBackport revision 908639, Add ogg mimetypes to desktop file
Dan Meltzer [Sun, 8 Feb 2009 00:53:52 +0000 (00:53 -0000)]
Backport revision 908639, Add ogg mimetypes to desktop file
BUG: 180155

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=923009

8 years agoBackport r909077, Fix possible crash in Amarok::decpaitateString()
Dan Meltzer [Sun, 8 Feb 2009 00:53:36 +0000 (00:53 -0000)]
Backport r909077, Fix possible crash in Amarok::decpaitateString()

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=923008

8 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sat, 7 Feb 2009 08:51:04 +0000 (08:51 -0000)]
SVN_SILENT made messages (.desktop file)

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=922562

8 years agoFix parsing of pubdate since it caused episodes to be ordered incorrectly.
Bart Cerneels [Thu, 5 Feb 2009 22:49:08 +0000 (22:49 -0000)]
Fix parsing of pubdate since it caused episodes to be ordered incorrectly.

BUG:181338

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=921917

8 years agoAdd last commit to changelog..
Dan Meltzer [Thu, 5 Feb 2009 15:01:51 +0000 (15:01 -0000)]
Add last commit to changelog..

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=921730

8 years agoShow a statusbar message when loving a track. There was no visual feedback previousl...
Dan Meltzer [Thu, 5 Feb 2009 14:58:38 +0000 (14:58 -0000)]
Show a statusbar message when loving a track.  There was no visual feedback previously, and I found myself guessing most of the time.

backport of 921447

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=921729

8 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Thu, 5 Feb 2009 08:40:49 +0000 (08:40 -0000)]
SVN_SILENT made messages (.desktop file)

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=921568

8 years agoFix null-pointer access in tagdialog if a track did not have an artist.
Dan Meltzer [Wed, 4 Feb 2009 13:53:57 +0000 (13:53 -0000)]
Fix null-pointer access in tagdialog if a track did not have an artist.

BUG: 183180

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=921078

8 years agoBackport r919847
Dan Meltzer [Sun, 1 Feb 2009 20:56:42 +0000 (20:56 -0000)]
Backport r919847

Fix statistics calculations
BUG: 182025

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=919914

8 years agoUpdate the stable changelog too.
Casey Link [Fri, 23 Jan 2009 01:05:59 +0000 (01:05 -0000)]
Update the stable changelog too.

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=915432

8 years agoCommit patches submitted by Adriaan de Groot <groot@kde.org>. Fixes compilation issue...
Casey Link [Fri, 23 Jan 2009 01:04:25 +0000 (01:04 -0000)]
Commit patches submitted by Adriaan de Groot <groot@kde.org>. Fixes compilation issues on OpenSolaris.

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=915430

8 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Thu, 22 Jan 2009 07:54:37 +0000 (07:54 -0000)]
SVN_SILENT made messages (.desktop file)

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=914948

8 years agoTrim URL before adding a new podcast.
Bart Cerneels [Wed, 21 Jan 2009 20:45:22 +0000 (20:45 -0000)]
Trim URL before adding a new podcast.

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=914821

8 years agoAdd Ok button to the podcast config.
Bart Cerneels [Mon, 19 Jan 2009 21:49:26 +0000 (21:49 -0000)]
Add Ok button to the podcast config.

BUG:181339

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=913805

8 years agoChangelog--++
Gary David Steinert [Sat, 17 Jan 2009 18:53:05 +0000 (18:53 -0000)]
Changelog--++

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=912592

8 years agoBackport of svn commit 912571
Gary David Steinert [Sat, 17 Jan 2009 18:43:27 +0000 (18:43 -0000)]
Backport of svn commit 912571

Add tooltips to the icons in the now playing applet (score, number of plays, last played)
Pretty hacky, but I believe the applets are being looked at in the near future anyway.

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=912588

8 years agoFix previous commit that fixed BR 180851.
Bart Cerneels [Sat, 17 Jan 2009 17:07:18 +0000 (17:07 -0000)]
Fix previous commit that fixed BR 180851.

It introduced race conditions by reloading the podcast channels to early. The end result was duplication of channels.

CCBUG:180851

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=912533

8 years agoSimple fix for BR 180851.
Bart Cerneels [Sat, 17 Jan 2009 09:30:37 +0000 (09:30 -0000)]
Simple fix for BR 180851.

Reload all podcasts once the PodcastReader has finished.

Will get a proper (tm) sollution in 2.1.

BUG:180851

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=912298

8 years agoBackport 911270.
Bart Cerneels [Sat, 17 Jan 2009 09:26:14 +0000 (09:26 -0000)]
Backport 911270.
fix build _and_ keep the collection working!

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=912295

8 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Tue, 13 Jan 2009 07:08:07 +0000 (07:08 -0000)]
SVN_SILENT made messages (.desktop file)

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=910342

8 years agoBackport r909049: get the right number of QString.arg()s for the number placeholders.
Alex Merry [Sun, 11 Jan 2009 00:25:15 +0000 (00:25 -0000)]
Backport r909049: get the right number of QString.arg()s for the number placeholders.

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=909106

8 years agoFix typo
Thomas Reitelbach [Sat, 10 Jan 2009 14:05:55 +0000 (14:05 -0000)]
Fix typo

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=908788

8 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sat, 10 Jan 2009 08:34:43 +0000 (08:34 -0000)]
SVN_SILENT made messages (.desktop file)

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=908693

8 years agoadd r908401
Martin Aumüller [Fri, 9 Jan 2009 17:51:00 +0000 (17:51 -0000)]
add r908401

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=908420

8 years agomerge r908391 from trunk: avoid excessive and short memory allocations, check for...
Martin Aumüller [Fri, 9 Jan 2009 17:10:43 +0000 (17:10 -0000)]
merge r908391 from trunk: avoid excessive and short memory allocations, check for allocation
failures

svn path=/branches/stable/extragear-kde4/multimedia/amarok/; revision=908401

8 years agoSVN_SILENT made messages (.desktop file, second try)
Script Kiddy [Tue, 6 Jan 2009 12:55:38 +0000 (12:55 -0000)]
SVN_SILENT made messages (.desktop file, second try)

svn path=/trunk/extragear/multimedia/amarok/; revision=906597

8 years agobump plugin versions for 2.0.1
Lydia Pintscher [Tue, 6 Jan 2009 12:46:03 +0000 (12:46 -0000)]
bump plugin versions for 2.0.1

svn path=/trunk/extragear/multimedia/amarok/; revision=906573

8 years agodebug++
Alejandro Daniel Wainzinger [Mon, 5 Jan 2009 23:57:33 +0000 (23:57 -0000)]
debug++

svn path=/trunk/extragear/multimedia/amarok/; revision=906344

8 years ago* show date of next radio show/end of voting
Sven Krohlas [Mon, 5 Jan 2009 22:10:37 +0000 (22:10 -0000)]
* show date of next radio show/end of voting
* cleanup
* fix service info for tracks

svn path=/trunk/extragear/multimedia/amarok/; revision=906304

8 years agounb0rk
Lydia Pintscher [Mon, 5 Jan 2009 19:42:25 +0000 (19:42 -0000)]
unb0rk

svn path=/trunk/extragear/multimedia/amarok/; revision=906239

8 years agoFix building for Qt 4.5. Thanks to Alex Merry for pointing out QTVERSION.
Ian Monroe [Mon, 5 Jan 2009 19:27:08 +0000 (19:27 -0000)]
Fix building for Qt 4.5. Thanks to Alex Merry for pointing out QTVERSION.
BUG: 177863

svn path=/trunk/extragear/multimedia/amarok/; revision=906213

8 years agomore cleaning up
Lydia Pintscher [Mon, 5 Jan 2009 19:17:07 +0000 (19:17 -0000)]
more cleaning up

svn path=/trunk/extragear/multimedia/amarok/; revision=906208

8 years agoclean up
Lydia Pintscher [Mon, 5 Jan 2009 19:09:10 +0000 (19:09 -0000)]
clean up

svn path=/trunk/extragear/multimedia/amarok/; revision=906198

8 years agoChangeLog++
Ian Monroe [Mon, 5 Jan 2009 17:49:58 +0000 (17:49 -0000)]
ChangeLog++

svn path=/trunk/extragear/multimedia/amarok/; revision=906167

8 years agoMake qtscript_network build and link with qt 4.4
Sven Krohlas [Mon, 5 Jan 2009 17:40:43 +0000 (17:40 -0000)]
Make qtscript_network build and link with qt 4.4

svn path=/trunk/extragear/multimedia/amarok/; revision=906165

8 years agopossible fix for sven423
Ian Monroe [Mon, 5 Jan 2009 17:06:32 +0000 (17:06 -0000)]
possible fix for sven423

svn path=/trunk/extragear/multimedia/amarok/; revision=906149

8 years agoMake libqtscript_gui.so link again with qt 4.4
Sven Krohlas [Mon, 5 Jan 2009 16:39:47 +0000 (16:39 -0000)]
Make libqtscript_gui.so link again with qt 4.4

svn path=/trunk/extragear/multimedia/amarok/; revision=906141

8 years agocmake fix for mikkoc
Ian Monroe [Mon, 5 Jan 2009 16:20:19 +0000 (16:20 -0000)]
cmake fix for mikkoc

svn path=/trunk/extragear/multimedia/amarok/; revision=906135

8 years agomore qt 4.4 fixes
Ian Monroe [Mon, 5 Jan 2009 14:55:28 +0000 (14:55 -0000)]
more qt 4.4 fixes

svn path=/trunk/extragear/multimedia/amarok/; revision=906109

8 years agoanother fix for qt 4.4 (would be really helpful if someone
Ian Monroe [Mon, 5 Jan 2009 14:49:04 +0000 (14:49 -0000)]
another fix for qt 4.4 (would be really helpful if someone
with qt 4.4 could do this)

svn path=/trunk/extragear/multimedia/amarok/; revision=906103

8 years agoan attempt at a fix for qt 4.4
Ian Monroe [Mon, 5 Jan 2009 14:36:04 +0000 (14:36 -0000)]
an attempt at a fix for qt 4.4

svn path=/trunk/extragear/multimedia/amarok/; revision=906095

8 years agoRevert the reversion
Ian Monroe [Mon, 5 Jan 2009 14:35:12 +0000 (14:35 -0000)]
Revert the reversion

svn path=/trunk/extragear/multimedia/amarok/; revision=906094

8 years agoNew queue track icons thanks to Lee Olson. We'll need to work on these
Seb Ruiz [Mon, 5 Jan 2009 10:08:13 +0000 (10:08 -0000)]
New queue track icons thanks to Lee Olson. We'll need to work on these
icons so they don't look so similar to append track (see pud).

svn path=/trunk/extragear/multimedia/amarok/; revision=905865

8 years agoI like const correctness.
Mark Kretschmann [Mon, 5 Jan 2009 09:33:51 +0000 (09:33 -0000)]
I like const correctness.

svn path=/trunk/extragear/multimedia/amarok/; revision=905847

8 years agoDisable spammy debug output during collection scanning.
Mark Kretschmann [Mon, 5 Jan 2009 09:33:43 +0000 (09:33 -0000)]
Disable spammy debug output during collection scanning.

svn path=/trunk/extragear/multimedia/amarok/; revision=905846

8 years agoRevert "wasn't able to figure out how to get something to conditionally"
Mark Kretschmann [Mon, 5 Jan 2009 06:37:22 +0000 (06:37 -0000)]
Revert "wasn't able to figure out how to get something to conditionally"
Revert "This is commiting the latest Qt Script Generator. This should fix things for"

Sorry, trunk still doesn't build with Qt 4.4, so I'm reverting both of
Ian's commits for now.

svn path=/trunk/extragear/multimedia/amarok/; revision=905810

8 years agowasn't able to figure out how to get something to conditionally
Ian Monroe [Mon, 5 Jan 2009 00:16:46 +0000 (00:16 -0000)]
wasn't able to figure out how to get something to conditionally
compile for Qt 4.5 only, see qtscript_network.cmake

So I seperated out what I think are all the Qt 4.5 files into seperate
variables. They aren't being compiled so Qt 4.5 isn't going to work,
which is the way it was before. But it should just take someone
with some cmake know-how to easily fix.

Hopefully Qt 4.4 users can compile now again.

svn path=/trunk/extragear/multimedia/amarok/; revision=905754

8 years agoFix GDK_FOUND definition -- the old one would result in
Bernhard Rosenkraenzer [Sun, 4 Jan 2009 23:10:25 +0000 (23:10 -0000)]
Fix GDK_FOUND definition -- the old one would result in
#define GDK_FOUND
if GDK was not found, causing false positives for #ifdef GDK_FOUND.

If GDK is found, the result remains the same.

svn path=/trunk/extragear/multimedia/amarok/; revision=905736

8 years agoFix
Bernhard Rosenkraenzer [Sun, 4 Jan 2009 22:59:47 +0000 (22:59 -0000)]
Fix

/usr/src/ark/BUILD/amarok/src/collection/ipodcollection/handler/IpodHandler.cpp:31:14: error: #if with no expression
/usr/src/ark/BUILD/amarok/src/collection/ipodcollection/handler/IpodHandler.cpp:1331:14: error: #if with no expression
/usr/src/ark/BUILD/amarok/src/collection/ipodcollection/handler/IpodHandler.cpp:1606:22: error: #if with no expression

when building with a fairly current gcc and without gdk support

svn path=/trunk/extragear/multimedia/amarok/; revision=905732

8 years agoFix
Bernhard Rosenkraenzer [Sun, 4 Jan 2009 22:58:16 +0000 (22:58 -0000)]
Fix

In file included from amarok/src/collection/ipodcollection/IpodCollection.h:30,
                 from amarok/src/collection/ipodcollection/IpodMeta.cpp:24:
amarok/src/collection/ipodcollection/handler/IpodHandler.h:166:25: error: #if with no expression

when building with a fairly current gcc and without gdk support

svn path=/trunk/extragear/multimedia/amarok/; revision=905731

8 years agoThis is commiting the latest Qt Script Generator. This should fix things for
Ian Monroe [Sun, 4 Jan 2009 20:44:36 +0000 (20:44 -0000)]
This is commiting the latest Qt Script Generator. This should fix things for
Qt 4.5, at least it does for me. I'm using a recent snaptshot, I didn't have
the problems reported by Jason and Leo.

I'm worried it might break compliation on Qt 4.4. Markey has promised to test
post-commit.

Jason Donenfeld gets credit for most of the cmake changes.

BUG: 177863

svn path=/trunk/extragear/multimedia/amarok/; revision=905679

8 years agocrash--
Sven Krohlas [Sun, 4 Jan 2009 16:40:03 +0000 (16:40 -0000)]
crash--
Setting the correct album name is a good idea.

svn path=/trunk/extragear/multimedia/amarok/; revision=905566

8 years agoUse new API to show custom service icon, cover and emblem.
Sven Krohlas [Sun, 4 Jan 2009 16:28:44 +0000 (16:28 -0000)]
Use new API to show custom service icon, cover and emblem.

*Icons still need some love
*Dragging a whole Album makes Amarok crash, single/multiple tracks work fine

svn path=/trunk/extragear/multimedia/amarok/; revision=905561

8 years agotypo--
Mark Kretschmann [Sun, 4 Jan 2009 15:35:29 +0000 (15:35 -0000)]
typo--

svn path=/trunk/extragear/multimedia/amarok/; revision=905546

8 years agoFix spurious space character in File_p.h which prevented the display of changed
Mark Kretschmann [Sun, 4 Jan 2009 15:10:55 +0000 (15:10 -0000)]
Fix spurious space character in File_p.h which prevented the display of changed
"composer" tag for flac files.

Thanks again to Michael Seiwert.

svn path=/trunk/extragear/multimedia/amarok/; revision=905533

8 years agoRegression fix: Make the URL navigator widget on top of the Files
Mark Kretschmann [Sun, 4 Jan 2009 12:13:31 +0000 (12:13 -0000)]
Regression fix: Make the URL navigator widget on top of the Files
browser work again.

Thanks Mikko.

svn path=/trunk/extragear/multimedia/amarok/; revision=905380

8 years agoAllow setting the "discnumber" and "composer" tags for local files.
Mark Kretschmann [Sun, 4 Jan 2009 11:28:32 +0000 (11:28 -0000)]
Allow setting the "discnumber" and "composer" tags for local files.

Thanks for the patch go to Michael Seiwert <seiwert@kde.org>.

CCBUG: 174984

svn path=/trunk/extragear/multimedia/amarok/; revision=905370

8 years agoUse more meaningful method name.
Mark Kretschmann [Sun, 4 Jan 2009 09:17:41 +0000 (09:17 -0000)]
Use more meaningful method name.

svn path=/trunk/extragear/multimedia/amarok/; revision=905327

8 years agoRemove dead code.
Mark Kretschmann [Sun, 4 Jan 2009 09:17:38 +0000 (09:17 -0000)]
Remove dead code.

svn path=/trunk/extragear/multimedia/amarok/; revision=905326

8 years agoReplace cryptic member name "m_btnFilter" with "m_filterButton".
Mark Kretschmann [Sun, 4 Jan 2009 09:17:35 +0000 (09:17 -0000)]
Replace cryptic member name "m_btnFilter" with "m_filterButton".

svn path=/trunk/extragear/multimedia/amarok/; revision=905325

8 years agoIn the Files browser, do _not_ save/restore the contents of the filter
Mark Kretschmann [Sun, 4 Jan 2009 08:45:39 +0000 (08:45 -0000)]
In the Files browser, do _not_ save/restore the contents of the filter
any more.

First of all remembering the filter content is inconsistent (we don't do
this in other browsers), and second it can be confusing if the user only
sees a part of his files on startup.

svn path=/trunk/extragear/multimedia/amarok/; revision=905320

8 years agoMake the Files browser correctly restore its view settings, i.e.
Mark Kretschmann [Sat, 3 Jan 2009 19:32:09 +0000 (19:32 -0000)]
Make the Files browser correctly restore its view settings, i.e.
"Simple" or "Detail" mode.

As KDirOperator::readConfig() didn't work (no idea why), we're now
simply reading the config value by ourselves and setting it directly.

BUG: 173742
CCBUG: 157038
CCMAIL: kwrite-devel@kde.org

svn path=/trunk/extragear/multimedia/amarok/; revision=905136

8 years agodebug++
Mark Kretschmann [Sat, 3 Jan 2009 19:31:15 +0000 (19:31 -0000)]
debug++

svn path=/trunk/extragear/multimedia/amarok/; revision=905134

8 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Sat, 3 Jan 2009 16:35:07 +0000 (16:35 -0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/extragear/multimedia/amarok/; revision=905064

8 years agoRemove some dubious old code whose purpose we can only guess today. I
Mark Kretschmann [Sat, 3 Jan 2009 08:43:57 +0000 (08:43 -0000)]
Remove some dubious old code whose purpose we can only guess today. I
assume it was a workaround for bugs from KDE 2 or somesuch.

svn path=/trunk/extragear/multimedia/amarok/; revision=904808

8 years agoRemove unneeded includes and forward declarations.
Mark Kretschmann [Sat, 3 Jan 2009 08:43:53 +0000 (08:43 -0000)]
Remove unneeded includes and forward declarations.

svn path=/trunk/extragear/multimedia/amarok/; revision=904807

8 years agochangelog++
Mark Kretschmann [Fri, 2 Jan 2009 14:22:18 +0000 (14:22 -0000)]
changelog++

svn path=/trunk/extragear/multimedia/amarok/; revision=904578

8 years agoMade the Files browser remember its settings, like the current
Mark Kretschmann [Fri, 2 Jan 2009 14:22:13 +0000 (14:22 -0000)]
Made the Files browser remember its settings, like the current
directory. Also did a major refactoring of the class, removing all
obsolete code, and cleaned up.

The only remaining problem is that KDirOperator won't restore its view
settings. It does however write the config correctly, so I guess this is
just a small issue with its initialization that should be fixable (the
API docs for KDirOperator are pretty fuzzy on that).

CCBUG: 173742

svn path=/trunk/extragear/multimedia/amarok/; revision=904577

8 years agoUpdate year in copyright header.
Mark Kretschmann [Fri, 2 Jan 2009 13:01:53 +0000 (13:01 -0000)]
Update year in copyright header.

svn path=/trunk/extragear/multimedia/amarok/; revision=904519

8 years agoAdded automatic recovery option to mysqle server.
Edward Hades Toroshchin [Thu, 1 Jan 2009 20:07:45 +0000 (20:07 -0000)]
Added automatic recovery option to mysqle server.

svn path=/trunk/extragear/multimedia/amarok/; revision=904284

8 years agoRevert "Attempt to fix CV bug that showed misplaced containments after resizing and...
Mark Kretschmann [Thu, 1 Jan 2009 15:53:53 +0000 (15:53 -0000)]
Revert "Attempt to fix CV bug that showed misplaced containments after resizing and changing containments. "

This patch introduced serious regressions with the vertical sizing of
applets. This is the second time that I'm reverting this patch.

William, to be honest with you, this wasn't very nice of you to commit the same
buggy patch twice, and then letting others try to fix it up. I spent
about two hours on that today. Time that I could have invested better.

CCBUG: 176101
CCMAIL: vianasw@gmail.com
CCMAIL: amarok-devel@kde.org

svn path=/trunk/extragear/multimedia/amarok/; revision=904193

8 years agoRevert "Remove unused variables."
Mark Kretschmann [Thu, 1 Jan 2009 15:53:42 +0000 (15:53 -0000)]
Revert "Remove unused variables."

This reverts commit 83217a9ece53e7d48859420026707b6d4a073a73.

svn path=/trunk/extragear/multimedia/amarok/; revision=904192

8 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Wed, 31 Dec 2008 14:44:20 +0000 (14:44 -0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/extragear/multimedia/amarok/; revision=903858

8 years agochangelog++
Mark Kretschmann [Wed, 31 Dec 2008 10:29:22 +0000 (10:29 -0000)]
changelog++

svn path=/trunk/extragear/multimedia/amarok/; revision=903688

8 years agoFixed problems with the collection scanner missing part of the
Mark Kretschmann [Wed, 31 Dec 2008 10:29:05 +0000 (10:29 -0000)]
Fixed problems with the collection scanner missing part of the
collection, or potentially failing altogether.

Specifically the problem was with restarting the amarokcollectionscanner
binary after it has crashed, which we are doing transparently in the
background, without the user ever noticing (normally). The scanner can
crash due to TagLib crashing, which still can happen sometimes.

The code for restarting the scanner was never properly ported over from
Amarok 1, and it would often miss a part of the data during restarting.
This should be fixed now.

PS: This took me about 4 days of intense hacking, so I'm really happy
now that it's done.

Please test :)

BUG: 176154

svn path=/trunk/extragear/multimedia/amarok/; revision=903687

8 years agoAs with Ipods, inform source collection of a copy operation of tracks that failed...
Alejandro Daniel Wainzinger [Tue, 30 Dec 2008 17:44:42 +0000 (17:44 -0000)]
As with Ipods, inform source collection of a copy operation of tracks that failed to copy.

svn path=/trunk/extragear/multimedia/amarok/; revision=903501

8 years agoBackport commit 893519 which fixes plasma crash when dtoring.
Seb Ruiz [Tue, 30 Dec 2008 10:42:14 +0000 (10:42 -0000)]
Backport commit 893519 which fixes plasma crash when dtoring.
BUG: 179110

svn path=/trunk/extragear/multimedia/amarok/; revision=903254

8 years agotypo--
Mark Kretschmann [Tue, 30 Dec 2008 10:05:21 +0000 (10:05 -0000)]
typo--

svn path=/trunk/extragear/multimedia/amarok/; revision=903246

8 years agoIf the user just enabled debugging output (amarok --debug),
Mark Kretschmann [Tue, 30 Dec 2008 07:55:35 +0000 (07:55 -0000)]
If the user just enabled debugging output (amarok --debug),
inform the user that the full output will only come into effect at
the next restart.

svn path=/trunk/extragear/multimedia/amarok/; revision=903197

8 years agoFix bug with the playlist search widget going into keyboard focus mode
Mark Kretschmann [Mon, 29 Dec 2008 19:51:03 +0000 (19:51 -0000)]
Fix bug with the playlist search widget going into keyboard focus mode
directly on startup, without a good reason.

svn path=/trunk/extragear/multimedia/amarok/; revision=903046

8 years agoFix a signal/slot connection, and remove defunct ones.
Alex Merry [Mon, 29 Dec 2008 14:39:23 +0000 (14:39 -0000)]
Fix a signal/slot connection, and remove defunct ones.

svn path=/trunk/extragear/multimedia/amarok/; revision=902956

8 years agoSVN_SILENT made messages (.desktop file)
Script Kiddy [Mon, 29 Dec 2008 14:09:33 +0000 (14:09 -0000)]
SVN_SILENT made messages (.desktop file)

svn path=/trunk/extragear/multimedia/amarok/; revision=902946

8 years agoAdded /usr/lib64 for mysqlclient so Mandriva's library locations can be found too
Alan Jones [Mon, 29 Dec 2008 05:40:38 +0000 (05:40 -0000)]
Added /usr/lib64 for mysqlclient so Mandriva's library locations can be found too

svn path=/trunk/extragear/multimedia/amarok/; revision=902768

8 years agoadd lib64 path for mysql search
Leo Franchi [Mon, 29 Dec 2008 05:20:10 +0000 (05:20 -0000)]
add lib64 path for mysql search

svn path=/trunk/extragear/multimedia/amarok/; revision=902767

8 years agoComment out some debugging code that can't execute
Erik Hovland [Sun, 28 Dec 2008 22:46:01 +0000 (22:46 -0000)]
Comment out some debugging code that can't execute

The debugging output is only available if the debug variable is
set to true. So I am commenting it out to reduce the compile size
a little.

svn path=/trunk/extragear/multimedia/amarok/; revision=902675

8 years agoThe argument number should be 18 and not 19.
Erik Hovland [Sun, 28 Dec 2008 21:38:37 +0000 (21:38 -0000)]
The argument number should be 18 and not 19.

The i18n call should have 18 arguments so a skip of
18 is errant. This was found by EBN. I am fixing it now
because the code is commented out and set to be removed
eventually. Might as well make it right in the repo before
it is removed.

svn path=/trunk/extragear/multimedia/amarok/; revision=902651

8 years agoTRUE and FALSE are so last millenia
Erik Hovland [Sun, 28 Dec 2008 21:35:54 +0000 (21:35 -0000)]
TRUE and FALSE are so last millenia

true and false should be used in C++ code. Not TRUE
and FALSE.

svn path=/trunk/extragear/multimedia/amarok/; revision=902650

8 years agoMake sure every member var is initialized
Erik Hovland [Sun, 28 Dec 2008 21:35:45 +0000 (21:35 -0000)]
Make sure every member var is initialized

Some member vars are not initialized in the ctor. This
commit brings in the latest batch of these types of
defects.

svn path=/trunk/extragear/multimedia/amarok/; revision=902649

8 years agoComment out code that is never executed
Erik Hovland [Sun, 28 Dec 2008 21:35:35 +0000 (21:35 -0000)]
Comment out code that is never executed

Since the code is never executed, them comment it out
so it is not even compiled into the executable.

svn path=/trunk/extragear/multimedia/amarok/; revision=902648

8 years agoResolve w/ upstream.
Erik Hovland [Sun, 28 Dec 2008 21:35:25 +0000 (21:35 -0000)]
Resolve w/ upstream.

svn path=/trunk/extragear/multimedia/amarok/; revision=902647

8 years agoDon't crash when double clicking "Enter Query" in librivox service
Dan Meltzer [Sun, 28 Dec 2008 17:52:06 +0000 (17:52 -0000)]
Don't crash when double clicking "Enter Query" in librivox service
BUG: 177991

svn path=/trunk/extragear/multimedia/amarok/; revision=902576

8 years agodebug++. Please test and provide the output if your collection gets messed up.
Dan Meltzer [Sun, 28 Dec 2008 16:58:01 +0000 (16:58 -0000)]
debug++.  Please test and provide the output if your collection gets messed up.
CCBUG: 176154

svn path=/trunk/extragear/multimedia/amarok/; revision=902548

8 years agochangelog++
Mark Kretschmann [Sun, 28 Dec 2008 15:21:52 +0000 (15:21 -0000)]
changelog++

svn path=/trunk/extragear/multimedia/amarok/; revision=902512

8 years agoFixed layout of the Edit Filter dialog. Now it resizes correctly.
Mark Kretschmann [Sun, 28 Dec 2008 15:14:53 +0000 (15:14 -0000)]
Fixed layout of the Edit Filter dialog. Now it resizes correctly.

Major thanks to Cyrille Berger for helping with this one :)

svn path=/trunk/extragear/multimedia/amarok/; revision=902511