Casey Link [Fri, 29 Jan 2010 18:36:06 +0000 (13:36 -0500)]
add build/ dir to gitignore for those who build amarok insource
Mark Kretschmann [Fri, 29 Jan 2010 18:25:54 +0000 (19:25 +0100)]
Add BR number.
Mark Kretschmann [Fri, 29 Jan 2010 18:22:51 +0000 (19:22 +0100)]
Revert "Remove feature: Scanner looking for "folder.png"."
This reverts commit
2e58e40975a0730ea1d2d39107654469c64a0bf0.
Gah. Turns out, there _are_ actually applications using "Folder.jpg".
So, here we go again...
BUG: 224692
Leo Franchi [Fri, 29 Jan 2010 16:03:50 +0000 (11:03 -0500)]
bail out on null active playlist
Mark Kretschmann [Fri, 29 Jan 2010 14:17:51 +0000 (15:17 +0100)]
Fix crash on startup. StatusBar was not yet constructed.
I've fixed this by adding a few checks for 0. This should do the trick.
If the solution is a good one, or if we should rethink the startup object
creation order, that's another question...
BUG: 217861
Mark Kretschmann [Fri, 29 Jan 2010 12:29:36 +0000 (13:29 +0100)]
EBN fix: Somehow weird characters got into this file.
Mark Kretschmann [Fri, 29 Jan 2010 12:21:56 +0000 (13:21 +0100)]
EBN fixes: Make these ctors explicit.
Mark Kretschmann [Fri, 29 Jan 2010 10:33:43 +0000 (11:33 +0100)]
EBN fixes: Make these ctors explicit.
Mark Kretschmann [Fri, 29 Jan 2010 10:26:14 +0000 (11:26 +0100)]
EBN fixes: Missing newline at end of file
Mark Kretschmann [Fri, 29 Jan 2010 09:53:29 +0000 (10:53 +0100)]
EBN fix: Don't create modal dialogs on the heap.
Mark Kretschmann [Fri, 29 Jan 2010 09:21:16 +0000 (10:21 +0100)]
Why on earth am I fixing files that are not used :(
For crying out loud: Can we please remove files that are no longer in use?
KTHXBAI.
Mark Kretschmann [Fri, 29 Jan 2010 09:17:56 +0000 (10:17 +0100)]
"HELLO, THIS IS AMAROK SPEAKING!"
"I want my good coding style back."
Mark Kretschmann [Fri, 29 Jan 2010 09:13:19 +0000 (10:13 +0100)]
EBN fix: Don't create modal dialogs on the heap.
Testing welcome.
(This commit message is totally not a copy/paste job from the last one.)
Mark Kretschmann [Fri, 29 Jan 2010 09:08:15 +0000 (10:08 +0100)]
EBN fix: Don't create modal dialogs on the heap.
Testing welcome.
Maximilian Kossick [Fri, 29 Jan 2010 08:23:15 +0000 (09:23 +0100)]
fixed a bug where too many tracks were copied when no complete artists or albums have to be copied
unit tests rock!
Maximilian Kossick [Fri, 29 Jan 2010 08:20:10 +0000 (09:20 +0100)]
added unit tests for synchronization classes, added new dependency for unit tests: googlemock, inital version of test for memoryquerymaker
Maximilian Kossick [Wed, 20 Jan 2010 19:31:20 +0000 (20:31 +0100)]
changed build system so that tests are always build when KDE_BUILD_TESTS = ON.
test files are only installed when the build type is debugfull though
Kevin Funk [Fri, 29 Jan 2010 07:23:45 +0000 (08:23 +0100)]
A safer approach for closing the notification. Avoids dereferencing a
dangling pointer. I don't get crashes anyway but this may fix it.
BUG: 224673
Bart Cerneels [Thu, 28 Jan 2010 13:57:42 +0000 (14:57 +0100)]
Fix a crash caused by a dangling pointer.
BUG:224114
Bart Cerneels [Tue, 26 Jan 2010 19:43:35 +0000 (20:43 +0100)]
Implement some more podcast functions for UMS
Kevin Funk [Thu, 28 Jan 2010 12:24:20 +0000 (13:24 +0100)]
Provide the correct bug number. See previous commit.
BUG: 217153
Kevin Funk [Thu, 28 Jan 2010 12:23:09 +0000 (13:23 +0100)]
Quick hack to enable queue management by doing Ctrl+RightClick.
There are still multiple issues left wrt Queue management (regarding
icon position, etc.).
BUG: 197555
Nikolaj Hald Nielsen [Thu, 28 Jan 2010 09:45:33 +0000 (10:45 +0100)]
Fix playback of some streams causing the progress slider to show complete and utter garbage track lengths and position values like -322:0-35:0-59.
ChangeLog++
Leo Franchi [Thu, 28 Jan 2010 05:13:36 +0000 (00:13 -0500)]
don't recreate a bias when setting active to currently selected
Leo Franchi [Wed, 27 Jan 2010 22:56:34 +0000 (17:56 -0500)]
add some copyrights
fix renaming of Random bias when saving a modified version of it
fix overwriting dynamic playlist with modified self
Leo Franchi [Wed, 27 Jan 2010 22:33:27 +0000 (17:33 -0500)]
get 30 similar artists from echonest rather than the old 15
Leo Franchi [Wed, 27 Jan 2010 22:24:50 +0000 (17:24 -0500)]
refactor: rename CustomBiasFactory to CustomBiasEntryFactory, less confusing
refactor: don't store the weight of a bias also in the CustomBiasEntry, led to subtle bugs when it was out of sync with the CustomBias stored value. now, get value directly from CustomBias when creating CollectionFilterCapability
fix: auto-load biases properly with new on-demand system
Leo Franchi [Tue, 26 Jan 2010 04:46:29 +0000 (23:46 -0500)]
enable dynamic track navigator again....
load first custom bias entry in list when creating a new custom bias
Leo Franchi [Mon, 18 Jan 2010 01:14:08 +0000 (19:14 -0600)]
initial non-compiling work
some more dynamic overhaul work
fixes for new dynamic combobox
re-enable cover fetching hopefully
fix merge
Mark Kretschmann [Wed, 27 Jan 2010 08:54:13 +0000 (09:54 +0100)]
Don't use backward-includes.
Mark Kretschmann [Wed, 27 Jan 2010 08:52:11 +0000 (09:52 +0100)]
Minor coding style cleanup.
Mark Kretschmann [Wed, 27 Jan 2010 08:48:20 +0000 (09:48 +0100)]
Fix a bunch of incorrect method overloads.
It seems these methods were supposed to be const:
In file included from /home/mark/kde/src/amarok/src/services/ampache/AmpacheMeta.cpp:18:
/home/mark/kde/src/amarok/src/services/ampache/../ServiceMetaBase.h:113: warning: ‘virtual bool BookmarkThisProvider::isBookmarkable() const’ was hidden
/home/mark/kde/src/amarok/src/services/ampache/AmpacheMeta.h:96: warning: by ‘virtual bool Meta::AmpacheArtist::isBookmarkable()’
/home/mark/kde/src/amarok/src/services/ampache/../ServiceMetaBase.h:115: warning: ‘virtual QString BookmarkThisProvider::collectionName() const’ was hidden
/home/mark/kde/src/amarok/src/services/ampache/AmpacheMeta.h:97: warning: by ‘virtual QString Meta::AmpacheArtist::collectionName()’
/home/mark/kde/src/amarok/src/services/ampache/../ServiceMetaBase.h:116: warning: ‘virtual bool BookmarkThisProvider::simpleFiltering() const’ was hidden
/home/mark/kde/src/amarok/src/services/ampache/AmpacheMeta.h:98: warning: by ‘virtual bool Meta::AmpacheArtist::simpleFiltering()’
Mark Kretschmann [Wed, 27 Jan 2010 08:32:58 +0000 (09:32 +0100)]
Merge commit 'refs/merge-requests/105' of git://gitorious.org/amarok/amarok into merge_this_request
Mark Kretschmann [Tue, 26 Jan 2010 19:02:17 +0000 (20:02 +0100)]
QIODevice::readAll() seems more efficient.
Nikolaj, could you check this commit for correctness? Thanks.
CCMAIL: nhnfreespirit@gmail.com
Mark Kretschmann [Tue, 26 Jan 2010 19:00:36 +0000 (20:00 +0100)]
Coding style fixes.
Mark Kretschmann [Tue, 26 Jan 2010 18:54:11 +0000 (19:54 +0100)]
Make EBN happy.
Bart Cerneels [Tue, 26 Jan 2010 18:31:41 +0000 (19:31 +0100)]
Prevent a crash when loading PLS playlists.
Bart Cerneels [Tue, 26 Jan 2010 15:30:14 +0000 (16:30 +0100)]
Do some input checking when importing playlistfile
Mark Kretschmann [Tue, 26 Jan 2010 12:20:15 +0000 (13:20 +0100)]
EBN fix: Don't create dialogs on the heap.
Stack works just fine, so we don't have to pull "deleteLater()" stunts,
if the dialog is modal anyway.
Kevin Funk [Tue, 26 Jan 2010 12:03:14 +0000 (13:03 +0100)]
SVG: Cleanup file (Vacuum defs)
Kevin Funk [Tue, 26 Jan 2010 12:00:43 +0000 (13:00 +0100)]
SVG: Rollback color changes to gradients
Kevin Funk [Tue, 26 Jan 2010 10:19:03 +0000 (11:19 +0100)]
SVG changes
* Clean up (remove loads of unused hidden layers)
* Give seek bar color and modify knob highlighting
Mark Kretschmann [Tue, 26 Jan 2010 07:24:27 +0000 (08:24 +0100)]
Merge commit 'refs/merge-requests/107' of git://gitorious.org/amarok/amarok into merge_it
Kevin Funk [Mon, 25 Jan 2010 22:07:56 +0000 (23:07 +0100)]
Ctrl-O supports both OSD and KNotify now.
* Shows KNotify only when OSD=0 && KNotify=1
Kevin Funk [Mon, 25 Jan 2010 22:06:06 +0000 (23:06 +0100)]
Refactor KNotificationBackend class
* Instantiate only once
* Now possible to check if KNotify support is enabled
Rick W. Chen [Mon, 25 Jan 2010 21:14:31 +0000 (10:14 +1300)]
Merge branch 'cover-manager'
This merge reworks the cover manager a bit. The main change is putting
the progress indicator into the statusbar, instead of a popup dialog.
Also, it fixes a few crashes in the process.
BUG: 224000
Rick W. Chen [Mon, 25 Jan 2010 21:06:51 +0000 (10:06 +1300)]
cover manager: interrupt cover loading when artist selection changes
Rick W. Chen [Mon, 25 Jan 2010 20:56:35 +0000 (09:56 +1300)]
cover manager: update status bar as fetching progresses
This prevents the progress indicator in the status bar sometimes appearing
frozen for a while before reaching 100%, even though fetching has in fact
already finished.
Rick W. Chen [Mon, 25 Jan 2010 20:45:24 +0000 (09:45 +1300)]
cover manager: prevent window closing crash while still loading covers
Rick W. Chen [Mon, 25 Jan 2010 19:47:47 +0000 (08:47 +1300)]
trivial: whitespace/style fixes
Rick W. Chen [Mon, 25 Jan 2010 19:06:17 +0000 (08:06 +1300)]
cover manager: use incrementProgress() when updating fetch progress
Rick W. Chen [Mon, 25 Jan 2010 18:54:05 +0000 (07:54 +1300)]
cover manager: reintroduce cancelling cover loading using button
Rick W. Chen [Mon, 25 Jan 2010 18:18:49 +0000 (07:18 +1300)]
cover manager: rename slots to be more meaningful
Rick W. Chen [Mon, 25 Jan 2010 18:06:37 +0000 (07:06 +1300)]
cover manager: remove massive comment blocks
Kevin Funk [Mon, 25 Jan 2010 20:24:06 +0000 (21:24 +0100)]
Fix KNotify popping up twice.
Close the old one before showing a new one.
Jakob Kummerow [Mon, 25 Jan 2010 18:09:13 +0000 (19:09 +0100)]
make EBN/Krazy happy
Mark Kretschmann [Mon, 25 Jan 2010 19:56:55 +0000 (20:56 +0100)]
EBN fix.
Issue: "Check for QString compares to "" [emptystrcompare]"
"Do not compare a QString to "". Instead use the .isEmpty() method.
For example, if(str == "") becomes if(str.isEmpty()"
Rick W. Chen [Mon, 25 Jan 2010 18:09:49 +0000 (07:09 +1300)]
cover manager: use a compound progress bar for all operation indications
Rick W. Chen [Mon, 25 Jan 2010 17:50:50 +0000 (06:50 +1300)]
compound progress bar: fix logic testing progress map is empty
Rick W. Chen [Mon, 25 Jan 2010 17:43:05 +0000 (06:43 +1300)]
compound progress bar: unite duplicate code
Rick W. Chen [Mon, 25 Jan 2010 16:19:58 +0000 (05:19 +1300)]
cover manager: merge slotArtistSelectedContinue() into slotArtistSelected()
Rick W. Chen [Mon, 25 Jan 2010 16:16:05 +0000 (05:16 +1300)]
cover manager: connect signals within init()
Nikolaj Hald Nielsen [Mon, 25 Jan 2010 19:15:31 +0000 (20:15 +0100)]
Add PUD to new filebrowser
Nikolaj Hald Nielsen [Mon, 25 Jan 2010 19:02:30 +0000 (20:02 +0100)]
Add basic context menu for new filebrowser
Nikolaj Hald Nielsen [Sun, 24 Jan 2010 20:44:54 +0000 (21:44 +0100)]
Better background text for the filter edit
Nikolaj Hald Nielsen [Sun, 24 Jan 2010 20:42:28 +0000 (21:42 +0100)]
Use extended selection mode, allowing multiple files/folders to be selected at once
Nikolaj Hald Nielsen [Sun, 24 Jan 2010 20:40:55 +0000 (21:40 +0100)]
Make dragging from the new filbrowser to the playlist work
Nikolaj Hald Nielsen [Sun, 24 Jan 2010 20:35:23 +0000 (21:35 +0100)]
Add a simple filter box to the new file browser and make it relative to the users home dir.
Nikolaj Hald Nielsen [Sun, 24 Jan 2010 16:33:45 +0000 (17:33 +0100)]
Make it possible to double click a directory to recursively add all tracks in it. Also a few other improvements.
Nikolaj Hald Nielsen [Sun, 24 Jan 2010 13:21:22 +0000 (14:21 +0100)]
Add the beginnings of a new, much simpler and more amarok specific, file browser.
Currently the only supported action is double clicking a track to add it to the playlist.
Mathias Panzenböck [Mon, 25 Jan 2010 19:01:41 +0000 (20:01 +0100)]
Fixed my issues discovered by EBN (PodcastReader, PodcastCategory)
Nikolaj Hald Nielsen [Mon, 25 Jan 2010 14:59:53 +0000 (15:59 +0100)]
Remember a small version bumb...
Nikolaj Hald Nielsen [Mon, 25 Jan 2010 14:55:56 +0000 (15:55 +0100)]
Some small maintenance changes and a new stations...
Mark Kretschmann [Mon, 25 Jan 2010 12:50:08 +0000 (13:50 +0100)]
typo--
Mark Kretschmann [Mon, 25 Jan 2010 11:03:37 +0000 (12:03 +0100)]
Remove feature: Scanner looking for "folder.png".
As it turned out, the whole thing was a misunderstanding, and the user
meant something completely different. So my patch was useless.
@jefferai: Could you please check my commit for correctness again?
(I already screwed up two things today, that's enough;)
Script Kiddy [Mon, 25 Jan 2010 10:45:20 +0000 (11:45 +0100)]
SVN_SILENT made messages (.desktop file)
Mark Kretschmann [Mon, 25 Jan 2010 09:57:12 +0000 (10:57 +0100)]
Aaaaand another stupid bug.
Markey is screwing with our code. This cannot stand. Someone stop
the guy!
Mark Kretschmann [Mon, 25 Jan 2010 09:40:54 +0000 (10:40 +0100)]
Fix stupid logic regression in ScanManager.
Mark Kretschmann [Mon, 25 Jan 2010 09:32:22 +0000 (10:32 +0100)]
Use better method for locating scanner binary.
Thanks to pinotree for pointing this out.
CCBUG: 224112
Mark Kretschmann [Mon, 25 Jan 2010 09:07:23 +0000 (10:07 +0100)]
Look for scanner both in $PATH and in PREFIX.
This has been requested by a user (with a very weird setup, but anyway).
BUG: 224112
Nikolaj Hald Nielsen [Mon, 25 Jan 2010 08:20:57 +0000 (09:20 +0100)]
Fix out of bounds crash in the coverfetcher.
Nikolaj Hald Nielsen [Mon, 25 Jan 2010 08:09:41 +0000 (09:09 +0100)]
Use new url for purchasing gift cards. The old one ws not working any more (a redirect has been put in place on the magnatune site to fix this for
older versions of amarok)
Rick W. Chen [Tue, 19 Jan 2010 22:34:18 +0000 (11:34 +1300)]
Revert "try to fix qt4.6.0 crash again"
This reverts commit
16abc173b86c048c13bebff622b355a93c7f64be.
The first pass of cover fetching always returns an xml, regardless
of whether there's an image. This causes no covers to ever get fetched.
Mark Kretschmann [Mon, 25 Jan 2010 07:26:51 +0000 (08:26 +0100)]
Change tooltip for the "seek to XY" feature.
Renamed this one from "Track position under cursor" to "Jump to", as
usability expert Thomas Pfeiffer had suggested. Thanks Thomas :)
CCMAIL: colomar@autistici.org
Mark Kretschmann [Sun, 24 Jan 2010 12:27:35 +0000 (13:27 +0100)]
Replace one more APP_VERSION that I had missed.
Thomas Coopman [Sun, 24 Jan 2010 10:28:25 +0000 (11:28 +0100)]
Add wma to the list of allowed format when copying to a UMS device.
Mark Kretschmann [Sat, 23 Jan 2010 13:27:04 +0000 (14:27 +0100)]
Rename APP_VERSION to AMAROK_VERSION.
Slightly nicer and more sensical, I think.
Nikolaj Hald Nielsen [Sat, 23 Jan 2010 11:39:39 +0000 (12:39 +0100)]
Make "Find in Source" work for MetaFile tracks. "Shown in Source" will open the file browser and navigate to the parent directory.
This even works for files that has not been added using the file browser, such as track sdragged
from an external app.
Script Kiddy [Sat, 23 Jan 2010 11:00:23 +0000 (12:00 +0100)]
SVN_SILENT made messages (.desktop file)
Mark Kretschmann [Sat, 23 Jan 2010 07:35:03 +0000 (08:35 +0100)]
Remove legacy release script.
Mark Kretschmann [Sat, 23 Jan 2010 07:33:03 +0000 (08:33 +0100)]
Adjust release script for the new Version.h.
Mark Kretschmann [Sat, 23 Jan 2010 07:30:46 +0000 (08:30 +0100)]
Move APP_VERSION to separate file Version.h.
This fixes the issues with amarokcollectionscanner (which is Qt-only)
pulling in KDE stuff via Amarok.h. Also seems more elegant to me in general.
Will also adjust our release script accordingly.
Mark Kretschmann [Sat, 23 Jan 2010 07:08:06 +0000 (08:08 +0100)]
Revert "Revert "Add "--version" argument to collection scanner.""
This reverts commit
b0bef274be1a9741c54c8d32e13d17600c79d300.
Proper fix coming up, including Amarok.h was a bad idea indeed. Hold on.
Jeff Mitchell [Sat, 23 Jan 2010 02:28:47 +0000 (21:28 -0500)]
Revert "Add "--version" argument to collection scanner."
~lart markey
Depending on Amarok.h and ../../src breaks build for those building just
the utilities. Figure out some other way to do this.
This reverts commit
764f62d9e120396cd7f682f56009e4847c1ac1fb.
Kevin Funk [Fri, 22 Jan 2010 22:43:27 +0000 (23:43 +0100)]
Fix keyboard navigation in Notification config dialog
Nikolaj Hald Nielsen [Fri, 22 Jan 2010 20:48:45 +0000 (21:48 +0100)]
ChangeLog++
Nikolaj Hald Nielsen [Fri, 22 Jan 2010 20:06:23 +0000 (21:06 +0100)]
Make the Equalizer dialog a tool window alongside the cover manager, script manager, et al, make it accessible from the tools menu and get rid of the list of presets in the settings menu.
This required quite a bit of moving stuff around, so please test. Also, we need a good icon for the eqalizer.
Jeff Mitchell [Fri, 22 Jan 2010 18:14:37 +0000 (13:14 -0500)]
Fix i18nc order
Jeff Mitchell [Fri, 22 Jan 2010 14:47:13 +0000 (09:47 -0500)]
Make things more efficient in image heuristics.
Script Kiddy [Fri, 22 Jan 2010 11:00:30 +0000 (12:00 +0100)]
SVN_SILENT made messages (.desktop file)