8 years agobug #2519304: more verbose logs for sending a MMS. Capture the payload size and mmsc... beagle-eclair master beagle-eclair-0x4 beagle-eclair-0x5
Wei Huang [Wed, 17 Mar 2010 15:06:17 +0000 (08:06 -0700)]
bug #2519304: more verbose logs for sending a MMS. Capture the payload size and mmsc url.

Change-Id: I615b004995e8d243e4bd9a6794d5e21d0c7df5d9

8 years agoAdd better logging info
Tom Taylor [Thu, 18 Feb 2010 01:08:25 +0000 (17:08 -0800)]
Add better logging info

When trying to track down bug 2447913, chain the original exception
and print out the url that we're trying to reach.

Change-Id: I9bcb326e77bfdc95ad75eb0ba5c08aa8cc506a28

8 years agobug #2434183: guard against ArrayIndexOutOfBoundEx when there is an empty slide show.
Wei Huang [Thu, 11 Feb 2010 17:41:45 +0000 (09:41 -0800)]
bug #2434183: guard against ArrayIndexOutOfBoundEx when there is an empty slide show.

Change-Id: Iad96489e787d3e6cb9162ced4adbf164566bf421

8 years agoreconcile main tree with open-source eclair
The Android Open Source Project [Fri, 5 Feb 2010 16:09:40 +0000 (08:09 -0800)]
reconcile main tree with open-source eclair

8 years agoreconcile android-2.1_r1 snapshot
The Android Open Source Project [Fri, 29 Jan 2010 22:09:26 +0000 (14:09 -0800)]
reconcile android-2.1_r1 snapshot

8 years agobug 2384418: fix bug in mms contact lookup.
Wei Huang [Tue, 26 Jan 2010 09:23:00 +0000 (01:23 -0800)]
bug 2384418: fix bug in mms contact lookup.

- a portion of the mms contact lookup wasn't protected by the synchronization block, and that portion used a member variable 'mSelectionArgs[]', which contains the number to be looked up. If this code is accessed by different threads at the same time, mSelectionArgs[] could be overridden by a wrong number, causing the resulting contact info be bad. With the bad contact cache, future lookups by phone number would result in the wrong contact.

While I didn't reproduce this with release builds, I was able to write a test that looks up a bunch of numbers in thread 1, and another bunch in thread 2. I observed thread #2 overwritting mSelectionArgs[] for thread 1, causing contact lookup to create bad contact cache. I believe in practice this can happen as the MMS code does look up and create contact cache entries from different threads.

This problem should be in builds before ERE19. In ERE19, Dmitri added an optimization in the ContactInfoCache's contact lookup, which should result in contact lookup to fail (zero cursor) when mSelectionArgs[] is overwritten by a bad phone number. It'd be nice to confirm that, but bug 2384418 doesn't contain a bug report, and we don't know for sure which build it was found in.

In any case, this fix is straight forward and should fix the contact lookup.

Change-Id: I516ff7039bec47c1b7bdc7dd5e52347c004a5a13

8 years agoBug: 2167799
Wei Huang [Thu, 21 Jan 2010 17:45:04 +0000 (09:45 -0800)]
Bug: 2167799

- use PhoneUtils.toCallerIDMinMatch() instead of getStrippedReversed(). The latter uses the whole number, and would treat numbers "1-650-555-1212" and "650-555-1212" differently. The former uses the first 7 digits of the reversed digits, and is what ContactsProvider uses to filter for numbers.

8 years agoOptimizing phone lookup for MMS recipient list.
Dmitri Plotnikov [Mon, 18 Jan 2010 23:14:38 +0000 (15:14 -0800)]
Optimizing phone lookup for MMS recipient list.

Bug: 2167799
Change-Id: I25a7fc18260bbec3dcc5eb87ede45be644d51ef6

8 years agoandroid-2.1_r1 snapshot
The Android Open Source Project [Tue, 12 Jan 2010 23:19:15 +0000 (15:19 -0800)]
android-2.1_r1 snapshot

8 years agoDon't load contacts on UI thread
Tom Taylor [Tue, 12 Jan 2010 22:40:37 +0000 (14:40 -0800)]
Don't load contacts on UI thread

There's a route through a Conversation constructor that will
result in the conversation's contacts getting loaded on the
UI thread. Add an explicit "allowQuery" parameter to give callers
the ability to throttle this behavior. Fixes bug 2280762.



8 years agoMerge branch 'eclair' into eclair-release
The Android Automerger [Thu, 10 Dec 2009 17:01:48 +0000 (09:01 -0800)]
Merge branch 'eclair' into eclair-release

8 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Thu, 10 Dec 2009 01:27:14 +0000 (17:27 -0800)]
Import revised translations.  DO NOT MERGE

8 years agoMerge branch 'eclair' into eclair-release
The Android Automerger [Fri, 4 Dec 2009 17:24:16 +0000 (09:24 -0800)]
Merge branch 'eclair' into eclair-release

8 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Thu, 3 Dec 2009 23:30:58 +0000 (15:30 -0800)]
Import revised translations.  DO NOT MERGE

8 years agoMerge branch 'eclair' into eclair-release
The Android Automerger [Thu, 3 Dec 2009 17:00:02 +0000 (09:00 -0800)]
Merge branch 'eclair' into eclair-release

8 years agoMerge change I2e5b602b into eclair
Android (Google) Code Review [Thu, 3 Dec 2009 00:19:21 +0000 (16:19 -0800)]
Merge change I2e5b602b into eclair

* changes:
  be sure to set mIsStale to false (bug 2299730)

8 years agobe sure to set mIsStale to false (bug 2299730)
Mark Wagner [Wed, 2 Dec 2009 22:33:57 +0000 (14:33 -0800)]
be sure to set mIsStale to false (bug 2299730)

8 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Wed, 2 Dec 2009 22:57:09 +0000 (14:57 -0800)]
Import revised translations.  DO NOT MERGE

8 years agoMerge branch 'eclair' into eclair-release
The Android Automerger [Wed, 2 Dec 2009 16:49:59 +0000 (08:49 -0800)]
Merge branch 'eclair' into eclair-release

8 years agoFix conversation loading
Tom Taylor [Wed, 2 Dec 2009 00:40:23 +0000 (16:40 -0800)]
Fix conversation loading

After loading a thread with an exact set of recipients, the code called
setRecipients() which resets the threadId to zero. As a result, a new
conversation was created and displayed, rather than the existing conversation
with all of its messages. Fixes bug 2284007.

Change-Id: I6b38a046120f320a95f5e63721ee3000290feb1c

8 years agobug: change default UA agent string for MMS.
Wei Huang [Tue, 1 Dec 2009 19:58:46 +0000 (11:58 -0800)]
bug: change default UA agent string for MMS.

- add conditional logging for UAProf url.
- if the MMS port isn't set, don't use Log.e() to log it.

Change-Id: I9557763d209226eafb5cb3b0b7e4092287f5ef29

8 years agoMerge branch 'eclair' into eclair-release
The Android Automerger [Tue, 1 Dec 2009 17:06:37 +0000 (09:06 -0800)]
Merge branch 'eclair' into eclair-release

8 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Mon, 30 Nov 2009 19:37:59 +0000 (11:37 -0800)]
Import revised translations.  DO NOT MERGE

8 years agoMerge branch 'eclair' into eclair-release
The Android Automerger [Mon, 23 Nov 2009 17:28:59 +0000 (09:28 -0800)]
Merge branch 'eclair' into eclair-release

8 years agoMerge branch 'eclair' into eclair-release
The Android Automerger [Fri, 20 Nov 2009 23:02:20 +0000 (15:02 -0800)]
Merge branch 'eclair' into eclair-release

8 years agobug #2271915: make MmsConfig more robust - use defaults when configs in the xml file...
Wei Huang [Fri, 20 Nov 2009 04:03:32 +0000 (20:03 -0800)]
bug #2271915: make MmsConfig more robust - use defaults when configs in the xml file isn't present.

Change-Id: I628ddd211e1a130b10075dbe55708fca020bcfb6

8 years agoFix two Messaging contact updating bugs
Tom Taylor [Thu, 19 Nov 2009 20:07:57 +0000 (12:07 -0800)]
Fix two Messaging contact updating bugs

1) There's a situation where getting a contact could potentially
return a cached contact whose contents haven't been completely filled
in yet.
2) When a contact's info does change, update the messages in the thread
to reflect the current contact data.
Bug 2271800.

Change-Id: I48403c45c461b3c609400a3a5f55b99aaee01cbd

8 years agoMerge branch 'eclair' into eclair-release
The Android Automerger [Wed, 18 Nov 2009 16:48:32 +0000 (08:48 -0800)]
Merge branch 'eclair' into eclair-release

8 years agoFix ANR from calling Contact.get()
Tom Taylor [Wed, 18 Nov 2009 00:00:44 +0000 (16:00 -0800)]
Fix ANR from calling Contact.get()

The Contact.get() API allows the caller to specify whether the operation
can block (looking up contact info in the DB) or not. There are about 10
places where various callers were passing "true" to canBlock, all coming
from the UI thread. We've previously fixed Contact.get() to always return
a Contact, with the number filled in, even if we don't have the contact
in the cache. With this change, never block the UI thread getting a contact.
The worst side-effect should be showing a number, instead of a name.
Fixes bug 2265631.

8 years agoMerge branch 'eclair' into eclair-release
The Android Automerger [Sun, 15 Nov 2009 17:05:32 +0000 (09:05 -0800)]
Merge branch 'eclair' into eclair-release

8 years agoMerge change I430b3e56 into eclair
Android (Google) Code Review [Sat, 14 Nov 2009 01:49:02 +0000 (17:49 -0800)]
Merge change I430b3e56 into eclair

* changes:
  Import revised translations.  DO NOT MERGE

8 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Sat, 14 Nov 2009 01:23:10 +0000 (17:23 -0800)]
Import revised translations.  DO NOT MERGE

Approver: jerryw

8 years agoFix null ref
Tom Taylor [Sat, 14 Nov 2009 00:02:04 +0000 (16:02 -0800)]
Fix null ref

Fixes bug 2261398.

Change-Id: Idb4db938e93b792248d49410b9474c71d5d4bb37

8 years agoMerge branch 'eclair' into eclair-release
The Android Automerger [Fri, 13 Nov 2009 21:13:00 +0000 (13:13 -0800)]
Merge branch 'eclair' into eclair-release

8 years agoMerge change Iee6fa925 into eclair
Android (Google) Code Review [Fri, 13 Nov 2009 18:17:17 +0000 (10:17 -0800)]
Merge change Iee6fa925 into eclair

* changes:
  Import revised translations.  DO NOT MERGE

8 years agoDon't show Converting to MMS
Tom Taylor [Thu, 5 Nov 2009 20:28:15 +0000 (12:28 -0800)]
Don't show Converting to MMS

When we open a thread where the recipient is an
email address, don't automatically show the "Converting
to multimedia message" The user already saw that when
he/she added the email recipient. Bug 2235226.

8 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Fri, 13 Nov 2009 03:48:59 +0000 (19:48 -0800)]
Import revised translations.  DO NOT MERGE

Approver: jerryw

8 years agoeclair snapshot
Jean-Baptiste Queru [Fri, 13 Nov 2009 02:46:11 +0000 (18:46 -0800)]
eclair snapshot

8 years agoOnly register for service changes when needed
Tom Taylor [Thu, 12 Nov 2009 22:41:02 +0000 (14:41 -0800)]
Only register for service changes when needed

The SmsReceiverService registered for SERVICE_STATE changes and this
was causing the Messaging app to be needlessly started up on every
SERVICE_STATE change. With this fix, we only register for that event
when we fail to send a SMS message because of no radio sig, etc.
Once we successfully send the queued message, we'll unregister the
event filter.

Change-Id: I12cbe0cb9a72bbf628bf9a4929680519e85057a2

8 years agoMerge branch 'eclair' into eclair-release
The Android Automerger [Thu, 12 Nov 2009 16:33:24 +0000 (08:33 -0800)]
Merge branch 'eclair' into eclair-release

8 years agoFix a draft mix-up bug
Tom Taylor [Wed, 11 Nov 2009 22:34:10 +0000 (14:34 -0800)]
Fix a draft mix-up bug

There's a particular situation that'll cause ComposeMessageActivity
to choose an existing draft even though the new intent is for a totally
different contact. Fixes bug 2254833.

Change-Id: I1065806c7535a48e1c27140c4c76ccf9b9959c03

8 years agoMerge branch 'eclair' into eclair-release
The Android Automerger [Wed, 11 Nov 2009 16:36:39 +0000 (08:36 -0800)]
Merge branch 'eclair' into eclair-release

8 years agobug 2251648: fix a bug where the Conversation's recipients field failed to be initial...
Wei Huang [Wed, 11 Nov 2009 01:50:58 +0000 (17:50 -0800)]
bug 2251648: fix a bug where the Conversation's recipients field failed to be initialized.

- this caused by a recent change to store the recipient id key as a Long instead of a String
in RecipientIdCache. It's an easy fix.

8 years agoMerge branch 'eclair' into eclair-release
The Android Automerger [Tue, 10 Nov 2009 16:46:07 +0000 (08:46 -0800)]
Merge branch 'eclair' into eclair-release

8 years agobug 2250049: need to allow email address when sending a SMS message.
Wei Huang [Tue, 10 Nov 2009 05:12:01 +0000 (21:12 -0800)]
bug 2250049: need to allow email address when sending a SMS message.

- my change Ia80a2736 added code to validate and scrub MMS address. However, as a side effect
it also disallowed email address for SMS messages. Fix that.

Change-Id: Iac3783e056c933531da73bd53eb8ea9d7c0eb154

8 years agoFix ANR deadlock
Tom Taylor [Tue, 10 Nov 2009 00:56:19 +0000 (16:56 -0800)]
Fix ANR deadlock

When the Mms app starts up, Conversation starts a background thread
to load all the conversations into a cache. It had a lock on the cache.
Meanwhile, the ComposeMessageActivity started up and tried to load
its conversation, but was blocked and eventually ANR'd. Make the
sync lock cover a much smaller scope and don't hold the lock during
the slow operation of looking up the contact info. Also, remove the
unused SuggestionsProvider. It was causing the Mms app to spin up
needlessly. Fixes bug 2220565.

Change-Id: I0f8260338a5368dc4b8ef11249361ca0716a2887

8 years agoMerge change Ifae5cfc5 into eclair
Android (Google) Code Review [Mon, 9 Nov 2009 21:02:09 +0000 (13:02 -0800)]
Merge change Ifae5cfc5 into eclair

* changes:
  bug 2248168: populate the recipient field when texting from the fast track.

8 years agoFix missing From field
Tom Taylor [Mon, 9 Nov 2009 20:04:50 +0000 (12:04 -0800)]
Fix missing From field

In rare cases, a Mms pdu header will not contain a "from" address.
Rather than leaving the from address blank, use a slower, but more
reliable method of getting the from address from the "addr" table.
This is the technique the Mms notification system uses to get the address
displayed in the notification bar when a new message is received.
Fixed bug 2241939.

Change-Id: If932d4f1c24f46f3c3906a7e2658d7f67d4a2cfa

8 years agobug 2248168: populate the recipient field when texting from the fast track.
Wei Huang [Mon, 9 Nov 2009 19:05:19 +0000 (11:05 -0800)]
bug 2248168: populate the recipient field when texting from the fast track.

- need to call Conversation.setRecipient() when creating a new Conversation object.

8 years agoMerge branch 'eclair' into eclair-release
The Android Automerger [Mon, 9 Nov 2009 00:52:26 +0000 (16:52 -0800)]
Merge branch 'eclair' into eclair-release

8 years agoCherry pick 963f4a964e227d62eddbe2e1f6fb0721f665f4d2
Wei Huang [Sun, 8 Nov 2009 18:11:40 +0000 (10:11 -0800)]
Cherry pick 963f4a964e227d62eddbe2e1f6fb0721f665f4d2

8 years agobug 2236535: find a way to update the stale canonical_addresses entries with new...
Wei Huang [Sat, 7 Nov 2009 01:58:01 +0000 (17:58 -0800)]
bug 2236535: find a way to update the stale canonical_addresses entries with new SMS/MMS number.

- when the user sends a message, let's check if the new message's address is different than the one
stored in the recipientId's cache. If it is, let's update the cache and the underlying canonical_addresses
table in the db, so we wouldn't keep using a bad number for future references.

Change-Id: I3ac9940fa3c37d29c7398cac4535915249469563

8 years agobug 2245490: fix MMS makeSendPdu() not to return null.
Wei Huang [Sun, 8 Nov 2009 18:11:40 +0000 (10:11 -0800)]
bug 2245490: fix MMS makeSendPdu() not to return null.

- one of my previous change allowed makeSendPdu() to return null if there is not a valid recipient for the message.
However, there is a separate code path that makes the recipientless message a valid scenario. So always return
a valid pdu object.

Change-Id: Ice49d158e23374ca31575efc523af7e063bcb2ff

8 years agoSpeedup contact name resolution
Tom Taylor [Fri, 6 Nov 2009 23:48:01 +0000 (15:48 -0800)]
Speedup contact name resolution

The first time Messaging is launched, a background thread loads
the conversations threads, which loads the contact info cache. While
this is happening, the ConversationList activity starts and the
first thing it does is clear the contact cache that is being built
in the background. Don't clear the cache if it's currently being
built. Fixes bug 2167799.

Change-Id: Id8a9345caaf7905d1f4bcc18ee45d11cb860d293

8 years agoMerge change Idc127177 into eclair
Android (Google) Code Review [Fri, 6 Nov 2009 19:51:49 +0000 (14:51 -0500)]
Merge change Idc127177 into eclair

* changes:
  Fix contact cache rebuilding

8 years agoFix contact cache rebuilding
Tom Taylor [Fri, 6 Nov 2009 19:42:28 +0000 (11:42 -0800)]
Fix contact cache rebuilding

Don't toss and rebuild the ContactInfoCache on every contact change.
With this change, we mark a contact as stale and the next time we're
asked for the contact, we asynchronously update the contact in the
background. Helps speedup bug 2167799.

Change-Id: Idc1271776cddd43fedcd7f31608a3302c8861813

8 years agobug #2236553: catch NPE thrown by SmsManager.sendMultipartTextMessage().
Wei Huang [Fri, 6 Nov 2009 06:23:48 +0000 (22:23 -0800)]
bug #2236553: catch NPE thrown by SmsManager.sendMultipartTextMessage().

- need to catch the NPE and deal with it, like clean up and delete the queued message. Otherwise we not only get a crash in the app, but the queued message would keep getting retried, therefore grow the conversation thread everytime it retries.

- also catch a RuntimeException when we try to insert an existing conversation into the Conversation cache. That caused an app crash too!

Change-Id: Iba081955e19d7a5eb517c3a3aea5186534787c15

8 years agobug 2236527: need to scrub the phone number before sending a MMS message.
Wei Huang [Thu, 5 Nov 2009 23:36:00 +0000 (15:36 -0800)]
bug 2236527: need to scrub the phone number before sending a MMS message.

- add MMS address validity checking and scrubbing. If the phone number used to send a MMS message
contains invalid characters (non digits and non-valid separators), we now warn the user when he tries
to send the message. The prior validity checking code only checks against GSM SMS address, so it
would miss all the invalid chars for MMS address.

- assuming the MMS address is ok but contains separators that are not valid MMS address chars (as
far as the network is concerned), we scrub the number when creating the SendReq data structure for
MMS message.

- flag a few places where things are still not correct, but too risky to fix for MR1.

Change-Id: Ia80a2736f955b94a8cac51ffeb06617a95580ab8

8 years agoWrong contact header
Tom Taylor [Thu, 5 Nov 2009 22:06:04 +0000 (14:06 -0800)]
Wrong contact header

Previously fixed this, but if the underlying search in ContactHeaderWidget
fails or takes a long time, the contact header will still show the wrong
info. Force an invalidate after clearing the ContactHeaderWidget so it'll
redraw empty, rather than leave the previous contact information.
Bug 2233151.

8 years agobug #2236535: when entering MMS compose screen via an address in an intent, replace...
Wei Huang [Thu, 5 Nov 2009 06:22:36 +0000 (22:22 -0800)]
bug #2236535: when entering MMS compose screen via an address in an intent, replace the matching contact cache with the intent address.

- this is basically another path in which we have the actual dest address (in the intent). When the compose screen finds the
matching cached contact, it should replace the contact's address with the specified address in the intent, in case the
cached contact has a bad address.

Change-Id: Id55500e212df5dcd47ff7a1858bc99d4b4656df1

8 years agobug #2236535: use an initial bad address (from a merged contact) would lead to perman...
Wei Huang [Wed, 4 Nov 2009 08:00:01 +0000 (00:00 -0800)]
bug #2236535: use an initial bad address (from a merged contact) would lead to permanent failure for the messaging thread even after a good number is used.

- when the user selects/types a new number in the recipients editor, and we find a cached contact, set the contact's number to be the newly selected number. This will allow the user to correct the address, at least until the next time MMS rebuilds the contact cache with the bad number stored in the database. This will get us to par with the Cupcake behavior. Unfortunately, after MMS app is relaunched, the thread would use the bad initial adddress again (loaded from the 'canonical_address' table in the db). That's a much harder, riskier fix, so deferring to later.

Change-Id: If32958482b14848bd770cff50e4736457c47ac8a

8 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Thu, 29 Oct 2009 04:19:11 +0000 (21:19 -0700)]
Import revised translations.  DO NOT MERGE

8 years agoMove mem change to MR1
Tom Taylor [Mon, 26 Oct 2009 18:46:18 +0000 (11:46 -0700)]
Move mem change to MR1

Manually merge change from MR2 to MR1. Handle an out of memory
exception when trying to build an attached image thumbnail.
Bug 2171440.

Change-Id: I5f7c6d7fff34e66d3e20b1fed9e78b08454e2db7

8 years agoFix build
Tom Taylor [Fri, 23 Oct 2009 21:59:48 +0000 (14:59 -0700)]
Fix build

Change-Id: I02b4038eda480b4bf78574e736dbb7813b78e6a0

8 years agoClear contact header
Tom Taylor [Fri, 23 Oct 2009 18:52:52 +0000 (11:52 -0700)]
Clear contact header

When updating the contact header widget, clear any stale info first
so we don't end up associating the wrong picture with a different
Fixed BC-triaged bug 2173406.

Change-Id: Ic4cabf8b88e8b0922308adefaeea9dd9467f9afa

9 years agoHandle null cursor
Tom Taylor [Thu, 22 Oct 2009 18:48:37 +0000 (11:48 -0700)]
Handle null cursor

If for some reason the SmsProvider returns a null cursor when we try
and load the SIM messages, show the "no sim messages" UI rather than
leaving the UI in a constant loading (animated loading cursor) state.
This is part three of three fixes for BC-triaged bug 2205782.

Change-Id: Ie3dceea621f8c2aa0a2c98f79278c120df3c37e7

9 years agoFix null ref
Tom Taylor [Thu, 22 Oct 2009 16:44:02 +0000 (09:44 -0700)]
Fix null ref

When getResizedImageData fails to scale down an image to a size that'll fit in
the remaining available message space, return null rather than trying to
dereference the null byte array.

Change-Id: Ibb1f5ddd935f952e5f90d8835947cc46bc138aa2

9 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Wed, 21 Oct 2009 17:46:34 +0000 (10:46 -0700)]
Import revised translations.  DO NOT MERGE

Approver: jerryw

9 years agoShow "converting to mms" message
Tom Taylor [Tue, 20 Oct 2009 22:55:00 +0000 (15:55 -0700)]
Show "converting to mms" message

There's one path when we have to downscale an attached picture where
we weren't showing the "converting to mms" message.

9 years agoFix message item click
Tom Taylor [Mon, 12 Oct 2009 18:31:57 +0000 (11:31 -0700)]
Fix message item click

When downloading a Mms video, the message item shows a play button.
Because there are various levels of nested click handlers, only the
button responds to clicks. That made it impossible for users to click
links in the text portion of the message. Turn on the click handler for
the item so both the item and the button can respond to clicks.

Change-Id: I76f5f5fb832a1bb40b9eeff2b22d0f21ee88371f

Change-Id: I5472672da2119cf01c2ab306dfa5111c93ddf478

9 years agobug 2170766: call ContactHeaderWidget.bindFromEmail() if the MMS from addr is an...
Wei Huang [Fri, 9 Oct 2009 22:58:56 +0000 (15:58 -0700)]
bug 2170766: call ContactHeaderWidget.bindFromEmail() if the MMS from addr is an email addr.

Change-Id: Ie933ece6e0871145893c547f788c6454f9babd47

9 years agoFix selection states
Tom Taylor [Fri, 9 Oct 2009 16:17:18 +0000 (09:17 -0700)]
Fix selection states

Use a compound drawable with the various list select states
to draw the conversation list item background.

Change-Id: I43baf202d75b9d146891a7433c3736f5cc926281

9 years agoam 147d4bd4: (-s ours) Import revised translations. DO NOT MERGE
Eric Fischer [Thu, 8 Oct 2009 22:02:43 +0000 (15:02 -0700)]
am 147d4bd4: (-s ours) Import revised translations.  DO NOT MERGE

Merge commit '147d4bd44bfee2c6f8177caa12d8ebfd898dba6c' into eclair

* commit '147d4bd44bfee2c6f8177caa12d8ebfd898dba6c':
  Import revised translations.  DO NOT MERGE

9 years agobug 2175321: add gray background to SMS unread message in Conversation List screen.
Wei Huang [Thu, 8 Oct 2009 18:35:52 +0000 (11:35 -0700)]
bug 2175321: add gray background to SMS unread message in Conversation List screen.

9 years agoMerge change I55133516 into eclair
Android (Google) Code Review [Wed, 7 Oct 2009 18:37:52 +0000 (14:37 -0400)]
Merge change I55133516 into eclair

* changes:
  Import revised translations.   DO NOT MERGE

9 years agoMerge change I863c5a3b into eclair
Android (Google) Code Review [Wed, 7 Oct 2009 17:36:02 +0000 (13:36 -0400)]
Merge change I863c5a3b into eclair

* changes:
  Don't allow attach audio

9 years agoDon't allow attach audio
Tom Taylor [Wed, 7 Oct 2009 17:02:08 +0000 (10:02 -0700)]
Don't allow attach audio

If MmsConfig doesn't allow attaching a ringtone to a Mms message,
hide the menu item. Fixes bug 2171112.

Change-Id: I863c5a3b5761dc5588c48c77aef76f9bb984287b

9 years agobug 2169583: fix a thread mixup problem caused by empty draft message having an unacc...
Wei Huang [Wed, 7 Oct 2009 05:45:29 +0000 (22:45 -0700)]
bug 2169583: fix a thread mixup problem caused by empty draft message having an unaccounted for thread id.

- there is a situation where if the user tries to attach an image in an empty draft message, we'd allocate
a thread id (creating one in the db), but immediately deleting it because the draft message is empty.
However, when we deleted the empty draft message, we didn't invalidate the in-memory thread id from the
initial allocation. At this point if a new message arrives and takes the same thread id, it will cause
the CMA to requery and pull in the new message to the draft message thread incorrectly (because both
have the same thread id).

Change-Id: I7981eb1ec1f4ba1e2650325093c2b60ac4324b94

9 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Tue, 6 Oct 2009 23:53:39 +0000 (16:53 -0700)]
Import revised translations.   DO NOT MERGE

Approver: jerryw

9 years agoMerge change Ie05aa504 into eclair
Android (Google) Code Review [Tue, 6 Oct 2009 18:21:10 +0000 (14:21 -0400)]
Merge change Ie05aa504 into eclair

* changes:
  Launch a forward activity

9 years agoLaunch a forward activity
Tom Taylor [Tue, 6 Oct 2009 18:07:38 +0000 (11:07 -0700)]
Launch a forward activity

When a user forwards a message, create a new copy of the ComposeMessageActivity.
We do this by starting an aliased activity that doesn't have the singleTop
flag set. Fixed bug 2164612.

Change-Id: Ie05aa504c39df3e88eb4ecd7309d84b06e8d61be

9 years agoUpdated icons for SMS/MMS apps.
Daniel Sandler [Tue, 6 Oct 2009 15:40:42 +0000 (11:40 -0400)]
Updated icons for SMS/MMS apps.

Change-Id: I78f28c437795a292a6646316989b1dcf5b8a5ddb
DrNo: mcleron

9 years agoReplace multi-recipient icon with new asset
Tom Taylor [Mon, 5 Oct 2009 22:48:08 +0000 (15:48 -0700)]
Replace multi-recipient icon with new asset

For bug 2154660.

Change-Id: Ie1783edb981a652dd9eb948230c1388c26a0a882

9 years agoDon't automatically go back to ConversationList
Tom Taylor [Mon, 5 Oct 2009 20:50:58 +0000 (13:50 -0700)]
Don't automatically go back to ConversationList

When saving a draft, don't automatically launch the ConversationList. The auto-launch
behavior made backing out of Messaging a two-step operation when launched from another
app like the Browser.

Change-Id: Iffcbfb8c3af00c125562541c7292d12118434985

9 years agobug 2161715: don't decode the large JPEG into Bitmap, which causes OOM. Instead read...
Wei Huang [Fri, 2 Oct 2009 17:57:19 +0000 (10:57 -0700)]
bug 2161715: don't decode the large JPEG into Bitmap, which causes OOM. Instead read the JPEG data directly.

Change-Id: Iab6f27b00b4ae9dc0d2126dd369d8d04e27bcb67

9 years agoMerge change I1331f979 into eclair
Android (Google) Code Review [Fri, 2 Oct 2009 07:58:48 +0000 (03:58 -0400)]
Merge change I1331f979 into eclair

* changes:
  Icons again

9 years agoIcons again
Mike Cleron [Fri, 2 Oct 2009 07:36:07 +0000 (00:36 -0700)]
Icons again

9 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Fri, 2 Oct 2009 00:01:29 +0000 (17:01 -0700)]
Import revised translations.  DO NOT MERGE

Approver: jerryw

9 years agoMerge change Ie63dc4f1 into eclair
Android (Google) Code Review [Thu, 1 Oct 2009 07:43:17 +0000 (03:43 -0400)]
Merge change Ie63dc4f1 into eclair

* changes:
  More icons

9 years agoMore icons
Mike Cleron [Thu, 1 Oct 2009 07:37:49 +0000 (00:37 -0700)]
More icons

9 years agoHandle out-of-memory while decoding image
Tom Taylor [Wed, 30 Sep 2009 20:45:21 +0000 (13:45 -0700)]
Handle out-of-memory while decoding image

When adding images to a mms message we attempt to resize an image, if
necessary, to keep the message within its maximum message length. In
some cases, the first crack at decoding the image can throw an
out-of-memory exception. With this change, we catch that exception and
try decoding again at a smaller scale.

Change-Id: Id8ebcab4c407f316dd850640ab8f058845fb7054

9 years agoMerge change I4a82fd6f into eclair
Android (Google) Code Review [Wed, 30 Sep 2009 18:20:06 +0000 (14:20 -0400)]
Merge change I4a82fd6f into eclair

* changes:
  Change dialog to toast

9 years agoChange dialog to toast
Tom Taylor [Wed, 30 Sep 2009 17:18:23 +0000 (10:18 -0700)]
Change dialog to toast

If we get an exception while adding a picture because the picture is
too large, a function is called to downscale the picture. If that process
take over a second, a "Compressing..." dialog is shown. If the user opens
and closes the keybaord during this period, the dialog is left dangling
or attached to the wrong window and this can cause several different crashes.
This checkin replaces the dialog with a toast that seems more immune to
the same steps. In other words, the toast closes itself, rather than us
having to call the dialog.dismiss function, which was problematic.
Also, fix a merge change on removing commas from recipient names.

Change-Id: I4a82fd6f832d935915583efb860a6c0382b3a2df

9 years agoMerge change Ib02a550d into eclair
Android (Google) Code Review [Wed, 30 Sep 2009 17:01:14 +0000 (13:01 -0400)]
Merge change Ib02a550d into eclair

* changes:
  Change FasttrackBadgeWidget->QuickContactBadge

9 years agoNewer icons
Mike Cleron [Wed, 30 Sep 2009 08:15:41 +0000 (01:15 -0700)]
Newer icons

9 years agoMerge change Ia04ca48d into eclair
Android (Google) Code Review [Wed, 30 Sep 2009 04:35:37 +0000 (00:35 -0400)]
Merge change Ia04ca48d into eclair

* changes:
  New hdpi assets.

9 years agoNew hdpi assets.
Daniel Sandler [Wed, 30 Sep 2009 04:31:24 +0000 (00:31 -0400)]
New hdpi assets.

Drop dated 29-Sep-2009.

Change-Id: Ia04ca48d8463db280965fe938d385074cc8464d6

9 years agoChange FasttrackBadgeWidget->QuickContactBadge
Evan Millar [Wed, 30 Sep 2009 01:09:30 +0000 (18:09 -0700)]
Change FasttrackBadgeWidget->QuickContactBadge

Change-Id: Ib02a550ddfd887152c7d2aabb5ba250a48b5d000

9 years agoMerge change I7e0211f6 into eclair
Android (Google) Code Review [Wed, 30 Sep 2009 01:04:37 +0000 (21:04 -0400)]
Merge change I7e0211f6 into eclair

* changes:
  Remove commas from recipient names

9 years agoRemove commas from recipient names
Tom Taylor [Wed, 30 Sep 2009 00:45:15 +0000 (17:45 -0700)]
Remove commas from recipient names

Change-Id: I7e0211f63ab46347a4aff74a6be2aa62b53536cc