Wednesday March 10 2010

• 12:22

  

  Favorite

  Olivier Goffart started watching Fixing bug with q3listview sorting

• 12:21

  

  Merge request

  Olivier Goffart updated merge request qt/qt #2260

  → State changed from Revise and resubmit to Merged

  Merged in 9bba92715d96939e4d36c6ea42e8b466756bf891

Thursday February 25 2010

• 10:38

  

  Merge request

  Olivier Goffart updated merge request qt/qt #2316

  → State changed from Revise and resubmit to Rejected

  Marked as closed as this in obsoleted bu MR 2318

• 10:35

  

  Merge request

  Olivier Goffart updated merge request qt/qt #2315

  → State changed from New to Merged

  Merge in 4.6 (72f3752b5b517c14e64c4e15d354ddf32e386c20)

Monday February 08 2010

• 08:45

  

  Merge request

  Olivier Goffart updated merge request qt/qt #2288

  → State changed from New to Merged

  Merged (fc58ceb0041626baa95d00ea)

Friday February 05 2010

• 12:33

  

  Merge request

  Olivier Goffart updated merge request qt/qt #2300

  → State changed from New to Merged

  Merged in a767da6f2d0fbee707f5c2fe896fa501b3da6b07

Monday January 11 2010

• 14:21

  

  Comment

  Olivier Goffart commented on merge request qt/qt #2282

  We are wondering the use case of that patch (correct, but that still change behaviour.)
  (We have guessed you might be building a GUI for a time ma...

Wednesday January 06 2010

• 10:00

  

  Merge request

  Olivier Goffart updated merge request qt/qt #416

  → State changed from New to Merged

  Submitted to master (d149a3faca9b97ce806249bc7ef73fe2f59589d5)

Monday December 28 2009

• 16:56

  

  Merge request

  Olivier Goffart updated merge request qt/qt #2276

  → State changed from New to Merged

  Merged in 8c306f8ee137baebc312a126c4e0d27bb9150f69

• 16:34

  

  Comment

  Olivier Goffart commented on merge request qt/qt #416

  Indeed. We have seen this problem while doing patch e8d7d2172627dd3c

  But we decided not to fix it as we were afraid to change behavior.

  Why d...

Friday December 18 2009

• 14:29

  

  Merge request

  Olivier Goffart updated merge request qt/qt #2266

  → State changed from Reviewing to Merged

  Now merged 82a35ed3f1dede556e9ab6e30b86997c4a8f0fd1

• 14:18

  

  Comment

  Olivier Goffart commented on merge request qt/qt #411

  If this goes in, All use of QStyleOptionTabV3 need to be updated.
  I know for example it is used in QStyleSheetStyle.

• 13:52

  

  Merge request

  Olivier Goffart updated merge request qt/qt #2262

  → State changed from Revise and resubmit to Merged

  Merged into oslo-staging-2
  315c09c3873f7c5d8b785443372bf975bae47ee7

• 13:50

  

  Merge request

  Olivier Goffart updated merge request qt/qt #2266

  → State changed from Merged to Reviewing

  This has not been merged yet. 2262 has been merged.

• 13:35

  

  Merge request

  Olivier Goffart updated merge request qt/qt #2266

  → State changed from New to Merged

  Merged into oslo-staging-2
  315c09c3873f7c5d8b785443372bf975bae47ee7

• 12:53

  

  Comment

  Olivier Goffart commented on merge request qt/qt #2260

  An autottest is a test in tests/auto/

  My question was why calling sortChildItems instead of isOpen() and sort()

Tuesday December 15 2009

• 12:38

  

  Merge request

  Olivier Goffart updated merge request qt/qt #2262

  → State changed from New to Revise and resubmit

  Please put the test in the QSortFilterProxy model test.
  Also remove the qDebug()

  And the Qt c...

Wednesday December 09 2009

• 17:01

  

  Comment

  Olivier Goffart commented on merge request qt/qt #2266

  Looks ok at a first glance.

  I don't really like the dependencies between tests.

  Maybe it is better to put anything that depends on ModelTest ...

• 16:51

  

  Comment

  Olivier Goffart commented on merge request qt/qt #2262

  Wouldn't it be better to just call create_mapping or something similair, and return ?

• 11:50

  

  Comment

  Olivier Goffart commented on merge request qt/qt #1575

  This code is the same as the one a little bit after, but a little bit different.

  However, the code after that does only call headerSectionSize() i...

• 11:45

  

  Comment

  Olivier Goffart commented on merge request qt/qt #1575

  The coding style is not respected, the brace need to be on the same line as the if

• 11:32

  

  Comment

  Olivier Goffart commented on merge request qt/qt #1575

  I tried to merge.
  But the emails in the commits is wrong.
  Can you please fix that.
  You can also squash the two commit into one, and rebase on t...

Monday December 07 2009

• 21:36

  

  Merge request

  Olivier Goffart updated merge request qt/qt #2260

  → State changed from New to Revise and resubmit

  The continuation of the function calls:
  if (siblings[i].item->isOpen())
  siblings...

Thursday December 03 2009

• 09:01

  

  Merge request

  Olivier Goffart updated merge request qt/qt #1661

  → State changed from New to Revise and resubmit

  Code Looks good.
  It is missing a test

• 08:59

  

  Comment

  Olivier Goffart commented on merge request qt/qt #1646

  I would have constructed the action lazily. But now it is consistent with QToolbar and QDockWidget.

  So it looks good.

• 08:42

  

  Comment

  Olivier Goffart commented on merge request qt/qt #1642

  Looks good.

• 08:39

  

  Comment

  Olivier Goffart commented on merge request qt/qt #1642

  What is the problem in CSS Parser?

• 08:38

  

  Comment

  Olivier Goffart commented on merge request qt/qt #1642

  or rather using QString::fromLatin1()

• 08:37

  

  Comment

  Olivier Goffart commented on merge request qt/qt #1642

  maybe styleString should be QLatin1String

Thursday November 26 2009

• 15:29

  

  Merge request

  Olivier Goffart updated merge request qt/qt #2219

  → State changed from New to Merged

  Merged in 88b9c6eb3f1dde9997d