Commit f2861a51289d2a6976d9421d19f8aa615b949652
- Date: Sun Jan 13 13:40:31 +0000 2008
- Committer: Johan Sørensen (johan@johansorensen.com)
- Author: Johan Sørensen (johan@johansorensen.com)
- Commit SHA1: f2861a51289d2a6976d9421d19f8aa615b949652
- Tree SHA1: 6ee006bf41a070404bccfed97da613f46f0eedec
unify logs per page usage
Commit diff
| | |
| 2 | 2 | before_filter :find_project_and_repository |
| 3 | 3 | before_filter :check_for_commits |
| 4 | 4 | |
| 5 | LOGS_PER_PAGE = 30 |
| 6 | |
| 5 | 7 | def index |
| 6 | 8 | @git = Git.bare(@repository.full_repository_path) |
| 7 | | @commits = @git.log(30) |
| 9 | @commits = @git.log(LOGS_PER_PAGE) |
| 8 | 10 | @tags_per_sha = returning({}) do |hash| |
| 9 | 11 | @git.tags.each do |tag| |
| 10 | 12 | hash[tag.sha] ||= [] |
| … | … | |
| 55 | 55 | render :text => @blob.contents, :content_type => "text/plain" |
| 56 | 56 | end |
| 57 | 57 | |
| 58 | | @@per_page = 30 |
| 59 | | |
| 60 | 58 | def log |
| 61 | 59 | @git = Git.bare(@repository.full_repository_path) |
| 62 | | skip = params[:page].blank? ? 0 : (params[:page].to_i-1) * @@per_page |
| 63 | | @commits = @git.log(30, skip) |
| 60 | skip = params[:page].blank? ? 0 : (params[:page].to_i-1) * LOGS_PER_PAGE |
| 61 | @commits = @git.log(LOGS_PER_PAGE, skip) |
| 64 | 62 | @tags_per_sha = returning({}) do |hash| |
| 65 | 63 | @git.tags.each do |tag| |
| 66 | 64 | hash[tag.sha] ||= [] |
| toggle raw diff |
--- a/app/controllers/browse_controller.rb
+++ b/app/controllers/browse_controller.rb
@@ -2,9 +2,11 @@ class BrowseController < ApplicationController
before_filter :find_project_and_repository
before_filter :check_for_commits
+ LOGS_PER_PAGE = 30
+
def index
@git = Git.bare(@repository.full_repository_path)
- @commits = @git.log(30)
+ @commits = @git.log(LOGS_PER_PAGE)
@tags_per_sha = returning({}) do |hash|
@git.tags.each do |tag|
hash[tag.sha] ||= []
@@ -53,12 +55,10 @@ class BrowseController < ApplicationController
render :text => @blob.contents, :content_type => "text/plain"
end
- @@per_page = 30
-
def log
@git = Git.bare(@repository.full_repository_path)
- skip = params[:page].blank? ? 0 : (params[:page].to_i-1) * @@per_page
- @commits = @git.log(30, skip)
+ skip = params[:page].blank? ? 0 : (params[:page].to_i-1) * LOGS_PER_PAGE
+ @commits = @git.log(LOGS_PER_PAGE, skip)
@tags_per_sha = returning({}) do |hash|
@git.tags.each do |tag|
hash[tag.sha] ||= [] |
