Commit 51dc0eaedf97266e513d73511494666fd6df21ad
- Date: Sun Jan 27 14:43:26 +0000 2008
- Committer: Priit Tamboom (priit@mx.ee)
- Author: Priit Tamboom (priit@mx.ee)
- Commit SHA1: 51dc0eaedf97266e513d73511494666fd6df21ad
- Tree SHA1: b07e4466540592d09f67f5209bd6c2d90e4d7df9
comments controller gots validates_presence_of :sha1 (plus spec fix)
Commit diff
| | |
| 19 | 19 | |
| 20 | 20 | attr_protected :user_id |
| 21 | 21 | |
| 22 | | validates_presence_of :user_id, :repository_id, :body, :project_id |
| 22 | validates_presence_of :user_id, :repository_id, :body, :project_id, :sha1 |
| 23 | 23 | |
| 24 | 24 | |
| 25 | 25 | end |
| toggle raw diff |
--- a/app/models/comment.rb
+++ b/app/models/comment.rb
@@ -19,7 +19,7 @@ class Comment < ActiveRecord::Base
attr_protected :user_id
- validates_presence_of :user_id, :repository_id, :body, :project_id
+ validates_presence_of :user_id, :repository_id, :body, :project_id, :sha1
end |
| | |
| 44 | 44 | describe "#create" do |
| 45 | 45 | |
| 46 | 46 | def do_post(opts = {}) |
| 47 | | get :create, :project_id => @project.slug, |
| 48 | | :repository_id => @repository.name, :comment => opts |
| 47 | post :create, :project_id => @project.slug, :repository_id => @repository.name, |
| 48 | :comment => {:sha1 => 'blabla'}.merge(opts) |
| 49 | 49 | end |
| 50 | 50 | |
| 51 | 51 | it "requires login" do |
| … | … | |
| 77 | 77 | |
| 78 | 78 | it "it re-renders on invalid data" do |
| 79 | 79 | login_as :johan |
| 80 | | do_post :body => nil |
| 80 | do_post :body => nil, :sha1 => nil |
| 81 | 81 | response.should be_success |
| 82 | 82 | response.should render_template("comments/new") |
| 83 | 83 | end |
| toggle raw diff |
--- a/spec/controllers/comments_controller_spec.rb
+++ b/spec/controllers/comments_controller_spec.rb
@@ -44,8 +44,8 @@ describe CommentsController do
describe "#create" do
def do_post(opts = {})
- get :create, :project_id => @project.slug,
- :repository_id => @repository.name, :comment => opts
+ post :create, :project_id => @project.slug, :repository_id => @repository.name,
+ :comment => {:sha1 => 'blabla'}.merge(opts)
end
it "requires login" do
@@ -77,7 +77,7 @@ describe CommentsController do
it "it re-renders on invalid data" do
login_as :johan
- do_post :body => nil
+ do_post :body => nil, :sha1 => nil
response.should be_success
response.should render_template("comments/new")
end |
