Commit 5e61707eeed61828047c8ba882e04fa694ede4f4

Prefer String#constantize over eval

Commit diff


5	5
6	6	Event.find(:all).each do \|event\|
7	7	begin
8		~~eval("#{event.target_type}").find(event.target_id)~~
	8	event.target_type.constantize.find(event.target_id)
9	9	Project.find(event.project_id)
10	10	rescue ActiveRecord::RecordNotFound
11	11	puts "Destroying invalid event '#{event.id}:#{Action.name(event.action)}'"
toggle raw diff
--- a/script/destroy_invalid_events +++ b/script/destroy_invalid_events @@ -5,7 +5,7 @@ require File.dirname(__FILE__)+'/../config/environment' Event.find(:all).each do \|event\| begin - eval("#{event.target_type}").find(event.target_id) + event.target_type.constantize.find(event.target_id) Project.find(event.project_id) rescue ActiveRecord::RecordNotFound puts "Destroying invalid event '#{event.id}:#{Action.name(event.action)}'"