This one is ok

The first three commits where cherry-picked but I don’t like this one. This breaks with the other views. Instead of displaying those actions above the boxes, I'd recommend putting them into the (left) details box at the bottom (but above build errors and request display). However, the amount of actions is likely to increase further in the next versions, so maybe this layout would work (depicting the left box):

package / projec title Build Results

longer description text that may consist of ……
several lines
——————————————————————————————|
4 open requests | Edit package information |
18 build errors | Submit package |

                           |

… you get the picture.

K, gitories doesn’t allow setting states for individual commits.

Sascha- I don’t understand what you are suggesting for the UI changes to the Actions list- the diagram looks like it got munged. If you are suggesting putting the actions below the description I disagree:

The build service’s primary user is someone wanting to build or change something and displaying metadata like a description should be secondary. The buttons are always small- the description can be arbitrarily long. e.g. https://build.opensuse.org/package/show?package=perl-ExtUtils-Depends&project=openSUSE%3A11.4

I see two solutions to this problem:

1) Javascript roll-up to limit description to 4 lines with a “more” button- actions below
2) Put actions, build status and errors above the description

Which do you like more? I prefer option 2 as it caters to the primary user better.

Side note: it is really hard to make UI decisions on the idea that “more will likely be added in the future”. Do you know how many more? What will they do?

Thanks for taking the other patches :)

Your welcome.

About the declined commit, I'm strongly against both #1 and #2. The current JavaScript solution is ugly and not accessible, #1 only increases that. Regarding #2, build status is fine on the right, example: https://build.opensuse.org/project/show?project=home%3Asaschpe

The actions in the ‘actions’ menu are mainly about changing the metadata that is displayed and for requesting certain things (deletion, branching, adding roles, submitting stuff, etc.). Therefore, I suggested (with ascii-art), that the bottom area in the description box is split. Currently it shows the amount of open requests and failing packages. Here’s a mockup of my ascii-art (shame on Gitorious eating it): http://i.imgur.com/AG14R.png

If a package has such a big description like yours (which nobody is going to read anyways), than it could be shortened with a “..more” link displaying it’s whole beauty.

Re reading this I am confused about your opinion on the javascript rollup. You say it is both ugly and not accessible and then at the end say that we could have a more link. Would you accept a patch to shorten the description to say 4 lines by default?

I made some more mockups and posted them on my blog but ran into trouble with Bento’s show_left class. Screenshots below.

My Suggested Patch

Sascha’s Suggestion

Controls on top

Gah, submitted too soon. I assume if there is a more link you want it to do a full GET to request the page with the full description, right?