Merkmal

Merkmal is a concentration game for GNOME. more…

Activities

• Tuesday November 02 2010

  • Push

    10:26

    

    Chris Kühl pushed 23a0bee2 to merkmal/merkmal:master

    Chris Kühl on November 02, 2010 10:22

    Bumped requirement for cluttermm to 1.1.2 due to Cairo::Texture bug in 1.1.1.

• Monday November 01 2010

  • Push

    16:21

    

    Chris Kühl pushed 5723e543 to merkmal/merkmal:master

    Chris Kühl on November 01, 2010 16:20

    Had to remove -pedantic flag from warnings due to clutter 1.2's trailing commas.

  • Commit

    16:20

    

    Chris Kühl tagged merkmal/merkmal

    0.1.0: Created tag 0.1.0

  • Push

    15:53

    

    Chris Kühl pushed 4b33c6d7 to merkmal/merkmal:master

    Chris Kühl on November 01, 2010 15:52

    Removed forgotten reference to GMemory from About dialog.

  • Push

    14:32

    

    Chris Kühl pushed 2 commits to merkmal/merkmal:master

    master changed from 50a10a9 to 8596b47

    

• Friday October 29 2010

  • Push

    12:04

    

    Chris Kühl pushed 2 commits to merkmal/merkmal:master

    master changed from b59dcad to 50a10a9

    

  • Push

    10:41

    

    Chris Kühl pushed b59dcade to merkmal/merkmal:master

    Chris Kühl on October 29, 2010 10:20

    Made various changes requested by murrayc.

• Thursday October 28 2010

  • Push

    13:06

    

    Chris Kühl pushed 2b172008 to merkmal/merkmal:master

    Chris Kühl on October 28, 2010 13:04

    Cleaned up and reorganized h and cc files.

  • Push

    08:46

    

    Chris Kühl pushed 4f0f561d to merkmal/merkmal:master

    Chris Kühl on October 28, 2010 08:40

    Small fixes to get rid of compiler warnings.

• Wednesday October 27 2010

  • Push

    22:48

    

    Chris Kühl pushed 5 commits to merkmal/merkmal:master

    master changed from 8a177ea to 4ecb405

    

  • Push

    00:05

    

    Chris Kühl pushed 8a177eab to merkmal/merkmal:master

    Chris Kühl on October 27, 2010 00:01

    Added logic and signals for matching cards and tracking card state.

• Tuesday October 26 2010

  • Push

    16:53

    

    Chris Kühl pushed 3 commits to merkmal/merkmal:master

    master changed from bb723b9 to c0a01a5

    

  • Push

    00:18

    

    Chris Kühl pushed 4 commits to merkmal/merkmal:master

    master changed from 8d8a8ee to bb723b9

    

• Sunday October 24 2010

  • Comment

    09:28

    

    Murray Cumming commented on merkmal/merkmal/42085cd

    > I'm using std::pair as the return value of the get_cards() method which was previously the awkward get_a_card(bool want_first)

    Yes, I see t...

  • Comment

    09:23

    

    Murray Cumming commented on merkmal/merkmal/42085cd

    > I'm deriving from ObjectBase so that I can use Glib::RefPtr.

    Well, a) why do you need reference-counting for this? Surely it's not being us...

• Saturday October 23 2010

  • Comment

    23:42

    

    Chris Kühl commented on merkmal/merkmal/42085cd

    I'm deriving from ObjectBase so that I can use Glib::RefPtr. Isn't that a requirement for getting proper reference counting? Maybe I'm over doing i...

  • Comment

    13:37

    

    Murray Cumming commented on merkmal/merkmal/e9f5e24

    > statusbar = new Gtk::Statusbar();

    You seem to be leaking that. You can either
    a) Use Gtk::manage()
    b) Use it as a member instance instea...

• Monday October 18 2010

  • Push

    17:02

    

    Chris Kühl pushed 5 commits to merkmal/merkmal:master

    master changed from 48ea84a to 8d8a8ee

    

• Wednesday October 06 2010

  • Comment

    11:03

    

    Murray Cumming commented on merkmal/merkmal/42085cd

    Why do you need to derive from ObjectBase? Note that I still think you probably just want to use std::pair<>.

  • Push

    10:14

    

    Chris Kühl pushed 2 commits to merkmal/merkmal:master

    master changed from 2083184 to 48ea84a

    

• Sunday October 03 2010

  • Comment

    15:19

    

    Murray Cumming commented on merkmal/merkmal/2083184

    Code is clearer when you give your enum values a common prefix. For instance:
    DIFFICULTY_EASY
    DIFFICULTY_NORMAL
    DIFFICULTY_HARD
    DIFFICULTY_EXTREME
    ...

  • Comment

    15:17

    

    Murray Cumming commented on merkmal/merkmal/2083184

    That should probably be const, and the parameter should probably be const, like so:

    bool is_paired(const Glib::RefPtr<const Card>& other...

  • Comment

    15:17

    

    Murray Cumming commented on merkmal/merkmal/2083184

    In general, for any constructor that can take a single argument, you should use the explicit keyword, to avoid instantiating an instance when you d...

  • Comment

    15:16

    

    Murray Cumming commented on merkmal/merkmal/2083184

    It makes the code clearer if you put the initialization lines on the next line. That separates the API from the implementation more.

  • Comment

    15:15

    

    Murray Cumming commented on merkmal/merkmal/2083184

    That's a rather weird API that would be better as just
    get_first() and get_second().

    If you didn't have the static next_card_id then you could jus...

• Friday October 01 2010

  • Push

    14:23

    

    Chris Kühl pushed 2083184c to merkmal/merkmal:master

    Chris Kühl on October 01, 2010 14:22

    Added initial classes. Compiles but doesn't really do anything.

• Thursday September 30 2010

  • Push

    08:28

    

    Chris Kühl pushed ab8a52f9 to merkmal/merkmal:master

    Chris Kühl on September 29, 2010 21:19

    Added clutter-gtkmm widget and other small changes.

• Tuesday September 28 2010

  • Comment

    10:36

    

    Murray Cumming commented on merkmal/merkmal/0ab4276

    Thanks. It avoids weird bugs like this:

    void MyClass::set_something(int something)
    {
    something = something
    }

    which actually happen when ...

  • Comment

    10:34

    

    Chris Kühl commented on merkmal/merkmal/0ab4276

    > Please use either an m_ prefix or a _ suffix with member variables.

    Ok, if that keeps with convention. Not really to my liking, though.

  • Comment

    09:21

    

    Murray Cumming commented on merkmal/merkmal/0ab4276

    You can use private instead of protected here.