Whether the terms are accepted by default when a user is added via the administration interface should be an option. As an admin I may still want users I add to accept the terms of use.

Well, I guess that was the way it was implemented in Gitorious in private mode before, when it was actually working. Now this part is broken and unless you have some patch for achieving your desired behavior, this should be fixed for now with this approach or we won’t be able to use the private mode, since we can’t register new users…

Good stuff; even spotted the copyright errors :–)

Could we do this the way it’s done in the regular user creation routine? In app/views/users/_form.html.erb we have:

<%= f.check_box :terms_of_use -%>

and in app/controllers/users_controller.rb:

if !@user.terms_of_use.blank?
  @user.accept_terms!  
end

This way you would need to check the box in order for user creation to succeed.

Would this work for you?

Yes, this would work for me, even though I don’t think it makes any sense…

The idea of agreeing with the acceptance terms is that the user will read and agree. It doesn’t make sense for the admin agreeing for the user who didn’t read himself.

Anyway, this license thing doesn’t make much sense at all in a private Gitorious install, in my opinion…

But feel free to make the change you’re suggesting. I won’t bother checking the accept terms checkbox. I just want to be able to register new users again :)

Thanks.

I made this change: http://gitorious.org/gitorious/mainline/commit/fcf112d4302b836be711ba91ada10a734fc521e1

It should resolve this issue

Thanks, Marius. I’ll test it at work.